wxWidgets.git
13 years agoMake wxOwnerDrawnComboBox sorting identical to the MSW sorting (same as wxComboBox)
Jaakko Salli [Fri, 17 Dec 2010 12:23:34 +0000 (12:23 +0000)] 
Make wxOwnerDrawnComboBox sorting identical to the MSW sorting (same as wxComboBox)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66398 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoAdd wxComboBox-compatible Popup() and Dismiss() functions in wxComboCtrl
Jaakko Salli [Fri, 17 Dec 2010 12:08:55 +0000 (12:08 +0000)] 
Add wxComboBox-compatible Popup() and Dismiss() functions in wxComboCtrl

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66397 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoAdd enough default arguments to one wxOwnerDrawnComboBox ctor so it can be consructed...
Jaakko Salli [Fri, 17 Dec 2010 11:50:54 +0000 (11:50 +0000)] 
Add enough default arguments to one wxOwnerDrawnComboBox ctor so it can be consructed using only two arguments, same as the wxComboBox

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66396 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoMostly change the wxOwnerDrawnComboBox text value using ChangeValue() instead of...
Jaakko Salli [Fri, 17 Dec 2010 11:39:38 +0000 (11:39 +0000)] 
Mostly change the wxOwnerDrawnComboBox text value using ChangeValue() instead of SetValue()

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66395 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoMake the wxComboCtrl's wxTextEntry interface more complete and consistent. All text...
Jaakko Salli [Fri, 17 Dec 2010 11:20:50 +0000 (11:20 +0000)] 
Make the wxComboCtrl's wxTextEntry interface more complete and consistent. All text is no longer selected on SetValue(), but only when user selects an item from the drop-down list.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66394 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoUse a " " (space) for the menu item if an empty string is used for an item in a wxCho...
Robin Dunn [Fri, 17 Dec 2010 00:56:26 +0000 (00:56 +0000)] 
Use a " " (space) for the menu item if an empty string is used for an item in a wxChoice, in order to avoid an assert in wxMenuItem.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66391 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoRemoved a return statement from void function
Jaakko Salli [Thu, 16 Dec 2010 19:25:31 +0000 (19:25 +0000)] 
Removed a return statement from void function

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66389 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoResolve ambiguity with wxOwnerDrawnComboBox::Clear(), virtual method which is derived...
Jaakko Salli [Thu, 16 Dec 2010 18:13:43 +0000 (18:13 +0000)] 
Resolve ambiguity with wxOwnerDrawnComboBox::Clear(), virtual method which is derived from two base classes

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66388 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoIn wxBitmapComboBox dtor, call DoClear() instead of ambiguous Clear()
Jaakko Salli [Thu, 16 Dec 2010 18:08:16 +0000 (18:08 +0000)] 
In wxBitmapComboBox dtor, call DoClear() instead of ambiguous Clear()

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66387 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoOverride wxTextEntry::GetSelection(long *from, long *to) in wxOwnerDrawnComboBox...
Jaakko Salli [Thu, 16 Dec 2010 18:07:05 +0000 (18:07 +0000)] 
Override wxTextEntry::GetSelection(long *from, long *to) in wxOwnerDrawnComboBox to resolve virtual method hiding issues

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66386 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoInstead of having wxComboCtrl mimic wxTextEntry interface, make it actually inherit...
Jaakko Salli [Thu, 16 Dec 2010 17:21:49 +0000 (17:21 +0000)] 
Instead of having wxComboCtrl mimic wxTextEntry interface, make it actually inherit from the class and implement functions to redirect to the embedded wxTextCtrl. This allows us to simplify the code and get rid of the dirty trick of directing wxComboCtrl's validator to the embedded wxTextCtrl. Also see #12779, which issue 1 is fixed by this change.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66385 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDocument how the sign is omitted from wxFloatProperty's displayed value when it is...
Jaakko Salli [Thu, 16 Dec 2010 16:12:55 +0000 (16:12 +0000)] 
Document how the sign is omitted from wxFloatProperty's displayed value when it is effectively zero (closes #12738).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66384 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoInitialize wxLogWindow::m_pLogFrame in ctor to avoid (rare) crash.
Vadim Zeitlin [Wed, 15 Dec 2010 13:36:44 +0000 (13:36 +0000)] 
Initialize wxLogWindow::m_pLogFrame in ctor to avoid (rare) crash.

If the log frame creation itself generates log messages, the code using
wxLogWindow could crash because its m_pLogFrame member variable wasn't
initialized yet at this moment.

Do set it to NULL initially now to avoid this.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66383 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoCompilation fixes for wx{X11,GTK1,Motif} after making ref data non copyable.
Vadim Zeitlin [Wed, 15 Dec 2010 12:04:13 +0000 (12:04 +0000)] 
Compilation fixes for wx{X11,GTK1,Motif} after making ref data non copyable.

Don't use wrong compiler-generated copy ctors in the other ports neither (see
r66371..66373 for wxGTK fixes). This fixes compilation after r66374 without
reducing functionality but just making it more clear where it is missing.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66382 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoCompilation fix for wxMotif PCH build.
Vadim Zeitlin [Wed, 15 Dec 2010 12:04:02 +0000 (12:04 +0000)] 
Compilation fix for wxMotif PCH build.

We need to include wx/unix/utilsx11.h even when using PCH to get
wxCharCodeXToWX() declaration.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66381 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoUpdate accelerator unit test to pass after recent changes.
Vadim Zeitlin [Wed, 15 Dec 2010 12:03:54 +0000 (12:03 +0000)] 
Update accelerator unit test to pass after recent changes.

Changes of r66379 broke the unit test as wxAcceleratorEntry::Create() now
requires the TAB to be present in the string passed to it (again).

Update the test to make it pass.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66380 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDon't pass strings not containing accelerators to ParseAccel().
Vadim Zeitlin [Wed, 15 Dec 2010 11:18:42 +0000 (11:18 +0000)] 
Don't pass strings not containing accelerators to ParseAccel().

Check for the presence of accelerator part in the string passed to
wxAcceleratorEntry::Create() and don't call ParseAccel() at all if it's not
there. This avoids the spurious warnings about unrecognized accelerators when
creating menu items that don't have any accelerators at all.

Also update wxAcceleratorEntry::FromString() documentation to mention that
the new code should pass just the accelerator to this function and that it
only accepts full menu item labels for compatibility.

Closes #12770.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66379 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoInclude compilation of tests for OpenVMS (part2)
Jouk Jansen [Wed, 15 Dec 2010 10:54:47 +0000 (10:54 +0000)] 
Include compilation of tests for OpenVMS (part2)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66378 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoInclude compilation of tests for OpenVMS (part1)
Jouk Jansen [Wed, 15 Dec 2010 09:51:48 +0000 (09:51 +0000)] 
Include compilation of tests for OpenVMS (part1)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66377 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoReturn false, not NULL, from a function returning bool.
Vadim Zeitlin [Tue, 14 Dec 2010 18:44:04 +0000 (18:44 +0000)] 
Return false, not NULL, from a function returning bool.

Fix a warning (which might be an error with some compilers) about returning
NULL from bool wxRichTextImageBlock::DoMakeImageBlock() function.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66376 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoNo real changes, just add a cast to fix a warning.
Vadim Zeitlin [Tue, 14 Dec 2010 18:43:57 +0000 (18:43 +0000)] 
No real changes, just add a cast to fix a warning.

Fix warning about implicitly converting -1 to CGKeyCode when building wxOSX
with 10.4 SDK.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66375 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoMake wxRefCounter non copyable.
Vadim Zeitlin [Tue, 14 Dec 2010 18:43:49 +0000 (18:43 +0000)] 
Make wxRefCounter non copyable.

wxRefCounter copy ctor was wrong as the new object had the same reference
count as the old one instead of starting its life with reference count set to
1 as any new object should.

While we could fix its copy ctor, it seems to be better to forbid copying
wxRefCounter objects at all because the semantics of doing this is not obvious
and the compiler-generated copy ctor in the derived classes often doesn't do
what the code using it expects it to do, as was discovered by making
wxRefCounter non copyable: see the fixes in the previous commits.

To uncover all such bugs, make wxRefCounter and classes deriving from it non
copyable. If this uncovers more problems, they should be fixed by implementing
copying properly (and explicitly) in the derived classes.

Closes #12768.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66374 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoFail in CloneGDIRefData() instead of implementing it incorrectly in wxOSX.
Vadim Zeitlin [Tue, 14 Dec 2010 18:43:39 +0000 (18:43 +0000)] 
Fail in CloneGDIRefData() instead of implementing it incorrectly in wxOSX.

wxIcon and wxMetaFile implemented CloneGDIRefData() using copy ctors of the
corresponding ref data classes but the copy ctors were either wrong (for
wxIconRefData as using it would result in messing up IconRef reference count)
or had wrong semantics (wxMetafileRefData copy ctor performed shallow copy
only while CloneGDIRefData() supposes a deep copy is done).

Replace the wrong implementations of these functions with assert that will be
triggered if they are ever used (which doesn't seem to be the case so far).

See #12768.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66373 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDon't use implicit wxBitmapRefData copy ctor in wxGTK code.
Vadim Zeitlin [Tue, 14 Dec 2010 18:43:32 +0000 (18:43 +0000)] 
Don't use implicit wxBitmapRefData copy ctor in wxGTK code.

wxBitmapRefData didn't have a proper copy ctor but the code in wxGTK wxBitmap
implementation used it nevertheless and then manually patched the newly copied
object to avoid double pointer deletion and other unpleasantness.

Make the code more obviously correct by not using (nor providing) copy ctor at
all. There are no real changes otherwise.

See #12768.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66372 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoFail instead of crashing in wxGTK wxCursor::CloneGDIRefData().
Vadim Zeitlin [Tue, 14 Dec 2010 18:43:25 +0000 (18:43 +0000)] 
Fail instead of crashing in wxGTK wxCursor::CloneGDIRefData().

CloneGDIRefData() used wxCursorRefData copy ctor which wasn't implemented
correctly and simply copied its internal m_cursor member without incrementing
its reference count which resulted in a crash when it was then dereferenced
twice.

Unfortunately there doesn't seem to be any simple way to clone GDK cursors but
as this should be something only rarely (if ever?) needed, simply don't
implement CloneGDIRefData() at all for now and just leave an assert in it if
it's ever really called. Also don't define wxCursorRefData copy ctor at all as
it can't be done correctly.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66371 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoImprove wxImage handlers documentation, especially ownership aspect.
Vadim Zeitlin [Tue, 14 Dec 2010 18:43:17 +0000 (18:43 +0000)] 
Improve wxImage handlers documentation, especially ownership aspect.

Correct wxImage::RemoveHandler() documentation which was plain wrong.

Also mention that the handler will be deleted by wxImage in AddHandler()
documentation.

And add an example of using AddHandler() as well as fix the broken text in
wxInitAllImageHandlers() description.

Closes #12772.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66370 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoPreserve value when changing range of inverted wxSlider in wxMSW.
Vadim Zeitlin [Mon, 13 Dec 2010 18:10:02 +0000 (18:10 +0000)] 
Preserve value when changing range of inverted wxSlider in wxMSW.

The logical value of wxSlider was changed when its range was changed in wxMSW
if the slider had wxSL_INVERSE style because the logical value was actually
computed using the range and the actual physical control value and we forgot
to update the latter when changing the range.

Do update it now in SetRange() to fix this.

Also add unit tests checking for this and, more generally, for other
operations with inversed sliders.

Closes #12765.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66368 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoHave wxPropertyGrid::DoubleToString() to also take comma into account as a decimal...
Jaakko Salli [Mon, 13 Dec 2010 16:07:49 +0000 (16:07 +0000)] 
Have wxPropertyGrid::DoubleToString() to also take comma into account as a decimal separator. In addition, the function now returns target wxString (makes writing tests easier).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66367 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoAdded code to remove sign from zero in wxPropertyGrid::DoubleToString(). Fixes #12738.
Jaakko Salli [Sat, 11 Dec 2010 11:57:26 +0000 (11:57 +0000)] 
Added code to remove sign from zero in wxPropertyGrid::DoubleToString(). Fixes #12738.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66363 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agochanging compositing mode for Clear, see #12756
Stefan Csomor [Sat, 11 Dec 2010 11:48:38 +0000 (11:48 +0000)] 
changing compositing mode for Clear, see #12756

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66362 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoadding support for layout coordinates via insets from framecoordinates
Stefan Csomor [Tue, 7 Dec 2010 15:46:12 +0000 (15:46 +0000)] 
adding support for layout coordinates via insets from framecoordinates

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66360 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agofixing redraw debugging
Stefan Csomor [Tue, 7 Dec 2010 15:41:33 +0000 (15:41 +0000)] 
fixing redraw debugging

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66359 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoattempt at making the line continuation characters stay correct
Stefan Csomor [Tue, 7 Dec 2010 13:28:32 +0000 (13:28 +0000)] 
attempt at making the line continuation characters stay correct

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66358 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoupdating files list for iphone opengl
Stefan Csomor [Tue, 7 Dec 2010 10:11:53 +0000 (10:11 +0000)] 
updating files list for iphone opengl

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66357 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoupdated comment was not saved in former commit
Stefan Csomor [Tue, 7 Dec 2010 09:45:54 +0000 (09:45 +0000)] 
updated comment was not saved in former commit

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66356 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoupdated comment was not saved in former commit
Stefan Csomor [Tue, 7 Dec 2010 09:10:02 +0000 (09:10 +0000)] 
updated comment was not saved in former commit

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66355 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoreverting content area calculation for iphone as translucent status bars get ignored...
Stefan Csomor [Tue, 7 Dec 2010 08:53:11 +0000 (08:53 +0000)] 
reverting content area calculation for iphone as translucent status bars get ignored otherwise

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66354 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agofixing osx iphone build
Stefan Csomor [Sat, 4 Dec 2010 13:34:19 +0000 (13:34 +0000)] 
fixing osx iphone build

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66332 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoguarding compile
Stefan Csomor [Sat, 4 Dec 2010 13:33:45 +0000 (13:33 +0000)] 
guarding compile

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66331 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoadapting inheritance to other osx ports
Stefan Csomor [Sat, 4 Dec 2010 13:33:20 +0000 (13:33 +0000)] 
adapting inheritance to other osx ports

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66330 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoguarding against non-implemented parts
Stefan Csomor [Sat, 4 Dec 2010 13:32:51 +0000 (13:32 +0000)] 
guarding against non-implemented parts

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66329 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoRename wxGenericDirCtrl::ExpandDir() to PopulateNode().
Vadim Zeitlin [Fri, 3 Dec 2010 14:12:23 +0000 (14:12 +0000)] 
Rename wxGenericDirCtrl::ExpandDir() to PopulateNode().

This function doesn't really expand anything (unlike CollapseDir()) so give it
a better name while keeping the old one too for compatibility.

See #12735.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66315 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoSet the window in focus event sent by wxComboCtrl correctly.
Vadim Zeitlin [Fri, 3 Dec 2010 14:00:31 +0000 (14:00 +0000)] 
Set the window in focus event sent by wxComboCtrl correctly.

The window parameter wasn't copied correctly in the forwarded event. Fix this
and avoid future problems of the same kind by using the copy ctor for creating
the new event and then override the fields that we need to change from the
original event instead of recreating the new event from bits and pieces of the
original one.

Closes #12741.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66314 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoUpdate AUI bitmaps when its colours change.
Vadim Zeitlin [Fri, 3 Dec 2010 12:40:28 +0000 (12:40 +0000)] 
Update AUI bitmaps when its colours change.

Extract the bitmaps initialization in wxAuiDefaultDockArt::InitBitmaps() and
call it from SetColour() to ensure that the bitmaps are updated when the
colour scheme changes.

Closes #12532.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66313 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoNo changes, just clean up duplicate colour functions in wxAUI.
Vadim Zeitlin [Fri, 3 Dec 2010 12:40:23 +0000 (12:40 +0000)] 
No changes, just clean up duplicate colour functions in wxAUI.

Reuse wxcolour::AlphaBlend() and ChangeLightness() methods instead of
duplicating them in wxAUI-specific wxAui{Blend,Step}Colour().

See #12532.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66312 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoUpdate the directory icon in wxGenericDirCtrl::ExpandDir().
Vadim Zeitlin [Fri, 3 Dec 2010 12:40:15 +0000 (12:40 +0000)] 
Update the directory icon in wxGenericDirCtrl::ExpandDir().

Calling ExpandDir() to notify the control that a new item was added in a
previously empty directory didn't work as wxTreeCtrl::SetItemHasChildren()
wasn't called.

Fix this by moving SetItemHasChildren() to ExpandDir() from OnExpandItem(), it
must be always done and not just in response to an interactive action.

Closes #12735.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66311 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoNo changes, just clean up duplicate colour functions in wxSearchCtrl.
Vadim Zeitlin [Fri, 3 Dec 2010 12:40:08 +0000 (12:40 +0000)] 
No changes, just clean up duplicate colour functions in wxSearchCtrl.

Use wxColor::ChangeLightness() instead of private wxStepColour() that
duplicates it.

Close #12744.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66310 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoOptimize pixels rotation in wxImage::Rotate90().
Vadim Zeitlin [Fri, 3 Dec 2010 12:40:03 +0000 (12:40 +0000)] 
Optimize pixels rotation in wxImage::Rotate90().

Rotate the image by entire strips instead of doing it pixel by pixel.

This seems to result in about 50% performance gain.

Closes #12739.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66309 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDon't require leading TAB in wxAcceleratorEntry::FromString().
Vadim Zeitlin [Fri, 3 Dec 2010 12:39:57 +0000 (12:39 +0000)] 
Don't require leading TAB in wxAcceleratorEntry::FromString().

FromString() should parse string returned by ToString() successfully but this
wasn't the case because the accelerator parsing functions always insisted on
having a TAB in the string.

Fix this, document the string format and add a unit test checking for the
correct behaviour.

Closes #12745.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66308 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDon't try to extract accelerators from menu items which don't have any.
Vadim Zeitlin [Fri, 3 Dec 2010 12:39:48 +0000 (12:39 +0000)] 
Don't try to extract accelerators from menu items which don't have any.

We don't need to call wxAcceleratorEntry::Create() in wxMenuItem::GetAccel()
if the menu item doesn't have any accelerator at all, i.e. if there is no TAB
in its label.

Calling wxAcceleratorEntry::Create() is useless and won't work correctly any
more when Create() is updated to allow passing it strings without TAB in them
in the next commit.

See #12745.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66307 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoFix wxRect::SetRightTop() which set the wrong corner.
Vadim Zeitlin [Fri, 3 Dec 2010 12:39:43 +0000 (12:39 +0000)] 
Fix wxRect::SetRightTop() which set the wrong corner.

SetRightTop() erroneously forwarded to SetTopLeft() instead of SetTopRight().

Closes #12746.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66306 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoMention in wxHashSet documentation that its contents is not sorted.
Vadim Zeitlin [Fri, 3 Dec 2010 12:39:34 +0000 (12:39 +0000)] 
Mention in wxHashSet documentation that its contents is not sorted.

The documentation gave a wrong impression that this class was a std::set
replacement which it isn't.

See #12727.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66305 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agofixing missing return value
Stefan Csomor [Wed, 1 Dec 2010 07:42:13 +0000 (07:42 +0000)] 
fixing missing return value

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66304 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agomerge libpng 1.4.4 to trunk
Paul Cornett [Tue, 30 Nov 2010 18:41:25 +0000 (18:41 +0000)] 
merge libpng 1.4.4 to trunk

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66303 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoadd src/gtk1/mnemonics.cpp to files.bkl and rebake
Paul Cornett [Tue, 30 Nov 2010 18:01:53 +0000 (18:01 +0000)] 
add src/gtk1/mnemonics.cpp to files.bkl and rebake

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66302 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoAdd mnemonics to wxGTK1
Jouk Jansen [Tue, 30 Nov 2010 10:19:29 +0000 (10:19 +0000)] 
Add mnemonics to wxGTK1

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66301 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoadding standard menu items for cocoa, adding translation macro to menulabels, fixes...
Stefan Csomor [Tue, 30 Nov 2010 09:59:11 +0000 (09:59 +0000)] 
adding standard menu items for cocoa, adding translation macro to menulabels, fixes #12732

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66300 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoadding defines to support building against 10.4u.SDK
Stefan Csomor [Mon, 29 Nov 2010 08:57:00 +0000 (08:57 +0000)] 
adding defines to support building against 10.4u.SDK

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66293 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDon't compare invalid iterators in wxCommandProcessor code.
Vadim Zeitlin [Sun, 28 Nov 2010 15:14:49 +0000 (15:14 +0000)] 
Don't compare invalid iterators in wxCommandProcessor code.

Comparing invalid iterators results in an assert failure in STL build.

We might also change wxList::compatibility_iterator::operator==() to allow
comparing invalid iterators (which should be different from all the other ones
but what about comparing two invalid iterators?) but it would probably be
better to get rid of all uses of compatibility_iterator in the code instead in
the long term.

Closes #12730.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66287 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoVerify the return value of wxItemContainer::Insert() in the tests.
Vadim Zeitlin [Sat, 27 Nov 2010 11:34:47 +0000 (11:34 +0000)] 
Verify the return value of wxItemContainer::Insert() in the tests.

Check that Insert() returns the index of the last inserted item.

Also document this behaviour for mulit-item renames explicitly.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66278 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoFix the return value of wxSimpleHtmlListBox::Insert().
Vadim Zeitlin [Sat, 27 Nov 2010 11:34:40 +0000 (11:34 +0000)] 
Fix the return value of wxSimpleHtmlListBox::Insert().

The returned index was off by 1.

Closes #12717.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66277 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoAdd wx(Simple)HtmlListBox unit test.
Vadim Zeitlin [Sat, 27 Nov 2010 11:34:34 +0000 (11:34 +0000)] 
Add wx(Simple)HtmlListBox unit test.

For now just test the wxItemContainer methods.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66276 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDocument wxSimpleHtmlListBox inheritance from wxItemContainer.
Vadim Zeitlin [Sat, 27 Nov 2010 11:34:25 +0000 (11:34 +0000)] 
Document wxSimpleHtmlListBox inheritance from wxItemContainer.

Without wxItemContainer in the docs all the item maintenance methods were
absent from wxSimpleHtmlListBox.

See #12717.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66275 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoMove the Mac methods from wxAppConsole to wxApp
Robin Dunn [Sat, 27 Nov 2010 08:42:04 +0000 (08:42 +0000)] 
Move the Mac methods from wxAppConsole to wxApp

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66270 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agowxDefaultVideoMode is const
Robin Dunn [Sat, 27 Nov 2010 08:40:27 +0000 (08:40 +0000)] 
wxDefaultVideoMode is const

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66269 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agowxPlatformInfo does not derive from wxObject
Robin Dunn [Sat, 27 Nov 2010 08:38:46 +0000 (08:38 +0000)] 
wxPlatformInfo does not derive from wxObject

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66268 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoFix 100% CPU usage on wxGTK caused by a recent change in wxPropertyGridEditorEventFor...
Jaakko Salli [Fri, 26 Nov 2010 17:39:47 +0000 (17:39 +0000)] 
Fix 100% CPU usage on wxGTK caused by a recent change in wxPropertyGridEditorEventForwarder::ProcessEvent()

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66267 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoUpdate configure helper scripts to latest versions from GNU project.
Vadim Zeitlin [Fri, 26 Nov 2010 13:31:15 +0000 (13:31 +0000)] 
Update configure helper scripts to latest versions from GNU project.

The new version (the one we used was 6 years out of date) notably detects 64
bit MinGW platforms correctly which closes #12356.

Also update config.{guess,sub} scripts in 3rd party libraries directories to
bring them all in sync with the main one and ensure that MinGW 64 is supported
by them too.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66265 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoSmall bug fixes for GetLibraryVersionInfo() changes.
Vadim Zeitlin [Fri, 26 Nov 2010 13:31:07 +0000 (13:31 +0000)] 
Small bug fixes for GetLibraryVersionInfo() changes.

Fix the minor version determination for libtiff which was done wrongly by
r66259 and provide a properly formatted description for Scintilla version.

See #12690.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66264 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoNo real changes, just remove unnecessary const workaround.
Vadim Zeitlin [Fri, 26 Nov 2010 13:30:43 +0000 (13:30 +0000)] 
No real changes, just remove unnecessary const workaround.

The comment about "wxString doesn't having enough const members" was totally
incomprehensible and clearly wrong. Just remove the hack it was explaining.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66263 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoAllow wxAutomationObject::GetInstance() create new instance if needed.
Vadim Zeitlin [Fri, 26 Nov 2010 13:30:37 +0000 (13:30 +0000)] 
Allow wxAutomationObject::GetInstance() create new instance if needed.

When getting an instance of an OLE automation object, it is often useful to
connect to the existing instance if any or start a new one otherwise. Make
GetInstance() behave like this by default while still allowing to use the
wxAutomationInstance_UseExistingOnly flag to reestablish the old behaviour.

Also improve the error reporting in wxAutomationObject.

See #12489.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66262 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoNo real changes, just use ProgID term instead of incorrect CLSID.
Vadim Zeitlin [Fri, 26 Nov 2010 13:30:25 +0000 (13:30 +0000)] 
No real changes, just use ProgID term instead of incorrect CLSID.

CLSID was used instead of ProgID in several places in the code and the
documentation but they are different things so clear up the confusion.

See #12489.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66261 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoled to build issues with xcode and graphics context
Stefan Csomor [Thu, 25 Nov 2010 18:04:01 +0000 (18:04 +0000)] 
led to build issues with xcode and graphics context

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66260 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoAdd wxVersionInfo and functions returning it for 3rd party libraries.
Vadim Zeitlin [Thu, 25 Nov 2010 00:53:44 +0000 (00:53 +0000)] 
Add wxVersionInfo and functions returning it for 3rd party libraries.

Add simple wxVersionInfo class holding the version information.

Also add GetLibraryVersionInfo() static method to wx{JPEG,PNG,TIFF}Handler,
wxStyledTextCtrl and wxXmlDocument classes and wxGetZlibVersionInfo() and
wxGetLibraryVersionInfo() global functions using it.

Closes #12690.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66259 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDocument some previously undocumented wxAboutDialogInfo getters.
Vadim Zeitlin [Thu, 25 Nov 2010 00:53:30 +0000 (00:53 +0000)] 
Document some previously undocumented wxAboutDialogInfo getters.

See #12690.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66258 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoMention status bar fields limits under pre-XP MSW systems.
Vadim Zeitlin [Thu, 25 Nov 2010 00:53:24 +0000 (00:53 +0000)] 
Mention status bar fields limits under pre-XP MSW systems.

Mention that before comctl32.dll status bar fields were limited to 127
characters only.

See #12709.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66257 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoWarn that normalizing a valid path may make it invalid sometimes.
Vadim Zeitlin [Wed, 24 Nov 2010 12:43:45 +0000 (12:43 +0000)] 
Warn that normalizing a valid path may make it invalid sometimes.

Mention the special case of a path without file name and with directory that
normalizes to empty string.

See #10960.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66255 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoOptimize wxImage::Rotate90() by rotating alpha separately.
Vadim Zeitlin [Wed, 24 Nov 2010 12:43:36 +0000 (12:43 +0000)] 
Optimize wxImage::Rotate90() by rotating alpha separately.

Bringing the alpha rotation out in a separate loop results in an
approximatively 10% performance improvement.

Closes #12712.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66254 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoAdd support for negatable command line switches.
Vadim Zeitlin [Wed, 24 Nov 2010 00:42:53 +0000 (00:42 +0000)] 
Add support for negatable command line switches.

Add wxCMD_LINE_SWITCH_NEGATABLE which allows to use a dash after a command
line switch to inverse its meaning (i.e. use "/X-" form). Also add new
wxCmdLineParser::FoundSwitch() allowing to check for whether the switch was
specified in normal or negated form.

Closes #11643.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66253 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoRewind the input stream after failing to load image from it.
Vadim Zeitlin [Wed, 24 Nov 2010 00:42:45 +0000 (00:42 +0000)] 
Rewind the input stream after failing to load image from it.

For seekable streams, don't change the current position when loading image
fails. This allows the subsequent image handlers to succeed during image
format auto-detection even if a previous, erroneously chosen, handler failed.

Closes #12702.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66252 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoImprove error messages from wxImage::LoadFile().
Vadim Zeitlin [Wed, 24 Nov 2010 00:42:35 +0000 (00:42 +0000)] 
Improve error messages from wxImage::LoadFile().

The error given when loading an image file failed was not very useful because
they didn't specify which file exactly we failed to load and also because the
numeric handler type which means nothing at all to the end user (and not much
to the developer) was used.

Use the description of the file format instead and also always give the name
of the file that we failed to load.

Finally, remove the test for file existence: this is one of many reasons why
opening the file could fail and it doesn't make sense to handle it specially,
just let the underlying stream generate the appropriate error message in all
cases.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66251 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoSkip mouse events outside of item area in wxDataViewCtrl.
Vadim Zeitlin [Wed, 24 Nov 2010 00:42:19 +0000 (00:42 +0000)] 
Skip mouse events outside of item area in wxDataViewCtrl.

Don't consume mouse events outside of the area occupied by the items in the
generic implementation of wxDataViewCtrl as this prevented wxEVT_CONTEXT_MENU
events from being generated.

Closes #12706.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66250 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoUse an enum for the colour/string conversion flags
Robin Dunn [Tue, 23 Nov 2010 22:14:57 +0000 (22:14 +0000)] 
Use an enum for the colour/string conversion flags

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66249 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoFixed parameter names. They can't be named "short"
Robin Dunn [Tue, 23 Nov 2010 22:14:18 +0000 (22:14 +0000)] 
Fixed parameter names.  They can't be named "short"

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66248 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoVC6 compilation fix: don't return void values.
Vadim Zeitlin [Tue, 23 Nov 2010 13:12:33 +0000 (13:12 +0000)] 
VC6 compilation fix: don't return void values.

Fix VC6 compilation broken by r66237: don't return the result from a void
function, this compiler doesn't support this C++ feature.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66246 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoSimplify timezone-related code and fix some minor bugs in it.
Vadim Zeitlin [Tue, 23 Nov 2010 13:11:10 +0000 (13:11 +0000)] 
Simplify timezone-related code and fix some minor bugs in it.

Try to make the chain of preprocessor checks for different ways of getting
time zone from the CRT more clear.

Also call _tzset() for all MSVC versions, not just MSVC8+ (closes #12700). We
should probably call tzset() for the other compilers too, in fact.

And multiply the timezone returned from ftime() by 60 as it's supposed to be
in minutes and not seconds as needed.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66245 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoCenter task dialog-based wxProgressDialog on the parent window.
Vadim Zeitlin [Tue, 23 Nov 2010 13:11:02 +0000 (13:11 +0000)] 
Center task dialog-based wxProgressDialog on the parent window.

wxProgressDialog was created without the parent when using task dialogs so it
was centred on screen and not on its parent as usual. Fix this by explicitly
positioning it so that it's centered over the parent.

Closes #12699.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66244 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDeselect all items in wxMSW wxListBox when selection is set to -1.
Vadim Zeitlin [Tue, 23 Nov 2010 13:10:54 +0000 (13:10 +0000)] 
Deselect all items in wxMSW wxListBox when selection is set to -1.

Even though this behaviour is somewhat counterintuitive, the documentation
mentions that this is what should happen and wxGTK and wxOSX already behave
like this so bring wxMSW in line.

wxListBox::DeselectAll() should probably just call SetSelection(wxNOT_FOUND)
when the item to leave selected is not specified too now.

Closes #12705.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66243 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agofixing 64 bit ranger error
Stefan Csomor [Mon, 22 Nov 2010 16:38:44 +0000 (16:38 +0000)] 
fixing 64 bit ranger error

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66242 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoInitialize time zone information before using it in wxGetTimeZone().
Vadim Zeitlin [Mon, 22 Nov 2010 16:18:47 +0000 (16:18 +0000)] 
Initialize time zone information before using it in wxGetTimeZone().

We must call _tzset() before calling _get_timezone() as while this is normally
done implicitly by the other time functions, it might not have been done yet
if create a wxDateTime::TimeZone before calling any of them.

Closes #12700.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66241 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoHave wxPropertyGridEditorEventForwarder::ProcessEvent() return true more often -...
Jaakko Salli [Mon, 22 Nov 2010 14:28:16 +0000 (14:28 +0000)] 
Have wxPropertyGridEditorEventForwarder::ProcessEvent() return true more often - that is when the event was recognized as being 'handled', and specifically for the case of property editor's button being pressed (fixes #12487).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66240 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoFix wxUniv build after deriving wxStatusBar from wxControl.
Vadim Zeitlin [Mon, 22 Nov 2010 12:51:05 +0000 (12:51 +0000)] 
Fix wxUniv build after deriving wxStatusBar from wxControl.

wxUniv build was broken since the base class of wxStatusBar was changed from
wxWindow to wxControl in r66226 because it derived twice from wxInputConsumer
now.

Fix this by simply not inheriting wxStatusBarUniv from wxInputConsumer any
more, it already derives from it via wxControl now.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66239 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoRevert "Always define WXUSINGDLL when compiling Scintilla in shared wx build."
Vadim Zeitlin [Mon, 22 Nov 2010 12:49:25 +0000 (12:49 +0000)] 
Revert "Always define WXUSINGDLL when compiling Scintilla in shared wx build."

Finally it's unnecessary to define WXUSINGDLL when building wxScintilla
library as it doesn't use the main DLL, it is simply used as part of it.

This reverts r66222 and finally closes #12626.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66238 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDon't try to center task dialogs under Windows.
Vadim Zeitlin [Mon, 22 Nov 2010 12:49:07 +0000 (12:49 +0000)] 
Don't try to center task dialogs under Windows.

This is either unnecessary or doesn't work anyhow (they are always centered on
the parent window) and just results in debug error messages.

Simply don't do anything in wxMessageDialog::Centre() when using task dialog
implementation under MSW.

Closes #12699.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66237 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoSet the width of the last status bar pane correctly in wxMSW.
Vadim Zeitlin [Mon, 22 Nov 2010 12:48:47 +0000 (12:48 +0000)] 
Set the width of the last status bar pane correctly in wxMSW.

The total width of status bar panes must add up to the size of the status bar
as otherwise an extra unwanted border is drawn after the last pane and we did
have this border for status bar with a size grip.

So while we still use the width without the size grip for calculating the
fields widths, pass the width with the size grip to Windows to prevent this
from happening.

Also, don't pretend that the last field stretches up to the status bar edge
when it should end before the size grip and Windows even already helpfully
does it for us.

Closes #12655.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66236 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoAdd status bar styles mapping to MSW styles broken by recent changes.
Vadim Zeitlin [Mon, 22 Nov 2010 12:48:42 +0000 (12:48 +0000)] 
Add status bar styles mapping to MSW styles broken by recent changes.

SBARS_SIZEGRIP and CCS_TOP should be added to the normal style, not the
extended one. This restores the behaviour broken by r66227.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66235 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoPut WINDRES_CPU_DEFINE in RESFLAGS and not RESCOMP in configure.
Vadim Zeitlin [Mon, 22 Nov 2010 12:48:35 +0000 (12:48 +0000)] 
Put WINDRES_CPU_DEFINE in RESFLAGS and not RESCOMP in configure.

WINDRES_CPU_DEFINE is just another resource compiler flag which should be part
of RESFLAGS instead of being added to RESCOMP definition itself. This is not
only more logical but also fixes the problem with matching RESCOMP against
"windres" or "wrc" in wx-config.

See #12356.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66234 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoMake wxChoicebook background transparent.
Vadim Zeitlin [Mon, 22 Nov 2010 01:23:21 +0000 (01:23 +0000)] 
Make wxChoicebook background transparent.

This fixes the appearance of an empty wxChoicebook used as a child of a
wxNotebook under MSW.

Closes #12503.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66233 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDeprecate not working wxSplitterWindow::SetSashSize().
Vadim Zeitlin [Mon, 22 Nov 2010 01:23:16 +0000 (01:23 +0000)] 
Deprecate not working wxSplitterWindow::SetSashSize().

Setting sash size to non default value didn't work correctly and didn't make
much sense anyhow as the sash appearance is platform-dependent and current
code for drawing it doesn't work for arbitrary sizes.

Simply remove the possibility to set the sash size.

Closes #12412.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66232 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

13 years agoDon't set explicit background colour for wxStatusBar in wxMSW.
Vadim Zeitlin [Mon, 22 Nov 2010 01:23:09 +0000 (01:23 +0000)] 
Don't set explicit background colour for wxStatusBar in wxMSW.

Setting the background colour for the status bar explicitly is unnecessary and
probably prevents it from rendering correctly with some themes. Simply remove
the call to SetBackgroundColour() from wxStatusBar::Create().

We should also define Get[Class]DefaultAttributes() in wxStatusBar in the
future.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66231 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775