Fail in CloneGDIRefData() instead of implementing it incorrectly in wxOSX.
authorVadim Zeitlin <vadim@wxwidgets.org>
Tue, 14 Dec 2010 18:43:39 +0000 (18:43 +0000)
committerVadim Zeitlin <vadim@wxwidgets.org>
Tue, 14 Dec 2010 18:43:39 +0000 (18:43 +0000)
commitf9b4d680d72930c31fe14dd63421a85d97ccd739
treeb3af698dc9c858b08e39b31c0ef6f4caffcb76c9
parentfc684792c6b050fbfeabbea92e302bc3469d7489
Fail in CloneGDIRefData() instead of implementing it incorrectly in wxOSX.

wxIcon and wxMetaFile implemented CloneGDIRefData() using copy ctors of the
corresponding ref data classes but the copy ctors were either wrong (for
wxIconRefData as using it would result in messing up IconRef reference count)
or had wrong semantics (wxMetafileRefData copy ctor performed shallow copy
only while CloneGDIRefData() supposes a deep copy is done).

Replace the wrong implementations of these functions with assert that will be
triggered if they are ever used (which doesn't seem to be the case so far).

See #12768.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66373 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
src/osx/carbon/icon.cpp
src/osx/carbon/metafile.cpp