Paul Cornett [Tue, 3 Sep 2013 05:37:30 +0000 (05:37 +0000)]
Fix referencing of cairo_t returned from wxDCImpl::GetCairoContext().
It was assumed that all callers were going to unref the cairo_t, but that is not
true, so callers that are going to unref it should ref it themselves.
See #15455
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74746
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Mon, 2 Sep 2013 12:17:06 +0000 (12:17 +0000)]
Replace @since 2.9.6 with 3.0 in the docs.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74742
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 31 Aug 2013 17:41:16 +0000 (17:41 +0000)]
Rewrite wxLogXXX() macros to avoid "ambiguous else" warnings.
Use a dummy for loop instead of an if statement to avoid all problems with the
dangling else clauses: both the need for an artificially inversed "if" to make
the code like
if ( something )
wxLogError("...");
else
something-else;
to work as expected and to avoid warnings given by some versions of g++ and
clang for the code above advising to add explicit braces.
Closes #11829.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74735
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 31 Aug 2013 17:41:13 +0000 (17:41 +0000)]
Removed a method using wxColour from non-GUI benchmark code.
No idea how could this work before but the presence of this code in the
non-GUI benchmark project prevented it from building. As it's not used anyhow,
just remove it.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74734
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Sat, 31 Aug 2013 03:25:12 +0000 (03:25 +0000)]
Don't update position of widgets in a wxPizza from size_allocate handler.
The values in m_{x,y} are not the same as client coordinates if the wxPizza is scrolled.
Closes #15444
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74733
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 30 Aug 2013 23:32:42 +0000 (23:32 +0000)]
Fix infinite loop in wxMSW with wxStaticBox inside non-wxTAB_TRAVERSAL parent.
We didn't ensure that the parent of a (native) control with WS_EX_CONTROLPARENT
had this style as well, unlike for our own windows. Fix this now to make
certain that we never call ::IsDialogMessage() on a window whose parent
doesn't have WS_EX_CONTROLPARENT as it simply hangs in this case, entering an
infinite loop searching for the default button.
Also try to reduce the possibility of such bugs in the future by checking for
WS_EX_CONTROLPARENT and not wxTAB_TRAVERSAL before calling ::IsDialogMessage()
even if this doesn't totally prevent them (it wasn't sufficient to fix even
this particular bug).
Closes #15458.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74732
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 30 Aug 2013 23:32:37 +0000 (23:32 +0000)]
Fix wxMenu::GetTitle() before the menu is appended to the menu bar.
The mnemonics conversion was not done correctly when the menu title contained
them but the menu hadn't been appended to the menu bar yet.
Closes #15461.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74731
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Fri, 30 Aug 2013 13:14:50 +0000 (13:14 +0000)]
Loosen the assert in IsScrollIncrement().
wxWindowGTK::GTKGetScrollEventType() tries to map GtkAdjustment's delta
to either step or page increment by comparing it with the respective
GtkAdjustment steps. Both of them can be 0, but this code is not
expected to be called in such case.
Yet, in practice, it occasionally is, see e.g.
http://devel.aegisub.org/ticket/979GTKGetScrollEventType (wxWebView is
prone to it as well).
Check for >= 0 instead, to be more robust when faced with unexpected
input from GTK+.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74730
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 29 Aug 2013 20:44:58 +0000 (20:44 +0000)]
Initialize wxImageFileProperty correctly when file is given in the ctor.
Previously the file had to be specified later and the value passed to the ctor
was ignored.
Closes #15456.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74729
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 29 Aug 2013 12:33:44 +0000 (12:33 +0000)]
Don't define __STRICT_ANSI__, we should build both with and without it.
For some reason, wxDialUpManager code defined __STRICT_ANSI__ itself, don't do
it as __STRICT_ANSI__ can be predefined by the compiler resulting in the
redefinition warnings and, in any case, our code should build both with and
without it.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74728
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Thu, 29 Aug 2013 11:41:48 +0000 (11:41 +0000)]
Crash fix for inserting text into a buffer without an associated control
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74727
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 29 Aug 2013 11:15:53 +0000 (11:15 +0000)]
Only patch bk-deps in configure if dependency tracking is used.
Otherwise we get (harmless) errors when trying to patch a non-existent file.
See #15454.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74726
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jouk Jansen [Thu, 29 Aug 2013 06:39:38 +0000 (06:39 +0000)]
wxGTK1 : another msiing include file in evtloop.cpp
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74725
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 28 Aug 2013 20:52:46 +0000 (20:52 +0000)]
Czech translations update from Zbyněk Schwarz.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74724
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jouk Jansen [Wed, 28 Aug 2013 06:01:12 +0000 (06:01 +0000)]
wxGTK1 : wx/private/eventloopsourcesmanager.h was missing in evtloop.cpp
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74723
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 27 Aug 2013 22:49:53 +0000 (22:49 +0000)]
Don't enable dialog navigation inside wxFrame by default.
This was done, apparently accidentally, by r68366 and resulted in cursor arrow
keys not being sent by default to the wxFrame children under MSW any more as
they were used for dialog navigation instead.
So don't derive wxTopLevelWindow from wxNavigationEnabled<> any more and only
derive from it at wxDialog level.
Closes #15445.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74722
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 27 Aug 2013 22:49:48 +0000 (22:49 +0000)]
Don't recurse into top level children in wxWindow::FindWindow().
Finding a button in a child dialog when looking for it in the current window
is totally unexpected and can result in subtle bugs, see #15442.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74721
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 27 Aug 2013 22:49:44 +0000 (22:49 +0000)]
Handle custom configurations in MSVC-specific setup.h.
Account for wxCFG when building the paths used for MSVC autolinking. This
variable should be defined to the same value as CFG during (command line)
build.
Closes #15431.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74720
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 27 Aug 2013 22:49:38 +0000 (22:49 +0000)]
Explicitly specify target names for all configurations in VC10 projects.
The target names were not specified for the "Release" configuration in some
projects, resulting in (harmless, but annoying) warnings during the build.
Closes #15439.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74719
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 27 Aug 2013 22:49:34 +0000 (22:49 +0000)]
Use $(OutDir) instead of explicit directories in VC10 project files.
This makes it simpler to use a different output directory as it only needs to
be changed in one place.
See #15439.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74718
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 27 Aug 2013 22:49:28 +0000 (22:49 +0000)]
Correct making the newly inserted menu item owner drawn in some cases.
The item being inserted is not inserted yet when we call
SetOwnerDrawnMenuItem() so we must call it separately for it after inserting
it.
Closes #15437.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74717
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 27 Aug 2013 22:49:23 +0000 (22:49 +0000)]
Don't use any icon for items inserted without one in wxMSW wxListCtrl.
Previously we erroneously used the first icon in the image list for them
instead. This was inconsistent with wxGTK and didn't make much sense, even if
it is the default behaviour of the native control, so don't do this any more
and explicitly specify I_IMAGENONE for the icon if it wasn't given.
Closes #15421.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74716
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 27 Aug 2013 13:12:38 +0000 (13:12 +0000)]
Make wxWindow::HasScrollbar() respect wxScrolled::ShowScrollbars().
Override CanScroll() in wxScrolled to return the real state of the scrollbar
instead of just relying on the wx[HV]SCROLL styles.
Closes #15440.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74714
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 27 Aug 2013 13:12:31 +0000 (13:12 +0000)]
No real changes, just make wxWindow::CanScroll() virtual.
This will allow overriding it in wxScrolled<>, see #15440.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74713
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jouk Jansen [Tue, 27 Aug 2013 12:02:20 +0000 (12:02 +0000)]
Update OpenVMS compile support
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74712
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jouk Jansen [Tue, 27 Aug 2013 11:46:13 +0000 (11:46 +0000)]
revert nested event loop support for wxGTK1 because it causes applications hangs
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74711
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Sun, 25 Aug 2013 08:36:54 +0000 (08:36 +0000)]
correct base for carbon is 10.6 max
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74710
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Sun, 25 Aug 2013 08:28:43 +0000 (08:28 +0000)]
adding correct valid architectures
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74709
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Sat, 24 Aug 2013 19:20:03 +0000 (19:20 +0000)]
proper default for iphone
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74708
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Sat, 24 Aug 2013 19:05:28 +0000 (19:05 +0000)]
carbon sdk must be 10.7 max, 10.8 is not supported anymore
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74707
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Sat, 24 Aug 2013 19:00:09 +0000 (19:00 +0000)]
leave i386 compiler to default
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74706
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 24 Aug 2013 14:33:33 +0000 (14:33 +0000)]
Add webviewarchivehandler.cpp to manually maintained VC10 project file.
Closes #15427.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74705
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 24 Aug 2013 14:33:28 +0000 (14:33 +0000)]
Fix Doxygen warnings due to documenting overloaded functions together.
Apparently we can't make @param statements apply just to some overloads, so
document them separately now.
See #15346.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74704
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 24 Aug 2013 14:33:22 +0000 (14:33 +0000)]
Move code removing "-psn_xxx" command line arguments to common code.
We need to do this when using any port under OS X, not just wxOSX, e.g. the
-psn_xxx arguments passed by the Finder when launching the application, must
also be ignored when using wxGTK.
Closes #15432.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74703
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 24 Aug 2013 14:33:16 +0000 (14:33 +0000)]
Fix DLL targets names in manually maintained VC10 project files.
This takes care of annoying warning about "target name does not match linker
output file name" when building the DLLs.
Closes #15435.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74702
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 24 Aug 2013 14:33:09 +0000 (14:33 +0000)]
Fix recreating of wxBitmapComboBox using untyped client data.
Use the correct array when restoring the client data, correcting a fatal typo
in the changes of r73880.
Closes #15436.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74701
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Sat, 24 Aug 2013 05:11:28 +0000 (05:11 +0000)]
remove redundant initialization of base class member variables
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74700
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Sat, 24 Aug 2013 05:04:11 +0000 (05:04 +0000)]
wxDialogBase only has one ctor, so just do initialization in ctor instead of Init()
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74699
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 24 Aug 2013 01:03:47 +0000 (01:03 +0000)]
Fix typo in wxConfig example in the documentation.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74698
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 24 Aug 2013 01:02:57 +0000 (01:02 +0000)]
Another Basque translations update from Xabier Aramendi.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74697
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 23 Aug 2013 16:37:09 +0000 (16:37 +0000)]
Fix wxHtmlHelpData::SetTempDir() to behave correctly without trailing slash.
The path passed to this function is always a directory, so use
wxFileName::AssignDir() instead of the default constructor of wxFileName which
considers the name to be a name of a file unless it ends with a path separator.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74696
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 23 Aug 2013 16:23:51 +0000 (16:23 +0000)]
Update Basque translations after wxGetTranslation() strings addition.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74695
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 23 Aug 2013 16:22:40 +0000 (16:22 +0000)]
Basque translations update from Xabier Aramendi.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74694
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 23 Aug 2013 16:22:35 +0000 (16:22 +0000)]
Regenerated message catalogs with the strings inside wxGetTranslation().
We didn't extract the strings inside wxGetTranslation() in the message catalog
when creating it using xgettext, do it now.
This notably fixes the missing translations for the generic progress dialog
elapsed/estimated/remaining time labels.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74693
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robin Dunn [Wed, 21 Aug 2013 15:50:27 +0000 (15:50 +0000)]
fix missing ;
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74692
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Steve Lamerton [Wed, 21 Aug 2013 15:26:34 +0000 (15:26 +0000)]
Fix various documentation warnings throughout core and base.
See #15346.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74691
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Steve Lamerton [Wed, 21 Aug 2013 15:21:08 +0000 (15:21 +0000)]
Fix ribbon documentation warnings.
See #15346.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74690
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Steve Lamerton [Wed, 21 Aug 2013 15:20:28 +0000 (15:20 +0000)]
Fix html documentation warnings.
See #15346.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74689
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Steve Lamerton [Wed, 21 Aug 2013 13:24:48 +0000 (13:24 +0000)]
Fix warnings in rich text documentation.
See #15346.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74688
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Mon, 19 Aug 2013 17:25:56 +0000 (17:25 +0000)]
Remove DoSetSizeHints() call from Create()
The reason it was added does not seem to be reproducible anymore,
and it interferes with wxRESIZE_BORDER on Ubuntu.
Closes #14870
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74685
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Mon, 19 Aug 2013 16:58:43 +0000 (16:58 +0000)]
revert r74683, wxTLW has its own {Width,Height}Default()
which are not the ones called by PreCreation()
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74684
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Mon, 19 Aug 2013 05:42:21 +0000 (05:42 +0000)]
Remove some old redundant code
Default size stuff is done by PreCreation()
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74683
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Sun, 18 Aug 2013 16:00:22 +0000 (16:00 +0000)]
avoid setting initial position if it was not specified, broken in r70734
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74682
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Sun, 18 Aug 2013 15:01:06 +0000 (15:01 +0000)]
Move code that does not need realized GdkWinow out of realize handler
These calls can be made much earlier, and it seems like a good idea to do so.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74681
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 18 Aug 2013 13:28:28 +0000 (13:28 +0000)]
Only give capture to wxPopupTransientWindow child if it's the only one.
This removes the arbitrariness of using the first child which didn't make any
sense when the popup had several controls inside it, e.g. in wxRichToolTip
case this resulted in the mouse capture being given to wxStaticBitmap showing
the tooltip icon even though it didn't need it at all.
This probably doesn't really change the observable behaviour but seems more
logical.
See #15288.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74680
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 18 Aug 2013 13:28:23 +0000 (13:28 +0000)]
Use wxFindWindowAtPoint() for hit testing in wxPopupTransientWindow.
This works even with irregularly shaped windows such as wxRichToolTip unlike
the old naive test using wxRect::Contains() which didn't and resulted in us
believing that the mouse was outside the window when it was still in it and
(somehow, the details are not totally clear) recapturing the mouse again and
again in the same window which resulted in assert failures with the new checks
in wxWindowBase::CaptureMouse() or the capture stack corruption before this.
Closes #15288.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74679
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 18 Aug 2013 13:28:19 +0000 (13:28 +0000)]
Return NULL from wxWindow::GetCapture() when the capture is being lost.
Make GetCapture() return NULL during wxEVT_MOUSE_CAPTURE_{LOST,CHANGED} events
processing in wxMSW to help their handlers to avoid calling ReleaseCapture():
this shouldn't be done as the mouse capture is being lost anyhow and results
in reentrancy problems between NotifyCaptureLost() and ReleaseCapture() if
it's called.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74678
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 18 Aug 2013 13:28:16 +0000 (13:28 +0000)]
Make mouse capture checking asserts stronger and more detailed.
Verify not only that we don't destroy the window having the capture now but
also that this window is not in the mouse capture stack at all, not
necessarily on top. This is important as keeping a dangling pointer in the
capture stack would result in difficult to diagnose bugs later.
Also check that we don't recapture the mouse in the same window as this should
never be necessary.
Finally, give more details in the assert checking that the window does have
capture in ReleaseMouse().
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74677
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 18 Aug 2013 13:28:13 +0000 (13:28 +0000)]
Don't set even try to set focus to wxPopupWindow itself in wxMSW.
This doesn't work anyhow with our popup window implementation (it's a child of
the desktop and we can't set focus to it) and provokes error messages due to
::SetFocus() failures, so simply don't do this at all.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74676
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 18 Aug 2013 13:28:09 +0000 (13:28 +0000)]
No changes, just change data structures used by mouse capture code.
Use a simple stack of windows instead of a separate singly linked list and a
separate current capture pointer.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74675
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 18 Aug 2013 13:28:06 +0000 (13:28 +0000)]
No changes, just use wxRecursionGuard instead of manual boolean flag.
Use wxRecursionGuard with the flag indicating whether the mouse capture is
changing to ensure that we always reset it correctly and make the code
slightly shorter.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74674
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 18 Aug 2013 13:28:02 +0000 (13:28 +0000)]
No changes, just move mouse capturing bookkeeping data out of wxWindow.
All mouse capture-related data doesn't have to be declared in wxWindow itself
and can just be global in wincmn.cpp, so move it there, this will facilitate
further changes as they won't require recompiling everything any more.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74673
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Sun, 18 Aug 2013 04:28:28 +0000 (04:28 +0000)]
should have been part of r74664: Avoid calling gtk_window_get_position() from "configure-event" handler
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74672
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Sat, 17 Aug 2013 16:38:12 +0000 (16:38 +0000)]
avoid duplicate move events
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74665
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Sat, 17 Aug 2013 16:25:13 +0000 (16:25 +0000)]
Avoid calling gtk_window_get_position() from "configure-event" handler, if possible.
This avoids a round trip to the X server, which is expensive over a remote connection.
Closes #15116
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74664
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Bryan Petty [Fri, 16 Aug 2013 18:17:01 +0000 (18:17 +0000)]
Fix typo in wxSingleInstanceChecker docs, props Lauri Nurmi.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74663
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Fri, 16 Aug 2013 15:43:51 +0000 (15:43 +0000)]
use names for gs_requestFrameExtentsStatus values
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74661
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 16 Aug 2013 11:04:39 +0000 (11:04 +0000)]
Replace wxFONTFAMILY_DEFAULT with wxFONTFAMILY_SWISS when comparing fonts.
Otherwise comparison always failed as no existing fonts had
wxFONTFAMILY_DEFAULT as their family in all ports except wxOSX, which does
keep wxFONTFAMILY_DEFAULT.
Closes #15410.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74660
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Wed, 14 Aug 2013 20:34:53 +0000 (20:34 +0000)]
forgotten commit :-( remove #if 0 if things work again
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74659
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Wed, 14 Aug 2013 15:47:21 +0000 (15:47 +0000)]
Fix wxComboCtrlBase::DoGetSizeFromTextSize() performance regression.
r72935 introduced code that created a temporary wxComboBox control to
take measurements. This is very expensive in MSW and adds noticeable
delay when creating more than a few controls.
Replace with equivalent wxMSW code that computes the height in the same
way other wxMSW controls do.
The wxGTK version cannot be eliminated in the same way, so at least add
some basic caching there. It's much less of a problem, because GTK+
controls creation is much cheaper than MSW one.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74658
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Wed, 14 Aug 2013 09:43:31 +0000 (09:43 +0000)]
using terminate: terminates prematurely, OnExit is not called anymore
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74657
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Wed, 14 Aug 2013 09:15:16 +0000 (09:15 +0000)]
using #ifdef wxABORT_ON_CONFIG_ERROR not just #if as elsewhere
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74656
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 13 Aug 2013 17:36:47 +0000 (17:36 +0000)]
Don't hide the window in its dtor in wxGTK.
This results in sending an unexpected wxShowEvent to an already half-destroyed
(because the derived class dtor had been already executed) by now object which
could provoke crashes. And it also seems to be completely unnecessary as the
window is going to be destroyed anyhow -- and the other ports don't hide it
before this happens (unless it's a TLW in which case it is already hidden in
wxTopLevelWindowBase::Destroy()).
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74655
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Mon, 12 Aug 2013 16:24:42 +0000 (16:24 +0000)]
avoid setting pango matrix when not needed
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74654
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Sun, 11 Aug 2013 06:39:20 +0000 (06:39 +0000)]
using #ifdef wxABORT_ON_CONFIG_ERROR not just #if as elsewhere
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74653
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 9 Aug 2013 20:55:27 +0000 (20:55 +0000)]
Tamil translations update from Dinakar T.D.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74649
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 9 Aug 2013 20:55:20 +0000 (20:55 +0000)]
Remove never implemented wxDateTime::IsGregorianDate().
This method was declared and even documented but never actually implemented,
and GregorianAdoption enum used by it had many incorrectly defined elements.
Just remove both the method and the enum instead of fixing/implementing them
as they are not that important (as witnessed by the fact that nobody has
complained about the method being missing since almost 15 years).
Closes #15400.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74648
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Fri, 9 Aug 2013 11:56:33 +0000 (11:56 +0000)]
Applied #15393 (dghart) fixing wxRichTextTable for percentage widths
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74647
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Thu, 8 Aug 2013 05:59:18 +0000 (05:59 +0000)]
add other known types for gdk_pixbuf_save()
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74646
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Thu, 8 Aug 2013 05:43:24 +0000 (05:43 +0000)]
Try native method first in LoadFile() and SaveFile()
closes #15394
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74645
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Wed, 7 Aug 2013 17:33:42 +0000 (17:33 +0000)]
Make wxOwnerDrawnComboBox::DoGetBestSize() twice as fast.
Don't call the very expensive wxComboCtrlBase::DoGetBestSize() method
when not needed - it calls wxComboCtrlBase::DoGetSizeFromTextSize(),
which is very expensive.
Also fix the code so that it doesn't apply GetSizeFromTextSize() twice
(once in the base class' DoGetBestSize(), once here).
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74644
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 7 Aug 2013 15:44:56 +0000 (15:44 +0000)]
Compilation fix for wxMSW with wxUSE_MSGBOX_HOOK==0.
Include wx/fontutil.h unconditionally, it's needed outside message box hook
code.
Closes #15395.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74643
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 7 Aug 2013 12:08:10 +0000 (12:08 +0000)]
Compilation fix to propgrid sample after r74628.
Use wxMax() and wxMin() instead of std::max() and min().
Also work around wrong for loop scoping for VC6.
See #15368.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74642
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 7 Aug 2013 11:08:38 +0000 (11:08 +0000)]
Document light grey colour handling in wxMSW wxBitmap::LoadFile().
For historical/compatibility reasons we handle this colour as transparent in
wxMSW when loading the bitmaps from resources, but this is rather not obvious
for the new users, so document it and provide a way of compensating for this
in the documentation as well.
Closes #15371.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74641
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 7 Aug 2013 11:08:33 +0000 (11:08 +0000)]
Define __VISUALC__ for ICC under Windows again.
During the refactoring of r74496, the logic of the check for Intel compiler
was slightly altered resulting in not defining __VISUALC__ for it any longer
which broke compilation with it.
Restore this definition now to fix it, even though it could admittedly be
better to explicitly check for __INTELC__ in the places where we currently
only check for __VISUALC__ and reserve the latter only for the case when we
are really using MSVC.
Closes #15359.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74640
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 7 Aug 2013 11:08:28 +0000 (11:08 +0000)]
Add wxFileName::SetPermissions().
This is a simple wrapper for the POSIX chmod().
Closes #12951.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74639
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 7 Aug 2013 11:08:21 +0000 (11:08 +0000)]
Update Travis configuration to run tests and build more configurations.
Install libcppunit-dev in order to be able to run the unit tests (at least the
non-GUI ones for now).
Also build in several configurations: shared/static, multilib/monolithic and
also STL. This should help to find problems appearing only in some specific
build variants.
Closes #15369.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74638
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 7 Aug 2013 11:08:17 +0000 (11:08 +0000)]
Don't document wxSortedArrayString as deriving from wxArrayString.
This is no longer the case since quite some time.
Closes #15374.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74637
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 7 Aug 2013 11:08:12 +0000 (11:08 +0000)]
Don't use DDEExec registry key in wxMSW wxExecute() if it's empty.
Some file types have DDEExec subkey in the registry but no value for it, don't
use DDE for launching the files of these types in this case as this only
results in errors.
Closes #15388.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74636
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 17:36:17 +0000 (17:36 +0000)]
Fix column sorting UI in wxDataViewCtrl under wxOSX.
Use -outlineView:didClickTableColumn: delegate method instead of
mouseDownInHeaderOfTableColumn: one to ensure that:
(a) We don't sort the column if it's being dragged/resized (closes #15340).
(b) We sort the column on mouse up, not down (closes #15386).
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74635
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 17:36:12 +0000 (17:36 +0000)]
Fix a couple of spelling mistakes in the documentation.
Closes #15382.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74634
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 17:00:10 +0000 (17:00 +0000)]
Use RIAA wrapper for wxSpinCtrl event disabling in wxGTK.
The use of wxSpinCtrlEventDisabler class ensures that we never forget to
reenable the events after disabling them.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74633
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 17:00:04 +0000 (17:00 +0000)]
Reflect changes in stc.cpp in stc.cpp.in from which it's generated.
This should have been part of r74596, see #15353.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74632
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 17:00:00 +0000 (17:00 +0000)]
Don't generate any events from wxSpinCtrl and wxSpinCtrlDouble methods.
After the changes of r53758 wxMSW didn't generate any wxEVT_TEXT events but
this was still the case for the generic version (and hence for
wxSpinCtrlDouble under MSW too) and wasn't documented.
Fix all versions to avoid sending events for programmatic actions, add unit
tests checking this behaviour and document it.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74631
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 16:59:54 +0000 (16:59 +0000)]
Add test for absence of events from wxSpinCtrlDouble ctor.
Run the same NoEventsInCtor() test as we already had for wxSpinCtrl for
wxSpinCtrlDouble as well.
Unfortunately currently there is no way to reuse the tests between these two
classes, we should refactor these test cases to use a common
SpinCtrlTestCaseBase<T> base class.
See #15375 which fixed the underlying bug.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74630
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 16:59:49 +0000 (16:59 +0000)]
Document wxTreeCtrl::GetItemFont() behaviour for items without font.
Explain that this method returns wxNullFont if no font was set for the item.
Closes #15390.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74629
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 13:05:42 +0000 (13:05 +0000)]
Add wxPropertyGridPageState::GetColumnFullWidth().
This method allows to get the full width needed by wxPropertyGrid and is
useful for determining the space to allocate for it, e.g. when creating a
popup showing the property grid, as shown by the changes to the sample.
Closes #15368.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74628
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 13:05:36 +0000 (13:05 +0000)]
Fix wxPropertyGrid::GetPropertyRect when the last item is collapsed.
Return the real height instead of -1.
Closes #15367.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74627
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 6 Aug 2013 12:31:58 +0000 (12:31 +0000)]
Dutch translations update from Gideon van Melle.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74626
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Paul Cornett [Tue, 6 Aug 2013 06:05:38 +0000 (06:05 +0000)]
Rewrite ConvertToGreyscale() and ConvertToDisabled()
They do almost the same thing, so use almost the same code.
Fixes ConvertToDisabled() modifying its own data.
Closes #15389
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74625
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775