]> git.saurik.com Git - apt.git/log
apt.git
11 years agoChangelog entry for translation fixes
bubulle@debian.org [Tue, 9 Apr 2013 05:59:33 +0000 (07:59 +0200)] 
Changelog entry for translation fixes

11 years agoComplete French translation
bubulle@debian.org [Tue, 9 Apr 2013 05:58:34 +0000 (07:58 +0200)] 
Complete French translation

11 years agoComplete translation
bubulle@debian.org [Tue, 9 Apr 2013 05:56:45 +0000 (07:56 +0200)] 
Complete translation

11 years agoReformat PO file
bubulle@debian.org [Tue, 9 Apr 2013 05:54:52 +0000 (07:54 +0200)] 
Reformat PO file

11 years agoFix typo
bubulle@debian.org [Tue, 9 Apr 2013 05:54:11 +0000 (07:54 +0200)] 
Fix typo

11 years agoreleasing version 0.9.7.9~exp3
Michael Vogt [Mon, 8 Apr 2013 15:30:18 +0000 (17:30 +0200)] 
releasing version 0.9.7.9~exp3

11 years agopo: refresh
Michael Vogt [Mon, 8 Apr 2013 15:29:47 +0000 (17:29 +0200)] 
po: refresh

11 years agomerged bundle from david
Michael Vogt [Mon, 8 Apr 2013 13:38:45 +0000 (15:38 +0200)] 
merged bundle from david

11 years agomerged lp:~mvo/apt/add-missing-dsc-hashes
Michael Vogt [Mon, 8 Apr 2013 06:45:06 +0000 (08:45 +0200)] 
merged lp:~mvo/apt/add-missing-dsc-hashes

11 years ago* debian/control:
Michael Vogt [Mon, 8 Apr 2013 06:41:51 +0000 (08:41 +0200)] 
* debian/control:
  - replace manpages-it (closes: #704723)

11 years ago* apt-pkg/sourcelist.cc:
Michael Vogt [Thu, 4 Apr 2013 16:22:16 +0000 (18:22 +0200)] 
* apt-pkg/sourcelist.cc:
  - fix segfault when a hostname contains a [, thanks to
    Tzafrir Cohen (closes: #704653)

11 years agoshare version strings between same versions (of different architectures)
David Kalnischkies [Wed, 3 Apr 2013 17:43:03 +0000 (19:43 +0200)] 
share version strings between same versions (of different architectures)
to save some space and allow quick comparisions later on

11 years ago* apt-pkg/cacheiterators.h:
David Kalnischkies [Wed, 3 Apr 2013 17:34:47 +0000 (19:34 +0200)] 
* apt-pkg/cacheiterators.h:
  - provide DepIterator::IsSatisfied as a nicer shorthand for DepCheck

11 years agoreleasing version 0.9.7.9~exp2
Michael Vogt [Wed, 3 Apr 2013 12:40:08 +0000 (14:40 +0200)] 
releasing version 0.9.7.9~exp2

11 years agopo/*: refreshed
Michael Vogt [Wed, 3 Apr 2013 12:39:40 +0000 (14:39 +0200)] 
po/*: refreshed

11 years agoapt-pkg/contrib/gpgv.cc: fix InRelease check
Michael Vogt [Wed, 3 Apr 2013 12:19:34 +0000 (14:19 +0200)] 
apt-pkg/contrib/gpgv.cc: fix InRelease check

11 years ago - sort group and package names in the hashtable on insert
David Kalnischkies [Wed, 3 Apr 2013 10:44:36 +0000 (12:44 +0200)] 
  - sort group and package names in the hashtable on insert
* apt-pkg/pkgcache.cc:
  - assume sorted hashtable entries for groups/packages

11 years agomerged lp:~mvo/apt/fix-inrelease5
Michael Vogt [Tue, 2 Apr 2013 13:20:16 +0000 (15:20 +0200)] 
merged lp:~mvo/apt/fix-inrelease5

11 years agopo/{ca,cs,ru}.po: fix merge artifacts harder
Michael Vogt [Tue, 2 Apr 2013 13:08:34 +0000 (15:08 +0200)] 
po/{ca,cs,ru}.po: fix merge artifacts harder

11 years agomicro-optimize and enhance readability of ListParser::VersionHash
David Kalnischkies [Mon, 1 Apr 2013 21:27:16 +0000 (23:27 +0200)] 
micro-optimize and enhance readability of ListParser::VersionHash

11 years agoequal comparisions are used mostly in same-source relations,
David Kalnischkies [Mon, 1 Apr 2013 13:41:02 +0000 (15:41 +0200)] 
equal comparisions are used mostly in same-source relations,
so use this to try to reuse some version strings

11 years ago* apt-pkg/deb/debversion.cc:
David Kalnischkies [Mon, 1 Apr 2013 11:19:43 +0000 (13:19 +0200)] 
* apt-pkg/deb/debversion.cc:
  - add a string-equal shortcut for equal version comparisions

11 years agomerge stuff from donkult
Michael Vogt [Tue, 26 Mar 2013 13:54:31 +0000 (14:54 +0100)] 
merge stuff from donkult

11 years ago* doc/apt.conf.5.xml:
Michael Vogt [Mon, 25 Mar 2013 12:55:07 +0000 (13:55 +0100)] 
* doc/apt.conf.5.xml:
  - document Acquire::ForceIPv{4,6}

11 years ago* methods/connect.cc:
Michael Vogt [Mon, 25 Mar 2013 08:03:48 +0000 (09:03 +0100)] 
* methods/connect.cc:
  - use Errno() instead of strerror(), thanks to David Kalnischk

11 years agomerge patches from daniel to fix merge artifact and test failure
Michael Vogt [Mon, 25 Mar 2013 07:56:42 +0000 (08:56 +0100)] 
merge patches from daniel to fix merge artifact and test failure

11 years agomerge patch from Daniel Hartwig
Michael Vogt [Mon, 25 Mar 2013 07:52:20 +0000 (08:52 +0100)] 
merge patch from Daniel Hartwig

11 years ago* Update all PO files and apt-all.pot
bubulle@debian.org [Sun, 24 Mar 2013 07:58:27 +0000 (08:58 +0100)] 
* Update all PO files and apt-all.pot
* French translation completed (Christian Perrier)

11 years agoUpdate POT and PO files
bubulle@debian.org [Sun, 24 Mar 2013 07:54:14 +0000 (08:54 +0100)] 
Update POT and PO files

11 years agoreleasing version 0.9.7.9~exp1
Michael Vogt [Fri, 22 Mar 2013 21:10:02 +0000 (22:10 +0100)] 
releasing version 0.9.7.9~exp1

11 years agoprepare upload
Michael Vogt [Fri, 22 Mar 2013 20:53:30 +0000 (21:53 +0100)] 
prepare upload

11 years agomerged lp:~mvo/apt/fix-tagfile-hash
Michael Vogt [Fri, 22 Mar 2013 20:52:42 +0000 (21:52 +0100)] 
merged lp:~mvo/apt/fix-tagfile-hash

11 years agomerged the debian-wheezy branch
Michael Vogt [Fri, 22 Mar 2013 20:49:22 +0000 (21:49 +0100)] 
merged the debian-wheezy branch

11 years agoadd new config options "Acquire::ForceIPv4" and
Michael Vogt [Fri, 22 Mar 2013 20:46:53 +0000 (21:46 +0100)] 
add new config options "Acquire::ForceIPv4" and
"Acquire::ForceIPv6" to allow focing one or the other
(closes: #611891)

11 years agoTurkish (Mert Dirik). Closes: #703526
bubulle@debian.org [Fri, 22 Mar 2013 06:17:05 +0000 (07:17 +0100)] 
Turkish (Mert Dirik). Closes: #703526

11 years agomerge patch from Colin to fix error message from getaddrinfo() (#703603)
Michael Vogt [Thu, 21 Mar 2013 15:18:58 +0000 (16:18 +0100)] 
merge patch from Colin to fix error message from getaddrinfo() (#703603)

11 years agoapt-pkg/edsp.cc: do not use stderr in WriteSolution at all
Michael Vogt [Wed, 20 Mar 2013 11:18:16 +0000 (12:18 +0100)] 
apt-pkg/edsp.cc: do not use stderr in WriteSolution at all

11 years agoapt-pkg/edsp.cc: do not spam stderr in WriteSolution
Michael Vogt [Wed, 20 Mar 2013 11:17:05 +0000 (12:17 +0100)] 
apt-pkg/edsp.cc: do not spam stderr in WriteSolution

11 years agosupport dash-escaped text in clearsigned files as implementations are
David Kalnischkies [Tue, 19 Mar 2013 11:37:50 +0000 (12:37 +0100)] 
support dash-escaped text in clearsigned files as implementations are
free to escape all lines (we have no lines in our files which need
 to be escaped as these would be invalid fieldnames) and while ExecGPGV
would detect dash-escaped text as invalid (as its not expected in
 messages with detached signatures) it would be possible to "comment"
lines in (signed) dsc files which are only parsed but not verified

11 years agouse FileFd instead of int fds to tidy up the interface a bit
David Kalnischkies [Tue, 19 Mar 2013 09:49:57 +0000 (10:49 +0100)] 
use FileFd instead of int fds to tidy up the interface a bit

11 years ago* apt-pkg/deb/debindexfile.cc,
David Kalnischkies [Mon, 18 Mar 2013 21:57:08 +0000 (22:57 +0100)] 
* apt-pkg/deb/debindexfile.cc,
  apt-pkg/deb/deblistparser.cc:
  - use OpenMaybeClearSignedFile to be free from detecting and
    skipping clearsigning metadata in dsc and Release files

We can't write a "clean" file to disk as not all acquire methods copy
Release files before checking them (e.g. cdrom), so this reverts recombining,
but uses the method we use for dsc files also in the two places we
deal with Release files

11 years ago - add method to open (maybe) clearsigned files transparently
David Kalnischkies [Mon, 18 Mar 2013 18:36:55 +0000 (19:36 +0100)] 
  - add method to open (maybe) clearsigned files transparently
* ftparchive/writer.cc:
  - use OpenMaybeClearSignedFile to be free from detecting and
    skipping clearsigning metadata in dsc files

11 years agorename testcase to mention CVE number, make the code more consistent with
David Kalnischkies [Mon, 18 Mar 2013 16:06:51 +0000 (17:06 +0100)] 
rename testcase to mention CVE number, make the code more consistent with
the rest and add some more tests (by fixing commented ones)

11 years agotest/libapt/tagfile_test.cc: add missing "unistd.h" (thanks to Niels Thykier)
Michael Vogt [Mon, 18 Mar 2013 12:52:43 +0000 (13:52 +0100)] 
test/libapt/tagfile_test.cc: add missing "unistd.h" (thanks to Niels Thykier)

11 years agofix pkgTagSection::Exists() and add test
Michael Vogt [Mon, 18 Mar 2013 11:10:35 +0000 (12:10 +0100)] 
fix pkgTagSection::Exists() and add test

11 years agotest/integration/framework: use EXIT_CODE to be consistent with the run-tests code
Michael Vogt [Mon, 18 Mar 2013 10:46:20 +0000 (11:46 +0100)] 
test/integration/framework: use EXIT_CODE to be consistent with the run-tests code

11 years agoreport failures via exit and ensure we don't overflow
Michael Vogt [Mon, 18 Mar 2013 10:38:19 +0000 (11:38 +0100)] 
report failures via exit and ensure we don't overflow

11 years ago* test/integration/framework:
Michael Vogt [Mon, 18 Mar 2013 07:08:37 +0000 (08:08 +0100)] 
* test/integration/framework:
  - continue after test failure but preserve exit status

11 years ago* test/libapt/assert.h, test/libapt/run-tests:
Michael Vogt [Sun, 17 Mar 2013 18:51:02 +0000 (19:51 +0100)] 
* test/libapt/assert.h, test/libapt/run-tests:
  - exit with status 1 on test failure

11 years agoensure that we fclose/unlink/free in the new gpg-code as soon as possible
David Kalnischkies [Sat, 16 Mar 2013 11:40:43 +0000 (12:40 +0100)] 
ensure that we fclose/unlink/free in the new gpg-code as soon as possible

11 years agoadd testcase and update changelog
Michael Vogt [Sat, 16 Mar 2013 09:08:28 +0000 (10:08 +0100)] 
add testcase and update changelog

11 years agomerged from davids bundle
Michael Vogt [Sat, 16 Mar 2013 08:15:46 +0000 (09:15 +0100)] 
merged from davids bundle

11 years ago - if ExecGPGV deals with a clear-signed file it will split this file
David Kalnischkies [Fri, 15 Mar 2013 17:53:53 +0000 (18:53 +0100)] 
  - if ExecGPGV deals with a clear-signed file it will split this file
    into data and signatures, pass it to gpgv for verification and
    recombines it after that in a known-good way without unsigned blocks
    and whitespaces resulting usually in more or less the same file as
    before, but later code can be sure about the format
* apt-pkg/deb/debmetaindex.cc:
  - reenable InRelease by default

11 years agosplit out a method to strip whitespaces only on the right side
Michael Vogt [Fri, 15 Mar 2013 13:57:27 +0000 (14:57 +0100)] 
split out a method to strip whitespaces only on the right side

11 years ago* apt-pkg/acquire-item.cc:
David Kalnischkies [Fri, 15 Mar 2013 13:55:43 +0000 (14:55 +0100)] 
* apt-pkg/acquire-item.cc:
  - keep the last good InRelease file around just as we do it with
    Release.gpg in case the new one we download isn't good for us

11 years agodon't close stdout/stderr if it is also the statusfd
David Kalnischkies [Fri, 15 Mar 2013 13:49:05 +0000 (14:49 +0100)] 
don't close stdout/stderr if it is also the statusfd

11 years ago* apt-pkg/contrib/gpgv.cc:
David Kalnischkies [Fri, 15 Mar 2013 13:29:46 +0000 (14:29 +0100)] 
* apt-pkg/contrib/gpgv.cc:
  - ExecGPGV is a method which should never return, so mark it as such
    and fix the inconsistency of returning in error cases

11 years ago* apt-pkg/indexcopy.cc:
David Kalnischkies [Fri, 15 Mar 2013 13:17:01 +0000 (14:17 +0100)] 
* apt-pkg/indexcopy.cc:
  - rename RunGPGV to ExecGPGV and move it to apt-pkg/contrib/gpgv.cc

11 years ago* SECURITY UPDATE: InRelease verification bypass 0.9.7.8
Michael Vogt [Thu, 14 Mar 2013 13:26:43 +0000 (14:26 +0100)] 
* SECURITY UPDATE: InRelease verification bypass
  - CVE-2013-1051

* apt-pkg/deb/debmetaindex.cc,
  test/integration/test-bug-595691-empty-and-broken-archive-files,
  test/integration/test-releasefile-verification:
  - disable InRelease downloading until the verification issue is
    fixed, thanks to Ansgar Burchardt for finding the flaw

11 years agofactor version string creation out of NewDepends, so we can easily reuse
David Kalnischkies [Wed, 13 Mar 2013 18:00:19 +0000 (19:00 +0100)] 
factor version string creation out of NewDepends, so we can easily reuse
version strings e.g. for implicit multi-arch dependencies

11 years agohandle language tags for descriptions are unique strings to be shared
David Kalnischkies [Tue, 12 Mar 2013 22:47:48 +0000 (23:47 +0100)] 
handle language tags for descriptions are unique strings to be shared

11 years ago* apt-pkg/pkgcachegen.cc:
David Kalnischkies [Tue, 12 Mar 2013 22:28:16 +0000 (23:28 +0100)] 
* apt-pkg/pkgcachegen.cc:
  - do not store the MD5Sum for every description language variant as
    it will be the same for all so it can be shared to save cache space

11 years agovarious simple changes to fix cppcheck warnings
David Kalnischkies [Sun, 10 Mar 2013 11:24:13 +0000 (12:24 +0100)] 
various simple changes to fix cppcheck warnings

11 years agoreleasing version 0.9.7.8~exp2
Michael Vogt [Fri, 1 Mar 2013 18:20:53 +0000 (19:20 +0100)] 
releasing version 0.9.7.8~exp2

11 years agomerged lp:~mvo/apt/hash-order
Michael Vogt [Fri, 1 Mar 2013 18:04:15 +0000 (19:04 +0100)] 
merged lp:~mvo/apt/hash-order

11 years agoinclude two missing patches to really fix bug #696225, thanks to
Michael Vogt [Fri, 1 Mar 2013 17:50:59 +0000 (18:50 +0100)] 
include two missing patches to really fix bug #696225, thanks to
Guillem Jover

11 years agoreleasing version 0.9.7.8~exp1
Michael Vogt [Fri, 1 Mar 2013 13:55:19 +0000 (14:55 +0100)] 
releasing version 0.9.7.8~exp1

11 years agomerged lp:~donkult/apt/sid
Michael Vogt [Fri, 1 Mar 2013 11:48:07 +0000 (12:48 +0100)] 
merged lp:~donkult/apt/sid

11 years agoadd changelog
Michael Vogt [Fri, 1 Mar 2013 11:17:08 +0000 (12:17 +0100)] 
add changelog

11 years agoadd changelog
Michael Vogt [Fri, 1 Mar 2013 11:12:05 +0000 (12:12 +0100)] 
add changelog

11 years ago* apt-pkg/depcache.cc:
David Kalnischkies [Sun, 24 Feb 2013 15:20:43 +0000 (16:20 +0100)] 
* apt-pkg/depcache.cc:
  - prefer to install packages which have an already installed M-A:same
    sibling while choosing providers (LP: #1130419)

11 years agoJapanese (Kenshi Muto). Closes: #699783
bubulle@debian.org [Tue, 5 Feb 2013 06:00:04 +0000 (07:00 +0100)] 
Japanese (Kenshi Muto). Closes: #699783

11 years agoadd a integration test for bug 1078697
Michael Vogt [Fri, 1 Feb 2013 06:07:33 +0000 (07:07 +0100)] 
add a integration test for bug 1078697

11 years agomerge patch apt_0.9.7.7ubuntu2~md1.debdiff, thanks to Marc Deslauriers
Michael Vogt [Thu, 31 Jan 2013 13:41:41 +0000 (14:41 +0100)] 
merge patch apt_0.9.7.7ubuntu2~md1.debdiff, thanks to Marc Deslauriers

11 years ago* apt-pkg/indexrecords.cc:
Michael Vogt [Thu, 24 Jan 2013 17:55:44 +0000 (18:55 +0100)] 
* apt-pkg/indexrecords.cc:
  - support '\r' in the Release file

11 years agoquote plus in filenames to work around a bug in the S3 server
Michael Vogt [Thu, 24 Jan 2013 17:52:25 +0000 (18:52 +0100)] 
quote plus in filenames to work around a bug in the S3 server
(LP: #1003633)

11 years agoensure sha512 is really used when available (thanks to Tyler Hicks )
Michael Vogt [Mon, 14 Jan 2013 05:31:51 +0000 (06:31 +0100)] 
ensure sha512 is really used when available (thanks to Tyler Hicks )

11 years ago* methods/http.cc:
Michael Vogt [Fri, 11 Jan 2013 08:51:00 +0000 (09:51 +0100)] 
* methods/http.cc:
  - quote spaces in filenames to ensure as the http method is also
    (potentially) used for non deb,dsc content that may contain
    spaces, thanks to Daniel Hartwig and Thomas Bushnell
    (LP: #1086997)

11 years agomerged train fixes
Michael Vogt [Thu, 10 Jan 2013 15:54:13 +0000 (16:54 +0100)] 
merged train fixes

11 years agoinstead of cut, use % 32767
Michael Vogt [Thu, 10 Jan 2013 15:46:06 +0000 (16:46 +0100)] 
instead of cut, use % 32767

11 years agoadd missing curl_easy_cleanup()
Michael Vogt [Wed, 9 Jan 2013 13:47:35 +0000 (14:47 +0100)] 
add missing curl_easy_cleanup()

11 years ago* methods/https.cc:
Michael Vogt [Wed, 9 Jan 2013 10:00:13 +0000 (11:00 +0100)] 
* methods/https.cc:
  - reuse connection in https, thanks to Thomas Bushnell, BSG for the
    patch. LP: #1087543, Closes: #695359

11 years agomerge train fixes
Michael Vogt [Wed, 9 Jan 2013 07:25:14 +0000 (08:25 +0100)] 
merge train fixes

11 years agofix missing translated apt.8 manpages, thanks to Helge Kreutzmann
Michael Vogt [Wed, 9 Jan 2013 07:24:42 +0000 (08:24 +0100)] 
fix missing translated apt.8 manpages, thanks to Helge Kreutzmann
for the report. Closes: #696923

11 years ago* debian/apt.cron.daily:
Michael Vogt [Wed, 9 Jan 2013 05:57:13 +0000 (06:57 +0100)] 
* debian/apt.cron.daily:
  - when reading from /dev/urandom, use less entropy and fix a rare
    bug when the random number chksum is less than 1000.
Closes: #695285
11 years ago* apt-pkg/contrib/progress.cc:
Michael Vogt [Wed, 9 Jan 2013 05:33:56 +0000 (06:33 +0100)] 
* apt-pkg/contrib/progress.cc:
  - Make "..." translatable to fix inconsistencies in the output
    of e.g. apt-get update. While this adds new translatable strings,
    not having translations for them will not break anything.
    Thanks to Guillem Jover. Closes: #696225

11 years agoadd missing translated apt.8 manpages, thanks to Helge Kreutzmann.
Michael Vogt [Tue, 8 Jan 2013 17:42:09 +0000 (18:42 +0100)] 
add missing translated apt.8 manpages, thanks to Helge Kreutzmann.
Closes: #696923
11 years agodoc/po/it.po: fix small XML errors
Michael Vogt [Tue, 8 Jan 2013 17:26:58 +0000 (18:26 +0100)] 
doc/po/it.po: fix small XML errors

11 years agofix pkgProblemResolver::Scores, thanks to Paul Wise.
Michael Vogt [Tue, 8 Jan 2013 16:56:32 +0000 (17:56 +0100)] 
fix pkgProblemResolver::Scores, thanks to Paul Wise.
Closes: #697577
11 years agofix pkgProblemResolver::Scores, thanks to Paul Wise.
Michael Vogt [Tue, 8 Jan 2013 15:35:57 +0000 (16:35 +0100)] 
fix pkgProblemResolver::Scores, thanks to Paul Wise.
Closes: #697577
11 years agoItalian translation update for manpages
bubulle@debian.org [Mon, 24 Dec 2012 06:02:36 +0000 (07:02 +0100)] 
Italian translation update for manpages

11 years agoreleasing version 0.9.7.7 0.9.7.7
Michael Vogt [Thu, 13 Dec 2012 09:01:52 +0000 (10:01 +0100)] 
releasing version 0.9.7.7

11 years agomerged from lp:~donkult/apt/sid
Michael Vogt [Thu, 13 Dec 2012 08:25:15 +0000 (09:25 +0100)] 
merged from lp:~donkult/apt/sid

11 years agochange permissions of /var/log/apt/term.log to 0640 (LP: #975199)
Michael Vogt [Thu, 13 Dec 2012 08:02:04 +0000 (09:02 +0100)] 
change permissions of /var/log/apt/term.log to 0640 (LP: #975199)

11 years agoFix Plural forms in German, French, Japanese and Portuguese
bubulle@debian.org [Sat, 8 Dec 2012 18:35:40 +0000 (19:35 +0100)] 
Fix Plural forms in German, French, Japanese and Portuguese
translations. Thanks to Jakub Wilk for reporting these errors.

12 years agoVietnamese (Trần Ngọc Quân). Closes: #693773
bubulle@debian.org [Tue, 20 Nov 2012 20:10:47 +0000 (21:10 +0100)] 
Vietnamese (Trần Ngọc Quân). Closes: #693773

12 years ago* apt-pkg/algorithms.cc:
Jonathan Thomas [Sat, 10 Nov 2012 13:25:45 +0000 (14:25 +0100)] 
* apt-pkg/algorithms.cc:
  - fix package-pointer array memory leak in ResolveByKeepInternal()

12 years ago* apt-pkg/algorithms.cc:
David Kalnischkies [Fri, 9 Nov 2012 10:00:02 +0000 (11:00 +0100)] 
* apt-pkg/algorithms.cc:
  - ensure pkgProblemResolver calls MarkDelete without FromUser set
    so that it can't overrule holds and the protection flag

12 years ago* cmdline/apt-get.cc:
David Kalnischkies [Fri, 9 Nov 2012 09:49:21 +0000 (10:49 +0100)] 
* cmdline/apt-get.cc:
  - do not call Mark{Install,Delete} from the autoremove code with
    the FromUser bit set to avoid modifying the auto-installed bit

12 years agono mode changes should obviously be ok for pkgDepCache::IsModeChangeOk
David Kalnischkies [Fri, 9 Nov 2012 09:47:30 +0000 (10:47 +0100)] 
no mode changes should obviously be ok for pkgDepCache::IsModeChangeOk