David Kalnischkies [Sun, 16 Jun 2013 16:28:45 +0000 (18:28 +0200)]
try defaults if auto-detection failed in apt-cdrom
The default is to ask udev for location and mountpoints of CD-ROMs,
but the old way of specifying the mountpoint is still available and
is tried now in case udev doesn't find any CD-ROM.
It probably fails, too, but we get a bunch of error messages this
way and the user can get an idea of how to make his setup work even
if udev can't be convienced to return something useful.
Closes: #712433
David Kalnischkies [Sun, 16 Jun 2013 13:42:31 +0000 (15:42 +0200)]
handle missing "Description" in apt-cache show
do not blindly assume that all packages stanzas have a "Description:"
field in 'apt-cache show' as well as in the cache creation itself.
We instead assume now that if the stanza has a Description, it will not
be the first field as we look out for "\nDescription" to take care of
MD5sum as well as (maybe ignored) translated Descriptions embedded in
the package stanza.
Closes: #712435
David Kalnischkies [Thu, 13 Jun 2013 11:52:18 +0000 (13:52 +0200)]
fix file location for configure-index.gz in apt.conf(5)
Closes: #711921
David Kalnischkies [Sun, 9 Jun 2013 20:13:20 +0000 (22:13 +0200)]
tests: add an interactive 'test' with multiple cdroms
Can't be used as a test as is, but shows how to build multiple
CD-ROMs for tests and can be used to reproduce debbug #711456.
Git-Dch: Ignore
David Kalnischkies [Sun, 9 Jun 2013 16:58:34 +0000 (18:58 +0200)]
ensure state-dir exists before coyping cdrom files
We do the same in the acquire system which handles the 'normal'
downloads, so do it here as well even though its unlikely anyone
will ever notice (beside testcases of course …)
David Kalnischkies [Sun, 9 Jun 2013 16:33:48 +0000 (18:33 +0200)]
fail in CopyFile if the FileFds have error flag set
Testing for global PendingErrors in users of CopyFile is incorrect
in so far as unrelated errors will prevent us from copying perfectly
fine files and checking for the validity of the files is just better
in CopyFiles as it already checks if files are at least opened.
Add also a higher-level error message to the error stack if it fails.
David Kalnischkies [Fri, 31 May 2013 16:19:09 +0000 (18:19 +0200)]
stop building l10n if strings are unchanged
The buildsystem tried to build l10n for test applications which never
produced the output it expected causing it to try building it all the
time.
David Kalnischkies [Tue, 28 May 2013 16:48:28 +0000 (18:48 +0200)]
depend on libapt-pkg in the libapt-inst build process
fixing parallel build in the handcrafted buildsystem is a pain,
so its not enabled by default, but its works for me – sometimes
Git-Dch: Ignore
David Kalnischkies [Tue, 28 May 2013 16:17:55 +0000 (18:17 +0200)]
tests: add expected port for cve-2013-105 testcase
Git-Dch: Ignore
David Kalnischkies [Tue, 28 May 2013 16:08:32 +0000 (18:08 +0200)]
tests: trap-adding can be post- as well as prefix
For testcases it might sometimes be handy to add trap-actions
before the general cleanup, e.g. if it has set directories read-
only which rm doesn't want to remove even with --force applied
(its fine with files though)
Git-Dch: Ignore
David Kalnischkies [Sat, 25 May 2013 18:33:15 +0000 (20:33 +0200)]
OpenDescriptor should autoclose fd always on error
OpenInternDescriptor failures would cause additional errors to be
generated by double-closing an fd. Other errors (although these
are generated if the method is used incorrectly, so unlikely)
didn't close the fd aswell.
Closes: 704608
David Kalnischkies [Sat, 25 May 2013 18:27:33 +0000 (20:27 +0200)]
don't explicitly init ExtractTar InFd with invalid fd
The default constructor of the FileFd will kick in anyway,
which will know that the Fd is invalid while with this explicit
call it must be assumed that the fd is in fact valid, which
might generate errors in the future
David Kalnischkies [Sat, 25 May 2013 18:22:06 +0000 (20:22 +0200)]
set Fail flag in FileFd on all errors consistently
Previously some errors would set the Fail flag while some didn't
without a clear reason as all errors leave a bad FileFd behind,
so we use a helper now to ensure that all errors set the flag.
David Kalnischkies [Sat, 25 May 2013 18:18:15 +0000 (20:18 +0200)]
make the vprintf like _error->Insert public
Git-Dch: Ignore
David Kalnischkies [Sat, 25 May 2013 17:57:48 +0000 (19:57 +0200)]
fix support for multiple patterns in apt-cache search
Patterns can appear in the name as well as in the description,
they don't have to match all in the name/description only.
Closes: 691453
David Kalnischkies [Sat, 25 May 2013 17:47:28 +0000 (19:47 +0200)]
initialize the whole search array with zero
Git-Dch: Ignore
David Kalnischkies [Fri, 24 May 2013 08:20:38 +0000 (10:20 +0200)]
deprecate InstallProtect as a cpu-eating no-op
In the past packages were flagged "Protected" so that install/
remove markings where issued before the ProblemResolver.
Nowadays, the marking methods check if they are allowed to modify
the marking of a package instead, so that markings set by FromUser
calls are not overwritten anymore by automatic calls which elimates
the need for InstallProtect which just eats CPU now.
The method itself is left untouched for now in case frontend needs it
still for some wierd usecase, but they should be eliminated.
David Kalnischkies [Thu, 23 May 2013 10:14:56 +0000 (12:14 +0200)]
do unpacks before configures in SmartConfigure
Splits the big loop over dependencies in SmartConfigure which unpacks and
configures dependencies into two loops and reverse their order, so that all
dependencies which need to be unpacked are handled first and only after that
configures are issued for dependencies.
This is needed as otherwise the unpack of a (new) dependency will be issued
in between a configure call for two (or more) packages which form a loop,
which means the configure calls aren't part of the same dpkg call and
therefore dpkg bails out.
Such tight loops should really be avoided as they are usually wrong – and in
reality the dependencies in libreoffice were greatly simplified thanks to
Rene Engelhard so the problem is gone for the benefit of all.
Closes: 707578
David Kalnischkies [Tue, 21 May 2013 19:50:30 +0000 (21:50 +0200)]
try all providers in order if uninstallable in MarkInstall
David Kalnischkies [Tue, 21 May 2013 16:06:17 +0000 (18:06 +0200)]
fix priority sorting by prefering higher in MarkInstall
Used to work until a certain (here unnamed) person came along and used
the wrong operator causing low-priority packages to be sorted above
high-priority packages while choosing a provider in commit
2b5c35c7bb915dbd46fefd7c79f05364ba22f93b from Nov 2011
David Kalnischkies [Tue, 21 May 2013 15:10:21 +0000 (17:10 +0200)]
prefer Essentials over Removals in ordering score
Doing Removes early is good to have them out of the way, so they
don't break 'Inst' or 'Conf' chains, but scoring them above Essentials
means that we end up upgrading (many) less important packages before
we handle big stuff like libc6 or debconf which not only fails if those
less important packages have unannounced (strict) dependencies, but also
leads to having these packages unconfigured for a long time triggering
bugs in maintainer scripts for no good reason (#708831).
So this commits sets the default value for remove scores to 100, which
is below the one for essentials (200) and a lot lower than the previous
default value (500).
David Kalnischkies [Mon, 20 May 2013 22:05:14 +0000 (00:05 +0200)]
rewrite pkgOrderList::DepRemove to stop incorrect immediate setting
Some squeeze → wheezy upgrades indicate that DepRemove runs amok
in complicated setups as it wasn't correctly working with or-groups.
Completely rewritten the check is now moving from or-group to or-group
instead.
The behavior should be the same as the code before, but
(hopefully) with less bugs and more comments.
Closes: 645713
David Kalnischkies [Sun, 19 May 2013 16:53:19 +0000 (18:53 +0200)]
remove -ldl from cdrom and -lutil from apt-get linkage
Building src:apt shows:
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/apt/usr/lib/apt/methods/cdrom was not linked against libdl.so.2
(it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/apt/usr/bin/apt-get was not linked against libutil.so.1 (it uses
none of the library's symbols)
David Kalnischkies [Sun, 19 May 2013 13:49:24 +0000 (15:49 +0200)]
build the en manpages in subdirectory doc/en
Building manpages becames more consistent this way and
it is simpler to ignore build artefacts, too.
David Kalnischkies [Sun, 19 May 2013 09:39:44 +0000 (11:39 +0200)]
streamline .gitignore further
adding some comments, regrouping files and use some patterns to avoid
updating the ignore file for new translations or abi changes
Git-Dch: Ignore
Michael Vogt [Thu, 6 Jun 2013 17:25:59 +0000 (19:25 +0200)]
merged trunk
Michael Vogt [Thu, 6 Jun 2013 17:17:25 +0000 (19:17 +0200)]
Merge branch 'debian/sid' of https://github.com/ion1/apt into debian/sid
Michael Vogt [Thu, 6 Jun 2013 17:15:52 +0000 (19:15 +0200)]
prepare release
Michael Vogt [Thu, 6 Jun 2013 16:20:35 +0000 (18:20 +0200)]
Fix double free (closes: #711045)
* Fix double free (closes: #711045)
* Fix crash when the "mirror" method does not find any entry
(closes: #699303)
Michael Vogt [Thu, 6 Jun 2013 16:17:14 +0000 (18:17 +0200)]
fix double free (closes: #711045)
Johan Kiviniemi [Wed, 22 May 2013 18:14:33 +0000 (21:14 +0300)]
cmdline/apt-key: Accept nonexistent --keyring file with adv as well
Johan Kiviniemi [Wed, 22 May 2013 18:06:26 +0000 (21:06 +0300)]
cmdline/apt-key: Create new keyrings with mode 0644 instead of 0600
Michael Vogt [Thu, 16 May 2013 21:12:37 +0000 (23:12 +0200)]
* buildlib/apti18n.h.in:
- fix build failure when building without NLS (closes: #671587)
Michael Vogt [Thu, 16 May 2013 20:38:21 +0000 (22:38 +0200)]
debian/gbp.conf: add debian-tag key to ensure git-dch works
Julian Andres Klode [Thu, 16 May 2013 20:34:04 +0000 (22:34 +0200)]
Update changelog to include Vcs-* changes
Christian PERRIER [Thu, 16 May 2013 20:28:52 +0000 (22:28 +0200)]
French translation : typo fix. Closes: #677272
Guillem Jover [Thu, 16 May 2013 17:45:25 +0000 (19:45 +0200)]
Update Vcs fields
Use the canonical URLs. Rename Vcs-Bzr to Vcs-Git and use the more
efficient git protocol instead of http. Point Vcs-Browser to the
gitweb interface.
Michael Vogt [Thu, 16 May 2013 13:30:23 +0000 (15:30 +0200)]
add export-dir and debian-branch
Michael Vogt [Thu, 16 May 2013 13:02:24 +0000 (15:02 +0200)]
update .gitignore
Michael Vogt [Thu, 16 May 2013 12:58:56 +0000 (14:58 +0200)]
prepare upload
Michael Vogt [Thu, 16 May 2013 12:31:14 +0000 (14:31 +0200)]
merged previous bzr commit
Michael Vogt [Thu, 16 May 2013 12:22:12 +0000 (14:22 +0200)]
moved to git, updated gbp.conf to match the bzr version
David Kalnischkies [Sat, 11 May 2013 08:10:07 +0000 (10:10 +0200)]
non-inline RunGPGV methods to restore ABI compatibility with previous versions to fix partial upgrades (Closes: #707771)
The rename in 0.9.7.9~exp2 moved the method body to the class definition
which means it became inline, which isn't ABI compatibile. The reverse of
moving inline to non-inline is safe though.
Michael Vogt [Thu, 16 May 2013 09:35:32 +0000 (11:35 +0200)]
rebuild po
Michael Vogt [Thu, 16 May 2013 09:34:38 +0000 (11:34 +0200)]
add .gitignore and gbp.conf
Michael Vogt [Wed, 8 May 2013 16:58:29 +0000 (18:58 +0200)]
releasing version 0.9.8
Michael Vogt [Wed, 8 May 2013 16:58:10 +0000 (18:58 +0200)]
fix uri test
Michael Vogt [Wed, 8 May 2013 16:57:09 +0000 (18:57 +0200)]
refresh translations
Michael Vogt [Wed, 8 May 2013 15:50:15 +0000 (17:50 +0200)]
merged patch from Daniel Hartwig to fix URI and proxy releated issues
Michael Vogt [Wed, 8 May 2013 15:48:31 +0000 (17:48 +0200)]
merged from the debian-wheezy branch
Michael Vogt [Wed, 8 May 2013 15:46:31 +0000 (17:46 +0200)]
* apt-pkg/algorithms.cc:
- Do not propagate negative scores from rdepends. Propagating the absolute
value of a negative score may boost obsolete packages and keep them
installed instead of installing their successors. (Closes: #699759)
Michael Vogt [Wed, 8 May 2013 15:45:17 +0000 (17:45 +0200)]
properly handle if-modfied-since with libcurl/https
(closes: #705648)
bubulle@debian.org [Wed, 10 Apr 2013 09:28:11 +0000 (11:28 +0200)]
Fix English spelling error in a message ('A error'). Unfuzzy
translations. Closes: #705087
bubulle@debian.org [Tue, 9 Apr 2013 05:59:33 +0000 (07:59 +0200)]
Changelog entry for translation fixes
bubulle@debian.org [Tue, 9 Apr 2013 05:58:34 +0000 (07:58 +0200)]
Complete French translation
bubulle@debian.org [Tue, 9 Apr 2013 05:56:45 +0000 (07:56 +0200)]
Complete translation
bubulle@debian.org [Tue, 9 Apr 2013 05:54:52 +0000 (07:54 +0200)]
Reformat PO file
bubulle@debian.org [Tue, 9 Apr 2013 05:54:11 +0000 (07:54 +0200)]
Fix typo
Michael Vogt [Mon, 8 Apr 2013 15:30:18 +0000 (17:30 +0200)]
releasing version 0.9.7.9~exp3
Michael Vogt [Mon, 8 Apr 2013 15:29:47 +0000 (17:29 +0200)]
po: refresh
Michael Vogt [Mon, 8 Apr 2013 13:38:45 +0000 (15:38 +0200)]
merged bundle from david
Michael Vogt [Mon, 8 Apr 2013 06:45:06 +0000 (08:45 +0200)]
merged lp:~mvo/apt/add-missing-dsc-hashes
Michael Vogt [Mon, 8 Apr 2013 06:41:51 +0000 (08:41 +0200)]
* debian/control:
- replace manpages-it (closes: #704723)
Michael Vogt [Thu, 4 Apr 2013 16:22:16 +0000 (18:22 +0200)]
* apt-pkg/sourcelist.cc:
- fix segfault when a hostname contains a [, thanks to
Tzafrir Cohen (closes: #704653)
David Kalnischkies [Wed, 3 Apr 2013 17:43:03 +0000 (19:43 +0200)]
share version strings between same versions (of different architectures)
to save some space and allow quick comparisions later on
David Kalnischkies [Wed, 3 Apr 2013 17:34:47 +0000 (19:34 +0200)]
* apt-pkg/cacheiterators.h:
- provide DepIterator::IsSatisfied as a nicer shorthand for DepCheck
Michael Vogt [Wed, 3 Apr 2013 12:40:08 +0000 (14:40 +0200)]
releasing version 0.9.7.9~exp2
Michael Vogt [Wed, 3 Apr 2013 12:39:40 +0000 (14:39 +0200)]
po/*: refreshed
Michael Vogt [Wed, 3 Apr 2013 12:19:34 +0000 (14:19 +0200)]
apt-pkg/contrib/gpgv.cc: fix InRelease check
David Kalnischkies [Wed, 3 Apr 2013 10:44:36 +0000 (12:44 +0200)]
- sort group and package names in the hashtable on insert
* apt-pkg/pkgcache.cc:
- assume sorted hashtable entries for groups/packages
Michael Vogt [Tue, 2 Apr 2013 13:20:16 +0000 (15:20 +0200)]
merged lp:~mvo/apt/fix-inrelease5
Michael Vogt [Tue, 2 Apr 2013 13:08:34 +0000 (15:08 +0200)]
po/{ca,cs,ru}.po: fix merge artifacts harder
David Kalnischkies [Mon, 1 Apr 2013 21:27:16 +0000 (23:27 +0200)]
micro-optimize and enhance readability of ListParser::VersionHash
David Kalnischkies [Mon, 1 Apr 2013 13:41:02 +0000 (15:41 +0200)]
equal comparisions are used mostly in same-source relations,
so use this to try to reuse some version strings
David Kalnischkies [Mon, 1 Apr 2013 11:19:43 +0000 (13:19 +0200)]
* apt-pkg/deb/debversion.cc:
- add a string-equal shortcut for equal version comparisions
Michael Vogt [Tue, 26 Mar 2013 13:54:31 +0000 (14:54 +0100)]
merge stuff from donkult
Michael Vogt [Mon, 25 Mar 2013 12:55:07 +0000 (13:55 +0100)]
* doc/apt.conf.5.xml:
- document Acquire::ForceIPv{4,6}
Michael Vogt [Mon, 25 Mar 2013 08:03:48 +0000 (09:03 +0100)]
* methods/connect.cc:
- use Errno() instead of strerror(), thanks to David Kalnischk
Michael Vogt [Mon, 25 Mar 2013 07:56:42 +0000 (08:56 +0100)]
merge patches from daniel to fix merge artifact and test failure
Michael Vogt [Mon, 25 Mar 2013 07:52:20 +0000 (08:52 +0100)]
merge patch from Daniel Hartwig
bubulle@debian.org [Sun, 24 Mar 2013 07:58:27 +0000 (08:58 +0100)]
* Update all PO files and apt-all.pot
* French translation completed (Christian Perrier)
bubulle@debian.org [Sun, 24 Mar 2013 07:54:14 +0000 (08:54 +0100)]
Update POT and PO files
Michael Vogt [Fri, 22 Mar 2013 21:10:02 +0000 (22:10 +0100)]
releasing version 0.9.7.9~exp1
Michael Vogt [Fri, 22 Mar 2013 20:53:30 +0000 (21:53 +0100)]
prepare upload
Michael Vogt [Fri, 22 Mar 2013 20:52:42 +0000 (21:52 +0100)]
merged lp:~mvo/apt/fix-tagfile-hash
Michael Vogt [Fri, 22 Mar 2013 20:49:22 +0000 (21:49 +0100)]
merged the debian-wheezy branch
Michael Vogt [Fri, 22 Mar 2013 20:46:53 +0000 (21:46 +0100)]
add new config options "Acquire::ForceIPv4" and
"Acquire::ForceIPv6" to allow focing one or the other
(closes: #611891)
bubulle@debian.org [Fri, 22 Mar 2013 06:17:05 +0000 (07:17 +0100)]
Turkish (Mert Dirik). Closes: #703526
Michael Vogt [Thu, 21 Mar 2013 15:18:58 +0000 (16:18 +0100)]
merge patch from Colin to fix error message from getaddrinfo() (#703603)
Michael Vogt [Wed, 20 Mar 2013 11:18:16 +0000 (12:18 +0100)]
apt-pkg/edsp.cc: do not use stderr in WriteSolution at all
Michael Vogt [Wed, 20 Mar 2013 11:17:05 +0000 (12:17 +0100)]
apt-pkg/edsp.cc: do not spam stderr in WriteSolution
David Kalnischkies [Tue, 19 Mar 2013 11:37:50 +0000 (12:37 +0100)]
support dash-escaped text in clearsigned files as implementations are
free to escape all lines (we have no lines in our files which need
to be escaped as these would be invalid fieldnames) and while ExecGPGV
would detect dash-escaped text as invalid (as its not expected in
messages with detached signatures) it would be possible to "comment"
lines in (signed) dsc files which are only parsed but not verified
David Kalnischkies [Tue, 19 Mar 2013 09:49:57 +0000 (10:49 +0100)]
use FileFd instead of int fds to tidy up the interface a bit
David Kalnischkies [Mon, 18 Mar 2013 21:57:08 +0000 (22:57 +0100)]
* apt-pkg/deb/debindexfile.cc,
apt-pkg/deb/deblistparser.cc:
- use OpenMaybeClearSignedFile to be free from detecting and
skipping clearsigning metadata in dsc and Release files
We can't write a "clean" file to disk as not all acquire methods copy
Release files before checking them (e.g. cdrom), so this reverts recombining,
but uses the method we use for dsc files also in the two places we
deal with Release files
David Kalnischkies [Mon, 18 Mar 2013 18:36:55 +0000 (19:36 +0100)]
- add method to open (maybe) clearsigned files transparently
* ftparchive/writer.cc:
- use OpenMaybeClearSignedFile to be free from detecting and
skipping clearsigning metadata in dsc files
David Kalnischkies [Mon, 18 Mar 2013 16:06:51 +0000 (17:06 +0100)]
rename testcase to mention CVE number, make the code more consistent with
the rest and add some more tests (by fixing commented ones)
Michael Vogt [Mon, 18 Mar 2013 12:52:43 +0000 (13:52 +0100)]
test/libapt/tagfile_test.cc: add missing "unistd.h" (thanks to Niels Thykier)
Michael Vogt [Mon, 18 Mar 2013 11:10:35 +0000 (12:10 +0100)]
fix pkgTagSection::Exists() and add test
Michael Vogt [Mon, 18 Mar 2013 10:46:20 +0000 (11:46 +0100)]
test/integration/framework: use EXIT_CODE to be consistent with the run-tests code
Michael Vogt [Mon, 18 Mar 2013 10:38:19 +0000 (11:38 +0100)]
report failures via exit and ensure we don't overflow