try defaults if auto-detection failed in apt-cdrom

The default is to ask udev for location and mountpoints of CD-ROMs,
but the old way of specifying the mountpoint is still available and
is tried now in case udev doesn't find any CD-ROM.

It probably fails, too, but we get a bunch of error messages this
way and the user can get an idea of how to make his setup work even
if udev can't be convienced to return something useful.

Closes: #712433

diff --git a/cmdline/apt-cdrom.cc b/cmdline/apt-cdrom.cc
index 2551f49161e9fc07fe5b775a708e339a6e816eb9..70e49910c48dae6494f660bf0987bdd5c75ffbd7 100644 (file)
--- a/cmdline/apt-cdrom.cc
+++ b/cmdline/apt-cdrom.cc
@@ -150,14 +150,12 @@ bool DoAdd(CommandLine &)
    bool res = true;
 
    bool AutoDetect = _config->FindB("Acquire::cdrom::AutoDetect", true);
    bool res = true;
 
    bool AutoDetect = _config->FindB("Acquire::cdrom::AutoDetect", true);

+   unsigned int count = 0;

    if (AutoDetect && UdevCdroms.Dlopen())
    if (AutoDetect && UdevCdroms.Dlopen())

-   {
-      unsigned int count = 0;

       while (AutoDetectCdrom(UdevCdroms, count))
         res &= cdrom.Add(&log);
       while (AutoDetectCdrom(UdevCdroms, count))
         res &= cdrom.Add(&log);

-   } else {
+   if (count == 0)

       res = cdrom.Add(&log);
       res = cdrom.Add(&log);

-   }

 
    if(res)
       cout << _("Repeat this process for the rest of the CDs in your set.") << endl;
 
    if(res)
       cout << _("Repeat this process for the rest of the CDs in your set.") << endl;


@@ -178,15 +176,12 @@ bool DoIdent(CommandLine &)
 
    bool AutoDetect = _config->FindB("Acquire::cdrom::AutoDetect");
 
 
    bool AutoDetect = _config->FindB("Acquire::cdrom::AutoDetect");
 

+   unsigned int count = 0;

    if (AutoDetect && UdevCdroms.Dlopen())
    if (AutoDetect && UdevCdroms.Dlopen())

-   {
-      unsigned int count = 0;

       while (AutoDetectCdrom(UdevCdroms, count))
         res &= cdrom.Ident(ident, &log);
       while (AutoDetectCdrom(UdevCdroms, count))
         res &= cdrom.Ident(ident, &log);

-   } else {
+   if (count == 0)

       return cdrom.Ident(ident, &log);
       return cdrom.Ident(ident, &log);

-   }
- 

    return res;
 }
                                                                        /*}}}*/
    return res;
 }
                                                                        /*}}}*/

diff --git a/debian/changelog b/debian/changelog
index 9cf85c9ea1bb128b554beee5e1a7abccdcf4d220..8fef47d14000e88241c34de96b0e01865c6d9c45 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -17,6 +17,7 @@ apt (0.9.8.3) UNRELEASED; urgency=low
   * ensure state-dir exists before coyping cdrom files
   * fix file location for configure-index.gz in apt.conf(5) (Closes: #711921)
   * handle missing "Description" in apt-cache show (Closes: #712435)
   * ensure state-dir exists before coyping cdrom files
   * fix file location for configure-index.gz in apt.conf(5) (Closes: #711921)
   * handle missing "Description" in apt-cache show (Closes: #712435)

+  * try defaults if auto-detection failed in apt-cdrom (Closes: #712433)

 
  -- David Kalnischkies <kalnischkies@gmail.com>  Sun, 09 Jun 2013 15:06:24 +0200
 
 
  -- David Kalnischkies <kalnischkies@gmail.com>  Sun, 09 Jun 2013 15:06:24 +0200