* [BREAK] merged lp:~mvo/apt/history

[apt.git] / apt-pkg / indexcopy.cc

diff --git a/apt-pkg/indexcopy.cc b/apt-pkg/indexcopy.cc
index b30777d8d28939e20a2493cc24a9dd7136ad652b..53eb111722fc9f9c383f4eddcef12ffb34ea4958 100644 (file)
--- a/apt-pkg/indexcopy.cc
+++ b/apt-pkg/indexcopy.cc
@@ -275,7 +275,7 @@ bool IndexCopy::CopyPackages(string CDROM,string Name,vector<string> &List,
       _error->Warning("No valid records were found.");
 
    if (NotFound + WrongSize > 10)
       _error->Warning("No valid records were found.");
 
    if (NotFound + WrongSize > 10)

-      _error->Warning("Alot of entries were discarded, something may be wrong.\n");
+      _error->Warning("A lot of entries were discarded, something may be wrong.\n");

    
 
    return true;
    
 
    return true;


@@ -522,15 +522,24 @@ bool SigVerify::Verify(string prefix, string file, indexRecords *MetaIndex)
 {
    const indexRecords::checkSum *Record = MetaIndex->Lookup(file);
 
 {
    const indexRecords::checkSum *Record = MetaIndex->Lookup(file);
 

+   // we skip non-existing files in the verifcation to support a cdrom
+   // with no Packages file (just a Package.gz), see LP: #255545
+   // (non-existing files are not considered a error)
+   if(!FileExists(prefix+file))
+   {
+      _error->Warning(_("Skipping nonexistent file %s"), string(prefix+file).c_str());
+      return true;
+   }
+

    if (!Record) 
    {
    if (!Record) 
    {

-      _error->Warning("Can't find authentication record for: %s",file.c_str());
+      _error->Warning(_("Can't find authentication record for: %s"), file.c_str());

       return false;
    }
 
    if (!Record->Hash.VerifyFile(prefix+file))
    {
       return false;
    }
 
    if (!Record->Hash.VerifyFile(prefix+file))
    {

-      _error->Warning("Hash mismatch for: %s",file.c_str());
+      _error->Warning(_("Hash mismatch for: %s"),file.c_str());

       return false;
    }
 
       return false;
    }
 


@@ -542,8 +551,8 @@ bool SigVerify::Verify(string prefix, string file, indexRecords *MetaIndex)
 
    return true;
 }
 
    return true;
 }

-
-bool SigVerify::CopyMetaIndex(string CDROM, string CDName, 
+                                                                       /*}}}*/
+bool SigVerify::CopyMetaIndex(string CDROM, string CDName,             /*{{{*/

                              string prefix, string file)
 {
       char S[400];
                              string prefix, string file)
 {
       char S[400];


@@ -563,8 +572,8 @@ bool SigVerify::CopyMetaIndex(string CDROM, string CDName,
    
       return true;
 }
    
       return true;
 }

-
-bool SigVerify::CopyAndVerify(string CDROM,string Name,vector<string> &SigList,
+                                                                       /*}}}*/
+bool SigVerify::CopyAndVerify(string CDROM,string Name,vector<string> &SigList,        /*{{{*/

                              vector<string> PkgList,vector<string> SrcList)
 {
    if (SigList.size() == 0)
                              vector<string> PkgList,vector<string> SrcList)
 {
    if (SigList.size() == 0)


@@ -583,7 +592,10 @@ bool SigVerify::CopyAndVerify(string CDROM,string Name,vector<string> &SigList,
 
       // a Release.gpg without a Release should never happen
       if(!FileExists(*I+"Release"))
 
       // a Release.gpg without a Release should never happen
       if(!FileExists(*I+"Release"))

+      {
+        delete MetaIndex;

         continue;
         continue;

+      }

 
 
       // verify the gpg signature of "Release"
 
 
       // verify the gpg signature of "Release"


@@ -639,7 +651,7 @@ bool SigVerify::CopyAndVerify(string CDROM,string Name,vector<string> &SigList,
       // Open the Release file and add it to the MetaIndex
       if(!MetaIndex->Load(*I+"Release"))
       {
       // Open the Release file and add it to the MetaIndex
       if(!MetaIndex->Load(*I+"Release"))
       {

-        _error->Error(MetaIndex->ErrorText.c_str());
+        _error->Error("%s",MetaIndex->ErrorText.c_str());

         return false;
       }
       
         return false;
       }
       


@@ -651,6 +663,7 @@ bool SigVerify::CopyAndVerify(string CDROM,string Name,vector<string> &SigList,
         if(!Verify(prefix,*I, MetaIndex)) {
            // something went wrong, don't copy the Release.gpg
            // FIXME: delete any existing gpg file?
         if(!Verify(prefix,*I, MetaIndex)) {
            // something went wrong, don't copy the Release.gpg
            // FIXME: delete any existing gpg file?

+           _error->Discard();

            continue;    
         }
       }
            continue;    
         }
       }


@@ -665,10 +678,9 @@ bool SigVerify::CopyAndVerify(string CDROM,string Name,vector<string> &SigList,
 
    return true;
 }
 
    return true;
 }

-
-
-bool TranslationsCopy::CopyTranslations(string CDROM,string Name,vector<string> &List,
-                            pkgCdromStatus *log)
+                                                                       /*}}}*/
+bool TranslationsCopy::CopyTranslations(string CDROM,string Name,      /*{{{*/
+                               vector<string> &List, pkgCdromStatus *log)

 {
    OpProgress *Progress = NULL;
    if (List.size() == 0)
 {
    OpProgress *Progress = NULL;
    if (List.size() == 0)


@@ -835,8 +847,9 @@ bool TranslationsCopy::CopyTranslations(string CDROM,string Name,vector<string>
       _error->Warning("No valid records were found.");
 
    if (NotFound + WrongSize > 10)
       _error->Warning("No valid records were found.");
 
    if (NotFound + WrongSize > 10)

-      _error->Warning("Alot of entries were discarded, something may be wrong.\n");
+      _error->Warning("A lot of entries were discarded, something may be wrong.\n");

    
 
    return true;
 }
    
 
    return true;
 }

+                                                                       /*}}}*/