1 // -*- mode: cpp; mode: fold -*-
3 // $Id: algorithms.cc,v 1.44 2002/11/28 18:49:16 jgg Exp $
4 /* ######################################################################
6 Algorithms - A set of misc algorithms
8 The pkgProblemResolver class has become insanely complex and
9 very sophisticated, it handles every test case I have thrown at it
10 to my satisfaction. Understanding exactly why all the steps the class
11 does are required is difficult and changing though not very risky
12 may result in other cases not working.
14 ##################################################################### */
16 // Include Files /*{{{*/
19 #include <apt-pkg/algorithms.h>
20 #include <apt-pkg/error.h>
21 #include <apt-pkg/configuration.h>
22 #include <apt-pkg/version.h>
23 #include <apt-pkg/sptr.h>
24 #include <apt-pkg/acquire-item.h>
25 #include <apt-pkg/edsp.h>
26 #include <apt-pkg/sourcelist.h>
27 #include <apt-pkg/fileutl.h>
28 #include <apt-pkg/progress.h>
30 #include <sys/types.h>
40 pkgProblemResolver
*pkgProblemResolver::This
= 0;
42 // Simulate::Simulate - Constructor /*{{{*/
43 // ---------------------------------------------------------------------
44 /* The legacy translations here of input Pkg iterators is obsolete,
45 this is not necessary since the pkgCaches are fully shared now. */
46 pkgSimulate::pkgSimulate(pkgDepCache
*Cache
) : pkgPackageManager(Cache
),
48 Sim(&Cache
->GetCache(),&iPolicy
),
52 Flags
= new unsigned char[Cache
->Head().PackageCount
];
53 memset(Flags
,0,sizeof(*Flags
)*Cache
->Head().PackageCount
);
55 // Fake a filename so as not to activate the media swapping
56 string Jnk
= "SIMULATE";
57 for (unsigned int I
= 0; I
!= Cache
->Head().PackageCount
; I
++)
61 // Simulate::~Simulate - Destructor /*{{{*/
62 pkgSimulate::~pkgSimulate()
67 // Simulate::Describe - Describe a package /*{{{*/
68 // ---------------------------------------------------------------------
69 /* Parameter Current == true displays the current package version,
70 Parameter Candidate == true displays the candidate package version */
71 void pkgSimulate::Describe(PkgIterator Pkg
,ostream
&out
,bool Current
,bool Candidate
)
75 out
<< Pkg
.FullName(true);
79 Ver
= Pkg
.CurrentVer();
80 if (Ver
.end() == false)
81 out
<< " [" << Ver
.VerStr() << ']';
84 if (Candidate
== true)
86 Ver
= Sim
[Pkg
].CandidateVerIter(Sim
);
87 if (Ver
.end() == true)
90 out
<< " (" << Ver
.VerStr() << ' ' << Ver
.RelStr() << ')';
94 // Simulate::Install - Simulate unpacking of a package /*{{{*/
95 // ---------------------------------------------------------------------
97 bool pkgSimulate::Install(PkgIterator iPkg
,string
/*File*/)
100 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name(), iPkg
.Arch());
104 Describe(Pkg
,cout
,true,true);
105 Sim
.MarkInstall(Pkg
,false);
107 // Look for broken conflicts+predepends.
108 for (PkgIterator I
= Sim
.PkgBegin(); I
.end() == false; ++I
)
110 if (Sim
[I
].InstallVer
== 0)
113 for (DepIterator D
= Sim
[I
].InstVerIter(Sim
).DependsList(); D
.end() == false;)
118 if (Start
.IsNegative() == true ||
119 End
->Type
== pkgCache::Dep::PreDepends
)
121 if ((Sim
[End
] & pkgDepCache::DepGInstall
) == 0)
123 cout
<< " [" << I
.FullName(false) << " on " << Start
.TargetPkg().FullName(false) << ']';
124 if (Start
->Type
== pkgCache::Dep::Conflicts
)
125 _error
->Error("Fatal, conflicts violated %s",I
.FullName(false).c_str());
131 if (Sim
.BrokenCount() != 0)
138 // Simulate::Configure - Simulate configuration of a Package /*{{{*/
139 // ---------------------------------------------------------------------
140 /* This is not an acurate simulation of relatity, we should really not
141 install the package.. For some investigations it may be necessary
143 bool pkgSimulate::Configure(PkgIterator iPkg
)
145 // Adapt the iterator
146 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name(), iPkg
.Arch());
150 if (Sim
[Pkg
].InstBroken() == true)
152 cout
<< "Conf " << Pkg
.FullName(false) << " broken" << endl
;
156 // Print out each package and the failed dependencies
157 for (pkgCache::DepIterator D
= Sim
[Pkg
].InstVerIter(Sim
).DependsList(); D
.end() == false; ++D
)
159 if (Sim
.IsImportantDep(D
) == false ||
160 (Sim
[D
] & pkgDepCache::DepInstall
) != 0)
163 if (D
->Type
== pkgCache::Dep::Obsoletes
)
164 cout
<< " Obsoletes:" << D
.TargetPkg().FullName(false);
165 else if (D
->Type
== pkgCache::Dep::Conflicts
)
166 cout
<< " Conflicts:" << D
.TargetPkg().FullName(false);
167 else if (D
->Type
== pkgCache::Dep::DpkgBreaks
)
168 cout
<< " Breaks:" << D
.TargetPkg().FullName(false);
170 cout
<< " Depends:" << D
.TargetPkg().FullName(false);
174 _error
->Error("Conf Broken %s",Pkg
.FullName(false).c_str());
179 Describe(Pkg
,cout
,false,true);
182 if (Sim
.BrokenCount() != 0)
190 // Simulate::Remove - Simulate the removal of a package /*{{{*/
191 // ---------------------------------------------------------------------
193 bool pkgSimulate::Remove(PkgIterator iPkg
,bool Purge
)
195 // Adapt the iterator
196 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name(), iPkg
.Arch());
197 if (Pkg
.end() == true)
199 std::cerr
<< (Purge
? "Purg" : "Remv") << " invalid package " << iPkg
.FullName() << std::endl
;
210 Describe(Pkg
,cout
,true,false);
212 if (Sim
.BrokenCount() != 0)
220 // Simulate::ShortBreaks - Print out a short line describing all breaks /*{{{*/
221 // ---------------------------------------------------------------------
223 void pkgSimulate::ShortBreaks()
226 for (PkgIterator I
= Sim
.PkgBegin(); I
.end() == false; ++I
)
228 if (Sim
[I
].InstBroken() == true)
230 if (Flags
[I
->ID
] == 0)
231 cout
<< I
.FullName(false) << ' ';
233 cout << I.Name() << "! ";*/
239 // ApplyStatus - Adjust for non-ok packages /*{{{*/
240 // ---------------------------------------------------------------------
241 /* We attempt to change the state of the all packages that have failed
242 installation toward their real state. The ordering code will perform
243 the necessary calculations to deal with the problems. */
244 bool pkgApplyStatus(pkgDepCache
&Cache
)
246 pkgDepCache::ActionGroup
group(Cache
);
248 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
250 if (I
->VersionList
== 0)
253 // Only choice for a ReInstReq package is to reinstall
254 if (I
->InstState
== pkgCache::State::ReInstReq
||
255 I
->InstState
== pkgCache::State::HoldReInstReq
)
257 if (I
->CurrentVer
!= 0 && I
.CurrentVer().Downloadable() == true)
258 Cache
.MarkKeep(I
, false, false);
261 // Is this right? Will dpkg choke on an upgrade?
262 if (Cache
[I
].CandidateVer
!= 0 &&
263 Cache
[I
].CandidateVerIter(Cache
).Downloadable() == true)
264 Cache
.MarkInstall(I
, false, 0, false);
266 return _error
->Error(_("The package %s needs to be reinstalled, "
267 "but I can't find an archive for it."),I
.FullName(true).c_str());
273 switch (I
->CurrentState
)
275 /* This means installation failed somehow - it does not need to be
276 re-unpacked (probably) */
277 case pkgCache::State::UnPacked
:
278 case pkgCache::State::HalfConfigured
:
279 case pkgCache::State::TriggersAwaited
:
280 case pkgCache::State::TriggersPending
:
281 if ((I
->CurrentVer
!= 0 && I
.CurrentVer().Downloadable() == true) ||
282 I
.State() != pkgCache::PkgIterator::NeedsUnpack
)
283 Cache
.MarkKeep(I
, false, false);
286 if (Cache
[I
].CandidateVer
!= 0 &&
287 Cache
[I
].CandidateVerIter(Cache
).Downloadable() == true)
288 Cache
.MarkInstall(I
, true, 0, false);
290 Cache
.MarkDelete(I
, false, 0, false);
294 // This means removal failed
295 case pkgCache::State::HalfInstalled
:
296 Cache
.MarkDelete(I
, false, 0, false);
300 if (I
->InstState
!= pkgCache::State::Ok
)
301 return _error
->Error("The package %s is not ok and I "
302 "don't know how to fix it!",I
.FullName(false).c_str());
308 // FixBroken - Fix broken packages /*{{{*/
309 // ---------------------------------------------------------------------
310 /* This autoinstalls every broken package and then runs the problem resolver
312 bool pkgFixBroken(pkgDepCache
&Cache
)
314 pkgDepCache::ActionGroup
group(Cache
);
316 // Auto upgrade all broken packages
317 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
318 if (Cache
[I
].NowBroken() == true)
319 Cache
.MarkInstall(I
, true, 0, false);
321 /* Fix packages that are in a NeedArchive state but don't have a
322 downloadable install version */
323 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
325 if (I
.State() != pkgCache::PkgIterator::NeedsUnpack
||
326 Cache
[I
].Delete() == true)
329 if (Cache
[I
].InstVerIter(Cache
).Downloadable() == false)
332 Cache
.MarkInstall(I
, true, 0, false);
335 pkgProblemResolver
Fix(&Cache
);
336 return Fix
.Resolve(true);
339 // DistUpgrade - Distribution upgrade /*{{{*/
340 // ---------------------------------------------------------------------
341 /* This autoinstalls every package and then force installs every
342 pre-existing package. This creates the initial set of conditions which
343 most likely contain problems because too many things were installed.
345 The problem resolver is used to resolve the problems.
347 bool pkgDistUpgrade(pkgDepCache
&Cache
)
349 std::string
const solver
= _config
->Find("APT::Solver", "internal");
350 if (solver
!= "internal") {
351 OpTextProgress
Prog(*_config
);
352 return EDSP::ResolveExternal(solver
.c_str(), Cache
, false, true, false, &Prog
);
355 pkgDepCache::ActionGroup
group(Cache
);
357 /* Upgrade all installed packages first without autoinst to help the resolver
358 in versioned or-groups to upgrade the old solver instead of installing
359 a new one (if the old solver is not the first one [anymore]) */
360 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
361 if (I
->CurrentVer
!= 0)
362 Cache
.MarkInstall(I
, false, 0, false);
364 /* Auto upgrade all installed packages, this provides the basis
365 for the installation */
366 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
367 if (I
->CurrentVer
!= 0)
368 Cache
.MarkInstall(I
, true, 0, false);
370 /* Now, install each essential package which is not installed
371 (and not provided by another package in the same name group) */
372 std::string essential
= _config
->Find("pkgCacheGen::Essential", "all");
373 if (essential
== "all")
375 for (pkgCache::GrpIterator G
= Cache
.GrpBegin(); G
.end() == false; ++G
)
377 bool isEssential
= false;
378 bool instEssential
= false;
379 for (pkgCache::PkgIterator P
= G
.PackageList(); P
.end() == false; P
= G
.NextPkg(P
))
381 if ((P
->Flags
& pkgCache::Flag::Essential
) != pkgCache::Flag::Essential
)
384 if (Cache
[P
].Install() == true)
386 instEssential
= true;
390 if (isEssential
== false || instEssential
== true)
392 pkgCache::PkgIterator P
= G
.FindPreferredPkg();
393 Cache
.MarkInstall(P
, true, 0, false);
396 else if (essential
!= "none")
397 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
398 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
399 Cache
.MarkInstall(I
, true, 0, false);
401 /* We do it again over all previously installed packages to force
402 conflict resolution on them all. */
403 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
404 if (I
->CurrentVer
!= 0)
405 Cache
.MarkInstall(I
, false, 0, false);
407 pkgProblemResolver
Fix(&Cache
);
409 // Hold back held packages.
410 if (_config
->FindB("APT::Ignore-Hold",false) == false)
412 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
414 if (I
->SelectedState
== pkgCache::State::Hold
)
417 Cache
.MarkKeep(I
, false, false);
422 return Fix
.Resolve();
425 // AllUpgrade - Upgrade as many packages as possible /*{{{*/
426 // ---------------------------------------------------------------------
427 /* Right now the system must be consistent before this can be called.
428 It also will not change packages marked for install, it only tries
429 to install packages not marked for install */
430 bool pkgAllUpgrade(pkgDepCache
&Cache
)
432 std::string
const solver
= _config
->Find("APT::Solver", "internal");
433 if (solver
!= "internal") {
434 OpTextProgress
Prog(*_config
);
435 return EDSP::ResolveExternal(solver
.c_str(), Cache
, true, false, false, &Prog
);
438 pkgDepCache::ActionGroup
group(Cache
);
440 pkgProblemResolver
Fix(&Cache
);
442 if (Cache
.BrokenCount() != 0)
445 // Upgrade all installed packages
446 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
448 if (Cache
[I
].Install() == true)
451 if (_config
->FindB("APT::Ignore-Hold",false) == false)
452 if (I
->SelectedState
== pkgCache::State::Hold
)
455 if (I
->CurrentVer
!= 0 && Cache
[I
].InstallVer
!= 0)
456 Cache
.MarkInstall(I
, false, 0, false);
459 return Fix
.ResolveByKeep();
462 // MinimizeUpgrade - Minimizes the set of packages to be upgraded /*{{{*/
463 // ---------------------------------------------------------------------
464 /* This simply goes over the entire set of packages and tries to keep
465 each package marked for upgrade. If a conflict is generated then
466 the package is restored. */
467 bool pkgMinimizeUpgrade(pkgDepCache
&Cache
)
469 pkgDepCache::ActionGroup
group(Cache
);
471 if (Cache
.BrokenCount() != 0)
474 // We loop for 10 tries to get the minimal set size.
476 unsigned int Count
= 0;
480 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
483 if (Cache
[I
].Upgrade() == false || Cache
[I
].NewInstall() == true)
486 // Keep it and see if that is OK
487 Cache
.MarkKeep(I
, false, false);
488 if (Cache
.BrokenCount() != 0)
489 Cache
.MarkInstall(I
, false, 0, false);
492 // If keep didnt actually do anything then there was no change..
493 if (Cache
[I
].Upgrade() == false)
499 while (Change
== true && Count
< 10);
501 if (Cache
.BrokenCount() != 0)
502 return _error
->Error("Internal Error in pkgMinimizeUpgrade");
507 // ProblemResolver::pkgProblemResolver - Constructor /*{{{*/
508 // ---------------------------------------------------------------------
510 pkgProblemResolver::pkgProblemResolver(pkgDepCache
*pCache
) : d(NULL
), Cache(*pCache
)
513 unsigned long Size
= Cache
.Head().PackageCount
;
514 Scores
= new int[Size
];
515 Flags
= new unsigned char[Size
];
516 memset(Flags
,0,sizeof(*Flags
)*Size
);
518 // Set debug to true to see its decision logic
519 Debug
= _config
->FindB("Debug::pkgProblemResolver",false);
522 // ProblemResolver::~pkgProblemResolver - Destructor /*{{{*/
523 // ---------------------------------------------------------------------
525 pkgProblemResolver::~pkgProblemResolver()
531 // ProblemResolver::ScoreSort - Sort the list by score /*{{{*/
532 // ---------------------------------------------------------------------
534 int pkgProblemResolver::ScoreSort(const void *a
,const void *b
)
536 Package
const **A
= (Package
const **)a
;
537 Package
const **B
= (Package
const **)b
;
538 if (This
->Scores
[(*A
)->ID
] > This
->Scores
[(*B
)->ID
])
540 if (This
->Scores
[(*A
)->ID
] < This
->Scores
[(*B
)->ID
])
545 // ProblemResolver::MakeScores - Make the score table /*{{{*/
546 // ---------------------------------------------------------------------
548 void pkgProblemResolver::MakeScores()
550 unsigned long Size
= Cache
.Head().PackageCount
;
551 memset(Scores
,0,sizeof(*Scores
)*Size
);
553 // Maps to pkgCache::State::VerPriority
554 // which is "Important Required Standard Optional Extra"
555 // (yes, that is confusing, the order of pkgCache::State::VerPriority
556 // needs to be adjusted but that requires a ABI break)
559 _config
->FindI("pkgProblemResolver::Scores::Important",2),
560 _config
->FindI("pkgProblemResolver::Scores::Required",3),
561 _config
->FindI("pkgProblemResolver::Scores::Standard",1),
562 _config
->FindI("pkgProblemResolver::Scores::Optional",-1),
563 _config
->FindI("pkgProblemResolver::Scores::Extra",-2)
565 int PrioEssentials
= _config
->FindI("pkgProblemResolver::Scores::Essentials",100);
566 int PrioInstalledAndNotObsolete
= _config
->FindI("pkgProblemResolver::Scores::NotObsolete",1);
567 int PrioDepends
= _config
->FindI("pkgProblemResolver::Scores::Depends",1);
568 int PrioRecommends
= _config
->FindI("pkgProblemResolver::Scores::Recommends",1);
569 int AddProtected
= _config
->FindI("pkgProblemResolver::Scores::AddProtected",10000);
570 int AddEssential
= _config
->FindI("pkgProblemResolver::Scores::AddEssential",5000);
572 if (_config
->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
573 clog
<< "Settings used to calculate pkgProblemResolver::Scores::" << endl
574 << " Required => " << PrioMap
[pkgCache::State::Required
] << endl
575 << " Important => " << PrioMap
[pkgCache::State::Important
] << endl
576 << " Standard => " << PrioMap
[pkgCache::State::Standard
] << endl
577 << " Optional => " << PrioMap
[pkgCache::State::Optional
] << endl
578 << " Extra => " << PrioMap
[pkgCache::State::Extra
] << endl
579 << " Essentials => " << PrioEssentials
<< endl
580 << " InstalledAndNotObsolete => " << PrioInstalledAndNotObsolete
<< endl
581 << " Depends => " << PrioDepends
<< endl
582 << " Recommends => " << PrioRecommends
<< endl
583 << " AddProtected => " << AddProtected
<< endl
584 << " AddEssential => " << AddEssential
<< endl
;
586 // Generate the base scores for a package based on its properties
587 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
589 if (Cache
[I
].InstallVer
== 0)
592 int &Score
= Scores
[I
->ID
];
594 /* This is arbitrary, it should be high enough to elevate an
595 essantial package above most other packages but low enough
596 to allow an obsolete essential packages to be removed by
597 a conflicts on a powerfull normal package (ie libc6) */
598 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
599 || (I
->Flags
& pkgCache::Flag::Important
) == pkgCache::Flag::Important
)
600 Score
+= PrioEssentials
;
602 // We transform the priority
603 if (Cache
[I
].InstVerIter(Cache
)->Priority
<= 5)
604 Score
+= PrioMap
[Cache
[I
].InstVerIter(Cache
)->Priority
];
606 /* This helps to fix oddball problems with conflicting packages
607 on the same level. We enhance the score of installed packages
608 if those are not obsolete
610 if (I
->CurrentVer
!= 0 && Cache
[I
].CandidateVer
!= 0 && Cache
[I
].CandidateVerIter(Cache
).Downloadable())
611 Score
+= PrioInstalledAndNotObsolete
;
614 // Now that we have the base scores we go and propogate dependencies
615 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
617 if (Cache
[I
].InstallVer
== 0)
620 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList(); D
.end() == false; ++D
)
622 if (D
->Type
== pkgCache::Dep::Depends
||
623 D
->Type
== pkgCache::Dep::PreDepends
)
624 Scores
[D
.TargetPkg()->ID
] += PrioDepends
;
625 else if (D
->Type
== pkgCache::Dep::Recommends
)
626 Scores
[D
.TargetPkg()->ID
] += PrioRecommends
;
630 // Copy the scores to advoid additive looping
631 SPtrArray
<int> OldScores
= new int[Size
];
632 memcpy(OldScores
,Scores
,sizeof(*Scores
)*Size
);
634 /* Now we cause 1 level of dependency inheritance, that is we add the
635 score of the packages that depend on the target Package. This
636 fortifies high scoring packages */
637 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
639 if (Cache
[I
].InstallVer
== 0)
642 for (pkgCache::DepIterator D
= I
.RevDependsList(); D
.end() == false; ++D
)
644 // Only do it for the install version
645 if ((pkgCache::Version
*)D
.ParentVer() != Cache
[D
.ParentPkg()].InstallVer
||
646 (D
->Type
!= pkgCache::Dep::Depends
&&
647 D
->Type
!= pkgCache::Dep::PreDepends
&&
648 D
->Type
!= pkgCache::Dep::Recommends
))
651 // Do not propagate negative scores otherwise
652 // an extra (-2) package might score better than an optional (-1)
653 if (OldScores
[D
.ParentPkg()->ID
] > 0)
654 Scores
[I
->ID
] += OldScores
[D
.ParentPkg()->ID
];
658 /* Now we propogate along provides. This makes the packages that
659 provide important packages extremely important */
660 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
662 for (pkgCache::PrvIterator P
= I
.ProvidesList(); P
.end() == false; ++P
)
664 // Only do it once per package
665 if ((pkgCache::Version
*)P
.OwnerVer() != Cache
[P
.OwnerPkg()].InstallVer
)
667 Scores
[P
.OwnerPkg()->ID
] += abs(Scores
[I
->ID
] - OldScores
[I
->ID
]);
671 /* Protected things are pushed really high up. This number should put them
672 ahead of everything */
673 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
675 if ((Flags
[I
->ID
] & Protected
) != 0)
676 Scores
[I
->ID
] += AddProtected
;
677 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
||
678 (I
->Flags
& pkgCache::Flag::Important
) == pkgCache::Flag::Important
)
679 Scores
[I
->ID
] += AddEssential
;
683 // ProblemResolver::DoUpgrade - Attempt to upgrade this package /*{{{*/
684 // ---------------------------------------------------------------------
685 /* This goes through and tries to reinstall packages to make this package
687 bool pkgProblemResolver::DoUpgrade(pkgCache::PkgIterator Pkg
)
689 pkgDepCache::ActionGroup
group(Cache
);
691 if ((Flags
[Pkg
->ID
] & Upgradable
) == 0 || Cache
[Pkg
].Upgradable() == false)
693 if ((Flags
[Pkg
->ID
] & Protected
) == Protected
)
696 Flags
[Pkg
->ID
] &= ~Upgradable
;
698 bool WasKept
= Cache
[Pkg
].Keep();
699 Cache
.MarkInstall(Pkg
, false, 0, false);
701 // This must be a virtual package or something like that.
702 if (Cache
[Pkg
].InstVerIter(Cache
).end() == true)
705 // Isolate the problem dependency
707 for (pkgCache::DepIterator D
= Cache
[Pkg
].InstVerIter(Cache
).DependsList(); D
.end() == false;)
709 // Compute a single dependency element (glob or)
710 pkgCache::DepIterator Start
= D
;
711 pkgCache::DepIterator End
= D
;
712 for (bool LastOR
= true; D
.end() == false && LastOR
== true;)
714 LastOR
= (D
->CompareOp
& pkgCache::Dep::Or
) == pkgCache::Dep::Or
;
720 // We only worry about critical deps.
721 if (End
.IsCritical() != true)
724 // Iterate over all the members in the or group
728 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
731 // Do not change protected packages
732 PkgIterator P
= Start
.SmartTargetPkg();
733 if ((Flags
[P
->ID
] & Protected
) == Protected
)
736 clog
<< " Reinst Failed because of protected " << P
.FullName(false) << endl
;
741 // Upgrade the package if the candidate version will fix the problem.
742 if ((Cache
[Start
] & pkgDepCache::DepCVer
) == pkgDepCache::DepCVer
)
744 if (DoUpgrade(P
) == false)
747 clog
<< " Reinst Failed because of " << P
.FullName(false) << endl
;
758 /* We let the algorithm deal with conflicts on its next iteration,
759 it is much smarter than us */
760 if (Start
.IsNegative() == true)
764 clog
<< " Reinst Failed early because of " << Start
.TargetPkg().FullName(false) << endl
;
777 // Undo our operations - it might be smart to undo everything this did..
781 Cache
.MarkKeep(Pkg
, false, false);
783 Cache
.MarkDelete(Pkg
, false, 0, false);
788 clog
<< " Re-Instated " << Pkg
.FullName(false) << endl
;
792 // ProblemResolver::Resolve - calls a resolver to fix the situation /*{{{*/
793 // ---------------------------------------------------------------------
795 bool pkgProblemResolver::Resolve(bool BrokenFix
)
797 std::string
const solver
= _config
->Find("APT::Solver", "internal");
798 if (solver
!= "internal") {
799 OpTextProgress
Prog(*_config
);
800 return EDSP::ResolveExternal(solver
.c_str(), Cache
, false, false, false, &Prog
);
802 return ResolveInternal(BrokenFix
);
805 // ProblemResolver::ResolveInternal - Run the resolution pass /*{{{*/
806 // ---------------------------------------------------------------------
807 /* This routines works by calculating a score for each package. The score
808 is derived by considering the package's priority and all reverse
809 dependents giving an integer that reflects the amount of breakage that
810 adjusting the package will inflict.
812 It goes from highest score to lowest and corrects all of the breaks by
813 keeping or removing the dependant packages. If that fails then it removes
814 the package itself and goes on. The routine should be able to intelligently
815 go from any broken state to a fixed state.
817 The BrokenFix flag enables a mode where the algorithm tries to
818 upgrade packages to advoid problems. */
819 bool pkgProblemResolver::ResolveInternal(bool const BrokenFix
)
821 pkgDepCache::ActionGroup
group(Cache
);
823 // Record which packages are marked for install
828 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
830 if (Cache
[I
].Install() == true)
831 Flags
[I
->ID
] |= PreInstalled
;
834 if (Cache
[I
].InstBroken() == true && BrokenFix
== true)
836 Cache
.MarkInstall(I
, false, 0, false);
837 if (Cache
[I
].Install() == true)
841 Flags
[I
->ID
] &= ~PreInstalled
;
843 Flags
[I
->ID
] |= Upgradable
;
846 while (Again
== true);
849 clog
<< "Starting, broken count: " << Cache
.BrokenCount() << endl
;
854 unsigned long const Size
= Cache
.Head().PackageCount
;
856 /* We have to order the packages so that the broken fixing pass
857 operates from highest score to lowest. This prevents problems when
858 high score packages cause the removal of lower score packages that
859 would cause the removal of even lower score packages. */
860 SPtrArray
<pkgCache::Package
*> PList
= new pkgCache::Package
*[Size
];
861 pkgCache::Package
**PEnd
= PList
;
862 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
865 qsort(PList
,PEnd
- PList
,sizeof(*PList
),&ScoreSort
);
867 if (_config
->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
869 clog
<< "Show Scores" << endl
;
870 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
871 if (Scores
[(*K
)->ID
] != 0)
873 pkgCache::PkgIterator
Pkg(Cache
,*K
);
874 clog
<< Scores
[(*K
)->ID
] << ' ' << Pkg
<< std::endl
;
879 clog
<< "Starting 2, broken count: " << Cache
.BrokenCount() << endl
;
882 /* Now consider all broken packages. For each broken package we either
883 remove the package or fix it's problem. We do this once, it should
884 not be possible for a loop to form (that is a < b < c and fixing b by
885 changing a breaks c) */
887 bool const TryFixByInstall
= _config
->FindB("pkgProblemResolver::FixByInstall", true);
888 for (int Counter
= 0; Counter
!= 10 && Change
== true; Counter
++)
891 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
893 pkgCache::PkgIterator
I(Cache
,*K
);
895 /* We attempt to install this and see if any breaks result,
896 this takes care of some strange cases */
897 if (Cache
[I
].CandidateVer
!= Cache
[I
].InstallVer
&&
898 I
->CurrentVer
!= 0 && Cache
[I
].InstallVer
!= 0 &&
899 (Flags
[I
->ID
] & PreInstalled
) != 0 &&
900 (Flags
[I
->ID
] & Protected
) == 0 &&
901 (Flags
[I
->ID
] & ReInstateTried
) == 0)
904 clog
<< " Try to Re-Instate (" << Counter
<< ") " << I
.FullName(false) << endl
;
905 unsigned long OldBreaks
= Cache
.BrokenCount();
906 pkgCache::Version
*OldVer
= Cache
[I
].InstallVer
;
907 Flags
[I
->ID
] &= ReInstateTried
;
909 Cache
.MarkInstall(I
, false, 0, false);
910 if (Cache
[I
].InstBroken() == true ||
911 OldBreaks
< Cache
.BrokenCount())
914 Cache
.MarkDelete(I
, false, 0, false);
916 Cache
.MarkKeep(I
, false, false);
920 clog
<< "Re-Instated " << I
.FullName(false) << " (" << OldBreaks
<< " vs " << Cache
.BrokenCount() << ')' << endl
;
923 if (Cache
[I
].InstallVer
== 0 || Cache
[I
].InstBroken() == false)
927 clog
<< "Investigating (" << Counter
<< ") " << I
<< endl
;
929 // Isolate the problem dependency
930 PackageKill KillList
[100];
931 PackageKill
*LEnd
= KillList
;
933 pkgCache::DepIterator Start
;
934 pkgCache::DepIterator End
;
935 PackageKill
*OldEnd
= LEnd
;
937 enum {OrRemove
,OrKeep
} OrOp
= OrRemove
;
938 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList();
939 D
.end() == false || InOr
== true;)
941 // Compute a single dependency element (glob or)
945 if (InOr
== true && OldEnd
== LEnd
)
947 if (OrOp
== OrRemove
)
949 if ((Flags
[I
->ID
] & Protected
) != Protected
)
952 clog
<< " Or group remove for " << I
.FullName(false) << endl
;
953 Cache
.MarkDelete(I
, false, 0, false);
957 else if (OrOp
== OrKeep
)
960 clog
<< " Or group keep for " << I
.FullName(false) << endl
;
961 Cache
.MarkKeep(I
, false, false);
966 /* We do an extra loop (as above) to finalize the or group
971 if (Start
.end() == true)
974 // We only worry about critical deps.
975 if (End
.IsCritical() != true)
984 // We only worry about critical deps.
985 if (Start
.IsCritical() != true)
990 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
997 clog
<< "Broken " << Start
<< endl
;
999 /* Look across the version list. If there are no possible
1000 targets then we keep the package and bail. This is necessary
1001 if a package has a dep on another package that cant be found */
1002 SPtrArray
<pkgCache::Version
*> VList
= Start
.AllTargets();
1003 if (*VList
== 0 && (Flags
[I
->ID
] & Protected
) != Protected
&&
1004 Start
.IsNegative() == false &&
1005 Cache
[I
].NowBroken() == false)
1009 /* No keep choice because the keep being OK could be the
1010 result of another element in the OR group! */
1015 Cache
.MarkKeep(I
, false, false);
1020 for (pkgCache::Version
**V
= VList
; *V
!= 0; V
++)
1022 pkgCache::VerIterator
Ver(Cache
,*V
);
1023 pkgCache::PkgIterator Pkg
= Ver
.ParentPkg();
1025 /* This is a conflicts, and the version we are looking
1026 at is not the currently selected version of the
1027 package, which means it is not necessary to
1029 if (Cache
[Pkg
].InstallVer
!= Ver
&& Start
.IsNegative() == true)
1032 clog
<< " Conflicts//Breaks against version "
1033 << Ver
.VerStr() << " for " << Pkg
.Name()
1034 << " but that is not InstVer, ignoring"
1040 clog
<< " Considering " << Pkg
.FullName(false) << ' ' << (int)Scores
[Pkg
->ID
] <<
1041 " as a solution to " << I
.FullName(false) << ' ' << (int)Scores
[I
->ID
] << endl
;
1043 /* Try to fix the package under consideration rather than
1044 fiddle with the VList package */
1045 if (Scores
[I
->ID
] <= Scores
[Pkg
->ID
] ||
1046 ((Cache
[Start
] & pkgDepCache::DepNow
) == 0 &&
1047 End
.IsNegative() == false))
1049 // Try a little harder to fix protected packages..
1050 if ((Flags
[I
->ID
] & Protected
) == Protected
)
1052 if (DoUpgrade(Pkg
) == true)
1054 if (Scores
[Pkg
->ID
] > Scores
[I
->ID
])
1055 Scores
[Pkg
->ID
] = Scores
[I
->ID
];
1062 /* See if a keep will do, unless the package is protected,
1063 then installing it will be necessary */
1064 bool Installed
= Cache
[I
].Install();
1065 Cache
.MarkKeep(I
, false, false);
1066 if (Cache
[I
].InstBroken() == false)
1068 // Unwind operation will be keep now
1069 if (OrOp
== OrRemove
)
1073 if (InOr
== true && Installed
== true)
1074 Cache
.MarkInstall(I
, false, 0, false);
1077 clog
<< " Holding Back " << I
.FullName(false) << " rather than change " << Start
.TargetPkg().FullName(false) << endl
;
1081 if (BrokenFix
== false || DoUpgrade(I
) == false)
1083 // Consider other options
1084 if (InOr
== false || Cache
[I
].Garbage
== true)
1087 clog
<< " Removing " << I
.FullName(false) << " rather than change " << Start
.TargetPkg().FullName(false) << endl
;
1088 Cache
.MarkDelete(I
, false, 0, false);
1089 if (Counter
> 1 && Scores
[Pkg
->ID
] > Scores
[I
->ID
])
1090 Scores
[I
->ID
] = Scores
[Pkg
->ID
];
1092 else if (TryFixByInstall
== true &&
1093 Start
.TargetPkg()->CurrentVer
== 0 &&
1094 Cache
[Start
.TargetPkg()].Delete() == false &&
1095 (Flags
[Start
.TargetPkg()->ID
] & ToRemove
) != ToRemove
&&
1096 Cache
.GetCandidateVer(Start
.TargetPkg()).end() == false)
1098 /* Before removing or keeping the package with the broken dependency
1099 try instead to install the first not previously installed package
1100 solving this dependency. This helps every time a previous solver
1101 is removed by the resolver because of a conflict or alike but it is
1102 dangerous as it could trigger new breaks/conflicts… */
1104 clog
<< " Try Installing " << Start
.TargetPkg() << " before changing " << I
.FullName(false) << std::endl
;
1105 unsigned long const OldBroken
= Cache
.BrokenCount();
1106 Cache
.MarkInstall(Start
.TargetPkg(), true, 1, false);
1107 // FIXME: we should undo the complete MarkInstall process here
1108 if (Cache
[Start
.TargetPkg()].InstBroken() == true || Cache
.BrokenCount() > OldBroken
)
1109 Cache
.MarkDelete(Start
.TargetPkg(), false, 1, false);
1120 if (Start
->Type
== pkgCache::Dep::DpkgBreaks
)
1122 // first, try upgradring the package, if that
1123 // does not help, the breaks goes onto the
1126 // FIXME: use DoUpgrade(Pkg) instead?
1127 if (Cache
[End
] & pkgDepCache::DepGCVer
)
1130 clog
<< " Upgrading " << Pkg
.FullName(false) << " due to Breaks field in " << I
.FullName(false) << endl
;
1131 Cache
.MarkInstall(Pkg
, false, 0, false);
1136 // Skip adding to the kill list if it is protected
1137 if ((Flags
[Pkg
->ID
] & Protected
) != 0)
1141 clog
<< " Added " << Pkg
.FullName(false) << " to the remove list" << endl
;
1147 if (Start
.IsNegative() == false)
1152 // Hm, nothing can possibly satisify this dep. Nuke it.
1153 if (VList
[0] == 0 &&
1154 Start
.IsNegative() == false &&
1155 (Flags
[I
->ID
] & Protected
) != Protected
)
1157 bool Installed
= Cache
[I
].Install();
1159 if (Cache
[I
].InstBroken() == false)
1161 // Unwind operation will be keep now
1162 if (OrOp
== OrRemove
)
1166 if (InOr
== true && Installed
== true)
1167 Cache
.MarkInstall(I
, false, 0, false);
1170 clog
<< " Holding Back " << I
.FullName(false) << " because I can't find " << Start
.TargetPkg().FullName(false) << endl
;
1175 clog
<< " Removing " << I
.FullName(false) << " because I can't find " << Start
.TargetPkg().FullName(false) << endl
;
1177 Cache
.MarkDelete(I
, false, 0, false);
1192 // Apply the kill list now
1193 if (Cache
[I
].InstallVer
!= 0)
1195 for (PackageKill
*J
= KillList
; J
!= LEnd
; J
++)
1198 if ((Cache
[J
->Dep
] & pkgDepCache::DepGNow
) == 0)
1200 if (J
->Dep
.IsNegative() == true)
1203 clog
<< " Fixing " << I
.FullName(false) << " via remove of " << J
->Pkg
.FullName(false) << endl
;
1204 Cache
.MarkDelete(J
->Pkg
, false, 0, false);
1210 clog
<< " Fixing " << I
.FullName(false) << " via keep of " << J
->Pkg
.FullName(false) << endl
;
1211 Cache
.MarkKeep(J
->Pkg
, false, false);
1216 if (Scores
[I
->ID
] > Scores
[J
->Pkg
->ID
])
1217 Scores
[J
->Pkg
->ID
] = Scores
[I
->ID
];
1225 clog
<< "Done" << endl
;
1227 if (Cache
.BrokenCount() != 0)
1229 // See if this is the result of a hold
1230 pkgCache::PkgIterator I
= Cache
.PkgBegin();
1231 for (;I
.end() != true; ++I
)
1233 if (Cache
[I
].InstBroken() == false)
1235 if ((Flags
[I
->ID
] & Protected
) != Protected
)
1236 return _error
->Error(_("Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages."));
1238 return _error
->Error(_("Unable to correct problems, you have held broken packages."));
1241 // set the auto-flags (mvo: I'm not sure if we _really_ need this)
1242 pkgCache::PkgIterator I
= Cache
.PkgBegin();
1243 for (;I
.end() != true; ++I
) {
1244 if (Cache
[I
].NewInstall() && !(Flags
[I
->ID
] & PreInstalled
)) {
1245 if(_config
->FindI("Debug::pkgAutoRemove",false)) {
1246 std::clog
<< "Resolve installed new pkg: " << I
.FullName(false)
1247 << " (now marking it as auto)" << std::endl
;
1249 Cache
[I
].Flags
|= pkgCache::Flag::Auto
;
1257 // ProblemResolver::BreaksInstOrPolicy - Check if the given pkg is broken/*{{{*/
1258 // ---------------------------------------------------------------------
1259 /* This checks if the given package is broken either by a hard dependency
1260 (InstBroken()) or by introducing a new policy breakage e.g. new
1261 unsatisfied recommends for a package that was in "policy-good" state
1263 Note that this is not perfect as it will ignore further breakage
1264 for already broken policy (recommends)
1266 bool pkgProblemResolver::InstOrNewPolicyBroken(pkgCache::PkgIterator I
)
1268 // a broken install is always a problem
1269 if (Cache
[I
].InstBroken() == true)
1272 std::clog
<< " Dependencies are not satisfied for " << I
<< std::endl
;
1276 // a newly broken policy (recommends/suggests) is a problem
1277 if (Cache
[I
].NowPolicyBroken() == false &&
1278 Cache
[I
].InstPolicyBroken() == true)
1281 std::clog
<< " Policy breaks with upgrade of " << I
<< std::endl
;
1288 // ProblemResolver::ResolveByKeep - Resolve problems using keep /*{{{*/
1289 // ---------------------------------------------------------------------
1290 /* This is the work horse of the soft upgrade routine. It is very gental
1291 in that it does not install or remove any packages. It is assumed that the
1292 system was non-broken previously. */
1293 bool pkgProblemResolver::ResolveByKeep()
1295 std::string
const solver
= _config
->Find("APT::Solver", "internal");
1296 if (solver
!= "internal") {
1297 OpTextProgress
Prog(*_config
);
1298 return EDSP::ResolveExternal(solver
.c_str(), Cache
, true, false, false, &Prog
);
1300 return ResolveByKeepInternal();
1303 // ProblemResolver::ResolveByKeepInternal - Resolve problems using keep /*{{{*/
1304 // ---------------------------------------------------------------------
1305 /* This is the work horse of the soft upgrade routine. It is very gental
1306 in that it does not install or remove any packages. It is assumed that the
1307 system was non-broken previously. */
1308 bool pkgProblemResolver::ResolveByKeepInternal()
1310 pkgDepCache::ActionGroup
group(Cache
);
1312 unsigned long Size
= Cache
.Head().PackageCount
;
1316 /* We have to order the packages so that the broken fixing pass
1317 operates from highest score to lowest. This prevents problems when
1318 high score packages cause the removal of lower score packages that
1319 would cause the removal of even lower score packages. */
1320 pkgCache::Package
**PList
= new pkgCache::Package
*[Size
];
1321 pkgCache::Package
**PEnd
= PList
;
1322 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
1325 qsort(PList
,PEnd
- PList
,sizeof(*PList
),&ScoreSort
);
1327 if (_config
->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
1329 clog
<< "Show Scores" << endl
;
1330 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
1331 if (Scores
[(*K
)->ID
] != 0)
1333 pkgCache::PkgIterator
Pkg(Cache
,*K
);
1334 clog
<< Scores
[(*K
)->ID
] << ' ' << Pkg
<< std::endl
;
1339 clog
<< "Entering ResolveByKeep" << endl
;
1341 // Consider each broken package
1342 pkgCache::Package
**LastStop
= 0;
1343 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
1345 pkgCache::PkgIterator
I(Cache
,*K
);
1347 if (Cache
[I
].InstallVer
== 0)
1350 if (InstOrNewPolicyBroken(I
) == false)
1353 /* Keep the package. If this works then great, otherwise we have
1354 to be significantly more agressive and manipulate its dependencies */
1355 if ((Flags
[I
->ID
] & Protected
) == 0)
1358 clog
<< "Keeping package " << I
.FullName(false) << endl
;
1359 Cache
.MarkKeep(I
, false, false);
1360 if (InstOrNewPolicyBroken(I
) == false)
1367 // Isolate the problem dependencies
1368 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList(); D
.end() == false;)
1372 D
.GlobOr(Start
,End
);
1374 // We only worry about critical deps.
1375 if (End
.IsCritical() != true)
1379 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
1382 /* Hm, the group is broken.. I suppose the best thing to do is to
1383 is to try every combination of keep/not-keep for the set, but thats
1384 slow, and this never happens, just be conservative and assume the
1385 list of ors is in preference and keep till it starts to work. */
1389 clog
<< "Package " << I
.FullName(false) << " " << Start
<< endl
;
1391 // Look at all the possible provides on this package
1392 SPtrArray
<pkgCache::Version
*> VList
= Start
.AllTargets();
1393 for (pkgCache::Version
**V
= VList
; *V
!= 0; V
++)
1395 pkgCache::VerIterator
Ver(Cache
,*V
);
1396 pkgCache::PkgIterator Pkg
= Ver
.ParentPkg();
1398 // It is not keepable
1399 if (Cache
[Pkg
].InstallVer
== 0 ||
1400 Pkg
->CurrentVer
== 0)
1403 if ((Flags
[I
->ID
] & Protected
) == 0)
1406 clog
<< " Keeping Package " << Pkg
.FullName(false) << " due to " << Start
.DepType() << endl
;
1407 Cache
.MarkKeep(Pkg
, false, false);
1410 if (InstOrNewPolicyBroken(I
) == false)
1414 if (InstOrNewPolicyBroken(I
) == false)
1422 if (InstOrNewPolicyBroken(I
) == false)
1426 if (InstOrNewPolicyBroken(I
) == true)
1430 if (K
== LastStop
) {
1431 // I is an iterator based off our temporary package list,
1432 // so copy the name we need before deleting the temporary list
1433 std::string
const LoopingPackage
= I
.FullName(false);
1435 return _error
->Error("Internal Error, pkgProblemResolver::ResolveByKeep is looping on package %s.", LoopingPackage
.c_str());
1445 // ProblemResolver::InstallProtect - Install all protected packages /*{{{*/
1446 // ---------------------------------------------------------------------
1447 /* This is used to make sure protected packages are installed */
1448 void pkgProblemResolver::InstallProtect()
1450 pkgDepCache::ActionGroup
group(Cache
);
1452 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
1454 if ((Flags
[I
->ID
] & Protected
) == Protected
)
1456 if ((Flags
[I
->ID
] & ToRemove
) == ToRemove
)
1457 Cache
.MarkDelete(I
);
1460 // preserve the information whether the package was auto
1461 // or manually installed
1462 bool autoInst
= (Cache
[I
].Flags
& pkgCache::Flag::Auto
);
1463 Cache
.MarkInstall(I
, false, 0, !autoInst
);
1469 // PrioSortList - Sort a list of versions by priority /*{{{*/
1470 // ---------------------------------------------------------------------
1471 /* This is ment to be used in conjunction with AllTargets to get a list
1472 of versions ordered by preference. */
1473 static pkgCache
*PrioCache
;
1474 static int PrioComp(const void *A
,const void *B
)
1476 pkgCache::VerIterator
L(*PrioCache
,*(pkgCache::Version
**)A
);
1477 pkgCache::VerIterator
R(*PrioCache
,*(pkgCache::Version
**)B
);
1479 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
&&
1480 (R
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) != pkgCache::Flag::Essential
)
1482 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) != pkgCache::Flag::Essential
&&
1483 (R
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
1486 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Important
) == pkgCache::Flag::Important
&&
1487 (R
.ParentPkg()->Flags
& pkgCache::Flag::Important
) != pkgCache::Flag::Important
)
1489 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Important
) != pkgCache::Flag::Important
&&
1490 (R
.ParentPkg()->Flags
& pkgCache::Flag::Important
) == pkgCache::Flag::Important
)
1493 if (L
->Priority
!= R
->Priority
)
1494 return R
->Priority
- L
->Priority
;
1495 return strcmp(L
.ParentPkg().Name(),R
.ParentPkg().Name());
1497 void pkgPrioSortList(pkgCache
&Cache
,pkgCache::Version
**List
)
1499 unsigned long Count
= 0;
1501 for (pkgCache::Version
**I
= List
; *I
!= 0; I
++)
1503 qsort(List
,Count
,sizeof(*List
),PrioComp
);
1506 // ListUpdate - construct Fetcher and update the cache files /*{{{*/
1507 // ---------------------------------------------------------------------
1508 /* This is a simple wrapper to update the cache. it will fetch stuff
1509 * from the network (or any other sources defined in sources.list)
1511 bool ListUpdate(pkgAcquireStatus
&Stat
,
1512 pkgSourceList
&List
,
1516 if (Fetcher
.Setup(&Stat
, _config
->FindDir("Dir::State::Lists")) == false)
1519 // Populate it with the source selection
1520 if (List
.GetIndexes(&Fetcher
) == false)
1523 return AcquireUpdate(Fetcher
, PulseInterval
, true);
1526 // AcquireUpdate - take Fetcher and update the cache files /*{{{*/
1527 // ---------------------------------------------------------------------
1528 /* This is a simple wrapper to update the cache with a provided acquire
1529 * If you only need control over Status and the used SourcesList use
1530 * ListUpdate method instead.
1532 bool AcquireUpdate(pkgAcquire
&Fetcher
, int const PulseInterval
,
1533 bool const RunUpdateScripts
, bool const ListCleanup
)
1536 if (RunUpdateScripts
== true)
1537 RunScripts("APT::Update::Pre-Invoke");
1539 pkgAcquire::RunResult res
;
1540 if(PulseInterval
> 0)
1541 res
= Fetcher
.Run(PulseInterval
);
1543 res
= Fetcher
.Run();
1545 if (res
== pkgAcquire::Failed
)
1548 bool Failed
= false;
1549 bool TransientNetworkFailure
= false;
1550 for (pkgAcquire::ItemIterator I
= Fetcher
.ItemsBegin();
1551 I
!= Fetcher
.ItemsEnd(); ++I
)
1553 if ((*I
)->Status
== pkgAcquire::Item::StatDone
)
1558 ::URI
uri((*I
)->DescURI());
1560 uri
.Password
.clear();
1561 string descUri
= string(uri
);
1562 _error
->Warning(_("Failed to fetch %s %s\n"), descUri
.c_str(),
1563 (*I
)->ErrorText
.c_str());
1565 if ((*I
)->Status
== pkgAcquire::Item::StatTransientNetworkError
)
1567 TransientNetworkFailure
= true;
1574 // Clean out any old list files
1575 // Keep "APT::Get::List-Cleanup" name for compatibility, but
1576 // this is really a global option for the APT library now
1577 if (!TransientNetworkFailure
&& !Failed
&& ListCleanup
== true &&
1578 (_config
->FindB("APT::Get::List-Cleanup",true) == true &&
1579 _config
->FindB("APT::List-Cleanup",true) == true))
1581 if (Fetcher
.Clean(_config
->FindDir("Dir::State::lists")) == false ||
1582 Fetcher
.Clean(_config
->FindDir("Dir::State::lists") + "partial/") == false)
1583 // something went wrong with the clean
1587 if (TransientNetworkFailure
== true)
1588 _error
->Warning(_("Some index files failed to download. They have been ignored, or old ones used instead."));
1589 else if (Failed
== true)
1590 return _error
->Error(_("Some index files failed to download. They have been ignored, or old ones used instead."));
1593 // Run the success scripts if all was fine
1594 if (RunUpdateScripts
== true)
1596 if(!TransientNetworkFailure
&& !Failed
)
1597 RunScripts("APT::Update::Post-Invoke-Success");
1599 // Run the other scripts
1600 RunScripts("APT::Update::Post-Invoke");