]>
git.saurik.com Git - apt.git/blob - apt-pkg/algorithms.cc
1 // -*- mode: cpp; mode: fold -*-
3 // $Id: algorithms.cc,v 1.44 2002/11/28 18:49:16 jgg Exp $
4 /* ######################################################################
6 Algorithms - A set of misc algorithms
8 The pkgProblemResolver class has become insanely complex and
9 very sophisticated, it handles every test case I have thrown at it
10 to my satisfaction. Understanding exactly why all the steps the class
11 does are required is difficult and changing though not very risky
12 may result in other cases not working.
14 ##################################################################### */
16 // Include Files /*{{{*/
18 #pragma implementation "apt-pkg/algorithms.h"
20 #include <apt-pkg/algorithms.h>
21 #include <apt-pkg/error.h>
22 #include <apt-pkg/configuration.h>
23 #include <apt-pkg/sptr.h>
31 pkgProblemResolver
*pkgProblemResolver::This
= 0;
33 // Simulate::Simulate - Constructor /*{{{*/
34 // ---------------------------------------------------------------------
35 /* The legacy translations here of input Pkg iterators is obsolete,
36 this is not necessary since the pkgCaches are fully shared now. */
37 pkgSimulate::pkgSimulate(pkgDepCache
*Cache
) : pkgPackageManager(Cache
),
39 Sim(&Cache
->GetCache(),&iPolicy
)
42 Flags
= new unsigned char[Cache
->Head().PackageCount
];
43 memset(Flags
,0,sizeof(*Flags
)*Cache
->Head().PackageCount
);
45 // Fake a filename so as not to activate the media swapping
46 string Jnk
= "SIMULATE";
47 for (unsigned int I
= 0; I
!= Cache
->Head().PackageCount
; I
++)
51 // Simulate::Describe - Describe a package /*{{{*/
52 // ---------------------------------------------------------------------
53 /* Parameter Current == true displays the current package version,
54 Parameter Candidate == true displays the candidate package version */
55 void pkgSimulate::Describe(PkgIterator Pkg
,ostream
&out
,bool Current
,bool Candidate
)
63 Ver
= Pkg
.CurrentVer();
64 if (Ver
.end() == false)
65 out
<< " [" << Ver
.VerStr() << ']';
68 if (Candidate
== true)
70 Ver
= Sim
[Pkg
].CandidateVerIter(Sim
);
71 if (Ver
.end() == true)
74 out
<< " (" << Ver
.VerStr() << ' ' << Ver
.RelStr() << ')';
78 // Simulate::Install - Simulate unpacking of a package /*{{{*/
79 // ---------------------------------------------------------------------
81 bool pkgSimulate::Install(PkgIterator iPkg
,string
/*File*/)
84 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name());
88 Describe(Pkg
,cout
,true,true);
89 Sim
.MarkInstall(Pkg
,false);
91 // Look for broken conflicts+predepends.
92 for (PkgIterator I
= Sim
.PkgBegin(); I
.end() == false; I
++)
94 if (Sim
[I
].InstallVer
== 0)
97 for (DepIterator D
= Sim
[I
].InstVerIter(Sim
).DependsList(); D
.end() == false;)
102 if (Start
->Type
== pkgCache::Dep::Conflicts
||
103 Start
->Type
== pkgCache::Dep::Obsoletes
||
104 End
->Type
== pkgCache::Dep::PreDepends
)
106 if ((Sim
[End
] & pkgDepCache::DepGInstall
) == 0)
108 cout
<< " [" << I
.Name() << " on " << Start
.TargetPkg().Name() << ']';
109 if (Start
->Type
== pkgCache::Dep::Conflicts
)
110 _error
->Error("Fatal, conflicts violated %s",I
.Name());
116 if (Sim
.BrokenCount() != 0)
123 // Simulate::Configure - Simulate configuration of a Package /*{{{*/
124 // ---------------------------------------------------------------------
125 /* This is not an acurate simulation of relatity, we should really not
126 install the package.. For some investigations it may be necessary
128 bool pkgSimulate::Configure(PkgIterator iPkg
)
130 // Adapt the iterator
131 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name());
134 // Sim.MarkInstall(Pkg,false);
135 if (Sim
[Pkg
].InstBroken() == true)
137 cout
<< "Conf " << Pkg
.Name() << " broken" << endl
;
141 // Print out each package and the failed dependencies
142 for (pkgCache::DepIterator D
= Sim
[Pkg
].InstVerIter(Sim
).DependsList(); D
.end() == false; D
++)
144 if (Sim
.IsImportantDep(D
) == false ||
145 (Sim
[D
] & pkgDepCache::DepInstall
) != 0)
148 if (D
->Type
== pkgCache::Dep::Obsoletes
)
149 cout
<< " Obsoletes:" << D
.TargetPkg().Name();
150 else if (D
->Type
== pkgCache::Dep::Conflicts
)
151 cout
<< " Conflicts:" << D
.TargetPkg().Name();
153 cout
<< " Depends:" << D
.TargetPkg().Name();
157 _error
->Error("Conf Broken %s",Pkg
.Name());
162 Describe(Pkg
,cout
,false,true);
165 if (Sim
.BrokenCount() != 0)
173 // Simulate::Remove - Simulate the removal of a package /*{{{*/
174 // ---------------------------------------------------------------------
176 bool pkgSimulate::Remove(PkgIterator iPkg
,bool Purge
)
178 // Adapt the iterator
179 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name());
187 Describe(Pkg
,cout
,true,false);
189 if (Sim
.BrokenCount() != 0)
197 // Simulate::ShortBreaks - Print out a short line describing all breaks /*{{{*/
198 // ---------------------------------------------------------------------
200 void pkgSimulate::ShortBreaks()
203 for (PkgIterator I
= Sim
.PkgBegin(); I
.end() == false; I
++)
205 if (Sim
[I
].InstBroken() == true)
207 if (Flags
[I
->ID
] == 0)
208 cout
<< I
.Name() << ' ';
210 cout << I.Name() << "! ";*/
216 // ApplyStatus - Adjust for non-ok packages /*{{{*/
217 // ---------------------------------------------------------------------
218 /* We attempt to change the state of the all packages that have failed
219 installation toward their real state. The ordering code will perform
220 the necessary calculations to deal with the problems. */
221 bool pkgApplyStatus(pkgDepCache
&Cache
)
223 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
225 if (I
->VersionList
== 0)
228 // Only choice for a ReInstReq package is to reinstall
229 if (I
->InstState
== pkgCache::State::ReInstReq
||
230 I
->InstState
== pkgCache::State::HoldReInstReq
)
232 if (I
->CurrentVer
!= 0 && I
.CurrentVer().Downloadable() == true)
236 // Is this right? Will dpkg choke on an upgrade?
237 if (Cache
[I
].CandidateVer
!= 0 &&
238 Cache
[I
].CandidateVerIter(Cache
).Downloadable() == true)
239 Cache
.MarkInstall(I
);
241 return _error
->Error(_("The package %s needs to be reinstalled, "
242 "but I can't find an archive for it."),I
.Name());
248 switch (I
->CurrentState
)
250 /* This means installation failed somehow - it does not need to be
251 re-unpacked (probably) */
252 case pkgCache::State::UnPacked
:
253 case pkgCache::State::HalfConfigured
:
254 if ((I
->CurrentVer
!= 0 && I
.CurrentVer().Downloadable() == true) ||
255 I
.State() != pkgCache::PkgIterator::NeedsUnpack
)
259 if (Cache
[I
].CandidateVer
!= 0 &&
260 Cache
[I
].CandidateVerIter(Cache
).Downloadable() == true)
261 Cache
.MarkInstall(I
);
267 // This means removal failed
268 case pkgCache::State::HalfInstalled
:
273 if (I
->InstState
!= pkgCache::State::Ok
)
274 return _error
->Error("The package %s is not ok and I "
275 "don't know how to fix it!",I
.Name());
281 // FixBroken - Fix broken packages /*{{{*/
282 // ---------------------------------------------------------------------
283 /* This autoinstalls every broken package and then runs the problem resolver
285 bool pkgFixBroken(pkgDepCache
&Cache
)
287 // Auto upgrade all broken packages
288 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
289 if (Cache
[I
].NowBroken() == true)
290 Cache
.MarkInstall(I
,true);
292 /* Fix packages that are in a NeedArchive state but don't have a
293 downloadable install version */
294 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
296 if (I
.State() != pkgCache::PkgIterator::NeedsUnpack
||
297 Cache
[I
].Delete() == true)
300 if (Cache
[I
].InstVerIter(Cache
).Downloadable() == false)
303 Cache
.MarkInstall(I
,true);
306 pkgProblemResolver
Fix(&Cache
);
307 return Fix
.Resolve(true);
310 // DistUpgrade - Distribution upgrade /*{{{*/
311 // ---------------------------------------------------------------------
312 /* This autoinstalls every package and then force installs every
313 pre-existing package. This creates the initial set of conditions which
314 most likely contain problems because too many things were installed.
316 The problem resolver is used to resolve the problems.
318 bool pkgDistUpgrade(pkgDepCache
&Cache
)
320 /* Auto upgrade all installed packages, this provides the basis
321 for the installation */
322 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
323 if (I
->CurrentVer
!= 0)
324 Cache
.MarkInstall(I
,true);
326 /* Now, auto upgrade all essential packages - this ensures that
327 the essential packages are present and working */
328 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
329 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
330 Cache
.MarkInstall(I
,true);
332 /* We do it again over all previously installed packages to force
333 conflict resolution on them all. */
334 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
335 if (I
->CurrentVer
!= 0)
336 Cache
.MarkInstall(I
,false);
338 pkgProblemResolver
Fix(&Cache
);
340 // Hold back held packages.
341 if (_config
->FindB("APT::Ignore-Hold",false) == false)
343 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
345 if (I
->SelectedState
== pkgCache::State::Hold
)
353 return Fix
.Resolve();
356 // AllUpgrade - Upgrade as many packages as possible /*{{{*/
357 // ---------------------------------------------------------------------
358 /* Right now the system must be consistent before this can be called.
359 It also will not change packages marked for install, it only tries
360 to install packages not marked for install */
361 bool pkgAllUpgrade(pkgDepCache
&Cache
)
363 pkgProblemResolver
Fix(&Cache
);
365 if (Cache
.BrokenCount() != 0)
368 // Upgrade all installed packages
369 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
371 if (Cache
[I
].Install() == true)
374 if (_config
->FindB("APT::Ignore-Hold",false) == false)
375 if (I
->SelectedState
== pkgCache::State::Hold
)
378 if (I
->CurrentVer
!= 0 && Cache
[I
].InstallVer
!= 0)
379 Cache
.MarkInstall(I
,false);
382 return Fix
.ResolveByKeep();
385 // MinimizeUpgrade - Minimizes the set of packages to be upgraded /*{{{*/
386 // ---------------------------------------------------------------------
387 /* This simply goes over the entire set of packages and tries to keep
388 each package marked for upgrade. If a conflict is generated then
389 the package is restored. */
390 bool pkgMinimizeUpgrade(pkgDepCache
&Cache
)
392 if (Cache
.BrokenCount() != 0)
395 // We loop for 10 tries to get the minimal set size.
397 unsigned int Count
= 0;
401 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
404 if (Cache
[I
].Upgrade() == false || Cache
[I
].NewInstall() == true)
407 // Keep it and see if that is OK
409 if (Cache
.BrokenCount() != 0)
410 Cache
.MarkInstall(I
,false);
413 // If keep didnt actually do anything then there was no change..
414 if (Cache
[I
].Upgrade() == false)
420 while (Change
== true && Count
< 10);
422 if (Cache
.BrokenCount() != 0)
423 return _error
->Error("Internal Error in pkgMinimizeUpgrade");
429 // ProblemResolver::pkgProblemResolver - Constructor /*{{{*/
430 // ---------------------------------------------------------------------
432 pkgProblemResolver::pkgProblemResolver(pkgDepCache
*pCache
) : Cache(*pCache
)
435 unsigned long Size
= Cache
.Head().PackageCount
;
436 Scores
= new signed short[Size
];
437 Flags
= new unsigned char[Size
];
438 memset(Flags
,0,sizeof(*Flags
)*Size
);
440 // Set debug to true to see its decision logic
441 Debug
= _config
->FindB("Debug::pkgProblemResolver",false);
444 // ProblemResolver::~pkgProblemResolver - Destructor /*{{{*/
445 // ---------------------------------------------------------------------
447 pkgProblemResolver::~pkgProblemResolver()
453 // ProblemResolver::ScoreSort - Sort the list by score /*{{{*/
454 // ---------------------------------------------------------------------
456 int pkgProblemResolver::ScoreSort(const void *a
,const void *b
)
458 Package
const **A
= (Package
const **)a
;
459 Package
const **B
= (Package
const **)b
;
460 if (This
->Scores
[(*A
)->ID
] > This
->Scores
[(*B
)->ID
])
462 if (This
->Scores
[(*A
)->ID
] < This
->Scores
[(*B
)->ID
])
467 // ProblemResolver::MakeScores - Make the score table /*{{{*/
468 // ---------------------------------------------------------------------
470 void pkgProblemResolver::MakeScores()
472 unsigned long Size
= Cache
.Head().PackageCount
;
473 memset(Scores
,0,sizeof(*Scores
)*Size
);
475 // Generate the base scores for a package based on its properties
476 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
478 if (Cache
[I
].InstallVer
== 0)
481 signed short &Score
= Scores
[I
->ID
];
483 /* This is arbitary, it should be high enough to elevate an
484 essantial package above most other packages but low enough
485 to allow an obsolete essential packages to be removed by
486 a conflicts on a powerfull normal package (ie libc6) */
487 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
490 // We transform the priority
491 // Important Required Standard Optional Extra
492 signed short PrioMap
[] = {0,3,2,1,-1,-2};
493 if (Cache
[I
].InstVerIter(Cache
)->Priority
<= 5)
494 Score
+= PrioMap
[Cache
[I
].InstVerIter(Cache
)->Priority
];
496 /* This helps to fix oddball problems with conflicting packages
497 on the same level. We enhance the score of installed packages
498 if those are not obsolete
500 if (I
->CurrentVer
!= 0 && Cache
[I
].CandidateVer
!= 0 && Cache
[I
].CandidateVerIter(Cache
).Downloadable())
504 // Now that we have the base scores we go and propogate dependencies
505 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
507 if (Cache
[I
].InstallVer
== 0)
510 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList(); D
.end() == false; D
++)
512 if (D
->Type
== pkgCache::Dep::Depends
|| D
->Type
== pkgCache::Dep::PreDepends
)
513 Scores
[D
.TargetPkg()->ID
]++;
517 // Copy the scores to advoid additive looping
518 SPtrArray
<signed short> OldScores
= new signed short[Size
];
519 memcpy(OldScores
,Scores
,sizeof(*Scores
)*Size
);
521 /* Now we cause 1 level of dependency inheritance, that is we add the
522 score of the packages that depend on the target Package. This
523 fortifies high scoring packages */
524 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
526 if (Cache
[I
].InstallVer
== 0)
529 for (pkgCache::DepIterator D
= I
.RevDependsList(); D
.end() == false; D
++)
531 // Only do it for the install version
532 if ((pkgCache::Version
*)D
.ParentVer() != Cache
[D
.ParentPkg()].InstallVer
||
533 (D
->Type
!= pkgCache::Dep::Depends
&& D
->Type
!= pkgCache::Dep::PreDepends
))
536 Scores
[I
->ID
] += abs(OldScores
[D
.ParentPkg()->ID
]);
540 /* Now we propogate along provides. This makes the packages that
541 provide important packages extremely important */
542 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
544 for (pkgCache::PrvIterator P
= I
.ProvidesList(); P
.end() == false; P
++)
546 // Only do it once per package
547 if ((pkgCache::Version
*)P
.OwnerVer() != Cache
[P
.OwnerPkg()].InstallVer
)
549 Scores
[P
.OwnerPkg()->ID
] += abs(Scores
[I
->ID
] - OldScores
[I
->ID
]);
553 /* Protected things are pushed really high up. This number should put them
554 ahead of everything */
555 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
557 if ((Flags
[I
->ID
] & Protected
) != 0)
558 Scores
[I
->ID
] += 10000;
559 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
560 Scores
[I
->ID
] += 5000;
564 // ProblemResolver::DoUpgrade - Attempt to upgrade this package /*{{{*/
565 // ---------------------------------------------------------------------
566 /* This goes through and tries to reinstall packages to make this package
568 bool pkgProblemResolver::DoUpgrade(pkgCache::PkgIterator Pkg
)
570 if ((Flags
[Pkg
->ID
] & Upgradable
) == 0 || Cache
[Pkg
].Upgradable() == false)
572 if ((Flags
[Pkg
->ID
] & Protected
) == Protected
)
575 Flags
[Pkg
->ID
] &= ~Upgradable
;
577 bool WasKept
= Cache
[Pkg
].Keep();
578 Cache
.MarkInstall(Pkg
,false);
580 // This must be a virtual package or something like that.
581 if (Cache
[Pkg
].InstVerIter(Cache
).end() == true)
584 // Isolate the problem dependency
586 for (pkgCache::DepIterator D
= Cache
[Pkg
].InstVerIter(Cache
).DependsList(); D
.end() == false;)
588 // Compute a single dependency element (glob or)
589 pkgCache::DepIterator Start
= D
;
590 pkgCache::DepIterator End
= D
;
591 unsigned char State
= 0;
592 for (bool LastOR
= true; D
.end() == false && LastOR
== true;)
595 LastOR
= (D
->CompareOp
& pkgCache::Dep::Or
) == pkgCache::Dep::Or
;
601 // We only worry about critical deps.
602 if (End
.IsCritical() != true)
605 // Iterate over all the members in the or group
609 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
612 // Do not change protected packages
613 PkgIterator P
= Start
.SmartTargetPkg();
614 if ((Flags
[P
->ID
] & Protected
) == Protected
)
617 clog
<< " Reinst Failed because of protected " << P
.Name() << endl
;
622 // Upgrade the package if the candidate version will fix the problem.
623 if ((Cache
[Start
] & pkgDepCache::DepCVer
) == pkgDepCache::DepCVer
)
625 if (DoUpgrade(P
) == false)
628 clog
<< " Reinst Failed because of " << P
.Name() << endl
;
639 /* We let the algorithm deal with conflicts on its next iteration,
640 it is much smarter than us */
641 if (Start
->Type
== pkgCache::Dep::Conflicts
||
642 Start
->Type
== pkgCache::Dep::Obsoletes
)
646 clog
<< " Reinst Failed early because of " << Start
.TargetPkg().Name() << endl
;
659 // Undo our operations - it might be smart to undo everything this did..
665 Cache
.MarkDelete(Pkg
);
670 clog
<< " Re-Instated " << Pkg
.Name() << endl
;
674 // ProblemResolver::Resolve - Run the resolution pass /*{{{*/
675 // ---------------------------------------------------------------------
676 /* This routines works by calculating a score for each package. The score
677 is derived by considering the package's priority and all reverse
678 dependents giving an integer that reflects the amount of breakage that
679 adjusting the package will inflict.
681 It goes from highest score to lowest and corrects all of the breaks by
682 keeping or removing the dependant packages. If that fails then it removes
683 the package itself and goes on. The routine should be able to intelligently
684 go from any broken state to a fixed state.
686 The BrokenFix flag enables a mode where the algorithm tries to
687 upgrade packages to advoid problems. */
688 bool pkgProblemResolver::Resolve(bool BrokenFix
)
690 unsigned long Size
= Cache
.Head().PackageCount
;
692 // Record which packages are marked for install
697 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
699 if (Cache
[I
].Install() == true)
700 Flags
[I
->ID
] |= PreInstalled
;
703 if (Cache
[I
].InstBroken() == true && BrokenFix
== true)
705 Cache
.MarkInstall(I
,false);
706 if (Cache
[I
].Install() == true)
710 Flags
[I
->ID
] &= ~PreInstalled
;
712 Flags
[I
->ID
] |= Upgradable
;
715 while (Again
== true);
718 clog
<< "Starting" << endl
;
722 /* We have to order the packages so that the broken fixing pass
723 operates from highest score to lowest. This prevents problems when
724 high score packages cause the removal of lower score packages that
725 would cause the removal of even lower score packages. */
726 SPtrArray
<pkgCache::Package
*> PList
= new pkgCache::Package
*[Size
];
727 pkgCache::Package
**PEnd
= PList
;
728 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
731 qsort(PList
,PEnd
- PList
,sizeof(*PList
),&ScoreSort
);
733 /* for (pkgCache::Package **K = PList; K != PEnd; K++)
734 if (Scores[(*K)->ID] != 0)
736 pkgCache::PkgIterator Pkg(Cache,*K);
737 clog << Scores[(*K)->ID] << ' ' << Pkg.Name() <<
738 ' ' << (pkgCache::Version *)Pkg.CurrentVer() << ' ' <<
739 Cache[Pkg].InstallVer << ' ' << Cache[Pkg].CandidateVer << endl;
743 clog
<< "Starting 2" << endl
;
745 /* Now consider all broken packages. For each broken package we either
746 remove the package or fix it's problem. We do this once, it should
747 not be possible for a loop to form (that is a < b < c and fixing b by
748 changing a breaks c) */
750 for (int Counter
= 0; Counter
!= 10 && Change
== true; Counter
++)
753 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
755 pkgCache::PkgIterator
I(Cache
,*K
);
757 /* We attempt to install this and see if any breaks result,
758 this takes care of some strange cases */
759 if (Cache
[I
].CandidateVer
!= Cache
[I
].InstallVer
&&
760 I
->CurrentVer
!= 0 && Cache
[I
].InstallVer
!= 0 &&
761 (Flags
[I
->ID
] & PreInstalled
) != 0 &&
762 (Flags
[I
->ID
] & Protected
) == 0 &&
763 (Flags
[I
->ID
] & ReInstateTried
) == 0)
766 clog
<< " Try to Re-Instate " << I
.Name() << endl
;
767 unsigned long OldBreaks
= Cache
.BrokenCount();
768 pkgCache::Version
*OldVer
= Cache
[I
].InstallVer
;
769 Flags
[I
->ID
] &= ReInstateTried
;
771 Cache
.MarkInstall(I
,false);
772 if (Cache
[I
].InstBroken() == true ||
773 OldBreaks
< Cache
.BrokenCount())
782 clog
<< "Re-Instated " << I
.Name() << " (" << OldBreaks
<< " vs " << Cache
.BrokenCount() << ')' << endl
;
785 if (Cache
[I
].InstallVer
== 0 || Cache
[I
].InstBroken() == false)
789 clog
<< "Investigating " << I
.Name() << endl
;
791 // Isolate the problem dependency
792 PackageKill KillList
[100];
793 PackageKill
*LEnd
= KillList
;
795 pkgCache::DepIterator Start
;
796 pkgCache::DepIterator End
;
797 PackageKill
*OldEnd
= LEnd
;
799 enum {OrRemove
,OrKeep
} OrOp
= OrRemove
;
800 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList();
801 D
.end() == false || InOr
== true;)
803 // Compute a single dependency element (glob or)
809 if (OldEnd
== LEnd
&& OrOp
== OrRemove
)
811 if ((Flags
[I
->ID
] & Protected
) != Protected
)
814 clog
<< " Or group remove for " << I
.Name() << endl
;
819 if (OldEnd
== LEnd
&& OrOp
== OrKeep
)
822 clog
<< " Or group keep for " << I
.Name() << endl
;
828 /* We do an extra loop (as above) to finalize the or group
833 if (Start
.end() == true)
836 // We only worry about critical deps.
837 if (End
.IsCritical() != true)
846 // We only worry about critical deps.
847 if (Start
.IsCritical() != true)
852 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
859 clog
<< "Package " << I
.Name() << " has broken dep on " << Start
.TargetPkg().Name() << endl
;
861 /* Look across the version list. If there are no possible
862 targets then we keep the package and bail. This is necessary
863 if a package has a dep on another package that cant be found */
864 SPtrArray
<pkgCache::Version
*> VList
= Start
.AllTargets();
865 if (*VList
== 0 && (Flags
[I
->ID
] & Protected
) != Protected
&&
866 Start
->Type
!= pkgCache::Dep::Conflicts
&&
867 Start
->Type
!= pkgCache::Dep::Obsoletes
&&
868 Cache
[I
].NowBroken() == false)
872 /* No keep choice because the keep being OK could be the
873 result of another element in the OR group! */
883 for (pkgCache::Version
**V
= VList
; *V
!= 0; V
++)
885 pkgCache::VerIterator
Ver(Cache
,*V
);
886 pkgCache::PkgIterator Pkg
= Ver
.ParentPkg();
889 clog
<< " Considering " << Pkg
.Name() << ' ' << (int)Scores
[Pkg
->ID
] <<
890 " as a solution to " << I
.Name() << ' ' << (int)Scores
[I
->ID
] << endl
;
892 /* Try to fix the package under consideration rather than
893 fiddle with the VList package */
894 if (Scores
[I
->ID
] <= Scores
[Pkg
->ID
] ||
895 ((Cache
[Start
] & pkgDepCache::DepNow
) == 0 &&
896 End
->Type
!= pkgCache::Dep::Conflicts
&&
897 End
->Type
!= pkgCache::Dep::Obsoletes
))
899 // Try a little harder to fix protected packages..
900 if ((Flags
[I
->ID
] & Protected
) == Protected
)
902 if (DoUpgrade(Pkg
) == true)
904 if (Scores
[Pkg
->ID
] > Scores
[I
->ID
])
905 Scores
[Pkg
->ID
] = Scores
[I
->ID
];
912 /* See if a keep will do, unless the package is protected,
913 then installing it will be necessary */
914 bool Installed
= Cache
[I
].Install();
916 if (Cache
[I
].InstBroken() == false)
918 // Unwind operation will be keep now
919 if (OrOp
== OrRemove
)
923 if (InOr
== true && Installed
== true)
924 Cache
.MarkInstall(I
,false);
927 clog
<< " Holding Back " << I
.Name() << " rather than change " << Start
.TargetPkg().Name() << endl
;
931 if (BrokenFix
== false || DoUpgrade(I
) == false)
933 // Consider other options
937 clog
<< " Removing " << I
.Name() << " rather than change " << Start
.TargetPkg().Name() << endl
;
941 if (Scores
[Pkg
->ID
] > Scores
[I
->ID
])
942 Scores
[I
->ID
] = Scores
[Pkg
->ID
];
954 /* This is a conflicts, and the version we are looking
955 at is not the currently selected version of the
956 package, which means it is not necessary to
958 if (Cache
[Pkg
].InstallVer
!= Ver
&&
959 (Start
->Type
== pkgCache::Dep::Conflicts
||
960 Start
->Type
== pkgCache::Dep::Obsoletes
))
963 // Skip adding to the kill list if it is protected
964 if ((Flags
[Pkg
->ID
] & Protected
) != 0)
968 clog
<< " Added " << Pkg
.Name() << " to the remove list" << endl
;
974 if (Start
->Type
!= pkgCache::Dep::Conflicts
&&
975 Start
->Type
!= pkgCache::Dep::Obsoletes
)
980 // Hm, nothing can possibly satisify this dep. Nuke it.
982 Start
->Type
!= pkgCache::Dep::Conflicts
&&
983 Start
->Type
!= pkgCache::Dep::Obsoletes
&&
984 (Flags
[I
->ID
] & Protected
) != Protected
)
986 bool Installed
= Cache
[I
].Install();
988 if (Cache
[I
].InstBroken() == false)
990 // Unwind operation will be keep now
991 if (OrOp
== OrRemove
)
995 if (InOr
== true && Installed
== true)
996 Cache
.MarkInstall(I
,false);
999 clog
<< " Holding Back " << I
.Name() << " because I can't find " << Start
.TargetPkg().Name() << endl
;
1004 clog
<< " Removing " << I
.Name() << " because I can't find " << Start
.TargetPkg().Name() << endl
;
1006 Cache
.MarkDelete(I
);
1021 // Apply the kill list now
1022 if (Cache
[I
].InstallVer
!= 0)
1024 for (PackageKill
*J
= KillList
; J
!= LEnd
; J
++)
1027 if ((Cache
[J
->Dep
] & pkgDepCache::DepGNow
) == 0)
1029 if (J
->Dep
->Type
== pkgCache::Dep::Conflicts
||
1030 J
->Dep
->Type
== pkgCache::Dep::Obsoletes
)
1033 clog
<< " Fixing " << I
.Name() << " via remove of " << J
->Pkg
.Name() << endl
;
1034 Cache
.MarkDelete(J
->Pkg
);
1040 clog
<< " Fixing " << I
.Name() << " via keep of " << J
->Pkg
.Name() << endl
;
1041 Cache
.MarkKeep(J
->Pkg
);
1046 if (Scores
[I
->ID
] > Scores
[J
->Pkg
->ID
])
1047 Scores
[J
->Pkg
->ID
] = Scores
[I
->ID
];
1055 clog
<< "Done" << endl
;
1057 if (Cache
.BrokenCount() != 0)
1059 // See if this is the result of a hold
1060 pkgCache::PkgIterator I
= Cache
.PkgBegin();
1061 for (;I
.end() != true; I
++)
1063 if (Cache
[I
].InstBroken() == false)
1065 if ((Flags
[I
->ID
] & Protected
) != Protected
)
1066 return _error
->Error(_("Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages."));
1068 return _error
->Error(_("Unable to correct problems, you have held broken packages."));
1074 // ProblemResolver::ResolveByKeep - Resolve problems using keep /*{{{*/
1075 // ---------------------------------------------------------------------
1076 /* This is the work horse of the soft upgrade routine. It is very gental
1077 in that it does not install or remove any packages. It is assumed that the
1078 system was non-broken previously. */
1079 bool pkgProblemResolver::ResolveByKeep()
1081 unsigned long Size
= Cache
.Head().PackageCount
;
1084 clog
<< "Entering ResolveByKeep" << endl
;
1088 /* We have to order the packages so that the broken fixing pass
1089 operates from highest score to lowest. This prevents problems when
1090 high score packages cause the removal of lower score packages that
1091 would cause the removal of even lower score packages. */
1092 pkgCache::Package
**PList
= new pkgCache::Package
*[Size
];
1093 pkgCache::Package
**PEnd
= PList
;
1094 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
1097 qsort(PList
,PEnd
- PList
,sizeof(*PList
),&ScoreSort
);
1099 // Consider each broken package
1100 pkgCache::Package
**LastStop
= 0;
1101 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
1103 pkgCache::PkgIterator
I(Cache
,*K
);
1105 if (Cache
[I
].InstallVer
== 0 || Cache
[I
].InstBroken() == false)
1108 /* Keep the package. If this works then great, otherwise we have
1109 to be significantly more agressive and manipulate its dependencies */
1110 if ((Flags
[I
->ID
] & Protected
) == 0)
1113 clog
<< "Keeping package " << I
.Name() << endl
;
1115 if (Cache
[I
].InstBroken() == false)
1122 // Isolate the problem dependencies
1123 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList(); D
.end() == false;)
1127 D
.GlobOr(Start
,End
);
1129 // We only worry about critical deps.
1130 if (End
.IsCritical() != true)
1134 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
1137 /* Hm, the group is broken.. I suppose the best thing to do is to
1138 is to try every combination of keep/not-keep for the set, but thats
1139 slow, and this never happens, just be conservative and assume the
1140 list of ors is in preference and keep till it starts to work. */
1144 clog
<< "Package " << I
.Name() << " has broken dep on " << Start
.TargetPkg().Name() << endl
;
1146 // Look at all the possible provides on this package
1147 SPtrArray
<pkgCache::Version
*> VList
= Start
.AllTargets();
1148 for (pkgCache::Version
**V
= VList
; *V
!= 0; V
++)
1150 pkgCache::VerIterator
Ver(Cache
,*V
);
1151 pkgCache::PkgIterator Pkg
= Ver
.ParentPkg();
1153 // It is not keepable
1154 if (Cache
[Pkg
].InstallVer
== 0 ||
1155 Pkg
->CurrentVer
== 0)
1158 if ((Flags
[I
->ID
] & Protected
) == 0)
1161 clog
<< " Keeping Package " << Pkg
.Name() << " due to dep" << endl
;
1162 Cache
.MarkKeep(Pkg
);
1165 if (Cache
[I
].InstBroken() == false)
1169 if (Cache
[I
].InstBroken() == false)
1177 if (Cache
[I
].InstBroken() == false)
1181 if (Cache
[I
].InstBroken() == true)
1186 return _error
->Error("Internal Error, pkgProblemResolver::ResolveByKeep is looping on package %s.",I
.Name());
1194 // ProblemResolver::InstallProtect - Install all protected packages /*{{{*/
1195 // ---------------------------------------------------------------------
1196 /* This is used to make sure protected packages are installed */
1197 void pkgProblemResolver::InstallProtect()
1199 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
1201 if ((Flags
[I
->ID
] & Protected
) == Protected
)
1203 if ((Flags
[I
->ID
] & ToRemove
) == ToRemove
)
1204 Cache
.MarkDelete(I
);
1206 Cache
.MarkInstall(I
,false);
1212 // PrioSortList - Sort a list of versions by priority /*{{{*/
1213 // ---------------------------------------------------------------------
1214 /* This is ment to be used in conjunction with AllTargets to get a list
1215 of versions ordered by preference. */
1216 static pkgCache
*PrioCache
;
1217 static int PrioComp(const void *A
,const void *B
)
1219 pkgCache::VerIterator
L(*PrioCache
,*(pkgCache::Version
**)A
);
1220 pkgCache::VerIterator
R(*PrioCache
,*(pkgCache::Version
**)B
);
1222 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
&&
1223 (R
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) != pkgCache::Flag::Essential
)
1225 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) != pkgCache::Flag::Essential
&&
1226 (R
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
1229 if (L
->Priority
!= R
->Priority
)
1230 return R
->Priority
- L
->Priority
;
1231 return strcmp(L
.ParentPkg().Name(),R
.ParentPkg().Name());
1233 void pkgPrioSortList(pkgCache
&Cache
,pkgCache::Version
**List
)
1235 unsigned long Count
= 0;
1237 for (pkgCache::Version
**I
= List
; *I
!= 0; I
++)
1239 qsort(List
,Count
,sizeof(*List
),PrioComp
);