1 // -*- mode: cpp; mode: fold -*-
3 // $Id: algorithms.cc,v 1.44 2002/11/28 18:49:16 jgg Exp $
4 /* ######################################################################
6 Algorithms - A set of misc algorithms
8 The pkgProblemResolver class has become insanely complex and
9 very sophisticated, it handles every test case I have thrown at it
10 to my satisfaction. Understanding exactly why all the steps the class
11 does are required is difficult and changing though not very risky
12 may result in other cases not working.
14 ##################################################################### */
16 // Include Files /*{{{*/
17 #include <apt-pkg/algorithms.h>
18 #include <apt-pkg/error.h>
19 #include <apt-pkg/configuration.h>
20 #include <apt-pkg/version.h>
21 #include <apt-pkg/sptr.h>
22 #include <apt-pkg/acquire-item.h>
25 #include <sys/types.h>
32 pkgProblemResolver
*pkgProblemResolver::This
= 0;
34 // Simulate::Simulate - Constructor /*{{{*/
35 // ---------------------------------------------------------------------
36 /* The legacy translations here of input Pkg iterators is obsolete,
37 this is not necessary since the pkgCaches are fully shared now. */
38 pkgSimulate::pkgSimulate(pkgDepCache
*Cache
) : pkgPackageManager(Cache
),
40 Sim(&Cache
->GetCache(),&iPolicy
),
44 Flags
= new unsigned char[Cache
->Head().PackageCount
];
45 memset(Flags
,0,sizeof(*Flags
)*Cache
->Head().PackageCount
);
47 // Fake a filename so as not to activate the media swapping
48 string Jnk
= "SIMULATE";
49 for (unsigned int I
= 0; I
!= Cache
->Head().PackageCount
; I
++)
53 // Simulate::Describe - Describe a package /*{{{*/
54 // ---------------------------------------------------------------------
55 /* Parameter Current == true displays the current package version,
56 Parameter Candidate == true displays the candidate package version */
57 void pkgSimulate::Describe(PkgIterator Pkg
,ostream
&out
,bool Current
,bool Candidate
)
61 out
<< Pkg
.FullName(true);
65 Ver
= Pkg
.CurrentVer();
66 if (Ver
.end() == false)
67 out
<< " [" << Ver
.VerStr() << ']';
70 if (Candidate
== true)
72 Ver
= Sim
[Pkg
].CandidateVerIter(Sim
);
73 if (Ver
.end() == true)
76 out
<< " (" << Ver
.VerStr() << ' ' << Ver
.RelStr() << ')';
80 // Simulate::Install - Simulate unpacking of a package /*{{{*/
81 // ---------------------------------------------------------------------
83 bool pkgSimulate::Install(PkgIterator iPkg
,string
/*File*/)
86 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name(), iPkg
.Arch());
90 Describe(Pkg
,cout
,true,true);
91 Sim
.MarkInstall(Pkg
,false);
93 if (strcmp(Pkg
.Arch(),"all") == 0)
95 pkgCache::GrpIterator G
= Pkg
.Group();
96 pkgCache::GrpIterator iG
= iPkg
.Group();
97 for (pkgCache::PkgIterator P
= G
.FindPkg("any"); P
.end() != true; P
= G
.NextPkg(P
))
99 if (strcmp(P
.Arch(), "all") == 0)
101 if (iG
.FindPkg(P
.Arch())->CurrentVer
== 0)
104 Sim
.MarkInstall(P
, false);
108 // Look for broken conflicts+predepends.
109 for (PkgIterator I
= Sim
.PkgBegin(); I
.end() == false; I
++)
111 if (Sim
[I
].InstallVer
== 0)
114 for (DepIterator D
= Sim
[I
].InstVerIter(Sim
).DependsList(); D
.end() == false;)
119 if (Start
->Type
== pkgCache::Dep::Conflicts
||
120 Start
->Type
== pkgCache::Dep::DpkgBreaks
||
121 Start
->Type
== pkgCache::Dep::Obsoletes
||
122 End
->Type
== pkgCache::Dep::PreDepends
)
124 if ((Sim
[End
] & pkgDepCache::DepGInstall
) == 0)
126 cout
<< " [" << I
.FullName(false) << " on " << Start
.TargetPkg().FullName(false) << ']';
127 if (Start
->Type
== pkgCache::Dep::Conflicts
)
128 _error
->Error("Fatal, conflicts violated %s",I
.FullName(false).c_str());
134 if (Sim
.BrokenCount() != 0)
141 // Simulate::Configure - Simulate configuration of a Package /*{{{*/
142 // ---------------------------------------------------------------------
143 /* This is not an acurate simulation of relatity, we should really not
144 install the package.. For some investigations it may be necessary
146 bool pkgSimulate::Configure(PkgIterator iPkg
)
148 // Adapt the iterator
149 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name(), iPkg
.Arch());
153 if (strcmp(Pkg
.Arch(),"all") == 0)
155 pkgCache::GrpIterator G
= Pkg
.Group();
156 for (pkgCache::PkgIterator P
= G
.FindPkg("any"); P
.end() != true; P
= G
.NextPkg(P
))
158 if (strcmp(P
.Arch(), "all") == 0)
160 if (Flags
[P
->ID
] == 1)
165 // Sim.MarkInstall(Pkg,false);
166 if (Sim
[Pkg
].InstBroken() == true)
168 cout
<< "Conf " << Pkg
.FullName(false) << " broken" << endl
;
172 // Print out each package and the failed dependencies
173 for (pkgCache::DepIterator D
= Sim
[Pkg
].InstVerIter(Sim
).DependsList(); D
.end() == false; D
++)
175 if (Sim
.IsImportantDep(D
) == false ||
176 (Sim
[D
] & pkgDepCache::DepInstall
) != 0)
179 if (D
->Type
== pkgCache::Dep::Obsoletes
)
180 cout
<< " Obsoletes:" << D
.TargetPkg().FullName(false);
181 else if (D
->Type
== pkgCache::Dep::Conflicts
)
182 cout
<< " Conflicts:" << D
.TargetPkg().FullName(false);
183 else if (D
->Type
== pkgCache::Dep::DpkgBreaks
)
184 cout
<< " Breaks:" << D
.TargetPkg().FullName(false);
186 cout
<< " Depends:" << D
.TargetPkg().FullName(false);
190 _error
->Error("Conf Broken %s",Pkg
.FullName(false).c_str());
195 Describe(Pkg
,cout
,false,true);
198 if (Sim
.BrokenCount() != 0)
206 // Simulate::Remove - Simulate the removal of a package /*{{{*/
207 // ---------------------------------------------------------------------
209 bool pkgSimulate::Remove(PkgIterator iPkg
,bool Purge
)
211 // Adapt the iterator
212 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name(), iPkg
.Arch());
217 if (strcmp(Pkg
.Arch(),"all") == 0)
219 pkgCache::GrpIterator G
= Pkg
.Group();
220 pkgCache::GrpIterator iG
= iPkg
.Group();
221 for (pkgCache::PkgIterator P
= G
.FindPkg("any"); P
.end() != true; P
= G
.NextPkg(P
))
223 if (strcmp(P
.Arch(), "all") == 0)
225 if (iG
.FindPkg(P
.Arch())->CurrentVer
== 0)
236 Describe(Pkg
,cout
,true,false);
238 if (Sim
.BrokenCount() != 0)
246 // Simulate::ShortBreaks - Print out a short line describing all breaks /*{{{*/
247 // ---------------------------------------------------------------------
249 void pkgSimulate::ShortBreaks()
252 for (PkgIterator I
= Sim
.PkgBegin(); I
.end() == false; I
++)
254 if (Sim
[I
].InstBroken() == true)
256 if (Flags
[I
->ID
] == 0)
257 cout
<< I
.FullName(false) << ' ';
259 cout << I.Name() << "! ";*/
265 // ApplyStatus - Adjust for non-ok packages /*{{{*/
266 // ---------------------------------------------------------------------
267 /* We attempt to change the state of the all packages that have failed
268 installation toward their real state. The ordering code will perform
269 the necessary calculations to deal with the problems. */
270 bool pkgApplyStatus(pkgDepCache
&Cache
)
272 pkgDepCache::ActionGroup
group(Cache
);
274 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
276 if (I
->VersionList
== 0)
279 // Only choice for a ReInstReq package is to reinstall
280 if (I
->InstState
== pkgCache::State::ReInstReq
||
281 I
->InstState
== pkgCache::State::HoldReInstReq
)
283 if (I
->CurrentVer
!= 0 && I
.CurrentVer().Downloadable() == true)
284 Cache
.MarkKeep(I
, false, false);
287 // Is this right? Will dpkg choke on an upgrade?
288 if (Cache
[I
].CandidateVer
!= 0 &&
289 Cache
[I
].CandidateVerIter(Cache
).Downloadable() == true)
290 Cache
.MarkInstall(I
, false, 0, false);
292 return _error
->Error(_("The package %s needs to be reinstalled, "
293 "but I can't find an archive for it."),I
.FullName(true).c_str());
299 switch (I
->CurrentState
)
301 /* This means installation failed somehow - it does not need to be
302 re-unpacked (probably) */
303 case pkgCache::State::UnPacked
:
304 case pkgCache::State::HalfConfigured
:
305 case pkgCache::State::TriggersAwaited
:
306 case pkgCache::State::TriggersPending
:
307 if ((I
->CurrentVer
!= 0 && I
.CurrentVer().Downloadable() == true) ||
308 I
.State() != pkgCache::PkgIterator::NeedsUnpack
)
309 Cache
.MarkKeep(I
, false, false);
312 if (Cache
[I
].CandidateVer
!= 0 &&
313 Cache
[I
].CandidateVerIter(Cache
).Downloadable() == true)
314 Cache
.MarkInstall(I
, true, 0, false);
320 // This means removal failed
321 case pkgCache::State::HalfInstalled
:
326 if (I
->InstState
!= pkgCache::State::Ok
)
327 return _error
->Error("The package %s is not ok and I "
328 "don't know how to fix it!",I
.FullName(false).c_str());
334 // FixBroken - Fix broken packages /*{{{*/
335 // ---------------------------------------------------------------------
336 /* This autoinstalls every broken package and then runs the problem resolver
338 bool pkgFixBroken(pkgDepCache
&Cache
)
340 pkgDepCache::ActionGroup
group(Cache
);
342 // Auto upgrade all broken packages
343 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
344 if (Cache
[I
].NowBroken() == true)
345 Cache
.MarkInstall(I
, true, 0, false);
347 /* Fix packages that are in a NeedArchive state but don't have a
348 downloadable install version */
349 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
351 if (I
.State() != pkgCache::PkgIterator::NeedsUnpack
||
352 Cache
[I
].Delete() == true)
355 if (Cache
[I
].InstVerIter(Cache
).Downloadable() == false)
358 Cache
.MarkInstall(I
, true, 0, false);
361 pkgProblemResolver
Fix(&Cache
);
362 return Fix
.Resolve(true);
365 // DistUpgrade - Distribution upgrade /*{{{*/
366 // ---------------------------------------------------------------------
367 /* This autoinstalls every package and then force installs every
368 pre-existing package. This creates the initial set of conditions which
369 most likely contain problems because too many things were installed.
371 The problem resolver is used to resolve the problems.
373 bool pkgDistUpgrade(pkgDepCache
&Cache
)
375 pkgDepCache::ActionGroup
group(Cache
);
377 /* Upgrade all installed packages first without autoinst to help the resolver
378 in versioned or-groups to upgrade the old solver instead of installing
379 a new one (if the old solver is not the first one [anymore]) */
380 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
381 if (I
->CurrentVer
!= 0)
382 Cache
.MarkInstall(I
, false, 0, false);
384 /* Auto upgrade all installed packages, this provides the basis
385 for the installation */
386 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
387 if (I
->CurrentVer
!= 0)
388 Cache
.MarkInstall(I
, true, 0, false);
390 /* Now, auto upgrade all essential packages - this ensures that
391 the essential packages are present and working */
392 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
393 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
394 Cache
.MarkInstall(I
, true, 0, false);
396 /* We do it again over all previously installed packages to force
397 conflict resolution on them all. */
398 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
399 if (I
->CurrentVer
!= 0)
400 Cache
.MarkInstall(I
, false, 0, false);
402 pkgProblemResolver
Fix(&Cache
);
404 // Hold back held packages.
405 if (_config
->FindB("APT::Ignore-Hold",false) == false)
407 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
409 if (I
->SelectedState
== pkgCache::State::Hold
)
412 Cache
.MarkKeep(I
, false, false);
417 return Fix
.Resolve();
420 // AllUpgrade - Upgrade as many packages as possible /*{{{*/
421 // ---------------------------------------------------------------------
422 /* Right now the system must be consistent before this can be called.
423 It also will not change packages marked for install, it only tries
424 to install packages not marked for install */
425 bool pkgAllUpgrade(pkgDepCache
&Cache
)
427 pkgDepCache::ActionGroup
group(Cache
);
429 pkgProblemResolver
Fix(&Cache
);
431 if (Cache
.BrokenCount() != 0)
434 // Upgrade all installed packages
435 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
437 if (Cache
[I
].Install() == true)
440 if (_config
->FindB("APT::Ignore-Hold",false) == false)
441 if (I
->SelectedState
== pkgCache::State::Hold
)
444 if (I
->CurrentVer
!= 0 && Cache
[I
].InstallVer
!= 0)
445 Cache
.MarkInstall(I
, false, 0, false);
448 return Fix
.ResolveByKeep();
451 // MinimizeUpgrade - Minimizes the set of packages to be upgraded /*{{{*/
452 // ---------------------------------------------------------------------
453 /* This simply goes over the entire set of packages and tries to keep
454 each package marked for upgrade. If a conflict is generated then
455 the package is restored. */
456 bool pkgMinimizeUpgrade(pkgDepCache
&Cache
)
458 pkgDepCache::ActionGroup
group(Cache
);
460 if (Cache
.BrokenCount() != 0)
463 // We loop for 10 tries to get the minimal set size.
465 unsigned int Count
= 0;
469 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
472 if (Cache
[I
].Upgrade() == false || Cache
[I
].NewInstall() == true)
475 // Keep it and see if that is OK
476 Cache
.MarkKeep(I
, false, false);
477 if (Cache
.BrokenCount() != 0)
478 Cache
.MarkInstall(I
, false, 0, false);
481 // If keep didnt actually do anything then there was no change..
482 if (Cache
[I
].Upgrade() == false)
488 while (Change
== true && Count
< 10);
490 if (Cache
.BrokenCount() != 0)
491 return _error
->Error("Internal Error in pkgMinimizeUpgrade");
496 // ProblemResolver::pkgProblemResolver - Constructor /*{{{*/
497 // ---------------------------------------------------------------------
499 pkgProblemResolver::pkgProblemResolver(pkgDepCache
*pCache
) : Cache(*pCache
)
502 unsigned long Size
= Cache
.Head().PackageCount
;
503 Scores
= new signed short[Size
];
504 Flags
= new unsigned char[Size
];
505 memset(Flags
,0,sizeof(*Flags
)*Size
);
507 // Set debug to true to see its decision logic
508 Debug
= _config
->FindB("Debug::pkgProblemResolver",false);
511 // ProblemResolver::~pkgProblemResolver - Destructor /*{{{*/
512 // ---------------------------------------------------------------------
514 pkgProblemResolver::~pkgProblemResolver()
520 // ProblemResolver::ScoreSort - Sort the list by score /*{{{*/
521 // ---------------------------------------------------------------------
523 int pkgProblemResolver::ScoreSort(const void *a
,const void *b
)
525 Package
const **A
= (Package
const **)a
;
526 Package
const **B
= (Package
const **)b
;
527 if (This
->Scores
[(*A
)->ID
] > This
->Scores
[(*B
)->ID
])
529 if (This
->Scores
[(*A
)->ID
] < This
->Scores
[(*B
)->ID
])
534 // ProblemResolver::MakeScores - Make the score table /*{{{*/
535 // ---------------------------------------------------------------------
537 void pkgProblemResolver::MakeScores()
539 unsigned long Size
= Cache
.Head().PackageCount
;
540 memset(Scores
,0,sizeof(*Scores
)*Size
);
542 // Important Required Standard Optional Extra
543 signed short PrioMap
[] = {
545 (signed short) _config
->FindI("pkgProblemResolver::Scores::Important",3),
546 (signed short) _config
->FindI("pkgProblemResolver::Scores::Required",2),
547 (signed short) _config
->FindI("pkgProblemResolver::Scores::Standard",1),
548 (signed short) _config
->FindI("pkgProblemResolver::Scores::Optional",-1),
549 (signed short) _config
->FindI("pkgProblemResolver::Scores::Extra",-2)
551 signed short PrioEssentials
= _config
->FindI("pkgProblemResolver::Scores::Essentials",100);
552 signed short PrioInstalledAndNotObsolete
= _config
->FindI("pkgProblemResolver::Scores::NotObsolete",1);
553 signed short PrioDepends
= _config
->FindI("pkgProblemResolver::Scores::Depends",1);
554 signed short PrioRecommends
= _config
->FindI("pkgProblemResolver::Scores::Recommends",1);
555 signed short AddProtected
= _config
->FindI("pkgProblemResolver::Scores::AddProtected",10000);
556 signed short AddEssential
= _config
->FindI("pkgProblemResolver::Scores::AddEssential",5000);
558 if (_config
->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
559 clog
<< "Settings used to calculate pkgProblemResolver::Scores::" << endl
560 << " Important => " << PrioMap
[1] << endl
561 << " Required => " << PrioMap
[2] << endl
562 << " Standard => " << PrioMap
[3] << endl
563 << " Optional => " << PrioMap
[4] << endl
564 << " Extra => " << PrioMap
[5] << endl
565 << " Essentials => " << PrioEssentials
<< endl
566 << " InstalledAndNotObsolete => " << PrioInstalledAndNotObsolete
<< endl
567 << " Depends => " << PrioDepends
<< endl
568 << " Recommends => " << PrioRecommends
<< endl
569 << " AddProtected => " << AddProtected
<< endl
570 << " AddEssential => " << AddEssential
<< endl
;
572 // Generate the base scores for a package based on its properties
573 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
575 if (Cache
[I
].InstallVer
== 0)
578 signed short &Score
= Scores
[I
->ID
];
580 /* This is arbitrary, it should be high enough to elevate an
581 essantial package above most other packages but low enough
582 to allow an obsolete essential packages to be removed by
583 a conflicts on a powerfull normal package (ie libc6) */
584 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
585 Score
+= PrioEssentials
;
587 // We transform the priority
588 if (Cache
[I
].InstVerIter(Cache
)->Priority
<= 5)
589 Score
+= PrioMap
[Cache
[I
].InstVerIter(Cache
)->Priority
];
591 /* This helps to fix oddball problems with conflicting packages
592 on the same level. We enhance the score of installed packages
593 if those are not obsolete
595 if (I
->CurrentVer
!= 0 && Cache
[I
].CandidateVer
!= 0 && Cache
[I
].CandidateVerIter(Cache
).Downloadable())
596 Score
+= PrioInstalledAndNotObsolete
;
599 // Now that we have the base scores we go and propogate dependencies
600 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
602 if (Cache
[I
].InstallVer
== 0)
605 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList(); D
.end() == false; D
++)
607 if (D
->Type
== pkgCache::Dep::Depends
||
608 D
->Type
== pkgCache::Dep::PreDepends
)
609 Scores
[D
.TargetPkg()->ID
] += PrioDepends
;
610 else if (D
->Type
== pkgCache::Dep::Recommends
)
611 Scores
[D
.TargetPkg()->ID
] += PrioRecommends
;
615 // Copy the scores to advoid additive looping
616 SPtrArray
<signed short> OldScores
= new signed short[Size
];
617 memcpy(OldScores
,Scores
,sizeof(*Scores
)*Size
);
619 /* Now we cause 1 level of dependency inheritance, that is we add the
620 score of the packages that depend on the target Package. This
621 fortifies high scoring packages */
622 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
624 if (Cache
[I
].InstallVer
== 0)
627 for (pkgCache::DepIterator D
= I
.RevDependsList(); D
.end() == false; D
++)
629 // Only do it for the install version
630 if ((pkgCache::Version
*)D
.ParentVer() != Cache
[D
.ParentPkg()].InstallVer
||
631 (D
->Type
!= pkgCache::Dep::Depends
&&
632 D
->Type
!= pkgCache::Dep::PreDepends
&&
633 D
->Type
!= pkgCache::Dep::Recommends
))
636 Scores
[I
->ID
] += abs(OldScores
[D
.ParentPkg()->ID
]);
640 /* Now we propogate along provides. This makes the packages that
641 provide important packages extremely important */
642 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
644 for (pkgCache::PrvIterator P
= I
.ProvidesList(); P
.end() == false; P
++)
646 // Only do it once per package
647 if ((pkgCache::Version
*)P
.OwnerVer() != Cache
[P
.OwnerPkg()].InstallVer
)
649 Scores
[P
.OwnerPkg()->ID
] += abs(Scores
[I
->ID
] - OldScores
[I
->ID
]);
653 /* Protected things are pushed really high up. This number should put them
654 ahead of everything */
655 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
657 if ((Flags
[I
->ID
] & Protected
) != 0)
658 Scores
[I
->ID
] += AddProtected
;
659 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
660 Scores
[I
->ID
] += AddEssential
;
664 // ProblemResolver::DoUpgrade - Attempt to upgrade this package /*{{{*/
665 // ---------------------------------------------------------------------
666 /* This goes through and tries to reinstall packages to make this package
668 bool pkgProblemResolver::DoUpgrade(pkgCache::PkgIterator Pkg
)
670 pkgDepCache::ActionGroup
group(Cache
);
672 if ((Flags
[Pkg
->ID
] & Upgradable
) == 0 || Cache
[Pkg
].Upgradable() == false)
674 if ((Flags
[Pkg
->ID
] & Protected
) == Protected
)
677 Flags
[Pkg
->ID
] &= ~Upgradable
;
679 bool WasKept
= Cache
[Pkg
].Keep();
680 Cache
.MarkInstall(Pkg
, false, 0, false);
682 // This must be a virtual package or something like that.
683 if (Cache
[Pkg
].InstVerIter(Cache
).end() == true)
686 // Isolate the problem dependency
688 for (pkgCache::DepIterator D
= Cache
[Pkg
].InstVerIter(Cache
).DependsList(); D
.end() == false;)
690 // Compute a single dependency element (glob or)
691 pkgCache::DepIterator Start
= D
;
692 pkgCache::DepIterator End
= D
;
693 unsigned char State
= 0;
694 for (bool LastOR
= true; D
.end() == false && LastOR
== true;)
697 LastOR
= (D
->CompareOp
& pkgCache::Dep::Or
) == pkgCache::Dep::Or
;
703 // We only worry about critical deps.
704 if (End
.IsCritical() != true)
707 // Iterate over all the members in the or group
711 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
714 // Do not change protected packages
715 PkgIterator P
= Start
.SmartTargetPkg();
716 if ((Flags
[P
->ID
] & Protected
) == Protected
)
719 clog
<< " Reinst Failed because of protected " << P
.FullName(false) << endl
;
724 // Upgrade the package if the candidate version will fix the problem.
725 if ((Cache
[Start
] & pkgDepCache::DepCVer
) == pkgDepCache::DepCVer
)
727 if (DoUpgrade(P
) == false)
730 clog
<< " Reinst Failed because of " << P
.FullName(false) << endl
;
741 /* We let the algorithm deal with conflicts on its next iteration,
742 it is much smarter than us */
743 if (Start
->Type
== pkgCache::Dep::Conflicts
||
744 Start
->Type
== pkgCache::Dep::DpkgBreaks
||
745 Start
->Type
== pkgCache::Dep::Obsoletes
)
749 clog
<< " Reinst Failed early because of " << Start
.TargetPkg().FullName(false) << endl
;
762 // Undo our operations - it might be smart to undo everything this did..
766 Cache
.MarkKeep(Pkg
, false, false);
768 Cache
.MarkDelete(Pkg
);
773 clog
<< " Re-Instated " << Pkg
.FullName(false) << endl
;
777 // ProblemResolver::Resolve - Run the resolution pass /*{{{*/
778 // ---------------------------------------------------------------------
779 /* This routines works by calculating a score for each package. The score
780 is derived by considering the package's priority and all reverse
781 dependents giving an integer that reflects the amount of breakage that
782 adjusting the package will inflict.
784 It goes from highest score to lowest and corrects all of the breaks by
785 keeping or removing the dependant packages. If that fails then it removes
786 the package itself and goes on. The routine should be able to intelligently
787 go from any broken state to a fixed state.
789 The BrokenFix flag enables a mode where the algorithm tries to
790 upgrade packages to advoid problems. */
791 bool pkgProblemResolver::Resolve(bool BrokenFix
)
793 pkgDepCache::ActionGroup
group(Cache
);
795 unsigned long Size
= Cache
.Head().PackageCount
;
797 // Record which packages are marked for install
802 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
804 if (Cache
[I
].Install() == true)
805 Flags
[I
->ID
] |= PreInstalled
;
808 if (Cache
[I
].InstBroken() == true && BrokenFix
== true)
810 Cache
.MarkInstall(I
, false, 0, false);
811 if (Cache
[I
].Install() == true)
815 Flags
[I
->ID
] &= ~PreInstalled
;
817 Flags
[I
->ID
] |= Upgradable
;
820 while (Again
== true);
823 clog
<< "Starting" << endl
;
827 /* We have to order the packages so that the broken fixing pass
828 operates from highest score to lowest. This prevents problems when
829 high score packages cause the removal of lower score packages that
830 would cause the removal of even lower score packages. */
831 SPtrArray
<pkgCache::Package
*> PList
= new pkgCache::Package
*[Size
];
832 pkgCache::Package
**PEnd
= PList
;
833 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
836 qsort(PList
,PEnd
- PList
,sizeof(*PList
),&ScoreSort
);
838 if (_config
->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
840 clog
<< "Show Scores" << endl
;
841 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
842 if (Scores
[(*K
)->ID
] != 0)
844 pkgCache::PkgIterator
Pkg(Cache
,*K
);
845 clog
<< Scores
[(*K
)->ID
] << ' ' << Pkg
<< std::endl
;
850 clog
<< "Starting 2" << endl
;
852 /* Now consider all broken packages. For each broken package we either
853 remove the package or fix it's problem. We do this once, it should
854 not be possible for a loop to form (that is a < b < c and fixing b by
855 changing a breaks c) */
857 bool const TryFixByInstall
= _config
->FindB("pkgProblemResolver::FixByInstall", true);
858 for (int Counter
= 0; Counter
!= 10 && Change
== true; Counter
++)
861 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
863 pkgCache::PkgIterator
I(Cache
,*K
);
865 /* We attempt to install this and see if any breaks result,
866 this takes care of some strange cases */
867 if (Cache
[I
].CandidateVer
!= Cache
[I
].InstallVer
&&
868 I
->CurrentVer
!= 0 && Cache
[I
].InstallVer
!= 0 &&
869 (Flags
[I
->ID
] & PreInstalled
) != 0 &&
870 (Flags
[I
->ID
] & Protected
) == 0 &&
871 (Flags
[I
->ID
] & ReInstateTried
) == 0)
874 clog
<< " Try to Re-Instate (" << Counter
<< ") " << I
.FullName(false) << endl
;
875 unsigned long OldBreaks
= Cache
.BrokenCount();
876 pkgCache::Version
*OldVer
= Cache
[I
].InstallVer
;
877 Flags
[I
->ID
] &= ReInstateTried
;
879 Cache
.MarkInstall(I
, false, 0, false);
880 if (Cache
[I
].InstBroken() == true ||
881 OldBreaks
< Cache
.BrokenCount())
886 Cache
.MarkKeep(I
, false, false);
890 clog
<< "Re-Instated " << I
.FullName(false) << " (" << OldBreaks
<< " vs " << Cache
.BrokenCount() << ')' << endl
;
893 if (Cache
[I
].InstallVer
== 0 || Cache
[I
].InstBroken() == false)
897 clog
<< "Investigating (" << Counter
<< ") " << I
<< endl
;
899 // Isolate the problem dependency
900 PackageKill KillList
[100];
901 PackageKill
*LEnd
= KillList
;
903 pkgCache::DepIterator Start
;
904 pkgCache::DepIterator End
;
905 PackageKill
*OldEnd
= LEnd
;
907 enum {OrRemove
,OrKeep
} OrOp
= OrRemove
;
908 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList();
909 D
.end() == false || InOr
== true;)
911 // Compute a single dependency element (glob or)
915 if (InOr
== true && OldEnd
== LEnd
)
917 if (OrOp
== OrRemove
)
919 if ((Flags
[I
->ID
] & Protected
) != Protected
)
922 clog
<< " Or group remove for " << I
.FullName(false) << endl
;
927 else if (OrOp
== OrKeep
)
930 clog
<< " Or group keep for " << I
.FullName(false) << endl
;
931 Cache
.MarkKeep(I
, false, false);
936 /* We do an extra loop (as above) to finalize the or group
941 if (Start
.end() == true)
944 // We only worry about critical deps.
945 if (End
.IsCritical() != true)
954 // We only worry about critical deps.
955 if (Start
.IsCritical() != true)
960 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
967 clog
<< "Broken " << Start
<< endl
;
969 /* Look across the version list. If there are no possible
970 targets then we keep the package and bail. This is necessary
971 if a package has a dep on another package that cant be found */
972 SPtrArray
<pkgCache::Version
*> VList
= Start
.AllTargets();
973 if (*VList
== 0 && (Flags
[I
->ID
] & Protected
) != Protected
&&
974 Start
->Type
!= pkgCache::Dep::Conflicts
&&
975 Start
->Type
!= pkgCache::Dep::DpkgBreaks
&&
976 Start
->Type
!= pkgCache::Dep::Obsoletes
&&
977 Cache
[I
].NowBroken() == false)
981 /* No keep choice because the keep being OK could be the
982 result of another element in the OR group! */
987 Cache
.MarkKeep(I
, false, false);
992 for (pkgCache::Version
**V
= VList
; *V
!= 0; V
++)
994 pkgCache::VerIterator
Ver(Cache
,*V
);
995 pkgCache::PkgIterator Pkg
= Ver
.ParentPkg();
997 /* This is a conflicts, and the version we are looking
998 at is not the currently selected version of the
999 package, which means it is not necessary to
1001 if (Cache
[Pkg
].InstallVer
!= Ver
&&
1002 (Start
->Type
== pkgCache::Dep::Conflicts
||
1003 Start
->Type
== pkgCache::Dep::DpkgBreaks
||
1004 Start
->Type
== pkgCache::Dep::Obsoletes
))
1007 clog
<< " Conflicts//Breaks against version "
1008 << Ver
.VerStr() << " for " << Pkg
.Name()
1009 << " but that is not InstVer, ignoring"
1015 clog
<< " Considering " << Pkg
.FullName(false) << ' ' << (int)Scores
[Pkg
->ID
] <<
1016 " as a solution to " << I
.FullName(false) << ' ' << (int)Scores
[I
->ID
] << endl
;
1018 /* Try to fix the package under consideration rather than
1019 fiddle with the VList package */
1020 if (Scores
[I
->ID
] <= Scores
[Pkg
->ID
] ||
1021 ((Cache
[Start
] & pkgDepCache::DepNow
) == 0 &&
1022 End
->Type
!= pkgCache::Dep::Conflicts
&&
1023 End
->Type
!= pkgCache::Dep::DpkgBreaks
&&
1024 End
->Type
!= pkgCache::Dep::Obsoletes
))
1026 // Try a little harder to fix protected packages..
1027 if ((Flags
[I
->ID
] & Protected
) == Protected
)
1029 if (DoUpgrade(Pkg
) == true)
1031 if (Scores
[Pkg
->ID
] > Scores
[I
->ID
])
1032 Scores
[Pkg
->ID
] = Scores
[I
->ID
];
1039 /* See if a keep will do, unless the package is protected,
1040 then installing it will be necessary */
1041 bool Installed
= Cache
[I
].Install();
1042 Cache
.MarkKeep(I
, false, false);
1043 if (Cache
[I
].InstBroken() == false)
1045 // Unwind operation will be keep now
1046 if (OrOp
== OrRemove
)
1050 if (InOr
== true && Installed
== true)
1051 Cache
.MarkInstall(I
, false, 0, false);
1054 clog
<< " Holding Back " << I
.FullName(false) << " rather than change " << Start
.TargetPkg().FullName(false) << endl
;
1058 if (BrokenFix
== false || DoUpgrade(I
) == false)
1060 // Consider other options
1064 clog
<< " Removing " << I
.FullName(false) << " rather than change " << Start
.TargetPkg().FullName(false) << endl
;
1065 Cache
.MarkDelete(I
);
1066 if (Counter
> 1 && Scores
[Pkg
->ID
] > Scores
[I
->ID
])
1067 Scores
[I
->ID
] = Scores
[Pkg
->ID
];
1069 else if (TryFixByInstall
== true &&
1070 Start
.TargetPkg()->CurrentVer
== 0 &&
1071 Cache
[Start
.TargetPkg()].Delete() == false &&
1072 (Flags
[Start
.TargetPkg()->ID
] & ToRemove
) != ToRemove
&&
1073 Cache
.GetCandidateVer(Start
.TargetPkg()).end() == false)
1075 /* Before removing or keeping the package with the broken dependency
1076 try instead to install the first not previously installed package
1077 solving this dependency. This helps every time a previous solver
1078 is removed by the resolver because of a conflict or alike but it is
1079 dangerous as it could trigger new breaks/conflicts… */
1081 clog
<< " Try Installing " << Start
.TargetPkg() << " before changing " << I
.FullName(false) << std::endl
;
1082 unsigned long const OldBroken
= Cache
.BrokenCount();
1083 Cache
.MarkInstall(Start
.TargetPkg(), true, 1, false);
1084 // FIXME: we should undo the complete MarkInstall process here
1085 if (Cache
[Start
.TargetPkg()].InstBroken() == true || Cache
.BrokenCount() > OldBroken
)
1086 Cache
.MarkDelete(Start
.TargetPkg(), false, 1, false);
1097 if (Start
->Type
== pkgCache::Dep::DpkgBreaks
)
1099 // first, try upgradring the package, if that
1100 // does not help, the breaks goes onto the
1103 // FIXME: use DoUpgrade(Pkg) instead?
1104 if (Cache
[End
] & pkgDepCache::DepGCVer
)
1107 clog
<< " Upgrading " << Pkg
.FullName(false) << " due to Breaks field in " << I
.FullName(false) << endl
;
1108 Cache
.MarkInstall(Pkg
, false, 0, false);
1113 // Skip adding to the kill list if it is protected
1114 if ((Flags
[Pkg
->ID
] & Protected
) != 0)
1118 clog
<< " Added " << Pkg
.FullName(false) << " to the remove list" << endl
;
1124 if (Start
->Type
!= pkgCache::Dep::Conflicts
&&
1125 Start
->Type
!= pkgCache::Dep::Obsoletes
)
1130 // Hm, nothing can possibly satisify this dep. Nuke it.
1131 if (VList
[0] == 0 &&
1132 Start
->Type
!= pkgCache::Dep::Conflicts
&&
1133 Start
->Type
!= pkgCache::Dep::DpkgBreaks
&&
1134 Start
->Type
!= pkgCache::Dep::Obsoletes
&&
1135 (Flags
[I
->ID
] & Protected
) != Protected
)
1137 bool Installed
= Cache
[I
].Install();
1139 if (Cache
[I
].InstBroken() == false)
1141 // Unwind operation will be keep now
1142 if (OrOp
== OrRemove
)
1146 if (InOr
== true && Installed
== true)
1147 Cache
.MarkInstall(I
, false, 0, false);
1150 clog
<< " Holding Back " << I
.FullName(false) << " because I can't find " << Start
.TargetPkg().FullName(false) << endl
;
1155 clog
<< " Removing " << I
.FullName(false) << " because I can't find " << Start
.TargetPkg().FullName(false) << endl
;
1157 Cache
.MarkDelete(I
);
1172 // Apply the kill list now
1173 if (Cache
[I
].InstallVer
!= 0)
1175 for (PackageKill
*J
= KillList
; J
!= LEnd
; J
++)
1178 if ((Cache
[J
->Dep
] & pkgDepCache::DepGNow
) == 0)
1180 if (J
->Dep
->Type
== pkgCache::Dep::Conflicts
||
1181 J
->Dep
->Type
== pkgCache::Dep::DpkgBreaks
||
1182 J
->Dep
->Type
== pkgCache::Dep::Obsoletes
)
1185 clog
<< " Fixing " << I
.FullName(false) << " via remove of " << J
->Pkg
.FullName(false) << endl
;
1186 Cache
.MarkDelete(J
->Pkg
);
1192 clog
<< " Fixing " << I
.FullName(false) << " via keep of " << J
->Pkg
.FullName(false) << endl
;
1193 Cache
.MarkKeep(J
->Pkg
, false, false);
1198 if (Scores
[I
->ID
] > Scores
[J
->Pkg
->ID
])
1199 Scores
[J
->Pkg
->ID
] = Scores
[I
->ID
];
1207 clog
<< "Done" << endl
;
1209 if (Cache
.BrokenCount() != 0)
1211 // See if this is the result of a hold
1212 pkgCache::PkgIterator I
= Cache
.PkgBegin();
1213 for (;I
.end() != true; I
++)
1215 if (Cache
[I
].InstBroken() == false)
1217 if ((Flags
[I
->ID
] & Protected
) != Protected
)
1218 return _error
->Error(_("Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages."));
1220 return _error
->Error(_("Unable to correct problems, you have held broken packages."));
1223 // set the auto-flags (mvo: I'm not sure if we _really_ need this)
1224 pkgCache::PkgIterator I
= Cache
.PkgBegin();
1225 for (;I
.end() != true; I
++) {
1226 if (Cache
[I
].NewInstall() && !(Flags
[I
->ID
] & PreInstalled
)) {
1227 if(_config
->FindI("Debug::pkgAutoRemove",false)) {
1228 std::clog
<< "Resolve installed new pkg: " << I
.FullName(false)
1229 << " (now marking it as auto)" << std::endl
;
1231 Cache
[I
].Flags
|= pkgCache::Flag::Auto
;
1239 // ProblemResolver::ResolveByKeep - Resolve problems using keep /*{{{*/
1240 // ---------------------------------------------------------------------
1241 /* This is the work horse of the soft upgrade routine. It is very gental
1242 in that it does not install or remove any packages. It is assumed that the
1243 system was non-broken previously. */
1244 bool pkgProblemResolver::ResolveByKeep()
1246 pkgDepCache::ActionGroup
group(Cache
);
1248 unsigned long Size
= Cache
.Head().PackageCount
;
1252 /* We have to order the packages so that the broken fixing pass
1253 operates from highest score to lowest. This prevents problems when
1254 high score packages cause the removal of lower score packages that
1255 would cause the removal of even lower score packages. */
1256 pkgCache::Package
**PList
= new pkgCache::Package
*[Size
];
1257 pkgCache::Package
**PEnd
= PList
;
1258 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
1261 qsort(PList
,PEnd
- PList
,sizeof(*PList
),&ScoreSort
);
1263 if (_config
->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
1265 clog
<< "Show Scores" << endl
;
1266 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
1267 if (Scores
[(*K
)->ID
] != 0)
1269 pkgCache::PkgIterator
Pkg(Cache
,*K
);
1270 clog
<< Scores
[(*K
)->ID
] << ' ' << Pkg
<< std::endl
;
1275 clog
<< "Entering ResolveByKeep" << endl
;
1277 // Consider each broken package
1278 pkgCache::Package
**LastStop
= 0;
1279 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
1281 pkgCache::PkgIterator
I(Cache
,*K
);
1283 if (Cache
[I
].InstallVer
== 0 || Cache
[I
].InstBroken() == false)
1286 /* Keep the package. If this works then great, otherwise we have
1287 to be significantly more agressive and manipulate its dependencies */
1288 if ((Flags
[I
->ID
] & Protected
) == 0)
1291 clog
<< "Keeping package " << I
.FullName(false) << endl
;
1292 Cache
.MarkKeep(I
, false, false);
1293 if (Cache
[I
].InstBroken() == false)
1300 // Isolate the problem dependencies
1301 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList(); D
.end() == false;)
1305 D
.GlobOr(Start
,End
);
1307 // We only worry about critical deps.
1308 if (End
.IsCritical() != true)
1312 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
1315 /* Hm, the group is broken.. I suppose the best thing to do is to
1316 is to try every combination of keep/not-keep for the set, but thats
1317 slow, and this never happens, just be conservative and assume the
1318 list of ors is in preference and keep till it starts to work. */
1322 clog
<< "Package " << I
.FullName(false) << " " << Start
<< endl
;
1324 // Look at all the possible provides on this package
1325 SPtrArray
<pkgCache::Version
*> VList
= Start
.AllTargets();
1326 for (pkgCache::Version
**V
= VList
; *V
!= 0; V
++)
1328 pkgCache::VerIterator
Ver(Cache
,*V
);
1329 pkgCache::PkgIterator Pkg
= Ver
.ParentPkg();
1331 // It is not keepable
1332 if (Cache
[Pkg
].InstallVer
== 0 ||
1333 Pkg
->CurrentVer
== 0)
1336 if ((Flags
[I
->ID
] & Protected
) == 0)
1339 clog
<< " Keeping Package " << Pkg
.FullName(false) << " due to " << Start
.DepType() << endl
;
1340 Cache
.MarkKeep(Pkg
, false, false);
1343 if (Cache
[I
].InstBroken() == false)
1347 if (Cache
[I
].InstBroken() == false)
1355 if (Cache
[I
].InstBroken() == false)
1359 if (Cache
[I
].InstBroken() == true)
1364 return _error
->Error("Internal Error, pkgProblemResolver::ResolveByKeep is looping on package %s.",I
.FullName(false).c_str());
1372 // ProblemResolver::InstallProtect - Install all protected packages /*{{{*/
1373 // ---------------------------------------------------------------------
1374 /* This is used to make sure protected packages are installed */
1375 void pkgProblemResolver::InstallProtect()
1377 pkgDepCache::ActionGroup
group(Cache
);
1379 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
1381 if ((Flags
[I
->ID
] & Protected
) == Protected
)
1383 if ((Flags
[I
->ID
] & ToRemove
) == ToRemove
)
1384 Cache
.MarkDelete(I
);
1387 // preserve the information whether the package was auto
1388 // or manually installed
1389 bool autoInst
= (Cache
[I
].Flags
& pkgCache::Flag::Auto
);
1390 Cache
.MarkInstall(I
, false, 0, !autoInst
);
1396 // PrioSortList - Sort a list of versions by priority /*{{{*/
1397 // ---------------------------------------------------------------------
1398 /* This is ment to be used in conjunction with AllTargets to get a list
1399 of versions ordered by preference. */
1400 static pkgCache
*PrioCache
;
1401 static int PrioComp(const void *A
,const void *B
)
1403 pkgCache::VerIterator
L(*PrioCache
,*(pkgCache::Version
**)A
);
1404 pkgCache::VerIterator
R(*PrioCache
,*(pkgCache::Version
**)B
);
1406 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
&&
1407 (R
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) != pkgCache::Flag::Essential
)
1409 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) != pkgCache::Flag::Essential
&&
1410 (R
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
1413 if (L
->Priority
!= R
->Priority
)
1414 return R
->Priority
- L
->Priority
;
1415 return strcmp(L
.ParentPkg().Name(),R
.ParentPkg().Name());
1417 void pkgPrioSortList(pkgCache
&Cache
,pkgCache::Version
**List
)
1419 unsigned long Count
= 0;
1421 for (pkgCache::Version
**I
= List
; *I
!= 0; I
++)
1423 qsort(List
,Count
,sizeof(*List
),PrioComp
);
1426 // CacheFile::ListUpdate - update the cache files /*{{{*/
1427 // ---------------------------------------------------------------------
1428 /* This is a simple wrapper to update the cache. it will fetch stuff
1429 * from the network (or any other sources defined in sources.list)
1431 bool ListUpdate(pkgAcquireStatus
&Stat
,
1432 pkgSourceList
&List
,
1435 pkgAcquire::RunResult res
;
1437 if (Fetcher
.Setup(&Stat
, _config
->FindDir("Dir::State::Lists")) == false)
1440 // Populate it with the source selection
1441 if (List
.GetIndexes(&Fetcher
) == false)
1445 RunScripts("APT::Update::Pre-Invoke");
1449 res
= Fetcher
.Run(PulseInterval
);
1451 res
= Fetcher
.Run();
1453 if (res
== pkgAcquire::Failed
)
1456 bool Failed
= false;
1457 bool TransientNetworkFailure
= false;
1458 for (pkgAcquire::ItemIterator I
= Fetcher
.ItemsBegin();
1459 I
!= Fetcher
.ItemsEnd(); I
++)
1461 if ((*I
)->Status
== pkgAcquire::Item::StatDone
)
1466 ::URI
uri((*I
)->DescURI());
1468 uri
.Password
.clear();
1469 string descUri
= string(uri
);
1470 _error
->Warning(_("Failed to fetch %s %s\n"), descUri
.c_str(),
1471 (*I
)->ErrorText
.c_str());
1473 if ((*I
)->Status
== pkgAcquire::Item::StatTransientNetworkError
)
1475 TransientNetworkFailure
= true;
1482 // Clean out any old list files
1483 // Keep "APT::Get::List-Cleanup" name for compatibility, but
1484 // this is really a global option for the APT library now
1485 if (!TransientNetworkFailure
&& !Failed
&&
1486 (_config
->FindB("APT::Get::List-Cleanup",true) == true &&
1487 _config
->FindB("APT::List-Cleanup",true) == true))
1489 if (Fetcher
.Clean(_config
->FindDir("Dir::State::lists")) == false ||
1490 Fetcher
.Clean(_config
->FindDir("Dir::State::lists") + "partial/") == false)
1491 // something went wrong with the clean
1495 if (TransientNetworkFailure
== true)
1496 _error
->Warning(_("Some index files failed to download, they have been ignored, or old ones used instead."));
1497 else if (Failed
== true)
1498 return _error
->Error(_("Some index files failed to download, they have been ignored, or old ones used instead."));
1501 // Run the success scripts if all was fine
1502 if(!TransientNetworkFailure
&& !Failed
)
1503 RunScripts("APT::Update::Post-Invoke-Success");
1505 // Run the other scripts
1506 RunScripts("APT::Update::Post-Invoke");