1 // -*- mode: cpp; mode: fold -*-
3 // $Id: algorithms.cc,v 1.44 2002/11/28 18:49:16 jgg Exp $
4 /* ######################################################################
6 Algorithms - A set of misc algorithms
8 The pkgProblemResolver class has become insanely complex and
9 very sophisticated, it handles every test case I have thrown at it
10 to my satisfaction. Understanding exactly why all the steps the class
11 does are required is difficult and changing though not very risky
12 may result in other cases not working.
14 ##################################################################### */
16 // Include Files /*{{{*/
17 #include <apt-pkg/algorithms.h>
18 #include <apt-pkg/error.h>
19 #include <apt-pkg/configuration.h>
20 #include <apt-pkg/version.h>
21 #include <apt-pkg/sptr.h>
22 #include <apt-pkg/acquire-item.h>
25 #include <sys/types.h>
32 pkgProblemResolver
*pkgProblemResolver::This
= 0;
34 // Simulate::Simulate - Constructor /*{{{*/
35 // ---------------------------------------------------------------------
36 /* The legacy translations here of input Pkg iterators is obsolete,
37 this is not necessary since the pkgCaches are fully shared now. */
38 pkgSimulate::pkgSimulate(pkgDepCache
*Cache
) : pkgPackageManager(Cache
),
40 Sim(&Cache
->GetCache(),&iPolicy
),
44 Flags
= new unsigned char[Cache
->Head().PackageCount
];
45 memset(Flags
,0,sizeof(*Flags
)*Cache
->Head().PackageCount
);
47 // Fake a filename so as not to activate the media swapping
48 string Jnk
= "SIMULATE";
49 for (unsigned int I
= 0; I
!= Cache
->Head().PackageCount
; I
++)
53 // Simulate::Describe - Describe a package /*{{{*/
54 // ---------------------------------------------------------------------
55 /* Parameter Current == true displays the current package version,
56 Parameter Candidate == true displays the candidate package version */
57 void pkgSimulate::Describe(PkgIterator Pkg
,ostream
&out
,bool Current
,bool Candidate
)
61 out
<< Pkg
.FullName(true);
65 Ver
= Pkg
.CurrentVer();
66 if (Ver
.end() == false)
67 out
<< " [" << Ver
.VerStr() << ']';
70 if (Candidate
== true)
72 Ver
= Sim
[Pkg
].CandidateVerIter(Sim
);
73 if (Ver
.end() == true)
76 out
<< " (" << Ver
.VerStr() << ' ' << Ver
.RelStr() << ')';
80 // Simulate::Install - Simulate unpacking of a package /*{{{*/
81 // ---------------------------------------------------------------------
83 bool pkgSimulate::Install(PkgIterator iPkg
,string
/*File*/)
86 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name(), iPkg
.Arch());
90 Describe(Pkg
,cout
,true,true);
91 Sim
.MarkInstall(Pkg
,false);
93 if (strcmp(Pkg
.Arch(),"all") == 0)
95 pkgCache::GrpIterator G
= Pkg
.Group();
96 pkgCache::GrpIterator iG
= iPkg
.Group();
97 for (pkgCache::PkgIterator P
= G
.FindPkg("any"); P
.end() != true; P
= G
.NextPkg(P
))
99 if (strcmp(P
.Arch(), "all") == 0)
101 if (iG
.FindPkg(P
.Arch())->CurrentVer
== 0)
104 Sim
.MarkInstall(P
, false);
108 // Look for broken conflicts+predepends.
109 for (PkgIterator I
= Sim
.PkgBegin(); I
.end() == false; I
++)
111 if (Sim
[I
].InstallVer
== 0)
114 for (DepIterator D
= Sim
[I
].InstVerIter(Sim
).DependsList(); D
.end() == false;)
119 if (Start
->Type
== pkgCache::Dep::Conflicts
||
120 Start
->Type
== pkgCache::Dep::DpkgBreaks
||
121 Start
->Type
== pkgCache::Dep::Obsoletes
||
122 End
->Type
== pkgCache::Dep::PreDepends
)
124 if ((Sim
[End
] & pkgDepCache::DepGInstall
) == 0)
126 cout
<< " [" << I
.FullName(false) << " on " << Start
.TargetPkg().FullName(false) << ']';
127 if (Start
->Type
== pkgCache::Dep::Conflicts
)
128 _error
->Error("Fatal, conflicts violated %s",I
.FullName(false).c_str());
134 if (Sim
.BrokenCount() != 0)
141 // Simulate::Configure - Simulate configuration of a Package /*{{{*/
142 // ---------------------------------------------------------------------
143 /* This is not an acurate simulation of relatity, we should really not
144 install the package.. For some investigations it may be necessary
146 bool pkgSimulate::Configure(PkgIterator iPkg
)
148 // Adapt the iterator
149 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name(), iPkg
.Arch());
153 if (strcmp(Pkg
.Arch(),"all") == 0)
155 pkgCache::GrpIterator G
= Pkg
.Group();
156 for (pkgCache::PkgIterator P
= G
.FindPkg("any"); P
.end() != true; P
= G
.NextPkg(P
))
158 if (strcmp(P
.Arch(), "all") == 0)
160 if (Flags
[P
->ID
] == 1)
165 if (Sim
[Pkg
].InstBroken() == true)
167 /* We don't call Configure for Pseudo packages and if the 'all' is already installed
168 the simulation will think the pseudo package is not installed, so if something is
169 broken we walk over the dependencies and search for not installed pseudo packages */
170 for (pkgCache::DepIterator D
= Sim
[Pkg
].InstVerIter(Sim
).DependsList(); D
.end() == false; D
++)
172 if (Sim
.IsImportantDep(D
) == false ||
173 (Sim
[D
] & pkgDepCache::DepInstall
) != 0)
175 pkgCache::PkgIterator T
= D
.TargetPkg();
176 if (T
.end() == true || T
->CurrentVer
!= 0 || Flags
[T
->ID
] != 0)
178 pkgCache::PkgIterator A
= T
.Group().FindPkg("all");
179 if (A
.end() == true || A
->VersionList
== 0 || A
->CurrentVer
== 0 ||
180 Cache
.VS().CheckDep(A
.CurVersion(), pkgCache::Dep::Equals
, T
.CandVersion()) == false)
182 Sim
.MarkInstall(T
, false);
187 if (Sim
[Pkg
].InstBroken() == true)
189 cout
<< "Conf " << Pkg
.FullName(false) << " broken" << endl
;
193 // Print out each package and the failed dependencies
194 for (pkgCache::DepIterator D
= Sim
[Pkg
].InstVerIter(Sim
).DependsList(); D
.end() == false; D
++)
196 if (Sim
.IsImportantDep(D
) == false ||
197 (Sim
[D
] & pkgDepCache::DepInstall
) != 0)
200 if (D
->Type
== pkgCache::Dep::Obsoletes
)
201 cout
<< " Obsoletes:" << D
.TargetPkg().FullName(false);
202 else if (D
->Type
== pkgCache::Dep::Conflicts
)
203 cout
<< " Conflicts:" << D
.TargetPkg().FullName(false);
204 else if (D
->Type
== pkgCache::Dep::DpkgBreaks
)
205 cout
<< " Breaks:" << D
.TargetPkg().FullName(false);
207 cout
<< " Depends:" << D
.TargetPkg().FullName(false);
211 _error
->Error("Conf Broken %s",Pkg
.FullName(false).c_str());
216 Describe(Pkg
,cout
,false,true);
219 if (Sim
.BrokenCount() != 0)
227 // Simulate::Remove - Simulate the removal of a package /*{{{*/
228 // ---------------------------------------------------------------------
230 bool pkgSimulate::Remove(PkgIterator iPkg
,bool Purge
)
232 // Adapt the iterator
233 PkgIterator Pkg
= Sim
.FindPkg(iPkg
.Name(), iPkg
.Arch());
238 if (strcmp(Pkg
.Arch(),"all") == 0)
240 pkgCache::GrpIterator G
= Pkg
.Group();
241 pkgCache::GrpIterator iG
= iPkg
.Group();
242 for (pkgCache::PkgIterator P
= G
.FindPkg("any"); P
.end() != true; P
= G
.NextPkg(P
))
244 if (strcmp(P
.Arch(), "all") == 0)
246 if (iG
.FindPkg(P
.Arch())->CurrentVer
== 0)
257 Describe(Pkg
,cout
,true,false);
259 if (Sim
.BrokenCount() != 0)
267 // Simulate::ShortBreaks - Print out a short line describing all breaks /*{{{*/
268 // ---------------------------------------------------------------------
270 void pkgSimulate::ShortBreaks()
273 for (PkgIterator I
= Sim
.PkgBegin(); I
.end() == false; I
++)
275 if (Sim
[I
].InstBroken() == true)
277 if (Flags
[I
->ID
] == 0)
278 cout
<< I
.FullName(false) << ' ';
280 cout << I.Name() << "! ";*/
286 // ApplyStatus - Adjust for non-ok packages /*{{{*/
287 // ---------------------------------------------------------------------
288 /* We attempt to change the state of the all packages that have failed
289 installation toward their real state. The ordering code will perform
290 the necessary calculations to deal with the problems. */
291 bool pkgApplyStatus(pkgDepCache
&Cache
)
293 pkgDepCache::ActionGroup
group(Cache
);
295 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
297 if (I
->VersionList
== 0)
300 // Only choice for a ReInstReq package is to reinstall
301 if (I
->InstState
== pkgCache::State::ReInstReq
||
302 I
->InstState
== pkgCache::State::HoldReInstReq
)
304 if (I
->CurrentVer
!= 0 && I
.CurrentVer().Downloadable() == true)
305 Cache
.MarkKeep(I
, false, false);
308 // Is this right? Will dpkg choke on an upgrade?
309 if (Cache
[I
].CandidateVer
!= 0 &&
310 Cache
[I
].CandidateVerIter(Cache
).Downloadable() == true)
311 Cache
.MarkInstall(I
, false, 0, false);
313 return _error
->Error(_("The package %s needs to be reinstalled, "
314 "but I can't find an archive for it."),I
.FullName(true).c_str());
320 switch (I
->CurrentState
)
322 /* This means installation failed somehow - it does not need to be
323 re-unpacked (probably) */
324 case pkgCache::State::UnPacked
:
325 case pkgCache::State::HalfConfigured
:
326 case pkgCache::State::TriggersAwaited
:
327 case pkgCache::State::TriggersPending
:
328 if ((I
->CurrentVer
!= 0 && I
.CurrentVer().Downloadable() == true) ||
329 I
.State() != pkgCache::PkgIterator::NeedsUnpack
)
330 Cache
.MarkKeep(I
, false, false);
333 if (Cache
[I
].CandidateVer
!= 0 &&
334 Cache
[I
].CandidateVerIter(Cache
).Downloadable() == true)
335 Cache
.MarkInstall(I
, true, 0, false);
341 // This means removal failed
342 case pkgCache::State::HalfInstalled
:
347 if (I
->InstState
!= pkgCache::State::Ok
)
348 return _error
->Error("The package %s is not ok and I "
349 "don't know how to fix it!",I
.FullName(false).c_str());
355 // FixBroken - Fix broken packages /*{{{*/
356 // ---------------------------------------------------------------------
357 /* This autoinstalls every broken package and then runs the problem resolver
359 bool pkgFixBroken(pkgDepCache
&Cache
)
361 pkgDepCache::ActionGroup
group(Cache
);
363 // Auto upgrade all broken packages
364 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
365 if (Cache
[I
].NowBroken() == true)
366 Cache
.MarkInstall(I
, true, 0, false);
368 /* Fix packages that are in a NeedArchive state but don't have a
369 downloadable install version */
370 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
372 if (I
.State() != pkgCache::PkgIterator::NeedsUnpack
||
373 Cache
[I
].Delete() == true)
376 if (Cache
[I
].InstVerIter(Cache
).Downloadable() == false)
379 Cache
.MarkInstall(I
, true, 0, false);
382 pkgProblemResolver
Fix(&Cache
);
383 return Fix
.Resolve(true);
386 // DistUpgrade - Distribution upgrade /*{{{*/
387 // ---------------------------------------------------------------------
388 /* This autoinstalls every package and then force installs every
389 pre-existing package. This creates the initial set of conditions which
390 most likely contain problems because too many things were installed.
392 The problem resolver is used to resolve the problems.
394 bool pkgDistUpgrade(pkgDepCache
&Cache
)
396 pkgDepCache::ActionGroup
group(Cache
);
398 /* Upgrade all installed packages first without autoinst to help the resolver
399 in versioned or-groups to upgrade the old solver instead of installing
400 a new one (if the old solver is not the first one [anymore]) */
401 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; ++I
)
402 if (I
->CurrentVer
!= 0)
403 Cache
.MarkInstall(I
, false, 0, false);
405 /* Auto upgrade all installed packages, this provides the basis
406 for the installation */
407 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
408 if (I
->CurrentVer
!= 0)
409 Cache
.MarkInstall(I
, true, 0, false);
411 /* Now, auto upgrade all essential packages - this ensures that
412 the essential packages are present and working */
413 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
414 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
415 Cache
.MarkInstall(I
, true, 0, false);
417 /* We do it again over all previously installed packages to force
418 conflict resolution on them all. */
419 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
420 if (I
->CurrentVer
!= 0)
421 Cache
.MarkInstall(I
, false, 0, false);
423 pkgProblemResolver
Fix(&Cache
);
425 // Hold back held packages.
426 if (_config
->FindB("APT::Ignore-Hold",false) == false)
428 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
430 if (I
->SelectedState
== pkgCache::State::Hold
)
433 Cache
.MarkKeep(I
, false, false);
438 return Fix
.Resolve();
441 // AllUpgrade - Upgrade as many packages as possible /*{{{*/
442 // ---------------------------------------------------------------------
443 /* Right now the system must be consistent before this can be called.
444 It also will not change packages marked for install, it only tries
445 to install packages not marked for install */
446 bool pkgAllUpgrade(pkgDepCache
&Cache
)
448 pkgDepCache::ActionGroup
group(Cache
);
450 pkgProblemResolver
Fix(&Cache
);
452 if (Cache
.BrokenCount() != 0)
455 // Upgrade all installed packages
456 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
458 if (Cache
[I
].Install() == true)
461 if (_config
->FindB("APT::Ignore-Hold",false) == false)
462 if (I
->SelectedState
== pkgCache::State::Hold
)
465 if (I
->CurrentVer
!= 0 && Cache
[I
].InstallVer
!= 0)
466 Cache
.MarkInstall(I
, false, 0, false);
469 return Fix
.ResolveByKeep();
472 // MinimizeUpgrade - Minimizes the set of packages to be upgraded /*{{{*/
473 // ---------------------------------------------------------------------
474 /* This simply goes over the entire set of packages and tries to keep
475 each package marked for upgrade. If a conflict is generated then
476 the package is restored. */
477 bool pkgMinimizeUpgrade(pkgDepCache
&Cache
)
479 pkgDepCache::ActionGroup
group(Cache
);
481 if (Cache
.BrokenCount() != 0)
484 // We loop for 10 tries to get the minimal set size.
486 unsigned int Count
= 0;
490 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
493 if (Cache
[I
].Upgrade() == false || Cache
[I
].NewInstall() == true)
496 // Keep it and see if that is OK
497 Cache
.MarkKeep(I
, false, false);
498 if (Cache
.BrokenCount() != 0)
499 Cache
.MarkInstall(I
, false, 0, false);
502 // If keep didnt actually do anything then there was no change..
503 if (Cache
[I
].Upgrade() == false)
509 while (Change
== true && Count
< 10);
511 if (Cache
.BrokenCount() != 0)
512 return _error
->Error("Internal Error in pkgMinimizeUpgrade");
517 // ProblemResolver::pkgProblemResolver - Constructor /*{{{*/
518 // ---------------------------------------------------------------------
520 pkgProblemResolver::pkgProblemResolver(pkgDepCache
*pCache
) : Cache(*pCache
)
523 unsigned long Size
= Cache
.Head().PackageCount
;
524 Scores
= new signed short[Size
];
525 Flags
= new unsigned char[Size
];
526 memset(Flags
,0,sizeof(*Flags
)*Size
);
528 // Set debug to true to see its decision logic
529 Debug
= _config
->FindB("Debug::pkgProblemResolver",false);
532 // ProblemResolver::~pkgProblemResolver - Destructor /*{{{*/
533 // ---------------------------------------------------------------------
535 pkgProblemResolver::~pkgProblemResolver()
541 // ProblemResolver::ScoreSort - Sort the list by score /*{{{*/
542 // ---------------------------------------------------------------------
544 int pkgProblemResolver::ScoreSort(const void *a
,const void *b
)
546 Package
const **A
= (Package
const **)a
;
547 Package
const **B
= (Package
const **)b
;
548 if (This
->Scores
[(*A
)->ID
] > This
->Scores
[(*B
)->ID
])
550 if (This
->Scores
[(*A
)->ID
] < This
->Scores
[(*B
)->ID
])
555 // ProblemResolver::MakeScores - Make the score table /*{{{*/
556 // ---------------------------------------------------------------------
558 void pkgProblemResolver::MakeScores()
560 unsigned long Size
= Cache
.Head().PackageCount
;
561 memset(Scores
,0,sizeof(*Scores
)*Size
);
563 // Important Required Standard Optional Extra
564 signed short PrioMap
[] = {
566 (signed short) _config
->FindI("pkgProblemResolver::Scores::Important",3),
567 (signed short) _config
->FindI("pkgProblemResolver::Scores::Required",2),
568 (signed short) _config
->FindI("pkgProblemResolver::Scores::Standard",1),
569 (signed short) _config
->FindI("pkgProblemResolver::Scores::Optional",-1),
570 (signed short) _config
->FindI("pkgProblemResolver::Scores::Extra",-2)
572 signed short PrioEssentials
= _config
->FindI("pkgProblemResolver::Scores::Essentials",100);
573 signed short PrioInstalledAndNotObsolete
= _config
->FindI("pkgProblemResolver::Scores::NotObsolete",1);
574 signed short PrioDepends
= _config
->FindI("pkgProblemResolver::Scores::Depends",1);
575 signed short PrioRecommends
= _config
->FindI("pkgProblemResolver::Scores::Recommends",1);
576 signed short AddProtected
= _config
->FindI("pkgProblemResolver::Scores::AddProtected",10000);
577 signed short AddEssential
= _config
->FindI("pkgProblemResolver::Scores::AddEssential",5000);
579 if (_config
->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
580 clog
<< "Settings used to calculate pkgProblemResolver::Scores::" << endl
581 << " Important => " << PrioMap
[1] << endl
582 << " Required => " << PrioMap
[2] << endl
583 << " Standard => " << PrioMap
[3] << endl
584 << " Optional => " << PrioMap
[4] << endl
585 << " Extra => " << PrioMap
[5] << endl
586 << " Essentials => " << PrioEssentials
<< endl
587 << " InstalledAndNotObsolete => " << PrioInstalledAndNotObsolete
<< endl
588 << " Depends => " << PrioDepends
<< endl
589 << " Recommends => " << PrioRecommends
<< endl
590 << " AddProtected => " << AddProtected
<< endl
591 << " AddEssential => " << AddEssential
<< endl
;
593 // Generate the base scores for a package based on its properties
594 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
596 if (Cache
[I
].InstallVer
== 0)
599 signed short &Score
= Scores
[I
->ID
];
601 /* This is arbitrary, it should be high enough to elevate an
602 essantial package above most other packages but low enough
603 to allow an obsolete essential packages to be removed by
604 a conflicts on a powerfull normal package (ie libc6) */
605 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
606 Score
+= PrioEssentials
;
608 // We transform the priority
609 if (Cache
[I
].InstVerIter(Cache
)->Priority
<= 5)
610 Score
+= PrioMap
[Cache
[I
].InstVerIter(Cache
)->Priority
];
612 /* This helps to fix oddball problems with conflicting packages
613 on the same level. We enhance the score of installed packages
614 if those are not obsolete
616 if (I
->CurrentVer
!= 0 && Cache
[I
].CandidateVer
!= 0 && Cache
[I
].CandidateVerIter(Cache
).Downloadable())
617 Score
+= PrioInstalledAndNotObsolete
;
620 // Now that we have the base scores we go and propogate dependencies
621 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
623 if (Cache
[I
].InstallVer
== 0)
626 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList(); D
.end() == false; D
++)
628 if (D
->Type
== pkgCache::Dep::Depends
||
629 D
->Type
== pkgCache::Dep::PreDepends
)
630 Scores
[D
.TargetPkg()->ID
] += PrioDepends
;
631 else if (D
->Type
== pkgCache::Dep::Recommends
)
632 Scores
[D
.TargetPkg()->ID
] += PrioRecommends
;
636 // Copy the scores to advoid additive looping
637 SPtrArray
<signed short> OldScores
= new signed short[Size
];
638 memcpy(OldScores
,Scores
,sizeof(*Scores
)*Size
);
640 /* Now we cause 1 level of dependency inheritance, that is we add the
641 score of the packages that depend on the target Package. This
642 fortifies high scoring packages */
643 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
645 if (Cache
[I
].InstallVer
== 0)
648 for (pkgCache::DepIterator D
= I
.RevDependsList(); D
.end() == false; D
++)
650 // Only do it for the install version
651 if ((pkgCache::Version
*)D
.ParentVer() != Cache
[D
.ParentPkg()].InstallVer
||
652 (D
->Type
!= pkgCache::Dep::Depends
&&
653 D
->Type
!= pkgCache::Dep::PreDepends
&&
654 D
->Type
!= pkgCache::Dep::Recommends
))
657 Scores
[I
->ID
] += abs(OldScores
[D
.ParentPkg()->ID
]);
661 /* Now we propogate along provides. This makes the packages that
662 provide important packages extremely important */
663 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
665 for (pkgCache::PrvIterator P
= I
.ProvidesList(); P
.end() == false; P
++)
667 // Only do it once per package
668 if ((pkgCache::Version
*)P
.OwnerVer() != Cache
[P
.OwnerPkg()].InstallVer
)
670 Scores
[P
.OwnerPkg()->ID
] += abs(Scores
[I
->ID
] - OldScores
[I
->ID
]);
674 /* Protected things are pushed really high up. This number should put them
675 ahead of everything */
676 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
678 if ((Flags
[I
->ID
] & Protected
) != 0)
679 Scores
[I
->ID
] += AddProtected
;
680 if ((I
->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
681 Scores
[I
->ID
] += AddEssential
;
685 // ProblemResolver::DoUpgrade - Attempt to upgrade this package /*{{{*/
686 // ---------------------------------------------------------------------
687 /* This goes through and tries to reinstall packages to make this package
689 bool pkgProblemResolver::DoUpgrade(pkgCache::PkgIterator Pkg
)
691 pkgDepCache::ActionGroup
group(Cache
);
693 if ((Flags
[Pkg
->ID
] & Upgradable
) == 0 || Cache
[Pkg
].Upgradable() == false)
695 if ((Flags
[Pkg
->ID
] & Protected
) == Protected
)
698 Flags
[Pkg
->ID
] &= ~Upgradable
;
700 bool WasKept
= Cache
[Pkg
].Keep();
701 Cache
.MarkInstall(Pkg
, false, 0, false);
703 // This must be a virtual package or something like that.
704 if (Cache
[Pkg
].InstVerIter(Cache
).end() == true)
707 // Isolate the problem dependency
709 for (pkgCache::DepIterator D
= Cache
[Pkg
].InstVerIter(Cache
).DependsList(); D
.end() == false;)
711 // Compute a single dependency element (glob or)
712 pkgCache::DepIterator Start
= D
;
713 pkgCache::DepIterator End
= D
;
714 unsigned char State
= 0;
715 for (bool LastOR
= true; D
.end() == false && LastOR
== true;)
718 LastOR
= (D
->CompareOp
& pkgCache::Dep::Or
) == pkgCache::Dep::Or
;
724 // We only worry about critical deps.
725 if (End
.IsCritical() != true)
728 // Iterate over all the members in the or group
732 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
735 // Do not change protected packages
736 PkgIterator P
= Start
.SmartTargetPkg();
737 if ((Flags
[P
->ID
] & Protected
) == Protected
)
740 clog
<< " Reinst Failed because of protected " << P
.FullName(false) << endl
;
745 // Upgrade the package if the candidate version will fix the problem.
746 if ((Cache
[Start
] & pkgDepCache::DepCVer
) == pkgDepCache::DepCVer
)
748 if (DoUpgrade(P
) == false)
751 clog
<< " Reinst Failed because of " << P
.FullName(false) << endl
;
762 /* We let the algorithm deal with conflicts on its next iteration,
763 it is much smarter than us */
764 if (Start
->Type
== pkgCache::Dep::Conflicts
||
765 Start
->Type
== pkgCache::Dep::DpkgBreaks
||
766 Start
->Type
== pkgCache::Dep::Obsoletes
)
770 clog
<< " Reinst Failed early because of " << Start
.TargetPkg().FullName(false) << endl
;
783 // Undo our operations - it might be smart to undo everything this did..
787 Cache
.MarkKeep(Pkg
, false, false);
789 Cache
.MarkDelete(Pkg
);
794 clog
<< " Re-Instated " << Pkg
.FullName(false) << endl
;
798 // ProblemResolver::Resolve - Run the resolution pass /*{{{*/
799 // ---------------------------------------------------------------------
800 /* This routines works by calculating a score for each package. The score
801 is derived by considering the package's priority and all reverse
802 dependents giving an integer that reflects the amount of breakage that
803 adjusting the package will inflict.
805 It goes from highest score to lowest and corrects all of the breaks by
806 keeping or removing the dependant packages. If that fails then it removes
807 the package itself and goes on. The routine should be able to intelligently
808 go from any broken state to a fixed state.
810 The BrokenFix flag enables a mode where the algorithm tries to
811 upgrade packages to advoid problems. */
812 bool pkgProblemResolver::Resolve(bool BrokenFix
)
814 pkgDepCache::ActionGroup
group(Cache
);
816 unsigned long Size
= Cache
.Head().PackageCount
;
818 // Record which packages are marked for install
823 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
825 if (Cache
[I
].Install() == true)
826 Flags
[I
->ID
] |= PreInstalled
;
829 if (Cache
[I
].InstBroken() == true && BrokenFix
== true)
831 Cache
.MarkInstall(I
, false, 0, false);
832 if (Cache
[I
].Install() == true)
836 Flags
[I
->ID
] &= ~PreInstalled
;
838 Flags
[I
->ID
] |= Upgradable
;
841 while (Again
== true);
844 clog
<< "Starting" << endl
;
848 /* We have to order the packages so that the broken fixing pass
849 operates from highest score to lowest. This prevents problems when
850 high score packages cause the removal of lower score packages that
851 would cause the removal of even lower score packages. */
852 SPtrArray
<pkgCache::Package
*> PList
= new pkgCache::Package
*[Size
];
853 pkgCache::Package
**PEnd
= PList
;
854 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
857 qsort(PList
,PEnd
- PList
,sizeof(*PList
),&ScoreSort
);
859 if (_config
->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
861 clog
<< "Show Scores" << endl
;
862 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
863 if (Scores
[(*K
)->ID
] != 0)
865 pkgCache::PkgIterator
Pkg(Cache
,*K
);
866 clog
<< Scores
[(*K
)->ID
] << ' ' << Pkg
<< std::endl
;
871 clog
<< "Starting 2" << endl
;
873 /* Now consider all broken packages. For each broken package we either
874 remove the package or fix it's problem. We do this once, it should
875 not be possible for a loop to form (that is a < b < c and fixing b by
876 changing a breaks c) */
878 bool const TryFixByInstall
= _config
->FindB("pkgProblemResolver::FixByInstall", true);
879 for (int Counter
= 0; Counter
!= 10 && Change
== true; Counter
++)
882 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
884 pkgCache::PkgIterator
I(Cache
,*K
);
886 /* We attempt to install this and see if any breaks result,
887 this takes care of some strange cases */
888 if (Cache
[I
].CandidateVer
!= Cache
[I
].InstallVer
&&
889 I
->CurrentVer
!= 0 && Cache
[I
].InstallVer
!= 0 &&
890 (Flags
[I
->ID
] & PreInstalled
) != 0 &&
891 (Flags
[I
->ID
] & Protected
) == 0 &&
892 (Flags
[I
->ID
] & ReInstateTried
) == 0)
895 clog
<< " Try to Re-Instate (" << Counter
<< ") " << I
.FullName(false) << endl
;
896 unsigned long OldBreaks
= Cache
.BrokenCount();
897 pkgCache::Version
*OldVer
= Cache
[I
].InstallVer
;
898 Flags
[I
->ID
] &= ReInstateTried
;
900 Cache
.MarkInstall(I
, false, 0, false);
901 if (Cache
[I
].InstBroken() == true ||
902 OldBreaks
< Cache
.BrokenCount())
907 Cache
.MarkKeep(I
, false, false);
911 clog
<< "Re-Instated " << I
.FullName(false) << " (" << OldBreaks
<< " vs " << Cache
.BrokenCount() << ')' << endl
;
914 if (Cache
[I
].InstallVer
== 0 || Cache
[I
].InstBroken() == false)
918 clog
<< "Investigating (" << Counter
<< ") " << I
<< endl
;
920 // Isolate the problem dependency
921 PackageKill KillList
[100];
922 PackageKill
*LEnd
= KillList
;
924 pkgCache::DepIterator Start
;
925 pkgCache::DepIterator End
;
926 PackageKill
*OldEnd
= LEnd
;
928 enum {OrRemove
,OrKeep
} OrOp
= OrRemove
;
929 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList();
930 D
.end() == false || InOr
== true;)
932 // Compute a single dependency element (glob or)
936 if (InOr
== true && OldEnd
== LEnd
)
938 if (OrOp
== OrRemove
)
940 if ((Flags
[I
->ID
] & Protected
) != Protected
)
943 clog
<< " Or group remove for " << I
.FullName(false) << endl
;
948 else if (OrOp
== OrKeep
)
951 clog
<< " Or group keep for " << I
.FullName(false) << endl
;
952 Cache
.MarkKeep(I
, false, false);
957 /* We do an extra loop (as above) to finalize the or group
962 if (Start
.end() == true)
965 // We only worry about critical deps.
966 if (End
.IsCritical() != true)
975 // We only worry about critical deps.
976 if (Start
.IsCritical() != true)
981 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
988 clog
<< "Broken " << Start
<< endl
;
990 /* Look across the version list. If there are no possible
991 targets then we keep the package and bail. This is necessary
992 if a package has a dep on another package that cant be found */
993 SPtrArray
<pkgCache::Version
*> VList
= Start
.AllTargets();
994 if (*VList
== 0 && (Flags
[I
->ID
] & Protected
) != Protected
&&
995 Start
->Type
!= pkgCache::Dep::Conflicts
&&
996 Start
->Type
!= pkgCache::Dep::DpkgBreaks
&&
997 Start
->Type
!= pkgCache::Dep::Obsoletes
&&
998 Cache
[I
].NowBroken() == false)
1002 /* No keep choice because the keep being OK could be the
1003 result of another element in the OR group! */
1008 Cache
.MarkKeep(I
, false, false);
1013 for (pkgCache::Version
**V
= VList
; *V
!= 0; V
++)
1015 pkgCache::VerIterator
Ver(Cache
,*V
);
1016 pkgCache::PkgIterator Pkg
= Ver
.ParentPkg();
1018 /* This is a conflicts, and the version we are looking
1019 at is not the currently selected version of the
1020 package, which means it is not necessary to
1022 if (Cache
[Pkg
].InstallVer
!= Ver
&&
1023 (Start
->Type
== pkgCache::Dep::Conflicts
||
1024 Start
->Type
== pkgCache::Dep::DpkgBreaks
||
1025 Start
->Type
== pkgCache::Dep::Obsoletes
))
1028 clog
<< " Conflicts//Breaks against version "
1029 << Ver
.VerStr() << " for " << Pkg
.Name()
1030 << " but that is not InstVer, ignoring"
1036 clog
<< " Considering " << Pkg
.FullName(false) << ' ' << (int)Scores
[Pkg
->ID
] <<
1037 " as a solution to " << I
.FullName(false) << ' ' << (int)Scores
[I
->ID
] << endl
;
1039 /* Try to fix the package under consideration rather than
1040 fiddle with the VList package */
1041 if (Scores
[I
->ID
] <= Scores
[Pkg
->ID
] ||
1042 ((Cache
[Start
] & pkgDepCache::DepNow
) == 0 &&
1043 End
->Type
!= pkgCache::Dep::Conflicts
&&
1044 End
->Type
!= pkgCache::Dep::DpkgBreaks
&&
1045 End
->Type
!= pkgCache::Dep::Obsoletes
))
1047 // Try a little harder to fix protected packages..
1048 if ((Flags
[I
->ID
] & Protected
) == Protected
)
1050 if (DoUpgrade(Pkg
) == true)
1052 if (Scores
[Pkg
->ID
] > Scores
[I
->ID
])
1053 Scores
[Pkg
->ID
] = Scores
[I
->ID
];
1060 /* See if a keep will do, unless the package is protected,
1061 then installing it will be necessary */
1062 bool Installed
= Cache
[I
].Install();
1063 Cache
.MarkKeep(I
, false, false);
1064 if (Cache
[I
].InstBroken() == false)
1066 // Unwind operation will be keep now
1067 if (OrOp
== OrRemove
)
1071 if (InOr
== true && Installed
== true)
1072 Cache
.MarkInstall(I
, false, 0, false);
1075 clog
<< " Holding Back " << I
.FullName(false) << " rather than change " << Start
.TargetPkg().FullName(false) << endl
;
1079 if (BrokenFix
== false || DoUpgrade(I
) == false)
1081 // Consider other options
1085 clog
<< " Removing " << I
.FullName(false) << " rather than change " << Start
.TargetPkg().FullName(false) << endl
;
1086 Cache
.MarkDelete(I
);
1087 if (Counter
> 1 && Scores
[Pkg
->ID
] > Scores
[I
->ID
])
1088 Scores
[I
->ID
] = Scores
[Pkg
->ID
];
1090 else if (TryFixByInstall
== true &&
1091 Start
.TargetPkg()->CurrentVer
== 0 &&
1092 Cache
[Start
.TargetPkg()].Delete() == false &&
1093 (Flags
[Start
.TargetPkg()->ID
] & ToRemove
) != ToRemove
&&
1094 Cache
.GetCandidateVer(Start
.TargetPkg()).end() == false)
1096 /* Before removing or keeping the package with the broken dependency
1097 try instead to install the first not previously installed package
1098 solving this dependency. This helps every time a previous solver
1099 is removed by the resolver because of a conflict or alike but it is
1100 dangerous as it could trigger new breaks/conflicts… */
1102 clog
<< " Try Installing " << Start
.TargetPkg() << " before changing " << I
.FullName(false) << std::endl
;
1103 unsigned long const OldBroken
= Cache
.BrokenCount();
1104 Cache
.MarkInstall(Start
.TargetPkg(), true, 1, false);
1105 // FIXME: we should undo the complete MarkInstall process here
1106 if (Cache
[Start
.TargetPkg()].InstBroken() == true || Cache
.BrokenCount() > OldBroken
)
1107 Cache
.MarkDelete(Start
.TargetPkg(), false, 1, false);
1118 if (Start
->Type
== pkgCache::Dep::DpkgBreaks
)
1120 // first, try upgradring the package, if that
1121 // does not help, the breaks goes onto the
1124 // FIXME: use DoUpgrade(Pkg) instead?
1125 if (Cache
[End
] & pkgDepCache::DepGCVer
)
1128 clog
<< " Upgrading " << Pkg
.FullName(false) << " due to Breaks field in " << I
.FullName(false) << endl
;
1129 Cache
.MarkInstall(Pkg
, false, 0, false);
1134 // Skip adding to the kill list if it is protected
1135 if ((Flags
[Pkg
->ID
] & Protected
) != 0)
1139 clog
<< " Added " << Pkg
.FullName(false) << " to the remove list" << endl
;
1145 if (Start
->Type
!= pkgCache::Dep::Conflicts
&&
1146 Start
->Type
!= pkgCache::Dep::Obsoletes
)
1151 // Hm, nothing can possibly satisify this dep. Nuke it.
1152 if (VList
[0] == 0 &&
1153 Start
->Type
!= pkgCache::Dep::Conflicts
&&
1154 Start
->Type
!= pkgCache::Dep::DpkgBreaks
&&
1155 Start
->Type
!= pkgCache::Dep::Obsoletes
&&
1156 (Flags
[I
->ID
] & Protected
) != Protected
)
1158 bool Installed
= Cache
[I
].Install();
1160 if (Cache
[I
].InstBroken() == false)
1162 // Unwind operation will be keep now
1163 if (OrOp
== OrRemove
)
1167 if (InOr
== true && Installed
== true)
1168 Cache
.MarkInstall(I
, false, 0, false);
1171 clog
<< " Holding Back " << I
.FullName(false) << " because I can't find " << Start
.TargetPkg().FullName(false) << endl
;
1176 clog
<< " Removing " << I
.FullName(false) << " because I can't find " << Start
.TargetPkg().FullName(false) << endl
;
1178 Cache
.MarkDelete(I
);
1193 // Apply the kill list now
1194 if (Cache
[I
].InstallVer
!= 0)
1196 for (PackageKill
*J
= KillList
; J
!= LEnd
; J
++)
1199 if ((Cache
[J
->Dep
] & pkgDepCache::DepGNow
) == 0)
1201 if (J
->Dep
->Type
== pkgCache::Dep::Conflicts
||
1202 J
->Dep
->Type
== pkgCache::Dep::DpkgBreaks
||
1203 J
->Dep
->Type
== pkgCache::Dep::Obsoletes
)
1206 clog
<< " Fixing " << I
.FullName(false) << " via remove of " << J
->Pkg
.FullName(false) << endl
;
1207 Cache
.MarkDelete(J
->Pkg
);
1213 clog
<< " Fixing " << I
.FullName(false) << " via keep of " << J
->Pkg
.FullName(false) << endl
;
1214 Cache
.MarkKeep(J
->Pkg
, false, false);
1219 if (Scores
[I
->ID
] > Scores
[J
->Pkg
->ID
])
1220 Scores
[J
->Pkg
->ID
] = Scores
[I
->ID
];
1228 clog
<< "Done" << endl
;
1230 if (Cache
.BrokenCount() != 0)
1232 // See if this is the result of a hold
1233 pkgCache::PkgIterator I
= Cache
.PkgBegin();
1234 for (;I
.end() != true; I
++)
1236 if (Cache
[I
].InstBroken() == false)
1238 if ((Flags
[I
->ID
] & Protected
) != Protected
)
1239 return _error
->Error(_("Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages."));
1241 return _error
->Error(_("Unable to correct problems, you have held broken packages."));
1244 // set the auto-flags (mvo: I'm not sure if we _really_ need this)
1245 pkgCache::PkgIterator I
= Cache
.PkgBegin();
1246 for (;I
.end() != true; I
++) {
1247 if (Cache
[I
].NewInstall() && !(Flags
[I
->ID
] & PreInstalled
)) {
1248 if(_config
->FindI("Debug::pkgAutoRemove",false)) {
1249 std::clog
<< "Resolve installed new pkg: " << I
.FullName(false)
1250 << " (now marking it as auto)" << std::endl
;
1252 Cache
[I
].Flags
|= pkgCache::Flag::Auto
;
1260 // ProblemResolver::ResolveByKeep - Resolve problems using keep /*{{{*/
1261 // ---------------------------------------------------------------------
1262 /* This is the work horse of the soft upgrade routine. It is very gental
1263 in that it does not install or remove any packages. It is assumed that the
1264 system was non-broken previously. */
1265 bool pkgProblemResolver::ResolveByKeep()
1267 pkgDepCache::ActionGroup
group(Cache
);
1269 unsigned long Size
= Cache
.Head().PackageCount
;
1273 /* We have to order the packages so that the broken fixing pass
1274 operates from highest score to lowest. This prevents problems when
1275 high score packages cause the removal of lower score packages that
1276 would cause the removal of even lower score packages. */
1277 pkgCache::Package
**PList
= new pkgCache::Package
*[Size
];
1278 pkgCache::Package
**PEnd
= PList
;
1279 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
1282 qsort(PList
,PEnd
- PList
,sizeof(*PList
),&ScoreSort
);
1284 if (_config
->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
1286 clog
<< "Show Scores" << endl
;
1287 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
1288 if (Scores
[(*K
)->ID
] != 0)
1290 pkgCache::PkgIterator
Pkg(Cache
,*K
);
1291 clog
<< Scores
[(*K
)->ID
] << ' ' << Pkg
<< std::endl
;
1296 clog
<< "Entering ResolveByKeep" << endl
;
1298 // Consider each broken package
1299 pkgCache::Package
**LastStop
= 0;
1300 for (pkgCache::Package
**K
= PList
; K
!= PEnd
; K
++)
1302 pkgCache::PkgIterator
I(Cache
,*K
);
1304 if (Cache
[I
].InstallVer
== 0 || Cache
[I
].InstBroken() == false)
1307 /* Keep the package. If this works then great, otherwise we have
1308 to be significantly more agressive and manipulate its dependencies */
1309 if ((Flags
[I
->ID
] & Protected
) == 0)
1312 clog
<< "Keeping package " << I
.FullName(false) << endl
;
1313 Cache
.MarkKeep(I
, false, false);
1314 if (Cache
[I
].InstBroken() == false)
1321 // Isolate the problem dependencies
1322 for (pkgCache::DepIterator D
= Cache
[I
].InstVerIter(Cache
).DependsList(); D
.end() == false;)
1326 D
.GlobOr(Start
,End
);
1328 // We only worry about critical deps.
1329 if (End
.IsCritical() != true)
1333 if ((Cache
[End
] & pkgDepCache::DepGInstall
) == pkgDepCache::DepGInstall
)
1336 /* Hm, the group is broken.. I suppose the best thing to do is to
1337 is to try every combination of keep/not-keep for the set, but thats
1338 slow, and this never happens, just be conservative and assume the
1339 list of ors is in preference and keep till it starts to work. */
1343 clog
<< "Package " << I
.FullName(false) << " " << Start
<< endl
;
1345 // Look at all the possible provides on this package
1346 SPtrArray
<pkgCache::Version
*> VList
= Start
.AllTargets();
1347 for (pkgCache::Version
**V
= VList
; *V
!= 0; V
++)
1349 pkgCache::VerIterator
Ver(Cache
,*V
);
1350 pkgCache::PkgIterator Pkg
= Ver
.ParentPkg();
1352 // It is not keepable
1353 if (Cache
[Pkg
].InstallVer
== 0 ||
1354 Pkg
->CurrentVer
== 0)
1357 if ((Flags
[I
->ID
] & Protected
) == 0)
1360 clog
<< " Keeping Package " << Pkg
.FullName(false) << " due to " << Start
.DepType() << endl
;
1361 Cache
.MarkKeep(Pkg
, false, false);
1364 if (Cache
[I
].InstBroken() == false)
1368 if (Cache
[I
].InstBroken() == false)
1376 if (Cache
[I
].InstBroken() == false)
1380 if (Cache
[I
].InstBroken() == true)
1385 return _error
->Error("Internal Error, pkgProblemResolver::ResolveByKeep is looping on package %s.",I
.FullName(false).c_str());
1393 // ProblemResolver::InstallProtect - Install all protected packages /*{{{*/
1394 // ---------------------------------------------------------------------
1395 /* This is used to make sure protected packages are installed */
1396 void pkgProblemResolver::InstallProtect()
1398 pkgDepCache::ActionGroup
group(Cache
);
1400 for (pkgCache::PkgIterator I
= Cache
.PkgBegin(); I
.end() == false; I
++)
1402 if ((Flags
[I
->ID
] & Protected
) == Protected
)
1404 if ((Flags
[I
->ID
] & ToRemove
) == ToRemove
)
1405 Cache
.MarkDelete(I
);
1408 // preserve the information whether the package was auto
1409 // or manually installed
1410 bool autoInst
= (Cache
[I
].Flags
& pkgCache::Flag::Auto
);
1411 Cache
.MarkInstall(I
, false, 0, !autoInst
);
1417 // PrioSortList - Sort a list of versions by priority /*{{{*/
1418 // ---------------------------------------------------------------------
1419 /* This is ment to be used in conjunction with AllTargets to get a list
1420 of versions ordered by preference. */
1421 static pkgCache
*PrioCache
;
1422 static int PrioComp(const void *A
,const void *B
)
1424 pkgCache::VerIterator
L(*PrioCache
,*(pkgCache::Version
**)A
);
1425 pkgCache::VerIterator
R(*PrioCache
,*(pkgCache::Version
**)B
);
1427 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
&&
1428 (R
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) != pkgCache::Flag::Essential
)
1430 if ((L
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) != pkgCache::Flag::Essential
&&
1431 (R
.ParentPkg()->Flags
& pkgCache::Flag::Essential
) == pkgCache::Flag::Essential
)
1434 if (L
->Priority
!= R
->Priority
)
1435 return R
->Priority
- L
->Priority
;
1436 return strcmp(L
.ParentPkg().Name(),R
.ParentPkg().Name());
1438 void pkgPrioSortList(pkgCache
&Cache
,pkgCache::Version
**List
)
1440 unsigned long Count
= 0;
1442 for (pkgCache::Version
**I
= List
; *I
!= 0; I
++)
1444 qsort(List
,Count
,sizeof(*List
),PrioComp
);
1447 // CacheFile::ListUpdate - update the cache files /*{{{*/
1448 // ---------------------------------------------------------------------
1449 /* This is a simple wrapper to update the cache. it will fetch stuff
1450 * from the network (or any other sources defined in sources.list)
1452 bool ListUpdate(pkgAcquireStatus
&Stat
,
1453 pkgSourceList
&List
,
1456 pkgAcquire::RunResult res
;
1458 if (Fetcher
.Setup(&Stat
, _config
->FindDir("Dir::State::Lists")) == false)
1461 // Populate it with the source selection
1462 if (List
.GetIndexes(&Fetcher
) == false)
1466 RunScripts("APT::Update::Pre-Invoke");
1470 res
= Fetcher
.Run(PulseInterval
);
1472 res
= Fetcher
.Run();
1474 if (res
== pkgAcquire::Failed
)
1477 bool Failed
= false;
1478 bool TransientNetworkFailure
= false;
1479 for (pkgAcquire::ItemIterator I
= Fetcher
.ItemsBegin();
1480 I
!= Fetcher
.ItemsEnd(); I
++)
1482 if ((*I
)->Status
== pkgAcquire::Item::StatDone
)
1487 ::URI
uri((*I
)->DescURI());
1489 uri
.Password
.clear();
1490 string descUri
= string(uri
);
1491 _error
->Warning(_("Failed to fetch %s %s\n"), descUri
.c_str(),
1492 (*I
)->ErrorText
.c_str());
1494 if ((*I
)->Status
== pkgAcquire::Item::StatTransientNetworkError
)
1496 TransientNetworkFailure
= true;
1503 // Clean out any old list files
1504 // Keep "APT::Get::List-Cleanup" name for compatibility, but
1505 // this is really a global option for the APT library now
1506 if (!TransientNetworkFailure
&& !Failed
&&
1507 (_config
->FindB("APT::Get::List-Cleanup",true) == true &&
1508 _config
->FindB("APT::List-Cleanup",true) == true))
1510 if (Fetcher
.Clean(_config
->FindDir("Dir::State::lists")) == false ||
1511 Fetcher
.Clean(_config
->FindDir("Dir::State::lists") + "partial/") == false)
1512 // something went wrong with the clean
1516 if (TransientNetworkFailure
== true)
1517 _error
->Warning(_("Some index files failed to download. They have been ignored, or old ones used instead."));
1518 else if (Failed
== true)
1519 return _error
->Error(_("Some index files failed to download. They have been ignored, or old ones used instead."));
1522 // Run the success scripts if all was fine
1523 if(!TransientNetworkFailure
&& !Failed
)
1524 RunScripts("APT::Update::Post-Invoke-Success");
1526 // Run the other scripts
1527 RunScripts("APT::Update::Post-Invoke");