Stefan Csomor [Tue, 7 Sep 2010 06:51:13 +0000 (06:51 +0000)]
modeling subclassing along msw, unsubclassing filedialog at end of ShowModal, fixes #12236
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65474
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Mon, 6 Sep 2010 13:50:12 +0000 (13:50 +0000)]
using non-sleep version for GUI mutex, solves #12411
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65473
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Steve Lamerton [Sun, 5 Sep 2010 13:31:13 +0000 (13:31 +0000)]
Simplify ButtonTestCase::Bitmap. The old test was not correct as it tested all bitmaps to see if they were valid, however these do not get set by SetBitmap and so the tests only passed if the platform set valid defaults.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65472
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Steve Lamerton [Sun, 5 Sep 2010 13:14:14 +0000 (13:14 +0000)]
Fix typo from previous commit.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65471
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Steve Lamerton [Sun, 5 Sep 2010 13:11:42 +0000 (13:11 +0000)]
Move the second wxListBox sort test back to the ownerdrawn section and re-enable it under wxGTK.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65470
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Steve Lamerton [Sun, 5 Sep 2010 12:47:46 +0000 (12:47 +0000)]
Wrap BitmapToggleButtonTestCase in a preprocessor check so compilation shouldn't fail on platforms that don't support it.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65469
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 4 Sep 2010 13:33:40 +0000 (13:33 +0000)]
Remove unused wxProgressDialogTaskRunner::m_parent field.
This seems to be a left over from old version of the code and is not used any
longer.
See #12414.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65468
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 4 Sep 2010 13:33:36 +0000 (13:33 +0000)]
Fix crash in wxMSW wxProgressDialog without wxPD_APP_MODAL style.
Use the correct method to retrieve the parent window to disable and check that
this pointer is not NULL before dereferencing it.
Closes #12414.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65467
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 4 Sep 2010 13:33:29 +0000 (13:33 +0000)]
Improve main and extended messages handling in new wxMSW wxMessageDialog.
Don't use the main message if there is no extended message: this looks bad as
the main message is emphasized to contrast with the extended one which doesn't
make sense visually if there is no extended message.
Also recognize the common use of wxMessageBox() with a multiline text composed
of the first string that plays the role of the main message with the rest
being the extended one and handle this appropriately automatically. This
results in a better appearance by default for a lot of message boxes,
including even the one in our own minimal sample.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65466
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 4 Sep 2010 09:36:25 +0000 (09:36 +0000)]
Add a link to Microsoft guidelines from wxICON_QUESTION documentation.
Microsoft documentation provides explanations as to how the icons should be
used in the message dialogs which can be useful for people wondering which
icon style to use an when.
See #12417.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65465
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 3 Sep 2010 22:48:44 +0000 (22:48 +0000)]
Don't link with long obsolete ctl3d32 library when using MinGW.
ctl3d32 was used for Win16 development and is not used by wxMSW since many
years, don't link with it unnecessarily when using MinGW.
Also remove a FIXME comment about an issue which doesn't seem to need any
fixing.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65464
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Fri, 3 Sep 2010 19:33:18 +0000 (19:33 +0000)]
Fix wxOwnerDrawnComboBox keyboard navigation with duplicate items.
If the combobox contained duplicate strings (i.e. multiple items with the
same string value, but differing indexes), then navigating to the second
and subsequent ones skipped to the first occurence instead. We need to
preserve the index.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65463
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Fri, 3 Sep 2010 19:33:11 +0000 (19:33 +0000)]
Fixed wxscintilla compilation for wxDFB.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65462
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Steve Lamerton [Wed, 1 Sep 2010 15:25:01 +0000 (15:25 +0000)]
Fix compilation under MinGW, also add missing SVN properties.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65457
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Wed, 1 Sep 2010 14:48:54 +0000 (14:48 +0000)]
wxRichTextCtrl::ApplyStyle now applies a paragraph style at the cursor
without needing a selection, and setting the default style now avoids duplicating
character attributes in subsequently typed text when they exist in the paragraph style.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65456
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Wed, 1 Sep 2010 13:28:43 +0000 (13:28 +0000)]
Reduce flicker when removing wxNotebook page.
wxMSW implementation hides all pages except the selected one. But when
removing selected page from the control, this invariant is temporarily
broken and this results in visible flicker. Hiding the page as soon as
it gets removed fixes it.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65454
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 1 Sep 2010 09:48:24 +0000 (09:48 +0000)]
Update wx_dll.dsw to include the ribbon library.
Add wx_ribbon project with dependency on core library.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65453
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 30 Aug 2010 22:18:52 +0000 (22:18 +0000)]
Add wxGrid::RefreshAttr() method to force attribute refresh.
A cached attribute may continue to be used even though the attribute returned
by a custom wxGridCellAttrProvider has changed so add a method to force wxGrid
to update the attribute by forgetting the cached copy.
Closes #12406.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65451
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 30 Aug 2010 21:48:25 +0000 (21:48 +0000)]
Don't center wxGenericMessageDialog elements.
Centering doesn't seem to be appropriate on neither of the major platforms and
makes wxGenericMessageDialog and wxGenericRichMessageDialog which uses it look
even less native than otherwise.
Simply don't do it neither for the text nor, especially, for the buttons where
wxStdDialogButtonSizer already exists to take care of their alignment.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65450
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 30 Aug 2010 21:48:21 +0000 (21:48 +0000)]
Allow using custom labels for wxGenericMessageDialog buttons.
Custom labels set for wxGenericMessageDialog buttons were simply ignored as it
used CreateSeparatedButtonSizer() to create the actual buttons which in turn
always used the standard labels.
Fix this by explicitly creating the buttons with custom labels if necessary.
This also fixes custom label support in wxGenericRichMessageDialog deriving
from this class.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65449
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 30 Aug 2010 21:48:16 +0000 (21:48 +0000)]
Extract CreateSeparatedSizer() from wxDialog::CreateSeparatedButtonSizer().
Extract the code adding a separating wxStaticLine to the sizer in its own
function to be able to reuse it in upcoming commits.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65448
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 30 Aug 2010 21:48:11 +0000 (21:48 +0000)]
Fix button order in wxStdDialogButtonSizer in all cases under GTK.
The order of Yes/No/Cancel was recently fixed by the changes in r65346 but it
broke the order of the buttons in Ok/Cancel case. Ensure the correct order is
used in all cases now: the one described by GNOME HIG by default but different
order for the special case of Yes/No/Cancel which follows the native message
box.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65447
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 30 Aug 2010 21:48:06 +0000 (21:48 +0000)]
Rewrite GTK section of wxStdDialogButtonSizer using wxSizerFlags.
Using wxSizerFlags makes the code shorter and more understandable but
otherwise there are no real changes in behaviour except for a minor fix to one
of the border which was wrong before.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65446
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Mon, 30 Aug 2010 11:27:42 +0000 (11:27 +0000)]
Fixed wrong line spacing calculation
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65444
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Mon, 30 Aug 2010 08:47:23 +0000 (08:47 +0000)]
Don't add space before para twice in paragraph layout
Discard attributes from empty text object when merging
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65442
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Sun, 29 Aug 2010 12:24:44 +0000 (12:24 +0000)]
include wx/sizer.h as buildbot complained
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65437
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Sun, 29 Aug 2010 09:42:55 +0000 (09:42 +0000)]
Add possibility to use sizers in ribbon panel, fixes #12404: wxRibbonPanel and wxSizer
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65436
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Sat, 28 Aug 2010 17:05:02 +0000 (17:05 +0000)]
Scale sizes more accurately in generic SetWindowVariant().
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65435
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jaakko Salli [Thu, 26 Aug 2010 13:51:45 +0000 (13:51 +0000)]
Changed wxArrayStringProperty default delimiter to comma. It should allow for better looking and more easily editable property values for common cases.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65424
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jaakko Salli [Thu, 26 Aug 2010 13:25:07 +0000 (13:25 +0000)]
Added missing wx/defs.h includes in propgrid headers
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65423
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jouk Jansen [Thu, 26 Aug 2010 06:53:51 +0000 (06:53 +0000)]
correcting wxX11 for wxkeysym as was done for wxMOTIF
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65422
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Václav Slavík [Wed, 25 Aug 2010 15:02:30 +0000 (15:02 +0000)]
Fix wxListBox selection handling broken by r64500.
r64500 introduced tracking of previous selection in wxMSW's wxListBox so
that an event isn't sent when the user clicks already selected item
again. Unfortunately, it forgot to account for programatic changes of
selection (e.g. when all items are removed, so is the selection) and
didn't update selection book-keeping information in that case. The
result was that the event wasn't sent when it should be in some cases.
Fixed by using UpdateOldSelections() even in single-selection case in
wxMSW.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65406
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Tue, 24 Aug 2010 17:22:12 +0000 (17:22 +0000)]
Reenable sorting tests for GTK
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65400
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Tue, 24 Aug 2010 17:06:15 +0000 (17:06 +0000)]
Make sorting of wxListBox, wxChoice and wxComboBox identical to the MSW sorting
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65399
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 24 Aug 2010 11:36:43 +0000 (11:36 +0000)]
Remove unused wxDisplay implementation using DirectDraw from wxMSW.
Remove commented out version of DirectDraw-based wxDisplayFactory
implementation. It doesn't seem to have any advantages compared to the
currently used version and nobody uses it anyhow.
Closes #12387.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65398
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jouk Jansen [Tue, 24 Aug 2010 11:23:22 +0000 (11:23 +0000)]
wxKeysym problem for wxMOTIF fixed
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65397
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Mon, 23 Aug 2010 18:54:59 +0000 (18:54 +0000)]
Compilation fix: forward declare wxTextEntry in unit tests code.
This should fix tests compilation on the build bot Mac OS X slaves.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65393
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jouk Jansen [Mon, 23 Aug 2010 07:50:00 +0000 (07:50 +0000)]
Update openVMS compile support
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65392
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 23:46:02 +0000 (23:46 +0000)]
Use "C" locale for locale-dependent part of TextCtrlTestCase.
As we expect to get decimal points in the text control when we stream floating
point numbers into it, we must do it in a locale which uses decimal point,
e.g. "C" one. Otherwise the test failed when ran in e.g. French locale.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65390
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 23:45:58 +0000 (23:45 +0000)]
Document that wxFD_FILE_MUST_EXIST is implied under OS X.
Mention in the documentation that the standard file open dialog under OS X
can't be used to select a non-existing file.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65389
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 23:45:53 +0000 (23:45 +0000)]
Remove unused src/osx/cocoa/bmpbuttn.mm file.
This file was empty and unused any more so simply remove it and all references
to it in the makefiles.
This avoids warnings about empty object files in static builds of the library.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65388
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 22:58:25 +0000 (22:58 +0000)]
Don't use uninitialized variable in wxCharCodeWXToOSX().
If an unsupported wxKeyCode was passed to this function, an undefined value
was returned. Return -1 instead to indicate failure.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65387
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 22:16:05 +0000 (22:16 +0000)]
Merge the new GUI tests from SOC2010_GUI_TEST branch.
Add a lot of tests for many wx GUI classes.
Add tests using the new wxUIActionSimulator class but disable them under OS X
as too many of them currently fail there.
Refactor the test suite to make organizing the existing tests and adding the
new ones easier.
Improve documentation using the information gathered while testing the
classes. Also update the documentation of the testing system itself.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65386
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 22:15:42 +0000 (22:15 +0000)]
Merge wxUIActionSimulator fixes from SOC2010_GUI_TEST branch.
Correct a lot of problems with the initial implementation, notably make the
API consistent across all platforms, e.g. all keyboard-related methods now
take just a wxKeyCode.
Add some useful higher-level helpers such as Text() and MouseDragDrop().
Improve documentation.
wxUIActionSimulator now works under MSW, GTK and OS X and is enabled by
default.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65385
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 22:15:32 +0000 (22:15 +0000)]
Fix selection corner cases in wxOSX wxComboBox.
Don't crash in wxComboBox::GetString() if it's passed an invalid index.
Don't call GetString() with invalid index from GetStringSelection() if there
is no selection.
Do accept wxNOT_FOUND in SetSelectedItem() as it means, according to the docs,
that the existing selection should be reset.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65384
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 22:15:27 +0000 (22:15 +0000)]
Don't crash in wxOSX::wxClipboard::Clear() if initialization failed.
Creating the clipboard may fail (e.g. when running from a ssh session to an OS
X machine), don't crash by passing NULL pointer to PasteboardClear() if this
happens but assert and return instead.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65383
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 22:15:22 +0000 (22:15 +0000)]
Work around a crash on starting editing in wxGrid under wxOSX/Cocoa.
wxOSX/Cocoa currently generates unexpected focus loss events with the window
gaining focus being the same one as losing it. This is wrong and shouldn't
happen but as long as it does, filter these events out to at least allow
editing the grid to work.
See #12267.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65382
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 22:15:17 +0000 (22:15 +0000)]
Don't send event from wxMSW::wxListCtrl::DeleteAllItems() if it did nothing.
wxEVT_COMMAND_LIST_DELETE_ALL_ITEMS should only be sent if the control hadn't
been empty before. Document this behaviour and adjust wxMSW to match the
other platforms.
Also document the return value better.
Closes #12336.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65381
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 22:15:13 +0000 (22:15 +0000)]
Extract X11 Display wrapper class in a private header.
No real changes, just extract a private Dpy class used by wxGTK to a header
and rename it to wxX11Display.
This will allow reusing it from X11 wxUIActionSimulator implementation in the
upcoming commits.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65380
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 22 Aug 2010 22:15:07 +0000 (22:15 +0000)]
Add missing header required if wx/mousestate.h is included first.
This header uses wxPoint so it must include wx/gdicmn.h (instead of relying on
it having been already included).
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65379
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sat, 21 Aug 2010 23:33:40 +0000 (23:33 +0000)]
Don't report spurious errors from wxSocket in "no wait" mode.
In wxSOCKET_NOWAIT mode wxSOCKET_WOULDBLOCK is not a real error as it's
expected and should be just discarded. Failing to do this could result in the
following scenario:
1. Try to read a big buffer with wxSOCKET_NOWAIT (setting wxSocket error to
wxSOCKET_WOULDBLOCK).
2. Process small part of it.
3. Read more data from wxSocket -- which now goes to the data containing
already cached data without going to the socket itself and this without
resetting the error.
4. Check wxSocket::Error() which turns out to be (still) true.
And this was exactly what happened in mysteriously failing unit test case
reading wxImage contents from a socket: the failure was difficult to reproduce
because it depended on how much data exactly did we read from the socket in
one go.
Fix this by resetting the error properly and reenable the unit test which was
previously disabled for the build bot, it should pass now.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65378
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Sat, 21 Aug 2010 10:17:13 +0000 (10:17 +0000)]
Allow calling wxGenericDirCtrl::GetPath() in multiple selection mode, fixes #12340 ([wxGenericDirCtrl] conflicts wxDirFilterListCtrl::OnSelFilter())
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65375
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Sat, 21 Aug 2010 09:54:30 +0000 (09:54 +0000)]
make Set/GetLabel() set and return something (albeit unused) as per the docs, fixes #12350: wxWindow Get/SetLabel non-functional in GTK
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65374
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Sat, 21 Aug 2010 09:53:25 +0000 (09:53 +0000)]
make Set/GetLabel() set and return title in wxTLW, fixes #12371: Dialog::GetLabel() Inconsistent behaviour across operating systems
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65373
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Sat, 21 Aug 2010 09:39:09 +0000 (09:39 +0000)]
Fix crash by checking if icon is valid before drawing it, fixes #12376: PATCH for Ribbon crash
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65372
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Sat, 21 Aug 2010 09:36:12 +0000 (09:36 +0000)]
Fix potential crash, fixes #12375: PATCH to fix help controller crash
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65371
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Fri, 20 Aug 2010 20:51:17 +0000 (20:51 +0000)]
Properly implement Cleared() by calling row_deleted on every child of root, fixes #12327: wxDataViewListCtrl Crash
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65370
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 20 Aug 2010 18:13:51 +0000 (18:13 +0000)]
Mention that not all standard IDs are stock IDs.
Also add a link to the list of stock IDs from the standard IDs documentation.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65369
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jouk Jansen [Fri, 20 Aug 2010 15:38:03 +0000 (15:38 +0000)]
include correct private.h for wxgtk1
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65368
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Fri, 20 Aug 2010 15:22:52 +0000 (15:22 +0000)]
Make it compile
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65367
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Thu, 19 Aug 2010 18:29:46 +0000 (18:29 +0000)]
Link to wxRichMessageDialog in some places
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65366
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Thu, 19 Aug 2010 18:17:51 +0000 (18:17 +0000)]
Make it compile a bit more
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65365
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 19 Aug 2010 15:41:24 +0000 (15:41 +0000)]
Slightly improve wx[Generic]RichMessageDialog layout.
Keep the icon at the top instead of centering it, this is more consistent with
the native behaviour under both MSW and GTK.
Get rid of an unnecessary sizer in wxGenericRichMessageDialog and give the
checkbox the right border to align with the rest of the dialog contents.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65364
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 19 Aug 2010 15:41:18 +0000 (15:41 +0000)]
Make the main message of wxGenericMessageDialog stand out.
Use larger bold font for the main message in wxGenericMessageDialog if the
extended message is also given to make it stand out similarly to how it
happens in the native GTK and MSW dialogs.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65363
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Thu, 19 Aug 2010 12:12:59 +0000 (12:12 +0000)]
Better close button placement on tabs, especially for bottom tab alignment
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65362
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jouk Jansen [Thu, 19 Aug 2010 07:13:01 +0000 (07:13 +0000)]
update compile configuration for OpenVMS
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65358
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 19 Aug 2010 00:06:17 +0000 (00:06 +0000)]
Compilation fix for STL build in wxGtkCollatableString code.
Include wx/string.h to define wxString used by this class.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65357
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Thu, 19 Aug 2010 00:06:12 +0000 (00:06 +0000)]
Compilation fix for non-PCH build in wxGenericRichMessageDialog code.
Move IsCheckBoxChecked() to the .cpp file where wxCheckBox is fully defined
and not just forward declared (at least when not using PCH).
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65356
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Aug 2010 23:57:26 +0000 (23:57 +0000)]
Compilation fix for old SDKs in new native MSW wxHyperLinkCtrl code.
Define WC_LINK ourselves if it's not defined in the headers.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65355
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Aug 2010 23:55:52 +0000 (23:55 +0000)]
VC6 compilation fix for native wxProgressDialog implementation.
Don't use return with a void value, VC6 doesn't support this and it's
unnecessary here anyhow.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65354
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Aug 2010 22:49:02 +0000 (22:49 +0000)]
Use task dialog for wxProgressDialog implementation in wxMSW.
If available, the task dialog is now used for the wxProgressDialog under
Windows. This provides a much more native looking dialog which doesn't look
out of place under modern Windows versions, unlike the generic implementation.
The internals of the code had to be significantly changed as the task dialog
can only be shown modally so, to emulate wxProgressDialog modeless nature, a
separate thread is used for the progress dialog management.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65352
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Aug 2010 22:48:53 +0000 (22:48 +0000)]
Only use native wxHyperlinkCtrl in Unicode build under MSW.
The native control is available to Unicode applications only so disable its
use in non-Unicode build.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65351
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Aug 2010 22:48:48 +0000 (22:48 +0000)]
Don't use native MSW wxCommandLinkButton in wxUniversal.
Test for __WXUNIVERSAL__ when selecting the version of this class to use.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65350
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Aug 2010 22:48:41 +0000 (22:48 +0000)]
Add wxRichMessageDialog class.
This is a generalization of wxMessageDialog based on the native task dialog
under recent (Vista and later) Windows versions and implemented generically
for the other ports for now.
It provides the possibility to use additional controls in the message boxes
(checkbox useful for the "Don't ask me again" kind of dialogs and collapsible
detailed explanations field) and better look and feel under Windows.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65349
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Aug 2010 22:48:28 +0000 (22:48 +0000)]
Provide a task-dialog based wxMSW wxMessageDialog implementation.
Use the task dialog instead of the legacy message box for wxMessageDialog
implementation under wxMSW on recent (Vista and later) Windows versions.
As part of this change, remove wxMessageDialogWithCustomLabels and integrate
its functionality in wxMessageDialogBase itself as it's now used by all
platforms.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65348
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Aug 2010 22:48:21 +0000 (22:48 +0000)]
Handle mnemonics correctly in wxGTK::wxCollapsiblePaneSetLabel().
Convert mnemonics in wx format to the one used by GTK+, just as we already do
in the ctor.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65347
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Wed, 18 Aug 2010 22:48:15 +0000 (22:48 +0000)]
Fix Yes/No/Cancel buttons order in wxGTK wxStdDialogButtonSizer.
"Yes" and "No" buttons should be positioned next to each other for consistency
with the native message box instead of separating them with the "Cancel"
button.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65346
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Wed, 18 Aug 2010 21:40:24 +0000 (21:40 +0000)]
Document recetnyl added name parameter in wxDataViewCtrl
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65345
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Wed, 18 Aug 2010 21:36:40 +0000 (21:36 +0000)]
Mention that you cannot call wxRadioButton::SetValue(false) if that radiobutton belongs to a group
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65344
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Wed, 18 Aug 2010 21:32:14 +0000 (21:32 +0000)]
GTK+ just won't let you uncheck any radiobutton that belongs to a group.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65343
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Wed, 18 Aug 2010 21:29:53 +0000 (21:29 +0000)]
make wxChoice and wxComboBox sort in a case insensitive and locale adapted way, fixes #12351: Incorrect sort order in wxChoice / wxComboBox
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65342
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Wed, 18 Aug 2010 21:28:11 +0000 (21:28 +0000)]
Make wxListBox sort in a case insensitive way, fixes #12352: Incorrect sort order in wxListBox
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65341
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Wed, 18 Aug 2010 12:59:52 +0000 (12:59 +0000)]
Use common inline version of wxHexToDec
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65336
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 17 Aug 2010 16:55:32 +0000 (16:55 +0000)]
Provide native wxHyperlinkCtrl implementation for wxMSW.
Use the "syslink" native control to implement wxHyperlinkCtrl under (recent
enough, i.e. XP or later) versions of Windows.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65334
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 17 Aug 2010 16:12:28 +0000 (16:12 +0000)]
Compilation fix: include wx/button.h from wx/commandlinkbutton.h.
Include the base class declaration to fix compilation under non-MSW.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65333
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 17 Aug 2010 15:13:14 +0000 (15:13 +0000)]
Export wxMSWButton::GetFittingSize() private function.
It is now used by wxCommandLinkButton from adv library and so needs to be
exported from core.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65328
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Tue, 17 Aug 2010 14:48:50 +0000 (14:48 +0000)]
Add new wxCommandLinkButton class.
A command link button wraps a native MSW control under recent Windows versions
and is implemented generically as a simple bitmap button elsewhere.
In the future, GTK implementation should allow using a different font for the
button label and its note.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65327
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Julian Smart [Tue, 17 Aug 2010 10:10:39 +0000 (10:10 +0000)]
Large image-loading speedup and small attribute-loading speedup
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65326
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Tue, 17 Aug 2010 06:21:53 +0000 (06:21 +0000)]
fixes horizontal scrolling in textfields, fixes #12322
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65325
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Mon, 16 Aug 2010 17:48:28 +0000 (17:48 +0000)]
Ignore non-existant string selection in wxComboBox::SetValue() in read-only mode, as per the very exact docs, fixes #12329: wxComboBox can set non-existing string in read only mode
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65324
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Mon, 16 Aug 2010 15:33:31 +0000 (15:33 +0000)]
Uncheck radiobutton when calling ::SetValue(false) as per wxMSW, fixes #12344: Cannot set GTK wxRadioButton to fasle
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65323
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 15 Aug 2010 21:14:11 +0000 (21:14 +0000)]
Improve EVT_SHOW documentation.
Mention that it applies to the TLWs only and explain when it is generated (and
not generated).
Closes #12353.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65316
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 15 Aug 2010 21:14:06 +0000 (21:14 +0000)]
Fix wxMSW compilation in wxUSE_STL==1 case.
A wxDECLARE_NO_ASSIGN_CLASS() was recently added to ClassRegInfo but storing
it in a vector requires it to be "Assignable" so this broke compilation in STL
case (wxVector<> doesn't enforce this requirement currently).
Make ClassRegInfo assignable again to fix this.
Closes #12355.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65315
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Sun, 15 Aug 2010 21:14:02 +0000 (21:14 +0000)]
Revert "Make wxComboBox::Popup() and ::Dismiss() emit events"
This reverts commit r65310 which was not, in fact, necessary as the events
were already sent.
See #12335.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65314
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Robert Roebling [Sun, 15 Aug 2010 16:16:22 +0000 (16:16 +0000)]
Make wxComboBox::Popup() and ::Dismiss() emit events as per the docs, fixes (wxComboBox not sending popup and dismiss events)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65310
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Jaakko Salli [Fri, 13 Aug 2010 20:12:03 +0000 (20:12 +0000)]
Allow wxVariant::Convert(wxUniChar* value) to convert single-character string into a character.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65297
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 13 Aug 2010 11:57:45 +0000 (11:57 +0000)]
Fix harmless MSVC warning about double to float conversion.
Make the constant double as well as it's compared with other doubles in the
code below.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65292
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Vadim Zeitlin [Fri, 13 Aug 2010 09:55:32 +0000 (09:55 +0000)]
Update wxWinCE compilation instructions.
Remove obsolete information about eVC. Give the example of using bakefile to
generate VC[89] CE projects directly.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65285
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Fri, 13 Aug 2010 04:23:37 +0000 (04:23 +0000)]
no-op change to get build bot running
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65283
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
Stefan Csomor [Thu, 12 Aug 2010 08:25:16 +0000 (08:25 +0000)]
no-op change to get build bot running
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65276
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775