]> git.saurik.com Git - wxWidgets.git/log
wxWidgets.git
12 years agoDon't return a dangling pointer from wxDateTime::ParseXXX(wxCStrData).
Vadim Zeitlin [Sun, 13 May 2012 21:37:25 +0000 (21:37 +0000)] 
Don't return a dangling pointer from wxDateTime::ParseXXX(wxCStrData).

We don't have any sufficiently long-lived pointer to return from this
overload, so don't return anything from it -- it's better to break the
compilation of the existing code rather than make it crash during run-time.

Closes #14214.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71430 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoNo changes, just simplify the code using wx2stc() a little.
Vadim Zeitlin [Sun, 13 May 2012 21:37:23 +0000 (21:37 +0000)] 
No changes, just simplify the code using wx2stc() a little.

Assign wx2stc() return value to a suitably const variable instead of using
ugly casts to get rid of constness.

Also use wxCharBuffer/char* explicitly inside explicit wxUSE_UNICODE checks,
using wxWX2MBbuf here doesn't gain us anything and just confuses the reader of
this code.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71429 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix wxStyledTextCtrl compilation in non-Unicode build.
Vadim Zeitlin [Sun, 13 May 2012 21:37:18 +0000 (21:37 +0000)] 
Fix wxStyledTextCtrl compilation in non-Unicode build.

The value returned by wx2stc() in non-Unicode build is a simple "char*" and we
can't call length() method on it, add a helper wx2stclen() function to get the
length from the original wxString itself in this case.

Closes #14013.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71428 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDon't assert if no icon is specified for a wxDataViewCtrl item.
Vadim Zeitlin [Sun, 13 May 2012 21:37:16 +0000 (21:37 +0000)] 
Don't assert if no icon is specified for a wxDataViewCtrl item.

An item in a column using wxDataViewIconTextRenderer might not have any valid
icon associated with it, don't assert in case it doesn't in the native GTK
version.

Notice that the generic wxDataViewCtrl implementation already supports this
but not perfectly: no space is reserved for the icon in the images without
one, so giving the image to only some of them looks ugly. The GTK version
aligns both the items with and without icon properly and simply leaves the
image part blank and it would be better to modify the generic version to do
the same thing in the future.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71427 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoMinor change to wxString pretty-printer for gdb.
Vadim Zeitlin [Sun, 13 May 2012 21:37:13 +0000 (21:37 +0000)] 
Minor change to wxString pretty-printer for gdb.

Calling string() explicitly isn't necessary, at least not with gdb 7.2, and is
actually harmful when using Python 2.5 (which doesn't support UTF-32) with
wide strings.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71426 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDon't handle branches specially when sorting items in wxDataViewCtrl.
Vadim Zeitlin [Sun, 13 May 2012 21:37:10 +0000 (21:37 +0000)] 
Don't handle branches specially when sorting items in wxDataViewCtrl.

The generic version of wxDataViewCtrl tried to put all branches before the
leaves when sorting. This had a couple of problems: first, it didn't do it
correctly and actually placed the branches after the leaves which didn't make
any sense. Second, this was only done in the generic version and not the
native GTK one making the behaviour inconsistent between platforms. Finally,
this behaviour just doesn't make sense in general (i.e. when items don't
necessarily represent anything in the file system and maybe even sometimes
when they do) and there doesn't seem any good reason to do it by default.

So stop doing it, partially reverting the changes of r47562.

Closes #14100.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71425 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDisable the use of UTF-8 by default in Unix builds.
Vadim Zeitlin [Sun, 13 May 2012 13:17:25 +0000 (13:17 +0000)] 
Disable the use of UTF-8 by default in Unix builds.

Add up-to-date description of UTF-8 support to the Unicode overview.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71424 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoRemove wxDECLARE_APP() from wxIMPLEMENT_APP_NO_MAIN().
Vadim Zeitlin [Sun, 13 May 2012 13:17:22 +0000 (13:17 +0000)] 
Remove wxDECLARE_APP() from wxIMPLEMENT_APP_NO_MAIN().

There is no need for a separate declaration inside wxIMPLEMENT_APP() as
wxGetApp() is defined by it and redeclaring it immediately after definition
results in a warning with some compilers/environments (Eclipse CDT).

The move of wxGetApp() to the beginning of the macro is only to ensure that a
semicolon is still required after wxIMPLEMENT_APP_NO_MAIN() and the other
macros terminating with it, such as wxIMPLEMENT_APP() itself.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71423 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFixed layout and hit-testing problem particularly with centred lines
Julian Smart [Fri, 11 May 2012 22:15:39 +0000 (22:15 +0000)] 
Fixed layout and hit-testing problem particularly with centred lines

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71419 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDocument that wxEVT_COMMAND_DATAVIEW_COLUMN_REORDERED is OSX-specific.
Vadim Zeitlin [Fri, 11 May 2012 22:10:28 +0000 (22:10 +0000)] 
Document that wxEVT_COMMAND_DATAVIEW_COLUMN_REORDERED is OSX-specific.

This even is not generated by neither generic nor GTK version right now.

See #14297.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71418 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix extra event sent by wxTextEntry::ChangeValue() since r71308.
Vadim Zeitlin [Fri, 11 May 2012 22:10:25 +0000 (22:10 +0000)] 
Fix extra event sent by wxTextEntry::ChangeValue() since r71308.

The changes of r71308 sent the event unconditionally in case the text didn't
really change but no events should be sent if the flags don't include
SetValue_SendEvent, add a check for it.

Re-closes #13936.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71417 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoEnable access to the native bitmap object wrapped by wxGraphicsBitmap
Robin Dunn [Fri, 11 May 2012 22:06:50 +0000 (22:06 +0000)] 
Enable access to the native bitmap object wrapped by wxGraphicsBitmap

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71416 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoEnsure a 32-bit cairo surface is created if it is needed
Robin Dunn [Fri, 11 May 2012 22:06:37 +0000 (22:06 +0000)] 
Ensure a 32-bit cairo surface is created if it is needed

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71415 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agofixes SetFirstItem, Thanks to David Wright
Stefan Csomor [Fri, 11 May 2012 06:28:54 +0000 (06:28 +0000)] 
fixes SetFirstItem, Thanks to David Wright

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71414 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoMore interface fixes for Phoenix
Robin Dunn [Thu, 10 May 2012 22:38:14 +0000 (22:38 +0000)] 
More interface fixes for Phoenix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71402 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdd wxFormatInvalid, and tweak the docs for wxDataObject::GetDataHere and SetData
Robin Dunn [Thu, 10 May 2012 22:34:46 +0000 (22:34 +0000)] 
Add wxFormatInvalid, and tweak the docs for wxDataObject::GetDataHere and SetData

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71401 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdd doc for wxCliboard::Get
Robin Dunn [Thu, 10 May 2012 22:34:39 +0000 (22:34 +0000)] 
Add doc for wxCliboard::Get

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71400 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdded wxRichTextXMLHandler::RegisterNodeName so custom content classes can be added...
Julian Smart [Thu, 10 May 2012 11:59:59 +0000 (11:59 +0000)] 
Added wxRichTextXMLHandler::RegisterNodeName so custom content classes can be added without
breaking XML loading

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71399 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoSet LF EOL style for setup.h.in file.
Vadim Zeitlin [Thu, 10 May 2012 11:53:45 +0000 (11:53 +0000)] 
Set LF EOL style for setup.h.in file.

This file is only used under Unix so should have Unix EOLs, e.g. to allow
building Unix ports from the sources checked out under Windows.

Closes #14266.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71398 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdd missing wx/scopeguard.h include to fix the build.
Vadim Zeitlin [Wed, 9 May 2012 17:16:26 +0000 (17:16 +0000)] 
Add missing wx/scopeguard.h include to fix the build.

Closes #14285.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71397 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix wxGenericListCtrl best size calculation in report view.
Vadim Zeitlin [Wed, 9 May 2012 14:24:54 +0000 (14:24 +0000)] 
Fix wxGenericListCtrl best size calculation in report view.

Just let the base class do it instead of using hard coded default value in
wxGenericListCtrl::DoGetBestClientSize().

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71396 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoUnconditionally define IID_IShellItem in wxMSW sources.
Vadim Zeitlin [Wed, 9 May 2012 14:24:51 +0000 (14:24 +0000)] 
Unconditionally define IID_IShellItem in wxMSW sources.

This GUID may not be defined in uuid.lib even when
__IShellItem_INTERFACE_DEFINED__ is defined in the headers, so just define it
always to avoid any problems.

Closes #14244.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71395 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoImplement constrained best size calculation in wxMSW wxListCtrl.
Vadim Zeitlin [Wed, 9 May 2012 14:24:47 +0000 (14:24 +0000)] 
Implement constrained best size calculation in wxMSW wxListCtrl.

This fixes wxListbook controller size to avoid spurious scrollbars.

Closes #13898.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71394 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoImprove wxBookCtrlBase controller size calculations.
Vadim Zeitlin [Wed, 9 May 2012 14:24:44 +0000 (14:24 +0000)] 
Improve wxBookCtrlBase controller size calculations.

Use GetBest{Height,Width}() in wxBookCtrlBase to compute the controller
control size height/width from its known (from wxBookCtrlBase size itself)
width/height. This will allow to correctly compute the size of wxListCtrl used
by wxListbook once it provides the necessary support for width-from-height and
height-from-width calculations.

See #13898.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71393 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdd wxWindow::GetBest{Height,Width}().
Vadim Zeitlin [Wed, 9 May 2012 14:24:37 +0000 (14:24 +0000)] 
Add wxWindow::GetBest{Height,Width}().

These functions will be used when it is necessary to determine the best size
of the control if one of its size components is fixed. Currently none of the
classes implements DoGetBestClient{Height,Width}() yet but wxListCtrl will do
it soon, see #13898.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71392 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoImprove wxWindow best size documentation, mention DoGetBestClientSize().
Vadim Zeitlin [Wed, 9 May 2012 14:24:34 +0000 (14:24 +0000)] 
Improve wxWindow best size documentation, mention DoGetBestClientSize().

Custom classes should typically override DoGetBestClientSize() instead of
DoGetBestSize() to avoid having to deal with the borders.

Also don't reference the deprecated SetInitialBestSize() unnecessarily and
document its non-deprecated replacement.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71391 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoMention wxFoobookEvent change from classes to #defines in the change log.
Vadim Zeitlin [Wed, 9 May 2012 14:24:30 +0000 (14:24 +0000)] 
Mention wxFoobookEvent change from classes to #defines in the change log.

These classes can't be forward-declared any more as they're not really classes
any longer but just compatibility #defines and can't be made classes again as
this would break the existing code using wxBookCtrlEvent in 2.9.

See #14242.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71390 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAllow entering more digits in wxSpinCtrl in wxMSW than fits into it.
Vadim Zeitlin [Wed, 9 May 2012 14:24:27 +0000 (14:24 +0000)] 
Allow entering more digits in wxSpinCtrl in wxMSW than fits into it.

Scroll the control automatically if there is not enough space. This is
consistent with (single line) wxTextCtrl and wxSpinCtrl under the other
platforms.

Closes #14211.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71389 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAttach MDI "Window" menu to the parent frame menu bar in wxMSW.
Vadim Zeitlin [Wed, 9 May 2012 14:24:23 +0000 (14:24 +0000)] 
Attach MDI "Window" menu to the parent frame menu bar in wxMSW.

This makes sense and fixes the regression with "Window" menu commands not
being processed any more after the changes of r71114.

Closes #14207.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71388 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoCorrect the initial value setting in wxMSW wxSpinCtrl.
Vadim Zeitlin [Wed, 9 May 2012 14:24:20 +0000 (14:24 +0000)] 
Correct the initial value setting in wxMSW wxSpinCtrl.

Always use value argument for the text control contents and also override the
initial numeric value with it if it's numeric.

This seems to be the only consistent thing to do, so document this behaviour
and add a unit test checking for it.

Closes #13589.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71387 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoRemove assert checking bitmap size in wxMenuItem drawing code in wxMSW.
Vadim Zeitlin [Wed, 9 May 2012 14:24:16 +0000 (14:24 +0000)] 
Remove assert checking bitmap size in wxMenuItem drawing code in wxMSW.

This assert was fatal, as usual when asserting from a WM_PAINT handler, as the
function was reentered resulting in nested asserts and program abort, so
remove it to at least let the program continue to run even if there is not
enough space for the bitmap in the menu.

There is, of course, still something wrong with the menu geometry calculations
if this happens but I can't even reproduce this any more so not sure what
exactly.

See #11657.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71386 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix creation of wxBitmap from wxIcon in wxMSW: premultiply the pixels.
Vadim Zeitlin [Wed, 9 May 2012 14:24:12 +0000 (14:24 +0000)] 
Fix creation of wxBitmap from wxIcon in wxMSW: premultiply the pixels.

wxBitmap in wxMSW is supposed to store its data in alpha-premultiplied format
but didn't do it when it was created from an icon (or a cursor), resulting in
wrong display of wxIcons with alpha channel when they were used for e.g. menu
items.

Fix this by ensuring that the data is always premultiplied. This is not the
best solution as in some cases (e.g. if this wxBitmap is added to wxImageList
later) we could need to undo this premultiplication later which is quite
inefficient but at least it's simple and straightforward.

Closes #11414.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71385 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix wxString unit test when not using UTF-8.
Vadim Zeitlin [Wed, 9 May 2012 14:24:10 +0000 (14:24 +0000)] 
Fix wxString unit test when not using UTF-8.

Restrict the tests added in r70987 to run when using UTF-8 strings only, they
test for something that is simply not true (and for a bug that can't happen)
with non-multibyte encodings.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71384 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix compilation of wxVariant code with VC6.
Vadim Zeitlin [Wed, 9 May 2012 14:24:07 +0000 (14:24 +0000)] 
Fix compilation of wxVariant code with VC6.

This was broken by the changes in r71196 as the original VC6 SDK doesn't
define VARIANT::llVal.

See #14210.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71383 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoUse better face names first in wxGTK wxNativeFontInfo::SetFamily().
Vadim Zeitlin [Wed, 9 May 2012 14:24:03 +0000 (14:24 +0000)] 
Use better face names first in wxGTK wxNativeFontInfo::SetFamily().

Try better matches and not the most widespread ones first when building a list
of face names to try for the given family. This gives better results when
these better fonts are indeed available and doesn't change anything if they
are not.

See #14126.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71382 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoCheck that item ID is initialized when inserting it in wxListCtrl.
Vadim Zeitlin [Wed, 9 May 2012 14:24:01 +0000 (14:24 +0000)] 
Check that item ID is initialized when inserting it in wxListCtrl.

Using uninitialized ID happened to work by accident with 2.8 but it doesn't
work any more, try to detect this as early as possible and give a clear
explanation of why it doesn't to help fixing the broken code that used to
accidentally work.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71381 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix wxStaticBitmap best size calculation in wxMSW.
Vadim Zeitlin [Wed, 9 May 2012 14:23:57 +0000 (14:23 +0000)] 
Fix wxStaticBitmap best size calculation in wxMSW.

Take the control borders into account by overriding DoGetBestClientSize()
instead of DoGetBestSize().

Also invalidate the default best size computed before we have any valid image
when setting the initial image in Create().

Closes #4099.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71380 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdded field implementation
Julian Smart [Wed, 9 May 2012 11:06:04 +0000 (11:06 +0000)] 
Added field implementation

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71379 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoMoved default margins to buffer class Init; reduced chance of accidental selection...
Julian Smart [Tue, 8 May 2012 17:31:06 +0000 (17:31 +0000)] 
Moved default margins to buffer class Init; reduced chance of accidental selection when clicking

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71378 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoCorrected top-level object layout in paragraphs
Julian Smart [Mon, 7 May 2012 15:47:23 +0000 (15:47 +0000)] 
Corrected top-level object layout in paragraphs

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71377 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFixed inconsistent calculation of line height in paragraph layout
Julian Smart [Mon, 7 May 2012 13:13:30 +0000 (13:13 +0000)] 
Fixed inconsistent calculation of line height in paragraph layout

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71376 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoNo real changes, just fix some typos in comments.
Vadim Zeitlin [Mon, 7 May 2012 13:12:27 +0000 (13:12 +0000)] 
No real changes, just fix some typos in comments.

Closes #14276.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71375 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdded non-breaking space to whitespace check
Julian Smart [Mon, 7 May 2012 13:12:27 +0000 (13:12 +0000)] 
Added non-breaking space to whitespace check

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71374 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoUse XkbKeycodeToKeysym() instead of deprecated XKeycodeToKeysym().
Vadim Zeitlin [Mon, 7 May 2012 13:12:23 +0000 (13:12 +0000)] 
Use XkbKeycodeToKeysym() instead of deprecated XKeycodeToKeysym().

XKeycodeToKeysym() is deprecated in new X11 headers because it doesn't work
correctly with all symbols (https://bugs.freedesktop.org/show_bug.cgi?id=5349).
Use XkbKeycodeToKeysym() instead, this should help with some keys and also
avoids deprecation warnings during compilation.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71373 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoCreate a wrapper file for X11/XKBlib.h header.
Vadim Zeitlin [Mon, 7 May 2012 13:12:20 +0000 (13:12 +0000)] 
Create a wrapper file for X11/XKBlib.h header.

We need some hacks for the older systems before including this header, extract
them from src/x11/utilsx.cpp into a new private header to be able to reuse it
from wxGTK in the next commit.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71372 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoMake wxDocTemplate::CreateDocument() exceptions-safe.
Václav Slavík [Mon, 7 May 2012 12:23:09 +0000 (12:23 +0000)] 
Make wxDocTemplate::CreateDocument() exceptions-safe.

Don't create the document object if InitDocument() throws.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71371 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix performance of wxHtmlParser::SkipCommentTag() in UTF-8 build.
Václav Slavík [Mon, 7 May 2012 11:15:31 +0000 (11:15 +0000)] 
Fix performance of wxHtmlParser::SkipCommentTag() in UTF-8 build.

Avoid computing the difference between two potentially distant
iterators, which is O(1) in wchar_t build, but O(n) in UTF-8 one.

See #13445.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71370 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix r71367: don't set bgCol twice needlessly.
Václav Slavík [Sun, 6 May 2012 16:56:38 +0000 (16:56 +0000)] 
Fix r71367: don't set bgCol twice needlessly.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71368 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix wxOwnerDrawnComboBox background on with classic theme.
Václav Slavík [Sun, 6 May 2012 13:10:34 +0000 (13:10 +0000)] 
Fix wxOwnerDrawnComboBox background on with classic theme.

In wxMSW, if the classic theme was used, read-only wxOwnerDrawnComboBox
had gray background, but native look should be the same for both
editable and read-only combo boxes: white text entry-like rectangle.

Apparently, a similar problem existed with non-classic themes too
before, as there was a workaround in place. Fixed by moving the
workaround into code used by both themed and classic rendering.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71367 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoNo changes, just spelling corrections in the comments.
Vadim Zeitlin [Sat, 5 May 2012 14:09:59 +0000 (14:09 +0000)] 
No changes, just spelling corrections in the comments.

Closes #14275.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71366 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoUpdate the field widths on demand in wxStatusBarGeneric.
Vadim Zeitlin [Sat, 5 May 2012 11:22:09 +0000 (11:22 +0000)] 
Update the field widths on demand in wxStatusBarGeneric.

This ensures that the value returned from GetFieldRect() is always up to date,
even when this method is called from the user-defined wxEVT_SIZE handler, i.e.
before our own OnSize() could run.

Also remove the now unneeded hack with calling the base class OnSize() from
the statbar sample.

Closes #14268.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71365 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agofixes crashes with embedded controls in toolbars after toolbar destruction, code...
Stefan Csomor [Sat, 5 May 2012 05:32:19 +0000 (05:32 +0000)] 
fixes crashes with embedded controls in toolbars after toolbar destruction, code was moved in r62988, but apparently Destroy doesn't have to be called, so do a last check, fixes #14258

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71364 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDon't return NULL widget from wxFileCtrl page of widgets sample.
Vadim Zeitlin [Fri, 4 May 2012 22:20:59 +0000 (22:20 +0000)] 
Don't return NULL widget from wxFileCtrl page of widgets sample.

This makes all the common operations such as setting tooltip, colours &c on
this page simply crash.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71363 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDerive wxGenericFileCtrl from wxControl.
Vadim Zeitlin [Fri, 4 May 2012 22:20:55 +0000 (22:20 +0000)] 
Derive wxGenericFileCtrl from wxControl.

wxFileCtrl -- which can be #define'd as wxGenericFileCtrl -- is documented to
inherit from wxControl and does derive from it in the native GTK version, so
do it for the generic version too.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71362 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoImprove documentation of wxDataViewCtrl mouse event handling.
Vadim Zeitlin [Fri, 4 May 2012 20:35:52 +0000 (20:35 +0000)] 
Improve documentation of wxDataViewCtrl mouse event handling.

Explain that catching mouse events directly doesn't work.

Also make it clear that double clicking an item can be caught by processing
wxEVT_COMMAND_DATAVIEW_ITEM_ACTIVATED.

See #14111.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71361 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix precompiled headers use with MSVC in wxGTK sources.
Vadim Zeitlin [Fri, 4 May 2012 20:35:48 +0000 (20:35 +0000)] 
Fix precompiled headers use with MSVC in wxGTK sources.

Don't use PCH for C sources, do include wx/wxprec.h from all wxGTK C++
sources.

Closes #14224.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71360 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDeclare variables before doing anything else in C code.
Vadim Zeitlin [Fri, 4 May 2012 20:35:44 +0000 (20:35 +0000)] 
Declare variables before doing anything else in C code.

Don't put statements before variable declaration in C source file. This fixes
compilation with non C99-compliant C compilers such as MSVC.

See #14224.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71359 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAllow using non-MSW toolkit in MSVC-specific auto-linking header.
Vadim Zeitlin [Fri, 4 May 2012 20:35:41 +0000 (20:35 +0000)] 
Allow using non-MSW toolkit in MSVC-specific auto-linking header.

This makes it possible to auto-link wxGTK library when using MSVC too.

Closes #14272.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71358 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDefine wxCONCATn() macro up to n=9 from n=5 previously.
Vadim Zeitlin [Fri, 4 May 2012 20:35:37 +0000 (20:35 +0000)] 
Define wxCONCATn() macro up to n=9 from n=5 previously.

We'll need it for n=6 for the next commit, so increase the max value of n a
bit more.

See #14272.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71357 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoUse GTK-based wxWebView when using GTK+, not under Unix.
Vadim Zeitlin [Fri, 4 May 2012 20:35:33 +0000 (20:35 +0000)] 
Use GTK-based wxWebView when using GTK+, not under Unix.

Test for the GTK+ toolkit, not Unix platform to determine whether GTK+
wxWebView version should be used.

Closes #14273.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71356 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdd wxDir::GetNameWithSep() and use it to avoid consecutive slashes.
Vadim Zeitlin [Fri, 4 May 2012 20:35:31 +0000 (20:35 +0000)] 
Add wxDir::GetNameWithSep() and use it to avoid consecutive slashes.

It is wrong to use dir.GetName()+"/" to obtain a slash-terminated directory
name as this results in (usually harmless but at best ugly) double slashes at
at the beginning of the string for the root directory. Add GetNameWithSep() to
obtain the correct result in all cases.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71355 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDocument wxTP_DEFAULT as a standalone constant.
Vadim Zeitlin [Fri, 4 May 2012 20:35:26 +0000 (20:35 +0000)] 
Document wxTP_DEFAULT as a standalone constant.

Make sure the declarations in the documentation header can be really parsed.

Closes #14270.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71354 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDon't remove the last slash from "/" directory name under Unix.
Vadim Zeitlin [Fri, 4 May 2012 18:31:48 +0000 (18:31 +0000)] 
Don't remove the last slash from "/" directory name under Unix.

This was totally wrong as it returned empty string as (invalid) directory
name.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71353 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdd wxDropSource::SetIcon for wxGTK to mimic SetCursor on the other ports.
Robin Dunn [Thu, 3 May 2012 23:30:40 +0000 (23:30 +0000)] 
Add wxDropSource::SetIcon for wxGTK to mimic SetCursor on the other ports.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71349 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years ago* Change "def" to defResult as def is a reserved word in Python
Robin Dunn [Thu, 3 May 2012 23:30:33 +0000 (23:30 +0000)] 
* Change "def" to defResult as def is a reserved word in Python
* Correct some methods that were marked pure virtual but which aren't.
* etc.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71348 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agofix incorrect default values
Robin Dunn [Thu, 3 May 2012 23:30:27 +0000 (23:30 +0000)] 
fix incorrect default values

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71347 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDocument wxDataViewChoiceByIndexRenderer.
Vadim Zeitlin [Thu, 3 May 2012 10:17:19 +0000 (10:17 +0000)] 
Document wxDataViewChoiceByIndexRenderer.

At least briefly document this class too and not only its parent
wxDataViewChoiceRenderer one.

Closes #14265.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71346 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoNo changes, just remove duplicate flags checks in wxUniv wxTLW.
Vadim Zeitlin [Thu, 3 May 2012 10:17:15 +0000 (10:17 +0000)] 
No changes, just remove duplicate flags checks in wxUniv wxTLW.

For some reason (rename of the old wxTHICK_FRAME to wxRESIZE_BORDER?) we
tested for wxRESIZE_BORDER twice in a couple of places. Don't do it for
clarity.

Closes #14264.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71345 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agouse explicit WakeUp variant, too many errors using heuristics, fixes #14176
Stefan Csomor [Wed, 2 May 2012 19:38:58 +0000 (19:38 +0000)] 
use explicit WakeUp variant, too many errors using heuristics, fixes #14176

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71344 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agomake WakeUp variant explicit, too many errors using heuristics, like #14176
Stefan Csomor [Wed, 2 May 2012 19:30:11 +0000 (19:30 +0000)] 
make WakeUp variant explicit, too many errors using heuristics, like #14176

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71343 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agofixes #14178
Stefan Csomor [Wed, 2 May 2012 18:44:23 +0000 (18:44 +0000)] 
fixes #14178

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71342 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFixed parts of toolbar background not being drawn with older comctl32.dll.
Dimitri Schoolwerth [Wed, 2 May 2012 14:44:45 +0000 (14:44 +0000)] 
Fixed parts of toolbar background not being drawn with older comctl32.dll.

When using comctl32.dll versions older than 6.0 toolbar icons would not have their background drawn. Fix this in a rough way by always completely erasing the background like was done before. Regression since r62971.

Closes #13512.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71341 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoGerman translations update from Thomas Krebs.
Vadim Zeitlin [Wed, 2 May 2012 10:37:36 +0000 (10:37 +0000)] 
German translations update from Thomas Krebs.

Closes #14262.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71340 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix destruction of wxDataViewCtrl's editor control.
Václav Slavík [Mon, 30 Apr 2012 14:51:52 +0000 (14:51 +0000)] 
Fix destruction of wxDataViewCtrl's editor control.

Don't pop event handler from the control more than once.

See r70002 and r70005 (which this reverts) for reference.

Fixes #14215.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71336 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agowxDataViewCtrl: always update the header when col best width changes.
Václav Slavík [Mon, 30 Apr 2012 09:33:30 +0000 (09:33 +0000)] 
wxDataViewCtrl: always update the header when col best width changes.

Have an explicit per-column dirty flag and use that to determine whether
we need to call wxHeaderCtrl::UpdateColumn(). Previously, the lack of
computed best width was used as an indicator, but this didn't work
correctly if some code called GetWidth() after invalidation but before
wxDataViewCtrl::UpdateColWidths() was called at idle time. This resulted
in header's column widths getting out of sync with the control itself.

Fixes #14167.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71335 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoInvalidate wxDataViewCtrl bests widths on expand/collapse.
Václav Slavík [Mon, 30 Apr 2012 09:33:25 +0000 (09:33 +0000)] 
Invalidate wxDataViewCtrl bests widths on expand/collapse.

The best column widths are computed from "realized" items that are
available as rows in wxDataViewCtrl. This information changes when a
previously collapsed node is expanded and new items become available for
column width calculation.

Fixes #14167.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71334 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoRespect minimal width in wxDataViewCtrl::GetBestColumnWidth().
Václav Slavík [Mon, 30 Apr 2012 09:33:21 +0000 (09:33 +0000)] 
Respect minimal width in wxDataViewCtrl::GetBestColumnWidth().

See #14167.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71333 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoWork around the problem with not exiting event loop under MSW.
Vadim Zeitlin [Sun, 29 Apr 2012 23:48:20 +0000 (23:48 +0000)] 
Work around the problem with not exiting event loop under MSW.

Changes of r71304 broke the event loop termination under MSW, limit them to
only the case in which they were really needed, i.e. when loop is really
exited by a pending event handler.

This is only a temporary solution, we need something better in longer term.

See #14250.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71329 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoNo changes, just refactor common IsSorted() tests in wxGTK wxDataViewCtrl.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:34 +0000 (23:22 +0000)] 
No changes, just refactor common IsSorted() tests in wxGTK wxDataViewCtrl.

Add wxDataViewCtrlInternal::ShouldBeSorted() helper instead of testing for
both IsSorted() and wxDataViewModel::HasDefaultCompare() in several places.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71327 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoNo real changes, just make wxDataViewCtrlInternal::IsSorted() const.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:32 +0000 (23:22 +0000)] 
No real changes, just make wxDataViewCtrlInternal::IsSorted() const.

This is a simple accessor, should have been const since the beginning.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71326 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoUse PCH in the tests in all Windows ports and not only when using wxMSW.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:28 +0000 (23:22 +0000)] 
Use PCH in the tests in all Windows ports and not only when using wxMSW.

This change doesn't actually change anything for the "normal" ports as it only
affects wxGTK/MSW which is not officially supported yet, so the make/project
files are unchanged by it.

Closes #14249.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71325 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdded wxDataViewEvent::SetDragFlags() and GetDropEffect() methods.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:25 +0000 (23:22 +0000)] 
Added wxDataViewEvent::SetDragFlags() and GetDropEffect() methods.

Allow specifying the drag operation flags and retrieving the drop effect when
it's over for wxDataViewCtrl drag-and-drop.

Currently this is only implemented in the generic version.

Closes #12583.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71324 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoSet the data size in wxEVT_COMMAND_DATAVIEW_ITEM_DROP_POSSIBLE in wxGTK.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:21 +0000 (23:22 +0000)] 
Set the data size in wxEVT_COMMAND_DATAVIEW_ITEM_DROP_POSSIBLE in wxGTK.

Allow wxEVT_COMMAND_DATAVIEW_ITEM_DROP_POSSIBLE handler to examine the data
being dragged by setting not only the pointer to it but also its size, as
otherwise it's impossible to do anything with it.

See #12583.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71323 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoExplicitly document wxDrag_XXX flags.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:18 +0000 (23:22 +0000)] 
Explicitly document wxDrag_XXX flags.

They were mentioned in DoDragDrop() documentation but not documented on their
own. Do it now to be able to refer to them from elsewhere.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71322 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoRemove internal only methods from wxDataViewEvent documentation.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:16 +0000 (23:22 +0000)] 
Remove internal only methods from wxDataViewEvent documentation.

SetDataXXX() methods are only meant to be used by wxDataViewCtrl itself, so
don't document them as part of public API. Their documentation was pretty
useless anyhow as it didn't say anything not already contained in the method
name.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71321 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoRestore 2.8 stock labels for wxID_PREVIEW inadvertently changed in 2.9.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:13 +0000 (23:22 +0000)] 
Restore 2.8 stock labels for wxID_PREVIEW inadvertently changed in 2.9.

The wxID_PREVIEW labels were accidentally removed in r68641 and added back
with a wrong/different label later. Restore the same one (or almost, just add
an ellipsis at the end) that was used in 2.8.

Closes #13906.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71320 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdd a hack to prevent the test suite from aborting after Grid test case.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:10 +0000 (23:22 +0000)] 
Add a hack to prevent the test suite from aborting after Grid test case.

There is a problem with the native header control still having the mouse
capture when the grid is destroyed in wxGTK and this resulted in asserts when
destroying the grid, nested asserts due to an exception being thrown from a
dtor and finally abort that prevented the rest of the tests from running.

As I failed to find the real reason for this problem, just forcefully ensure
that we don't have the mouse capture when destroying the grid. This at least
allows the complete test suite to run.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71319 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoImprove error reporting for nested asserts failures in the test suite.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:08 +0000 (23:22 +0000)] 
Improve error reporting for nested asserts failures in the test suite.

If an assert occurred while handling an exception generated by a previous
assert handler, the information about the original assert was lost even if
though it was more important than the secondary assert. Do preserve and show
the original assert message in this case now.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71318 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoWork around wxDateTime::ParseFormat() problem in generic wxDateTimePickerCtrl.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:05 +0000 (23:22 +0000)] 
Work around wxDateTime::ParseFormat() problem in generic wxDateTimePickerCtrl.

Due to a bug in wxDateTime::ParseFormat(), calling it with wxString::c_str()
currently just crashes, so don't do this in generic wxDateTimePickerCtrl code.
The real fix is, of course, to correct the bug in wxDateTime itself but for
now this at least prevents the crash when executing the test suite. And using
c_str() here is unnecessary anyhow.

See #14214.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71317 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoPreserve wxComboBox selection when modifying the selected item in wxGTK too.
Vadim Zeitlin [Sun, 29 Apr 2012 23:22:01 +0000 (23:22 +0000)] 
Preserve wxComboBox selection when modifying the selected item in wxGTK too.

This does the same thing as r70018 did for wxMSW but for wxGTK, i.e. it keeps
the combo box item selected when its text is modified.

This fixes [Bitmap]ComboBox unit tests under wxGTK.

See #13769.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71316 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoEnable wxComboBox::SetString() test in the widgets sample.
Vadim Zeitlin [Sun, 29 Apr 2012 23:21:57 +0000 (23:21 +0000)] 
Enable wxComboBox::SetString() test in the widgets sample.

It was disabled because it wasn't implemented for wxGTK at some time in the
past -- but it is implemented now, so there is no reason to not allow testing
it.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71315 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDon't use ancient -no-cpp-precomp flag on OS X.
Václav Slavík [Sun, 29 Apr 2012 09:36:44 +0000 (09:36 +0000)] 
Don't use ancient -no-cpp-precomp flag on OS X.

See http://trac.wxwidgets.org/ticket/14029 for a discussion of the
problems it causes when using non-Apple compiler. Even for Apple's GCC,
it does nothing these days and we no longer support OS X 10.3, so
there's no point in continuing to use it.

Fixes #14029.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71314 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoMake wxGTK code returning correct focus in popup menu presence more robust.
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:26 +0000 (22:25 +0000)] 
Make wxGTK code returning correct focus in popup menu presence more robust.

Replace the changes of r69938 with an alternative and simpler solution:
instead of playing games with gs_pendingFocus, which could break down if its
old value became invalid while the menu was shown as happened if one of the
menu commands resulted in this window being destroyed, just take the currently
shown popup menu into account in DoFindFocus() itself.

This should be safer as there is no danger of any dangling pointers here and
is also simpler and more obviously correct.

Closes #14103.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71313 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdd missing "flags" argument to wxNotificationMessage ctor in wxMSW.
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:23 +0000 (22:25 +0000)] 
Add missing "flags" argument to wxNotificationMessage ctor in wxMSW.

It was impossible to specify the flags when creating wxNotificationMessage in
wxMSW, cotrary to the other ports and the documentation.

Fix this by adding the missing argument to the ctor and simply passing it to
the base class one, we don't have to do anything else as the existing code
already calls GetFlags() later so it should respect these flags without any
more changes.

Closes #14245.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71312 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix crash in wxFileConfig when deleting last entry of the root group.
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:19 +0000 (22:25 +0000)] 
Fix crash in wxFileConfig when deleting last entry of the root group.

This resulted in keeping a dangling pointer to the group line in
wxFileConfigGroup and any attempt to use it after this resulted in a crash.
Fix this by explicitly resetting the last line in this case.

Also add a unit test for this scenario.

Closes #14243.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71311 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoMake it possible to forward declare wx{Choice,Tool,Tree}bookEvent again.
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:15 +0000 (22:25 +0000)] 
Make it possible to forward declare wx{Choice,Tool,Tree}bookEvent again.

Don't use typedef for these classes as it makes it impossible to
forward-declare them, just use #define instead as we already do for
wxListbookEvent and wxNotebookEvent. This allows forward declaration and is
also more consistent.

Closes #12242.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71310 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoUse generic wxAboutBox() in wxUniv/GTK.
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:07 +0000 (22:25 +0000)] 
Use generic wxAboutBox() in wxUniv/GTK.

The native GTK implementation is not used in wxUniv/GTK, so don't exclude the
generic one as well.

Notice that the same should be done for wxMSW and wxOSX too but we currently
seem to use the native version even in wxUniv there. It would be better to
consistently use the generic version in all wxUniv ports.

Closes #14236.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71309 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDon't change wxTextEntry value if it didn't really change.
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:03 +0000 (22:25 +0000)] 
Don't change wxTextEntry value if it didn't really change.

This is not only unnecessary but also can result in a kind of infinite loop
when wxTextEntry::SetValue() is called from wxEVT_IDLE handler as really
modifying the text results in another wxEVT_IDLE being generated and another
call to SetValue() and so on while not doing it in the first place completely
works around the problem and is also more efficient.

Closes #13936.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71308 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoRun some wxTextCtrl unit test cases for single and multi-line controls.
Vadim Zeitlin [Sat, 28 Apr 2012 22:25:01 +0000 (22:25 +0000)] 
Run some wxTextCtrl unit test cases for single and multi-line controls.

Some of the tests that were previously ran for single or multi-line controls
only actually apply to both of them, so run them for both kinds of control to
test that both of them work correctly.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71307 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoNo changes, just refactor wxTextCtrl unit test case.
Vadim Zeitlin [Sat, 28 Apr 2012 22:24:59 +0000 (22:24 +0000)] 
No changes, just refactor wxTextCtrl unit test case.

Allow running the same tests for both single and multi-line controls easily.
No real changes yet though, the tests are still ran for the controls with the
same styles as before for now.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71306 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775