wxWidgets.git
11 years agoRevert "Show the name of the actually tested class in text entry unit tests."
Vadim Zeitlin [Fri, 10 May 2013 19:21:38 +0000 (19:21 +0000)] 
Revert "Show the name of the actually tested class in text entry unit tests."

Revert r73959, the name of the control can be seen from the name of the
failing test case actually, so there is no need to include it in the message.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73962 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoapplying editor part of patch, see #15003
Stefan Csomor [Fri, 10 May 2013 18:31:51 +0000 (18:31 +0000)] 
applying editor part of patch, see #15003

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73961 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse wxjpeg_boolean in libtiff sources.
Vadim Zeitlin [Fri, 10 May 2013 13:25:29 +0000 (13:25 +0000)] 
Use wxjpeg_boolean in libtiff sources.

This fixes compilation problem when using libtiff with the built-in modified
version of libjpeg that uses wxjpeg_boolean instead of boolean as it doesn't
define boolean at all in its headers, but just wxjpeg_boolean.

Closes #15179.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73960 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoShow the name of the actually tested class in text entry unit tests.
Vadim Zeitlin [Fri, 10 May 2013 13:22:11 +0000 (13:22 +0000)] 
Show the name of the actually tested class in text entry unit tests.

This test is used for several different classes, show the name of the class
being tested when the assert in Editable() test fails.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73959 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoEnable a few more tests in wxAnyTestCase::GetAs().
Vadim Zeitlin [Fri, 10 May 2013 13:22:08 +0000 (13:22 +0000)] 
Enable a few more tests in wxAnyTestCase::GetAs().

This is part of the continuing series of commits to find out what results in
heap corruption in wxOSX PPC builds.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73958 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDisable a sporadically failing check in wxBitmapComboBox unit test.
Vadim Zeitlin [Thu, 9 May 2013 23:22:09 +0000 (23:22 +0000)] 
Disable a sporadically failing check in wxBitmapComboBox unit test.

This check keeps failing in buildbot builds even though it always passes in
local ones (and sometimes in buildbot ones too). Disable it to allow the
entire test suite to pass.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73957 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoReduce the number of wxAny tests ran under wxOSX further.
Vadim Zeitlin [Thu, 9 May 2013 23:22:06 +0000 (23:22 +0000)] 
Reduce the number of wxAny tests ran under wxOSX further.

Something in GetAs() test definitely corrupts memory, but what?

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73956 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoStart bisecting GetAs() wxAny test itself.
Vadim Zeitlin [Thu, 9 May 2013 22:29:13 +0000 (22:29 +0000)] 
Start bisecting GetAs() wxAny test itself.

This is the test that results in memory corruption in wxOSX PPC builds, try
to find out where exactly does this happen.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73955 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoLeave only a single wxAny unit test disabled.
Vadim Zeitlin [Thu, 9 May 2013 19:56:47 +0000 (19:56 +0000)] 
Leave only a single wxAny unit test disabled.

It looks like the culprit is GetAs() test, verify it.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73954 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAnother attempt to isolate memory corrupting wxAny test.
Vadim Zeitlin [Wed, 8 May 2013 23:18:12 +0000 (23:18 +0000)] 
Another attempt to isolate memory corrupting wxAny test.

We now know it's either As() or GetAs() (or both).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73953 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoContinue bisecting tests crash in PPC OS X builds.
Vadim Zeitlin [Wed, 8 May 2013 22:01:02 +0000 (22:01 +0000)] 
Continue bisecting tests crash in PPC OS X builds.

Disable more wxAny tests.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73952 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix wxRichTextCtrl test compilation.
Vadim Zeitlin [Wed, 8 May 2013 22:00:11 +0000 (22:00 +0000)] 
Fix wxRichTextCtrl test compilation.

Work around broken pre-C++98 for loop scoping rules in VC6.

See #15184.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73951 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoReally disable wxAny tests under wxOSX.
Vadim Zeitlin [Wed, 8 May 2013 21:17:00 +0000 (21:17 +0000)] 
Really disable wxAny tests under wxOSX.

Instead of disabling them everywhere but there.

See r73944.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73950 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix duplicate wxContextMenuEvent generation in wxMSW.
Vadim Zeitlin [Wed, 8 May 2013 11:21:41 +0000 (11:21 +0000)] 
Fix duplicate wxContextMenuEvent generation in wxMSW.

Prevent WM_CONTEXTMENU from being propagated upwards the window parent chain
by DefWindowProc(), we already do it ourselves and not marking the message as
processed could result in multiple calls to the same wxEVT_CONTEXT_MENU
handler if it skipped the event.

See #13683.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73949 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix wrong wxUSE_ACCEL around wxUSE_HOTKEY-related code in wxMSW.
Vadim Zeitlin [Wed, 8 May 2013 11:21:37 +0000 (11:21 +0000)] 
Fix wrong wxUSE_ACCEL around wxUSE_HOTKEY-related code in wxMSW.

Closes #15193.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73948 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd wxVector<>::const_reverse_iterator.
Vadim Zeitlin [Wed, 8 May 2013 11:21:32 +0000 (11:21 +0000)] 
Add wxVector<>::const_reverse_iterator.

Provide this type too for compatibility with std::vector<>.

Closes #15192.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73947 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoCall InitializeModules instead of just module->Init(). This is needed so the module...
Robin Dunn [Tue, 7 May 2013 21:09:31 +0000 (21:09 +0000)] 
Call InitializeModules instead of just module->Init().  This is needed so the module will have the proper state and not cause an assert when the modules are cleaned up.  Since InitializeModules will skip any that are already initialized it doesn't hurt to call it for modules loaded later.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73946 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoTest for NULL associated frame in doc/view event handling code.
Vadim Zeitlin [Tue, 7 May 2013 15:56:53 +0000 (15:56 +0000)] 
Test for NULL associated frame in doc/view event handling code.

A view might not have any associated frame at all (this is probably a bad idea
but we don't seem to explicitly forbid this).

This should have been part of r73943, see #14314.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73945 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDisable more wxAny tests under OS X to try to find the buildbot crash.
Vadim Zeitlin [Tue, 7 May 2013 15:10:53 +0000 (15:10 +0000)] 
Disable more wxAny tests under OS X to try to find the buildbot crash.

Disabling wxVariantConversions test was not enough to fix the crash happening
in OS X PPC build slave, so disable a few more of them.

Temporarily do it for any wxOSX build, the run-time check for buildbot will be
restored later when I finally manage to find the problematic test(s?).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73944 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix for event propagation in "single document" doc/view mode.
Vadim Zeitlin [Tue, 7 May 2013 15:07:28 +0000 (15:07 +0000)] 
Fix for event propagation in "single document" doc/view mode.

Ensure that the events still get to wxDocManager even when we are using the
single document mode in which a view can be directly associated with the
parent frame.

Closes #14314.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73943 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDisable wxAny-to-wxVariant conversion test case under OS X.
Vadim Zeitlin [Mon, 6 May 2013 21:46:55 +0000 (21:46 +0000)] 
Disable wxAny-to-wxVariant conversion test case under OS X.

This is a blind attempt to fix the test crash under PPC OS X.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73942 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoApplied patches for #15184 (wxRichTextAction fix for when the command identifier...
Julian Smart [Mon, 6 May 2013 13:39:01 +0000 (13:39 +0000)] 
Applied patches for #15184 (wxRichTextAction fix for when the command identifier is wxRICHTEXT_CHANGE_OBJECT) and #15185 (Make adding/deleting wxRichTextTable rows and columns undoable)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73941 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix a typo in wxNumberFormatter styles documentation.
Vadim Zeitlin [Mon, 6 May 2013 13:08:43 +0000 (13:08 +0000)] 
Fix a typo in wxNumberFormatter styles documentation.

s/cab/can/

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73940 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoApplied patch #15183 (wxRichTextTable::DeleteColumns doesn't remove the deleted colum...
Julian Smart [Mon, 6 May 2013 08:54:48 +0000 (08:54 +0000)] 
Applied patch #15183 (wxRichTextTable::DeleteColumns doesn't remove the deleted columns: dghart)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73939 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd IEEE 754 single/double precision support to wxDataStream classes.
Vadim Zeitlin [Mon, 6 May 2013 00:31:03 +0000 (00:31 +0000)] 
Add IEEE 754 single/double precision support to wxDataStream classes.

Allow to optionally raed/write float/double values in IEEE 754 single/double
precision formats, respectively, instead of always using the extended
precision format for both of them.

This makes the code more flexible, allowing for better interoperability with
the other programs, and also allows to implement floating point functions in
these classes even when wxUSE_APPLE_IEEE is turned off (as can be the case
because of the licencing concerns for the code in extended.c).

Closes #10625.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73938 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoMinor wording fixes in wxDataStream classes documentation.
Vadim Zeitlin [Mon, 6 May 2013 00:30:59 +0000 (00:30 +0000)] 
Minor wording fixes in wxDataStream classes documentation.

Mostly just s/amount/number/

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73937 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoTest wxDataStream floating point methods in big endian format too.
Vadim Zeitlin [Mon, 6 May 2013 00:30:56 +0000 (00:30 +0000)] 
Test wxDataStream floating point methods in big endian format too.

Added a hack to test float/double reading/writing using
wxDataInputStream/wxDataOutputStream to the test case using big endian
extended float format too.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73936 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoNo changes, just a small optimization in DataStreamTestCase.
Vadim Zeitlin [Mon, 6 May 2013 00:30:53 +0000 (00:30 +0000)] 
No changes, just a small optimization in DataStreamTestCase.

Don't create streams on the heap completely unnecessarily, just allocate them
on the stack. This makes the code shorter, safer and slightly more efficient.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73935 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoNo real changes, just rename double variables to "d".
Vadim Zeitlin [Mon, 6 May 2013 00:30:49 +0000 (00:30 +0000)] 
No real changes, just rename double variables to "d".

Don't use "i" or "f" for double variable names, this is confusing, especially
when we do it inconsistently.

See #10625.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73934 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoExtract common parts of wxData{In,Out}putStream in a common base class.
Vadim Zeitlin [Mon, 6 May 2013 00:30:42 +0000 (00:30 +0000)] 
Extract common parts of wxData{In,Out}putStream in a common base class.

No real changes, just put BigEndianOrdered() and SetConv() methods and the
corresponding fields in a common wxDataStreamBase class instead of duplicating
them in wxDataInputStream and wxDataOutputStream.

This will make it simpler to add more features common to both classes in the
future, see #10625.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73933 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDon't use gtk_file_chooser_set_filename() for save file dialogs.
Vadim Zeitlin [Sun, 5 May 2013 16:17:50 +0000 (16:17 +0000)] 
Don't use gtk_file_chooser_set_filename() for save file dialogs.

This seems to be broken in old GTK+ versions, so use
gtk_file_chooser_set_current_name() and gtk_file_chooser_set_current_folder()
for save file dialogs which seem to work in all versions.

Closes #15133.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73932 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoSpeculative fix for wxWebView unit tests on OSX.
Steve Lamerton [Sun, 5 May 2013 11:48:47 +0000 (11:48 +0000)] 
Speculative fix for wxWebView unit tests on OSX.

Use stringByEvaluatingJavaScriptFromString as it is guaranteed to return an NSString.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73931 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoCorrect misleading error message in locale mismatch assert.
Vadim Zeitlin [Sun, 5 May 2013 00:07:05 +0000 (00:07 +0000)] 
Correct misleading error message in locale mismatch assert.

Don't advise people to use non-existent (or at least not publicly accessible)
wxSetLocale(), they should just create wxLocale objects instead.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73930 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse wxWindow::Refresh() instead of artificial wxPaintEvent in the test.
Vadim Zeitlin [Sun, 5 May 2013 00:00:01 +0000 (00:00 +0000)] 
Use wxWindow::Refresh() instead of artificial wxPaintEvent in the test.

This fixes memory leaks under wxMSW: as the test code didn't (and couldn't)
call wxPaintDCImpl::EndPaint(), there was a leak for each wxPaintEvent
generated in it since the changes to wxDC caching in r72938.

It's also preferable because it uses public API instead of feeding events to
the window which is not documented to work.

Unfortunately even using Refresh() still doesn't allow the test to work under
wxOSX.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73929 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix event handling order in doc/view framework.
Vadim Zeitlin [Sat, 4 May 2013 23:59:56 +0000 (23:59 +0000)] 
Fix event handling order in doc/view framework.

Ensure that the events are always (provided there is an open document)
processed in the following order:

1. wxDocument
2. wxView
3. wxDocManager
4. wxDocChildFrame
5. wxDocParentFrame
6. wxApp

Do this by forwarding the events from wxDocParentFrame to wxDocChildFrame
first and forward them from there to wxDocManager which -- and this part
remains unchanged -- in turn forwards them to the active wxView which finally
forwards them to wxDocument. This requires another condition in the event
handling code as we still must forward from wxDocParentFrame to wxDocManager
itself if there are no active children at all, but this is the only way to
have the same event order in all cases, whether the event is originally
received by wxDocChildFrame or wxDocParentFrame.

Document this and add a unit test verifying that things indeed work like this.

See #14314.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73928 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoForward events to active child at MSW, not wx, level in wxMDIParentFrame.
Vadim Zeitlin [Sat, 4 May 2013 23:59:51 +0000 (23:59 +0000)] 
Forward events to active child at MSW, not wx, level in wxMDIParentFrame.

We want to handle menu (and toolbar) events in the active MDI child before
handling them in the parent frame itself and the existing code achieved this
by forwarding wxEVT_MENU events at wx event processing level to the active
child. However this was not enough as the underlying MSW WM_COMMAND message
was still sent to the parent frame only and this could result in wx event not
being generated at all if the parent frame had a disabled menu item with the
same ID as (an enabled) item in the child frame, see #14314.

So forward WM_COMMAND directly to ensure that the correct window gets the
event in the first place. And this makes wxEVT_MENU forwarding in TryBefore()
unnecessary.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73927 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFactor out functions dealing with menus in the event propagation test.
Vadim Zeitlin [Sat, 4 May 2013 23:59:48 +0000 (23:59 +0000)] 
Factor out functions dealing with menus in the event propagation test.

No real changes, just refactor the code to allow testing for menu events in
other frames too.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73926 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd public wxDocManager::GetAnyUsableView().
Vadim Zeitlin [Sat, 4 May 2013 23:59:43 +0000 (23:59 +0000)] 
Add public wxDocManager::GetAnyUsableView().

This method tries to find the current view harder than GetCurrentView() and
always returns a non-NULL view if there are any open documents at all.

This is used by wxDocManager internally to find the view to apply the user
commands to and will also be needed in the upcoming changes outside of
wxDocManager, so just make this method public, as it seems that it could be
useful in user code too, especially if we could use some better fallback than
the first opened document (e.g. the last document the user interacted with
would be better).

This also clarifies the confusion between GetCurrentView() and GetActiveView(),
see #13296.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73925 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse correct line numbers in assert failures in event propagation test.
Vadim Zeitlin [Sat, 4 May 2013 23:59:40 +0000 (23:59 +0000)] 
Use correct line numbers in assert failures in event propagation test.

Replace the calls to CheckMenuEvent() helper with ASSERT_MENU_EVENT_RESULT()
macro to allow passing the correct line number to cppunit assertion function,
otherwise the line number of CheckMenuEvent() was always used in case of
failure.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73924 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoConsistently set wxMenuBar parent in all ports.
Vadim Zeitlin [Sat, 4 May 2013 23:59:37 +0000 (23:59 +0000)] 
Consistently set wxMenuBar parent in all ports.

Previously, wxGTK used the associated frame as wxMenuBar parent, while the
other ports did not. Do set the frame as menu bar parent in all ports now.

Of course, considering that wxMenuBar is not a window at all, this doesn't
necessarily make much sense, but at least it makes the behaviour consistent.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73923 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoPass menu events to the handler in the associated menu bar.
Vadim Zeitlin [Sat, 4 May 2013 23:59:32 +0000 (23:59 +0000)] 
Pass menu events to the handler in the associated menu bar.

We handled the menu events in the menu itself and the associated window, but
not in the menu bar that the menu belonged to. This was unexpected, so allow
handling the events in the menu bar itself too.

Closes #15095.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73922 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix menu event handlers calling order.
Vadim Zeitlin [Sat, 4 May 2013 23:59:29 +0000 (23:59 +0000)] 
Fix menu event handlers calling order.

Pass the menu event to the window associated with the menu first, before
falling back on wxApp.

This required adding yet another flag to keep state in wxEvent but it seems to
be unavoidable as wxMenuBase::SendEvent() calls ProcessEvent() twice and we
must have some way to distinguish the first call from the second one.

Added a test case verifying that the menu events are indeed processed in the
expected order.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73921 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoMention using wxString::c_str() with vararg functions in the change log.
Vadim Zeitlin [Thu, 2 May 2013 22:08:19 +0000 (22:08 +0000)] 
Mention using wxString::c_str() with vararg functions in the change log.

This is sufficiently important to be mentioned here in addition to the main
documentation. Especially considering that this results in run-time crashes
instead of (just) compile-time errors with MSVC.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73906 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoExpand wxString overview and document some problems due to its dual nature.
Vadim Zeitlin [Thu, 2 May 2013 22:08:15 +0000 (22:08 +0000)] 
Expand wxString overview and document some problems due to its dual nature.

Explain the possible problems with wxString due to its dual Unicode/ASCII
nature.

Also document the various conversions in the overview itself.

Closes #14694.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73905 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoCopy max width of wxGridCellTextEditor when cloning it.
Vadim Zeitlin [Wed, 1 May 2013 20:53:26 +0000 (20:53 +0000)] 
Copy max width of wxGridCellTextEditor when cloning it.

Previously the max number of characters that could be entered into the editor
was lost when it was cloned, making it impossible to really limit the user
entry.

Closes #15175.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73899 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoRemove the apparently unneeded wxPGPropArgCls default ctor.
Vadim Zeitlin [Wed, 1 May 2013 20:53:17 +0000 (20:53 +0000)] 
Remove the apparently unneeded wxPGPropArgCls default ctor.

This ctor didn't initialize the flags correctly and could result in a crash
when a default constructed object was destroyed.

Closes #15174.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73898 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoexport wxRichTextObjectPtrArrayArray since it is used in the public API.
Robin Dunn [Tue, 30 Apr 2013 20:23:39 +0000 (20:23 +0000)] 
export wxRichTextObjectPtrArrayArray since it is used in the public API.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73897 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoRichtext interface fixes and additions for Phoenix
Robin Dunn [Tue, 30 Apr 2013 20:23:30 +0000 (20:23 +0000)] 
Richtext interface fixes and additions for Phoenix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73896 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoRichtext interface fixes and additions for Phoenix
Robin Dunn [Tue, 30 Apr 2013 20:23:20 +0000 (20:23 +0000)] 
Richtext interface fixes and additions for Phoenix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73895 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDocumentation tweaks for wxFontInfo
Robin Dunn [Tue, 30 Apr 2013 20:07:58 +0000 (20:07 +0000)] 
Documentation tweaks for wxFontInfo

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73892 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd wxICON_AUTH_NEEDED
Robin Dunn [Tue, 30 Apr 2013 20:07:49 +0000 (20:07 +0000)] 
Add wxICON_AUTH_NEEDED

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73891 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoCompilation fix for wxFont in wxGTK1.
Vadim Zeitlin [Tue, 30 Apr 2013 15:39:18 +0000 (15:39 +0000)] 
Compilation fix for wxFont in wxGTK1.

wx/encinfo.h is not included from wx/wx.h so include it explicitly.

This is the same change as was done in r73519 for wxX11/wxMotif.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73890 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix wxFont test compilation after wxFont(int flags) ctor removal.
Vadim Zeitlin [Tue, 30 Apr 2013 11:13:21 +0000 (11:13 +0000)] 
Fix wxFont test compilation after wxFont(int flags) ctor removal.

Also mention this incompatible (since 2.9.4) change in the change log.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73889 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse WXUNUSED() to suppress unused parameter warnings.
Vadim Zeitlin [Tue, 30 Apr 2013 10:36:02 +0000 (10:36 +0000)] 
Use WXUNUSED() to suppress unused parameter warnings.

Just suppress a harmless warning in wxCarbon build.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73888 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoWork around harmless g++ warning about possible uninitialized variable.
Vadim Zeitlin [Tue, 30 Apr 2013 10:36:00 +0000 (10:36 +0000)] 
Work around harmless g++ warning about possible uninitialized variable.

Return from the function before using the variables in the (impossible) case
they are actually not initialized.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73887 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd a trivial virtual dtor to suppress g++ warnings.
Vadim Zeitlin [Tue, 30 Apr 2013 10:35:57 +0000 (10:35 +0000)] 
Add a trivial virtual dtor to suppress g++ warnings.

Add a useless but virtual dtor to ValidationTraverserBase private class to
avoid g++ warnings.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73886 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd wxFontInfo class to allow using named parameters for wxFont creation.
Vadim Zeitlin [Tue, 30 Apr 2013 10:27:38 +0000 (10:27 +0000)] 
Add wxFontInfo class to allow using named parameters for wxFont creation.

This helper class allows to create wxFonts using shorter and more readable
code, e.g.

wxFont font(12, wxFONTFLAG_DEFAULT,
    wxFONTSTYLE_NORMAL, wxFONTWEIGHT_NORMAL, true,
    "DejaVu Sans");

can now be written simply as

wxFont font(wxFontInfo(12).FaceName("DejaVu Sans").Underlined());

Remove the ctor from font flags added in r70445 as it's not needed any longer
now that we have this one and adding it resulted in compilation errors in the
existing code which compiled with 2.8 because of ambiguities between that ctor
and wxFont(int size, int family, int style, int weight. bool underlined, ...)
one, e.g.

wxFont(12, wxFONTFAMILY_SWISS, wxNORMAL, wxNORMAL)

didn't compile any more but it does compile again now.

See #9907.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73885 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAllow using wxDEFAULT as font size in wxOSX.
Vadim Zeitlin [Tue, 30 Apr 2013 10:27:32 +0000 (10:27 +0000)] 
Allow using wxDEFAULT as font size in wxOSX.

Using wxDEFAULT as the font size in wxOSX resulted in creating 70pt font,
change this to use the normal font size instead for compatibility with the
other platforms.

Also allow using -1 as wxDEFAULT for compatibility with wxGTK, see #12541.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73884 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix VC6 compilation after r73880.
Vadim Zeitlin [Mon, 29 Apr 2013 23:53:15 +0000 (23:53 +0000)] 
Fix VC6 compilation after r73880.

Work around the broken scoping for the variables declared inside for loops in
this compiler by declaring the loop variable once for all loops.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73881 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix assert when adding items with bitmaps wxBitmapComboBox.
Vadim Zeitlin [Mon, 29 Apr 2013 23:13:24 +0000 (23:13 +0000)] 
Fix assert when adding items with bitmaps wxBitmapComboBox.

The change of r73567 resulted in an assert when adding items with bitmaps to
wxBitmapComboBox without object client data. Fix the code added by this commit
to work for all kinds of client data, including wxClientData_None.

See #14892.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73880 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoTrying to blindly fix WebTestCase unit test failure.
Vadim Zeitlin [Mon, 29 Apr 2013 23:00:57 +0000 (23:00 +0000)] 
Trying to blindly fix WebTestCase unit test failure.

Navigate to about:blank initially, not "about:".

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73879 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd empty paragraph in wxRichTextTable::AddColumns() and AddRows().
Vadim Zeitlin [Mon, 29 Apr 2013 12:54:13 +0000 (12:54 +0000)] 
Add empty paragraph in wxRichTextTable::AddColumns() and AddRows().

Do the same thing in Add{Columns,Rows}() as in CreateTable() to ensure the
proper cell creation.

Closes #15153,

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73878 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd support for wxICON_AUTH_NEEDED to wxMessageDialog.
Vadim Zeitlin [Mon, 29 Apr 2013 12:54:08 +0000 (12:54 +0000)] 
Add support for wxICON_AUTH_NEEDED to wxMessageDialog.

Allow showing the standard "Authentication needed" dialog in the message boxes
under MSW.

Closes #15121.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73877 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoReally fix the problem with caret in wxGrid text editor under MSW.
Vadim Zeitlin [Sun, 28 Apr 2013 18:25:42 +0000 (18:25 +0000)] 
Really fix the problem with caret in wxGrid text editor under MSW.

The problem (see #11681) was due to not allowing the native control handle the
focus loss event. This, in turn, was due to the changes of r58969 which tried
to work around a crash which happened if the grid was destroyed from the code
of one of the user-defined event handlers called during the editor dismissal.

Fix both problems at once by calling event.Skip() in OnKillFocus() to let the
native handler have the event too and postponing the editor dismissal a little
by calling DisableCellEditControl() indirectly from a posted event handler
instead of immediately.

As this reverts the now unnecessary changes of r64646, it closes #15162.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73876 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoNo real changes, just make wxGridCellEditor accessors const.
Vadim Zeitlin [Sun, 28 Apr 2013 18:25:39 +0000 (18:25 +0000)] 
No real changes, just make wxGridCellEditor accessors const.

IsCreated(), GetControl() and GetCellAttr() should both be const, so make them
so.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73875 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agowxOSX: store the menu title when inserting it in the menu bar.
Vadim Zeitlin [Fri, 26 Apr 2013 20:00:52 +0000 (20:00 +0000)] 
wxOSX: store the menu title when inserting it in the menu bar.

We "lost" the menu title if the menu was inserted, and not appended, to the
menu bar, resulting wxMenuBar::GetMenuLabel[Text]() returning empty strings
for it in this case.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73870 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoRemove "Windows only" mention from wxTE_PROCESS_ENTER documentation.
Vadim Zeitlin [Fri, 26 Apr 2013 19:41:14 +0000 (19:41 +0000)] 
Remove "Windows only" mention from wxTE_PROCESS_ENTER documentation.

This style works for wxComboBox under GTK and OS X as well.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73869 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoTest wxTE_PROCESS_ENTER in the combobox page of the widgets sample.
Vadim Zeitlin [Fri, 26 Apr 2013 19:41:11 +0000 (19:41 +0000)] 
Test wxTE_PROCESS_ENTER in the combobox page of the widgets sample.

Remove the unused "File name" checkbox in this page and put "Process Enter"
one in its place to allow toggling wxTE_PROCESS_ENTER interactively to test
whether it works as expected.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73868 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoMinor visual enhancement in the combobox page of the widgets sample.
Vadim Zeitlin [Fri, 26 Apr 2013 19:41:07 +0000 (19:41 +0000)] 
Minor visual enhancement in the combobox page of the widgets sample.

Expand the lower static box to align it with the upper one, otherwise they
look really ugly, especially under Mac.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73867 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agorevert part of last change, run configure from the builddir or cwd, not from configur...
Robin Dunn [Fri, 26 Apr 2013 16:48:23 +0000 (16:48 +0000)] 
revert part of last change, run configure from the builddir or cwd, not from configure's location.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73866 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd wxEVT_DIRCTRL_CHANGED
Robin Dunn [Fri, 26 Apr 2013 06:37:25 +0000 (06:37 +0000)] 
Add wxEVT_DIRCTRL_CHANGED

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73856 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoChanges needed to help builder.py be more generic and working well with other modules
Robin Dunn [Fri, 26 Apr 2013 06:37:17 +0000 (06:37 +0000)] 
Changes needed to help builder.py be more generic and working well with other modules

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73855 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix generic wxDataViewToggleRenderer hit testing with any alignment.
Vadim Zeitlin [Thu, 25 Apr 2013 13:16:29 +0000 (13:16 +0000)] 
Fix generic wxDataViewToggleRenderer hit testing with any alignment.

This change reverts the changes of r73835 and r73838 to
wxDataViewToggleRenderer::WXActivateCell() and instead fix the bug with mouse
hit testing in this function in the wxDataViewMainWindow::OnMouse() itself.
The problem there was that it offset the coordinates of the event differently
depending on whether the column alignment was set or left as default. Now
always make the coordinates relative to the item (not cell) rectangle for
compatibility with GTK+ native version, which is enough to make the original,
i.e. before the changes of r73835, code work.

See #15144.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73854 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix compilation-breaking typo in the previous commit.
Vadim Zeitlin [Thu, 25 Apr 2013 12:54:50 +0000 (12:54 +0000)] 
Fix compilation-breaking typo in the previous commit.

s/LoadUrl/LoadURL/

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73853 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix wxWebView test setup failure under OS X.
Vadim Zeitlin [Thu, 25 Apr 2013 12:53:51 +0000 (12:53 +0000)] 
Fix wxWebView test setup failure under OS X.

Call LoadUrl() after associating our custom event handler with the browser
object as otherwise the wxEVT_WEBVIEW_LOADED event could be generated before
we were set up to catch it, resulting in the assertion failure inside
ENSURE_LOADED.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73852 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix wxEVT_DATAVIEW_COLUMN_HEADER_RIGHT_CLICK event type name.
Vadim Zeitlin [Thu, 25 Apr 2013 11:56:55 +0000 (11:56 +0000)] 
Fix wxEVT_DATAVIEW_COLUMN_HEADER_RIGHT_CLICK event type name.

Fix incorrect conflict resolution between the changes of r73823 and r73850:
the first renamed wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_RIGHT_CLICKED to
wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_RIGHT_CLICK while the latter renamed it
to wxEVT_DATAVIEW_COLUMN_HEADER_RIGHT_CLICKED. The proper new name is
wxEVT_DATAVIEW_COLUMN_HEADER_RIGHT_CLICK, use it instead.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73851 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoProvide shorter synonyms for wxEVT_XXX constants.
Vadim Zeitlin [Thu, 25 Apr 2013 10:11:03 +0000 (10:11 +0000)] 
Provide shorter synonyms for wxEVT_XXX constants.

Use the same short names as are used by the event table macros for the event
type constants themselves. This makes them much more comfortable to use, e.g.
Bind(wxEVT_BUTTON) compared to Bind(wxEVT_COMMAND_BUTTON_CLICKED).

The old long names are still kept for backwards compatibility and shouldn't be
removed as it doesn't really cost anything to continue providing them, but all
new event types should only use the short versions.

Closes #10661.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73850 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoSmall fixes after wxHtmlTagHandler::GetParser() addition.
Vadim Zeitlin [Thu, 25 Apr 2013 09:35:38 +0000 (09:35 +0000)] 
Small fixes after wxHtmlTagHandler::GetParser() addition.

Amend the changes of r73839:

- Don't use covariant return type for wxHtmlWinTagHandler::GetParser() as
  VC6, which we still support, doesn't like it. Besides, this seems
  unnecessary.

- Don't make GetParser() virtual at all as this doesn't appear to be necessary
  neither.

- Add "@since 2.9.5" to the documentation of the new method.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73849 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix showing back hidden columns and rows in wxGrid.
Vadim Zeitlin [Wed, 24 Apr 2013 09:01:57 +0000 (09:01 +0000)] 
Fix showing back hidden columns and rows in wxGrid.

While we don't support auto-sizing of the hidden columns and rows, we need to
still show them back when SetColSize() or SetRowSize() is called with -1
(a.k.a. wxGRID_AUTOSIZE) argument.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73848 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd documentation for some additional cell types so they can be seen in Phoenix
Robin Dunn [Wed, 24 Apr 2013 02:40:21 +0000 (02:40 +0000)] 
Add documentation for some additional cell types so they can be seen in Phoenix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73841 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd ctor for wxHtmlWinTagHandler
Robin Dunn [Wed, 24 Apr 2013 02:40:11 +0000 (02:40 +0000)] 
Add ctor for wxHtmlWinTagHandler

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73840 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd GetParser methods for the tag handlers
Robin Dunn [Wed, 24 Apr 2013 02:40:02 +0000 (02:40 +0000)] 
Add GetParser methods for the tag handlers

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73839 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoReally fix hit testing in the generic wxDataViewToggleRenderer.
Vadim Zeitlin [Tue, 23 Apr 2013 11:56:55 +0000 (11:56 +0000)] 
Really fix hit testing in the generic wxDataViewToggleRenderer.

The changes of r73835 fixed hit testing in horizontal direction but broke it
in the vertical one as the computed checkbox rectangle was not relative to the
cell rectangle as it should have been. Do fix this now.

See #15144.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73838 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd wxSocketBase::GetSocket().
Vadim Zeitlin [Mon, 22 Apr 2013 10:45:30 +0000 (10:45 +0000)] 
Add wxSocketBase::GetSocket().

Provide direct access to the underlying socket descriptor.

Closes #8829.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73837 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd test for correct short/long file names in wxDir.
Vadim Zeitlin [Mon, 22 Apr 2013 00:32:55 +0000 (00:32 +0000)] 
Add test for correct short/long file names in wxDir.

Verify that enumerating the files using the pattern *.foo doesn't match
*.foo.bar files, as it used to do under MSW.

See #3432.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73836 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix hit testing in generic wxDataViewToggleRenderer.
Vadim Zeitlin [Sun, 21 Apr 2013 17:39:43 +0000 (17:39 +0000)] 
Fix hit testing in generic wxDataViewToggleRenderer.

Handle clicks on the checkboxes in generic wxDataViewCtrl correctly by taking
into account that the checkbox rectangle is centred inside the total cell
rectangle.

Closes #15144.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73835 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoReset sorting column in generic wxDataViewCtrl properly.
Vadim Zeitlin [Sun, 21 Apr 2013 17:18:44 +0000 (17:18 +0000)] 
Reset sorting column in generic wxDataViewCtrl properly.

We could keep using the column previously used for sorting even after
UnsetAsSortKey() was called on it. Ensure that this doesn't happen by
resetting the owner wxDataViewCtrl sort column index too.

Closes #15160.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73834 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd wxTextEntryDialog::SetMaxLength().
Vadim Zeitlin [Sat, 20 Apr 2013 22:13:33 +0000 (22:13 +0000)] 
Add wxTextEntryDialog::SetMaxLength().

Allow restricting the maximal number of characters that can be entered in
wxTextEntryDialog.

Closes #15158.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73832 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoStandardize on using "Added" instead of "Add" in the change log.
Vadim Zeitlin [Sat, 20 Apr 2013 22:13:30 +0000 (22:13 +0000)] 
Standardize on using "Added" instead of "Add" in the change log.

As all the other verbs were used in the infinitive and not past tense, do the
same thing for this one too, especially as we already had a mix of both forms.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73831 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoEVT_TREE_STATE_IMAGE_CLICK is not Windows-only any more.
Vadim Zeitlin [Fri, 19 Apr 2013 10:47:16 +0000 (10:47 +0000)] 
EVT_TREE_STATE_IMAGE_CLICK is not Windows-only any more.

State images in wxTreeCtrl are now supported under all platforms.

See #9591.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73824 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoRemove "ED" suffix from EVT_DATAVIEW_COLUMN_HEADER_RIGHT_CLICKED.
Vadim Zeitlin [Wed, 17 Apr 2013 11:45:07 +0000 (11:45 +0000)] 
Remove "ED" suffix from EVT_DATAVIEW_COLUMN_HEADER_RIGHT_CLICKED.

The naming of this macro was inconsistent with other similar macros in
wxListCtrl and wxTreeCtrl and even EVT_DATAVIEW_COLUMN_HEADER_CLICK in
wxDataViewCtrl itself. Moreover, it was even documented under the wrong name
without "ED".

Clear this mess by removing the "ED" suffix while still keeping the old macro
name for compatibility.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73823 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDocument lack of wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_CLICK under OS X.
Vadim Zeitlin [Wed, 17 Apr 2013 11:36:38 +0000 (11:36 +0000)] 
Document lack of wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_CLICK under OS X.

The native versions don't contain any code to send it currently.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73822 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_CLICK name in the documentation.
Vadim Zeitlin [Wed, 17 Apr 2013 11:31:50 +0000 (11:31 +0000)] 
Fix wxEVT_COMMAND_DATAVIEW_COLUMN_HEADER_CLICK name in the documentation.

Unlike the corresponding event table macro, it doesn't have "ED" suffix.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73821 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd missing interface items for Phoenix
Robin Dunn [Wed, 17 Apr 2013 02:50:32 +0000 (02:50 +0000)] 
Add missing interface items for Phoenix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73817 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDocument that wxPoint(wxRealPoint) ctor truncates, not rounds.
Vadim Zeitlin [Tue, 16 Apr 2013 19:44:08 +0000 (19:44 +0000)] 
Document that wxPoint(wxRealPoint) ctor truncates, not rounds.

Also give an example showing how to do rounding instead.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73816 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoEnsure there is valid context for DrawRectangle
Robin Dunn [Fri, 12 Apr 2013 23:45:15 +0000 (23:45 +0000)] 
Ensure there is valid context for DrawRectangle

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73812 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoCheck that focused window is non-NULL before using it in wxComboCtrl.
Vadim Zeitlin [Thu, 11 Apr 2013 16:54:41 +0000 (16:54 +0000)] 
Check that focused window is non-NULL before using it in wxComboCtrl.

wxWindow::FindFocus() may return NULL, don't crash by attempting to
dereference the pointer returned by it.

Closes #15146.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73809 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd missing t_str() call to fix wxUSE_STL build after r73792.
Vadim Zeitlin [Thu, 11 Apr 2013 16:54:36 +0000 (16:54 +0000)] 
Add missing t_str() call to fix wxUSE_STL build after r73792.

Don't rely on implicit conversion from wxString to wxChar* which is not
available in all builds.

Closes #15145.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73808 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoalso check for the SDK in subtrees used by newer XCodes
Robin Dunn [Wed, 10 Apr 2013 23:06:21 +0000 (23:06 +0000)] 
also check for the SDK in subtrees used by newer XCodes

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73807 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdded chainable wxWizardPageSimple::Chain() overload.
Vadim Zeitlin [Wed, 10 Apr 2013 12:12:57 +0000 (12:12 +0000)] 
Added chainable wxWizardPageSimple::Chain() overload.

Add the simplest and most fool proof of chaining the pages in static wizards:
just chain several calls to the new, non-static, wxWizardPageSimple::Chain()
overload.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73806 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775