Further corrections to bitmap and blit code.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@24227 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/samples/image/image.cpp b/samples/image/image.cpp
index 8b45bf81b5a34f140dbf77fc76cfb624925e53de..7d6f8acd753a1cadf87a773884add33c6426a36d 100644 (file)
--- a/samples/image/image.cpp
+++ b/samples/image/image.cpp
@@ -716,17 +716,41 @@ void MyCanvas::OnPaint( wxPaintEvent &WXUNUSED(event) )
         dc.SetTextForeground( wxT("BLACK") );
     }
 
-    dc.DrawText(_T("XPM bitmap"), 30, 2230);
+    // For testing transparency
+    dc.SetBrush( *wxRED_BRUSH );
+    dc.DrawRectangle( 20, 2220, 560, 68 );
+    
+    dc.DrawText(_T("XPM bitmap"), 30, 2230 );
     if ( m_bmpSmileXpm.Ok() )
-    {
         dc.DrawBitmap(m_bmpSmileXpm, 30, 2250, TRUE);
-    }
 
-    dc.DrawText(_T("XPM icon"), 150, 2230);
+    dc.DrawText(_T("XPM icon"), 110, 2230 );
     if ( m_iconSmileXpm.Ok() )
-    {
-        dc.DrawIcon(m_iconSmileXpm, 150, 2250);
-    }
+        dc.DrawIcon(m_iconSmileXpm, 110, 2250);
+    
+    // testing icon -> bitmap conversion    
+    wxBitmap to_blit( m_iconSmileXpm );
+
+    dc.DrawText( _T("SubBitmap"), 170, 2230 );
+    wxBitmap sub = to_blit.GetSubBitmap( wxRect(0,0,15,15) );
+    dc.DrawBitmap( sub, 170, 2250, TRUE );
+
+    dc.DrawText( _T("Enlarged"), 250, 2230 );
+    dc.SetUserScale( 1.5, 1.5 );
+    dc.DrawBitmap( to_blit, (int)(250/1.5), (int)(2250/1.5), TRUE );
+    dc.SetUserScale( 2, 2 );
+    dc.DrawBitmap( to_blit, (int)(300/2), (int)(2250/2), TRUE );
+    dc.SetUserScale( 1.0, 1.0 );
+    
+    dc.DrawText( _T("Blit"), 400, 2230);
+    wxMemoryDC blit_dc;
+    blit_dc.SelectObject( to_blit );
+    dc.Blit( 400, 2250, to_blit.GetWidth(), to_blit.GetHeight(), &blit_dc, 0, 0, wxCOPY, TRUE );
+    dc.SetUserScale( 1.5, 1.5 );
+    dc.Blit( (int)(450/1.5), (int)(2250/1.5), to_blit.GetWidth(), to_blit.GetHeight(), &blit_dc, 0, 0, wxCOPY, TRUE );
+    dc.SetUserScale( 2, 2 );
+    dc.Blit( (int)(500/2), (int)(2250/2), to_blit.GetWidth(), to_blit.GetHeight(), &blit_dc, 0, 0, wxCOPY, TRUE );
+    dc.SetUserScale( 1.0, 1.0 );
 
     dc.DrawText( _T("ICO handler (1st image)"), 30, 2290 );
     if (my_horse_ico32 && my_horse_ico32->Ok())

diff --git a/src/gtk/bitmap.cpp b/src/gtk/bitmap.cpp
index 907d7f634b9e63373f6cfdbf384f79893a1b21a1..38a044b1aa640f50f1cf9e1a439a211a08231de5 100644 (file)
--- a/src/gtk/bitmap.cpp
+++ b/src/gtk/bitmap.cpp
@@ -417,16 +417,20 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
         int old_x = -1;
         guint32 old_pixval;
 
-        for (int w=0; w<width; w++)
+        for (int w = 0; w < width; w++)
         {
             guint32 pixval;
             int x = tablex[w];
             if (x == old_x)
                 pixval = old_pixval;
             else
+            {
                 pixval = gdk_image_get_pixel( img, x, tabley[h] );
+                old_pixval = pixval;
+                old_x = x;
+            }
                 
-            if (bpp==1)
+            if (bpp == 1)
             {
                 if (!pixval)
                 {
@@ -437,7 +441,7 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
                 
                 if ((w+1)%8==0)
                 {
-                    dst[h*dstbyteperline+w/8]=~outbyte;
+                    dst[h*dstbyteperline+w/8] = outbyte;
                     outbyte = 0;
                 }
             }
@@ -451,8 +455,8 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
         }
     
         // do not forget the last byte
-        if (bpp == 1)
-            dst[h*dstbyteperline+width/8] = ~outbyte;
+        if ((bpp == 1) && (width % 8 != 0))
+            dst[h*dstbyteperline+width/8] = outbyte;
     }
     
     gdk_image_destroy( img );
@@ -466,9 +470,8 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
     
     if (GetMask())
     {
-        bpp = 1;
-        dstbyteperline = width/8*bpp;
-        if (width*bpp % 8 != 0)
+        dstbyteperline = width/8;
+        if (width % 8 != 0)
             dstbyteperline++;
         dst = (char*) malloc(dstbyteperline*height);
         img = gdk_image_get( GetMask()->GetBitmap(), 0, 0, GetWidth(), GetHeight() );
@@ -476,10 +479,22 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
         for (int h = 0; h < height; h++)
         {
             char outbyte = 0;
+            int old_x = -1;
+            guint32 old_pixval;
     
-            for (int w=0; w<width; w++)
+            for (int w = 0; w < width; w++)
             {
-                guint32 pixval = gdk_image_get_pixel( img, tablex[w], tabley[h] );
+                guint32 pixval;
+                int x = tablex[w];
+                if (x == old_x)
+                    pixval = old_pixval;
+                else
+                {
+                    pixval = gdk_image_get_pixel( img, x, tabley[h] );
+                    old_pixval = pixval;
+                    old_x = x;
+                }
+                
                 if (pixval)
                 {
                     char bit=1;
@@ -487,22 +502,21 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
                     outbyte |= shift;
                 }
                 
-                if ((w+1)%8==0)
+                if ((w+1)%8 == 0)
                 {
-                    dst[h*dstbyteperline+w/8]=~outbyte;
+                    dst[h*dstbyteperline+w/8] = outbyte;
                     outbyte = 0;
                 }
             }
         
             // do not forget the last byte
-            if (bpp == 1)
-                dst[h*dstbyteperline+width/8] = ~outbyte;
+            if (width % 8 != 0)
+                dst[h*dstbyteperline+width/8] = outbyte;
         }
-        
-        wxBitmap mask_bmp( (const char *)dst, width, height, 1 );
-        wxMask* mask = new wxMask(mask_bmp);
+        wxMask* mask = new wxMask;
+        mask->m_bitmap = gdk_bitmap_create_from_data( wxGetRootWindow()->window, (gchar *) dst, width, height );
         bmp.SetMask(mask);
-        
+
         free( dst );
         gdk_image_destroy( img );
     }
@@ -1130,6 +1144,11 @@ wxBitmap wxBitmap::GetSubBitmap( const wxRect& rect) const
     else
     {
         GdkGC *gc = gdk_gc_new( ret.GetBitmap() );
+        GdkColor col;
+        col.pixel = 0xFFFFFF;
+        gdk_gc_set_foreground( gc, &col );
+        col.pixel = 0;
+        gdk_gc_set_background( gc, &col );
         gdk_wx_draw_bitmap( ret.GetBitmap(), gc, GetBitmap(), rect.x, rect.y, 0, 0, rect.width, rect.height );
         gdk_gc_destroy( gc );
     }
@@ -1140,7 +1159,12 @@ wxBitmap wxBitmap::GetSubBitmap( const wxRect& rect) const
         mask->m_bitmap = gdk_pixmap_new( wxGetRootWindow()->window, rect.width, rect.height, 1 );
 
         GdkGC *gc = gdk_gc_new( mask->m_bitmap );
-        gdk_wx_draw_bitmap( mask->m_bitmap, gc, M_BMPDATA->m_mask->m_bitmap, 0, 0, rect.x, rect.y, rect.width, rect.height );
+        GdkColor col;
+        col.pixel = 0xFFFFFF;
+        gdk_gc_set_foreground( gc, &col );
+        col.pixel = 0;
+        gdk_gc_set_background( gc, &col );
+        gdk_wx_draw_bitmap( mask->m_bitmap, gc, M_BMPDATA->m_mask->m_bitmap, rect.x, rect.y, 0, 0, rect.width, rect.height );
         gdk_gc_destroy( gc );
 
         ret.SetMask( mask );

diff --git a/src/gtk1/bitmap.cpp b/src/gtk1/bitmap.cpp
index 907d7f634b9e63373f6cfdbf384f79893a1b21a1..38a044b1aa640f50f1cf9e1a439a211a08231de5 100644 (file)
--- a/src/gtk1/bitmap.cpp
+++ b/src/gtk1/bitmap.cpp
@@ -417,16 +417,20 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
         int old_x = -1;
         guint32 old_pixval;
 
-        for (int w=0; w<width; w++)
+        for (int w = 0; w < width; w++)
         {
             guint32 pixval;
             int x = tablex[w];
             if (x == old_x)
                 pixval = old_pixval;
             else
+            {
                 pixval = gdk_image_get_pixel( img, x, tabley[h] );
+                old_pixval = pixval;
+                old_x = x;
+            }
                 
-            if (bpp==1)
+            if (bpp == 1)
             {
                 if (!pixval)
                 {
@@ -437,7 +441,7 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
                 
                 if ((w+1)%8==0)
                 {
-                    dst[h*dstbyteperline+w/8]=~outbyte;
+                    dst[h*dstbyteperline+w/8] = outbyte;
                     outbyte = 0;
                 }
             }
@@ -451,8 +455,8 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
         }
     
         // do not forget the last byte
-        if (bpp == 1)
-            dst[h*dstbyteperline+width/8] = ~outbyte;
+        if ((bpp == 1) && (width % 8 != 0))
+            dst[h*dstbyteperline+width/8] = outbyte;
     }
     
     gdk_image_destroy( img );
@@ -466,9 +470,8 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
     
     if (GetMask())
     {
-        bpp = 1;
-        dstbyteperline = width/8*bpp;
-        if (width*bpp % 8 != 0)
+        dstbyteperline = width/8;
+        if (width % 8 != 0)
             dstbyteperline++;
         dst = (char*) malloc(dstbyteperline*height);
         img = gdk_image_get( GetMask()->GetBitmap(), 0, 0, GetWidth(), GetHeight() );
@@ -476,10 +479,22 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
         for (int h = 0; h < height; h++)
         {
             char outbyte = 0;
+            int old_x = -1;
+            guint32 old_pixval;
     
-            for (int w=0; w<width; w++)
+            for (int w = 0; w < width; w++)
             {
-                guint32 pixval = gdk_image_get_pixel( img, tablex[w], tabley[h] );
+                guint32 pixval;
+                int x = tablex[w];
+                if (x == old_x)
+                    pixval = old_pixval;
+                else
+                {
+                    pixval = gdk_image_get_pixel( img, x, tabley[h] );
+                    old_pixval = pixval;
+                    old_x = x;
+                }
+                
                 if (pixval)
                 {
                     char bit=1;
@@ -487,22 +502,21 @@ wxBitmap wxBitmap::Rescale( int clipx, int clipy, int clipwidth, int clipheight,
                     outbyte |= shift;
                 }
                 
-                if ((w+1)%8==0)
+                if ((w+1)%8 == 0)
                 {
-                    dst[h*dstbyteperline+w/8]=~outbyte;
+                    dst[h*dstbyteperline+w/8] = outbyte;
                     outbyte = 0;
                 }
             }
         
             // do not forget the last byte
-            if (bpp == 1)
-                dst[h*dstbyteperline+width/8] = ~outbyte;
+            if (width % 8 != 0)
+                dst[h*dstbyteperline+width/8] = outbyte;
         }
-        
-        wxBitmap mask_bmp( (const char *)dst, width, height, 1 );
-        wxMask* mask = new wxMask(mask_bmp);
+        wxMask* mask = new wxMask;
+        mask->m_bitmap = gdk_bitmap_create_from_data( wxGetRootWindow()->window, (gchar *) dst, width, height );
         bmp.SetMask(mask);
-        
+
         free( dst );
         gdk_image_destroy( img );
     }
@@ -1130,6 +1144,11 @@ wxBitmap wxBitmap::GetSubBitmap( const wxRect& rect) const
     else
     {
         GdkGC *gc = gdk_gc_new( ret.GetBitmap() );
+        GdkColor col;
+        col.pixel = 0xFFFFFF;
+        gdk_gc_set_foreground( gc, &col );
+        col.pixel = 0;
+        gdk_gc_set_background( gc, &col );
         gdk_wx_draw_bitmap( ret.GetBitmap(), gc, GetBitmap(), rect.x, rect.y, 0, 0, rect.width, rect.height );
         gdk_gc_destroy( gc );
     }
@@ -1140,7 +1159,12 @@ wxBitmap wxBitmap::GetSubBitmap( const wxRect& rect) const
         mask->m_bitmap = gdk_pixmap_new( wxGetRootWindow()->window, rect.width, rect.height, 1 );
 
         GdkGC *gc = gdk_gc_new( mask->m_bitmap );
-        gdk_wx_draw_bitmap( mask->m_bitmap, gc, M_BMPDATA->m_mask->m_bitmap, 0, 0, rect.x, rect.y, rect.width, rect.height );
+        GdkColor col;
+        col.pixel = 0xFFFFFF;
+        gdk_gc_set_foreground( gc, &col );
+        col.pixel = 0;
+        gdk_gc_set_background( gc, &col );
+        gdk_wx_draw_bitmap( mask->m_bitmap, gc, M_BMPDATA->m_mask->m_bitmap, rect.x, rect.y, 0, 0, rect.width, rect.height );
         gdk_gc_destroy( gc );
 
         ret.SetMask( mask );