// resolve ambiguities among virtual functions inherited from both base
// classes
virtual void Clear();
+ virtual wxString GetValue() const;
virtual void SetValue(const wxString& value);
virtual wxString GetStringSelection() const
{ return wxChoice::GetStringSelection(); }
virtual void SetSelection(long from, long to)
{ wxTextEntry::SetSelection(from, to); }
virtual int GetSelection() const { return wxChoice::GetSelection(); }
- virtual void GetSelection(long *from, long *to) const
- { wxTextEntry::GetSelection(from, to); }
+ virtual void GetSelection(long *from, long *to) const;
virtual bool IsEditable() const;
virtual void DoSetToolTip(wxToolTip *tip);
#endif
+ // this is the overridden wxTextEntry method which should only be called
+ // when we do have an edit control so it asserts if this is not the case
virtual WXHWND GetEditHWND() const;
+ // this is the implementation of GetEditHWND() which can also be used when
+ // we don't have the edit control, it simply returns NULL then
+ //
+ // try not to use this function unless absolutely necessary (as in the
+ // message handling code where the edit control might not be created yet
+ // for the messages we receive during the control creation) as normally
+ // just testing for IsEditable() and using GetEditHWND() should be enough
+ WXHWND GetEditHWNDIfAvailable() const;
+
private:
DECLARE_DYNAMIC_CLASS_NO_COPY(wxComboBox)
DECLARE_EVENT_TABLE()
{
// combobox selection sometimes spontaneously changes when its
// size changes, restore it to the old value if necessary
+ if ( !GetEditHWNDIfAvailable() )
+ break;
+
long fromOld, toOld;
GetSelection(&fromOld, &toOld);
WXLRESULT result = wxChoice::MSWWindowProc(nMsg, wParam, lParam);
return wxChoice::MSWShouldPreProcessMessage(pMsg);
}
+WXHWND wxComboBox::GetEditHWNDIfAvailable() const
+{
+ POINT pt = { 4, 4 };
+ WXHWND hWndEdit = (WXHWND)::ChildWindowFromPoint(GetHwnd(), pt);
+ if ( hWndEdit == GetHWND() )
+ hWndEdit = NULL;
+
+ return hWndEdit;
+}
+
WXHWND wxComboBox::GetEditHWND() const
{
// this function should not be called for wxCB_READONLY controls, it is
- // the callers responsability to check this
+ // the callers responsibility to check this
wxASSERT_MSG( !HasFlag(wxCB_READONLY),
_T("read-only combobox doesn't have any edit control") );
- POINT pt;
- pt.x = pt.y = 4;
- HWND hwndEdit = ::ChildWindowFromPoint(GetHwnd(), pt);
- if ( !hwndEdit || hwndEdit == GetHwnd() )
- {
- wxFAIL_MSG(_T("combobox without edit control?"));
- }
+ WXHWND hWndEdit = GetEditHWNDIfAvailable();
+ wxASSERT_MSG( hWndEdit, _T("combobox without edit control?") );
- return (WXHWND)hwndEdit;
+ return hWndEdit;
}
// ----------------------------------------------------------------------------
// wxComboBox text control-like methods
// ----------------------------------------------------------------------------
+wxString wxComboBox::GetValue() const
+{
+ return HasFlag(wxCB_READONLY) ? GetStringSelection()
+ : wxTextEntry::GetValue();
+}
+
void wxComboBox::SetValue(const wxString& value)
{
if ( HasFlag(wxCB_READONLY) )
wxTextEntry::Clear();
}
+void wxComboBox::GetSelection(long *from, long *to) const
+{
+ if ( !HasFlag(wxCB_READONLY) )
+ {
+ wxTextEntry::GetSelection(from, to);
+ }
+ else // text selection doesn't make sense for read only comboboxes
+ {
+ if ( from )
+ *from = -1;
+ if ( to )
+ *to = -1;
+ }
+}
+
bool wxComboBox::IsEditable() const
{
return !HasFlag(wxCB_READONLY) && wxTextEntry::IsEditable();