Added comments explaining more about the changes in my last commit. Also, removed...

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@32845 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/unix/gsocket.cpp b/src/unix/gsocket.cpp
index 4c99c3787a4b62ec1dc286f622c65d91005235d7..8b59a145cb09e497a9d4637cc4ad675582dd1bd5 100644 (file)
--- a/src/unix/gsocket.cpp
+++ b/src/unix/gsocket.cpp
@@ -156,6 +156,10 @@ int _System soclose(int);
   signal(SIGPIPE, old_handler);             \
 }
 
   signal(SIGPIPE, old_handler);             \
 }
 

+/* If a SIGPIPE is issued by a socket call on a remotely closed socket,
+   the program will "crash" unless it explicitly handles the SIGPIPE.
+   By using MSG_NOSIGNAL, the SIGPIPE is suppressed. Later, we will
+   use SO_NOSIGPIPE (if available), the BSD equivalent. */

 #ifdef MSG_NOSIGNAL
 #  define GSOCKET_MSG_NOSIGNAL MSG_NOSIGNAL
 #else /* MSG_NOSIGNAL not available (FreeBSD including OS X) */
 #ifdef MSG_NOSIGNAL
 #  define GSOCKET_MSG_NOSIGNAL MSG_NOSIGNAL
 #else /* MSG_NOSIGNAL not available (FreeBSD including OS X) */


@@ -539,11 +543,6 @@ GSocket *GSocket::WaitConnection()
 
   assert(this);
 
 
   assert(this);
 

-#ifndef __DARWIN__
-  /* Reenable CONNECTION events */
-  Enable(GSOCK_CONNECTION);
-#endif
-

   /* If the socket has already been created, we exit immediately */
   if (m_fd == INVALID_SOCKET || !m_server)
   {
   /* If the socket has already been created, we exit immediately */
   if (m_fd == INVALID_SOCKET || !m_server)
   {


@@ -570,10 +569,8 @@ GSocket *GSocket::WaitConnection()
 
   connection->m_fd = accept(m_fd, &from, (SOCKLEN_T *) &fromlen);
 
 
   connection->m_fd = accept(m_fd, &from, (SOCKLEN_T *) &fromlen);
 

-#ifdef __DARWIN__

   /* Reenable CONNECTION events */
   Enable(GSOCK_CONNECTION);
   /* Reenable CONNECTION events */
   Enable(GSOCK_CONNECTION);

-#endif

 
   if (connection->m_fd == INVALID_SOCKET)
   {
 
   if (connection->m_fd == INVALID_SOCKET)
   {


@@ -701,6 +698,8 @@ GSocketError GSocket::Connect(GSocketStream stream)
   /* Connect it to the peer address, with a timeout (see below) */
   ret = connect(m_fd, m_peer->m_addr, m_peer->m_len);
 
   /* Connect it to the peer address, with a timeout (see below) */
   ret = connect(m_fd, m_peer->m_addr, m_peer->m_len);
 

+  /* We only call Enable_Events if we know e aren't shutting down the socket */
+

   if (m_non_blocking)
   {
     gs_gui_functions->Enable_Events(this);
   if (m_non_blocking)
   {
     gs_gui_functions->Enable_Events(this);


@@ -1303,7 +1302,7 @@ int GSocket::Recv_Stream(char *buffer, int size)
   do 
   {
     ret = recv(m_fd, buffer, size, GSOCKET_MSG_NOSIGNAL);
   do 
   {
     ret = recv(m_fd, buffer, size, GSOCKET_MSG_NOSIGNAL);

-  } while (ret == -1 && errno == EINTR);
+  } while (ret == -1 && errno == EINTR); /* Loop until not interrupted */

   return ret;
 }
 
   return ret;
 }
 


@@ -1319,7 +1318,7 @@ int GSocket::Recv_Dgram(char *buffer, int size)
   do 
   {
     ret = recvfrom(m_fd, buffer, size, 0, &from, (SOCKLEN_T *) &fromlen);
   do 
   {
     ret = recvfrom(m_fd, buffer, size, 0, &from, (SOCKLEN_T *) &fromlen);

-  } while (ret == -1 && errno == EINTR);
+  } while (ret == -1 && errno == EINTR); /* Loop until not interrupted */

 
   if (ret == -1)
     return -1;
 
   if (ret == -1)
     return -1;


@@ -1356,7 +1355,7 @@ int GSocket::Send_Stream(const char *buffer, int size)
   do 
   {
     ret = send(m_fd, (char *)buffer, size, GSOCKET_MSG_NOSIGNAL);
   do 
   {
     ret = send(m_fd, (char *)buffer, size, GSOCKET_MSG_NOSIGNAL);

-  } while (ret == -1 && errno == EINTR);
+  } while (ret == -1 && errno == EINTR); /* Loop until not interrupted */

 #ifndef __VISAGECPP__
   UNMASK_SIGNAL();
 #endif
 #ifndef __VISAGECPP__
   UNMASK_SIGNAL();
 #endif


@@ -1389,7 +1388,7 @@ int GSocket::Send_Dgram(const char *buffer, int size)
   do 
   {
     ret = sendto(m_fd, (char *)buffer, size, 0, addr, len);
   do 
   {
     ret = sendto(m_fd, (char *)buffer, size, 0, addr, len);

-  } while (ret == -1 && errno == EINTR);
+  } while (ret == -1 && errno == EINTR); /* Loop until not interrupted */

 #ifndef __VISAGECPP__
   UNMASK_SIGNAL();
 #endif
 #ifndef __VISAGECPP__
   UNMASK_SIGNAL();
 #endif


@@ -1436,6 +1435,7 @@ void GSocket::Detected_Read()
     }
     else
     {
     }
     else
     {

+      /* Do not throw a lost event in cases where the socket isn't really lost */

       if ((errno == EWOULDBLOCK) || (errno == EAGAIN) || (errno == EINTR)) 
       {
         CALL_CALLBACK(this, GSOCK_INPUT);
       if ((errno == EWOULDBLOCK) || (errno == EAGAIN) || (errno == EINTR)) 
       {
         CALL_CALLBACK(this, GSOCK_INPUT);