Make wxMotif buttons smaller (and nicer) by default,

with the option of reverting to the old behaviour.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@27059 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/docs/changes.txt b/docs/changes.txt
index 3fc742c9d7272a2940d5e1b016f016a10e0e3a47..ea72d3a3f27e2f898cf8d62587157e28e3c6eda8 100644 (file)
--- a/docs/changes.txt
+++ b/docs/changes.txt
@@ -133,6 +133,9 @@ wxMSW:
 wxMotif:
 
 - removed wxMenuItem::DeleteSubMenu()
 wxMotif:
 
 - removed wxMenuItem::DeleteSubMenu()

+- wxButtons use Motif default size, which is smaller than it used to be
+  and closer to wxMSW/wxGTK look. This can be disabled by setting
+  motif.largebuttons system option to 1 (see wxSystemOptions).

 
 wxUniv/X11:
 
 
 wxUniv/X11:
 

diff --git a/include/wx/motif/button.h b/include/wx/motif/button.h
index 8a5044d68b2693da67348797ccba5685b6c575e9..32958d5753144ef9ac5382baa3ffde590492918c 100644 (file)
--- a/include/wx/motif/button.h
+++ b/include/wx/motif/button.h
@@ -48,6 +48,7 @@ public:
     // Implementation
 private:
     virtual wxSize DoGetBestSize() const;
     // Implementation
 private:
     virtual wxSize DoGetBestSize() const;

+    wxSize OldGetBestSize() const;

     void SetDefaultShadowThicknessAndResize();
 };
 
     void SetDefaultShadowThicknessAndResize();
 };
 

diff --git a/src/motif/button.cpp b/src/motif/button.cpp
index c8bdc6af8994967033b314da1df1273ec86b554b..a1afbd74be9c620718f22689b541896c25959471 100644 (file)
--- a/src/motif/button.cpp
+++ b/src/motif/button.cpp
@@ -34,11 +34,15 @@
 #endif
 
 #include "wx/motif/private.h"
 #endif
 
 #include "wx/motif/private.h"

+#include "wx/sysopt.h"

 
 void wxButtonCallback (Widget w, XtPointer clientData, XtPointer ptr);
 
 IMPLEMENT_DYNAMIC_CLASS(wxButton, wxControl)
 
 
 void wxButtonCallback (Widget w, XtPointer clientData, XtPointer ptr);
 
 IMPLEMENT_DYNAMIC_CLASS(wxButton, wxControl)
 

+#define MIN_WIDTH 78
+#define MIN_LARGE_HEIGHT 30
+

 // Button
 
 bool wxButton::Create(wxWindow *parent, wxWindowID id, const wxString& label,
 // Button
 
 bool wxButton::Create(wxWindow *parent, wxWindowID id, const wxString& label,


@@ -87,7 +91,7 @@ bool wxButton::Create(wxWindow *parent, wxWindowID id, const wxString& label,
 
     ChangeBackgroundColour();
 
 
     ChangeBackgroundColour();
 

-    return TRUE;
+    return true;

 }
 
 void wxButton::SetDefaultShadowThicknessAndResize()
 }
 
 void wxButton::SetDefaultShadowThicknessAndResize()


@@ -144,15 +148,36 @@ void wxButton::SetDefault()
                    NULL);
 }
 
                    NULL);
 }
 

+static inline bool wxMotifLargeButtons()
+{
+    return wxSystemOptions::HasOption("motif.largebuttons")
+        && wxSystemOptions::GetOptionInt("motif.largebuttons") != 0;
+}
+

 /* static */
 wxSize wxButton::GetDefaultSize()
 {
     // TODO: check font size as in wxMSW ?  MB
     // Note: this is the button size (text + margin + shadow + defaultBorder)
 /* static */
 wxSize wxButton::GetDefaultSize()
 {
     // TODO: check font size as in wxMSW ?  MB
     // Note: this is the button size (text + margin + shadow + defaultBorder)

-    return wxSize(78,30);
+    return wxSize( MIN_WIDTH, MIN_LARGE_HEIGHT );

 }
 
 wxSize wxButton::DoGetBestSize() const
 }
 
 wxSize wxButton::DoGetBestSize() const

+{
+    if( wxMotifLargeButtons() )
+        return OldGetBestSize();
+
+    wxSize best = wxControl::DoGetBestSize();
+
+    if( HasFlag( wxBU_EXACTFIT ) )
+        return best;
+    else if( best.x < MIN_WIDTH )
+        best.x = MIN_WIDTH;
+
+    return best;
+}
+
+wxSize wxButton::OldGetBestSize() const

 {
     Dimension xmargin, ymargin, highlight, shadow, defThickness;
 
 {
     Dimension xmargin, ymargin, highlight, shadow, defThickness;