fix for infinite loop when wxBeginBusyCursor is called from idle handler, #1547

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@55463 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/gtk/cursor.cpp b/src/gtk/cursor.cpp
index 63a0340630007c2e79928c0fc44a74566a7b4f7b..8e9c50a44e410e7634233c56e7d3ee1aca06b1cb 100644 (file)
--- a/src/gtk/cursor.cpp
+++ b/src/gtk/cursor.cpp
@@ -13,10 +13,9 @@
 #include "wx/cursor.h"
 
 #ifndef WX_PRECOMP
 #include "wx/cursor.h"
 
 #ifndef WX_PRECOMP

+    #include "wx/window.h"

     #include "wx/app.h"
     #include "wx/app.h"

-    #include "wx/utils.h"

     #include "wx/image.h"
     #include "wx/image.h"

-    #include "wx/colour.h"

     #include "wx/bitmap.h"
 #endif // WX_PRECOMP
 
     #include "wx/bitmap.h"
 #endif // WX_PRECOMP
 


@@ -345,19 +344,31 @@ const wxCursor wxBusyCursor::GetBusyCursor()
     return wxCursor(wxCURSOR_WATCH);
 }
 
     return wxCursor(wxCURSOR_WATCH);
 }
 

+static void InternalIdle(const wxWindowList& list, GdkDisplay*& display)
+{
+    wxWindowList::const_iterator i = list.begin();
+    for (size_t n = list.size(); n--; ++i)
+    {
+        wxWindow* win = *i;
+        if (display == NULL && win->m_widget && win->m_widget->window)
+            display = gdk_drawable_get_display(win->m_widget->window);
+        win->OnInternalIdle();
+        InternalIdle(win->GetChildren(), display);
+    }
+}
+

 void wxEndBusyCursor()
 {
     if (--gs_busyCount > 0)
         return;
 
 void wxEndBusyCursor()
 {
     if (--gs_busyCount > 0)
         return;
 

-    wxSetCursor( gs_savedCursor );
+    g_globalCursor = gs_savedCursor;

     gs_savedCursor = wxNullCursor;
     gs_savedCursor = wxNullCursor;

-
-    if (wxTheApp)
-        wxTheApp->ProcessIdle();
+    GdkDisplay* unused = NULL;
+    InternalIdle(wxTopLevelWindows, unused);

 }
 
 }
 

-void wxBeginBusyCursor( const wxCursor *WXUNUSED(cursor) )
+void wxBeginBusyCursor(const wxCursor* cursor)

 {
     if (gs_busyCount++ > 0)
         return;
 {
     if (gs_busyCount++ > 0)
         return;


@@ -366,13 +377,11 @@ void wxBeginBusyCursor( const wxCursor *WXUNUSED(cursor) )
                   wxT("forgot to call wxEndBusyCursor, will leak memory") );
 
     gs_savedCursor = g_globalCursor;
                   wxT("forgot to call wxEndBusyCursor, will leak memory") );
 
     gs_savedCursor = g_globalCursor;

-
-    wxSetCursor( wxCursor(wxCURSOR_WATCH) );
-
-    if (wxTheApp)
-        wxTheApp->ProcessIdle();
-
-    gdk_flush();
+    g_globalCursor = *cursor;
+    GdkDisplay* display = NULL;
+    InternalIdle(wxTopLevelWindows, display);
+    if (display)
+        gdk_display_flush(display);

 }
 
 bool wxIsBusy()
 }
 
 bool wxIsBusy()