Move "static" keyword out from wxDEPRECATED() macros to placate icc.

Intel compiler gives warnings if the static keyword is not at the beginning of
the declaration and this happened when using it inside wxDEPRECATED() and
related macros because the declaration started with __declspec(deprecated) or
__attribute__((deprecated)) instead.

To avoid this problem, simply move "static" outside the macro.

Closes #12932.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66966 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/include/wx/artprov.h b/include/wx/artprov.h
index 2dbf51a23a44927fcb2043b2f5120a09e9a9694c..7eef3973c4266c2fd1a0d479e6d086ea1ccbccfb 100644 (file)
--- a/include/wx/artprov.h
+++ b/include/wx/artprov.h
@@ -136,7 +136,7 @@ public:
 
 #if WXWIN_COMPATIBILITY_2_8
     // use PushBack(), it's the same thing
-    wxDEPRECATED( static void Insert(wxArtProvider *provider) );
+    static wxDEPRECATED( void Insert(wxArtProvider *provider) );
 #endif
 
     // Remove latest added provider and delete it.
@@ -189,14 +189,14 @@ public:
 
 #if WXWIN_COMPATIBILITY_2_6
     // use the corresponding methods without redundant "Provider" suffix
-    wxDEPRECATED( static void PushProvider(wxArtProvider *provider) );
-    wxDEPRECATED( static void InsertProvider(wxArtProvider *provider) );
-    wxDEPRECATED( static bool PopProvider() );
+    static wxDEPRECATED( void PushProvider(wxArtProvider *provider) );
+    static wxDEPRECATED( void InsertProvider(wxArtProvider *provider) );
+    static wxDEPRECATED( bool PopProvider() );
 
     // use Delete() if this is what you really need, or just delete the
     // provider pointer, do not use Remove() as it does not delete the pointer
     // unlike RemoveProvider() which does
-    wxDEPRECATED( static bool RemoveProvider(wxArtProvider *provider) );
+    static wxDEPRECATED( bool RemoveProvider(wxArtProvider *provider) );
 #endif // WXWIN_COMPATIBILITY_2_6
 
 protected:

diff --git a/include/wx/colour.h b/include/wx/colour.h
index 3de95570f11792d121f27a45ca365f4fcfe2cdef..cf19ba4838ead09f9dd46de2949dcec9a726ccc4 100644 (file)
--- a/include/wx/colour.h
+++ b/include/wx/colour.h
@@ -172,7 +172,7 @@ public:
     // ---------------
 
 #if WXWIN_COMPATIBILITY_2_6
-    wxDEPRECATED( static wxColour CreateByName(const wxString& name) );
+    static wxDEPRECATED( wxColour CreateByName(const wxString& name) );
     wxDEPRECATED( void InitFromName(const wxString& col) );
 #endif
 

diff --git a/include/wx/image.h b/include/wx/image.h
index bfb21298816090da95bdd1cdf983d0a00f783995..43e7115ea03bde494c2bd5fd4c0dcc11c2ab47bf 100644 (file)
--- a/include/wx/image.h
+++ b/include/wx/image.h
@@ -561,15 +561,15 @@ public:
         }
     )
 
-    wxDEPRECATED(
-        static wxImageHandler *FindHandler(const wxString& ext, long type)
+    static wxDEPRECATED(
+        wxImageHandler *FindHandler(const wxString& ext, long type)
         {
             return FindHandler(ext, (wxBitmapType)type);
         }
     )
 
-    wxDEPRECATED(
-        static wxImageHandler *FindHandler(long imageType)
+    static wxDEPRECATED(
+        wxImageHandler *FindHandler(long imageType)
         {
             return FindHandler((wxBitmapType)imageType);
         }

diff --git a/include/wx/log.h b/include/wx/log.h
index 71903146580a38e228e2952fc371f05cb668e06f..8f872af38e273d1f3be2553cd1bee01f93af4d04 100644 (file)
--- a/include/wx/log.h
+++ b/include/wx/log.h
@@ -522,14 +522,14 @@ public:
 
 #if WXWIN_COMPATIBILITY_2_6
     // this function doesn't do anything any more, don't call it
-    wxDEPRECATED_INLINE(
-        static wxChar *SetLogBuffer(wxChar *, size_t = 0), return NULL;
+    static wxDEPRECATED_INLINE(
+        wxChar *SetLogBuffer(wxChar *, size_t = 0), return NULL;
     );
 #endif // WXWIN_COMPATIBILITY_2_6
 
     // don't use integer masks any more, use string trace masks instead
 #if WXWIN_COMPATIBILITY_2_8
-    wxDEPRECATED_INLINE( static void SetTraceMask(wxTraceMask ulMask),
+    static wxDEPRECATED_INLINE( void SetTraceMask(wxTraceMask ulMask),
         ms_ulTraceMask = ulMask; )
 
     // this one can't be marked deprecated as it's used in our own wxLogger

diff --git a/include/wx/menuitem.h b/include/wx/menuitem.h
index 51ce402b49cb0516a898bbf3d550cfe197224abd..9dfb98e094dc2b8faf432885f47ed3ea0cab286c 100644 (file)
--- a/include/wx/menuitem.h
+++ b/include/wx/menuitem.h
@@ -127,7 +127,7 @@ public:
     wxDEPRECATED( const wxString& GetText() const );
 
     // Now use GetLabelText to strip the accelerators
-    wxDEPRECATED( static wxString GetLabelFromText(const wxString& text) );
+    static wxDEPRECATED( wxString GetLabelFromText(const wxString& text) );
 
     // Now use SetItemLabel
     wxDEPRECATED( virtual void SetText(const wxString& str) );

diff --git a/include/wx/validate.h b/include/wx/validate.h
index f6832d16d154a6d1149dad36f368f488cd93ea95..27473364bcd665b29e140a570eb0e9ad7c63f4a2 100644 (file)
--- a/include/wx/validate.h
+++ b/include/wx/validate.h
@@ -74,8 +74,8 @@ public:
     // unnaturally: it disabled the bell when it was true, not false as could
     // be expected; use SuppressBellOnError() instead
 #if WXWIN_COMPATIBILITY_2_8
-    wxDEPRECATED_INLINE(
-        static void SetBellOnError(bool doIt = true),
+    static wxDEPRECATED_INLINE(
+        void SetBellOnError(bool doIt = true),
         ms_isSilent = doIt;
     )
 #endif