fix some (harmless) mingw32 4.3 warnings

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@55376 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/generic/datavgen.cpp b/src/generic/datavgen.cpp
index f9e574216ddf825f42cb2c2b3ee64046a47e44cf..8ab4f85c53765b875efcbed747cdf53ff60095a7 100644 (file)
--- a/src/generic/datavgen.cpp
+++ b/src/generic/datavgen.cpp
@@ -1364,7 +1364,7 @@ bool wxDataViewHeaderWindowMSW::Create( wxDataViewCtrl *parent, wxWindowID id,
     }
 
     m_imageList = new wxImageList( 16, 16 );
     }
 
     m_imageList = new wxImageList( 16, 16 );

-    Header_SetImageList( (HWND) m_hWnd, m_imageList->GetHIMAGELIST() );
+    (void)Header_SetImageList((HWND) m_hWnd, m_imageList->GetHIMAGELIST());

 
     // we need to subclass the m_hWnd to force wxWindow::HandleNotify
     // to call wxDataViewHeaderWindow::MSWOnNotify
 
     // we need to subclass the m_hWnd to force wxWindow::HandleNotify
     // to call wxDataViewHeaderWindow::MSWOnNotify

diff --git a/src/msw/listctrl.cpp b/src/msw/listctrl.cpp
index ff4b32b8024ae4e0e322884554a60d8834afb9e8..6bdf97590dfb69f7f51273225507e721acf56be7 100644 (file)
--- a/src/msw/listctrl.cpp
+++ b/src/msw/listctrl.cpp
@@ -2831,10 +2831,10 @@ WXLPARAM wxListCtrl::OnCustomDraw(WXLPARAM lParam)
 // Necessary for drawing hrules and vrules, if specified
 void wxListCtrl::OnPaint(wxPaintEvent& event)
 {
 // Necessary for drawing hrules and vrules, if specified
 void wxListCtrl::OnPaint(wxPaintEvent& event)
 {

-    bool drawHRules = HasFlag(wxLC_HRULES);
-    bool drawVRules = HasFlag(wxLC_VRULES);
+    const bool drawHRules = HasFlag(wxLC_HRULES);
+    const bool drawVRules = HasFlag(wxLC_VRULES);

 
 

-    if (!InReportView() || !drawHRules && !drawVRules)
+    if (!InReportView() || !(drawHRules || drawVRules))

     {
         event.Skip();
         return;
     {
         event.Skip();
         return;

diff --git a/src/stc/ScintillaWX.cpp b/src/stc/ScintillaWX.cpp
index 3f2b272c819b71d26b715e435631de81477cd2e5..0ac6b14415b157718c16741d4bc94baff2c74717 100644 (file)
--- a/src/stc/ScintillaWX.cpp
+++ b/src/stc/ScintillaWX.cpp
@@ -617,8 +617,8 @@ void ScintillaWX::UpdateSystemCaret() {
 
 bool ScintillaWX::HasCaretSizeChanged() {
 #ifdef __WXMSW__
 
 bool ScintillaWX::HasCaretSizeChanged() {
 #ifdef __WXMSW__

-    if (( (0 != vs.caretWidth) && (sysCaretWidth != vs.caretWidth) )
-        || (0 != vs.lineHeight) && (sysCaretHeight != vs.lineHeight)) {
+    if ( (vs.caretWidth && (sysCaretWidth != vs.caretWidth))
+        || (vs.lineHeight && (sysCaretHeight != vs.lineHeight)) ) {

         return true;
     }
 #endif
         return true;
     }
 #endif