We need to use RemoveTree() to remove watches for the paths added with
AddTree().
See #14480.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72067
c3d73ce0-8a6f-49c7-b76d-
6d57e0e08775
filename,
type == wxFSWPath_Dir ? "directory" : "directory tree");
filename,
type == wxFSWPath_Dir ? "directory" : "directory tree");
bool ok = false;
switch ( type )
{
case wxFSWPath_Dir:
ok = m_watcher->Add(wxFileName::DirName(filename));
bool ok = false;
switch ( type )
{
case wxFSWPath_Dir:
ok = m_watcher->Add(wxFileName::DirName(filename));
break;
case wxFSWPath_Tree:
ok = m_watcher->AddTree(wxFileName::DirName(filename));
break;
case wxFSWPath_Tree:
ok = m_watcher->AddTree(wxFileName::DirName(filename));
break;
case wxFSWPath_File:
break;
case wxFSWPath_File:
- m_filesList->InsertItem(m_filesList->GetItemCount(), filename);
+ // Prepend 'prefix' to the filepath, partly for display
+ // but mostly so that OnRemove() can work out the correct way to remove it
+ m_filesList->InsertItem(m_filesList->GetItemCount(),
+ prefix + wxFileName::DirName(filename).GetFullPath());
}
void MyFrame::OnRemove(wxCommandEvent& WXUNUSED(event))
}
void MyFrame::OnRemove(wxCommandEvent& WXUNUSED(event))
- wxString path = m_filesList->GetItemText(idx);
-
+ bool ret;
+ wxString path;
// TODO we know it is a dir, but it doesn't have to be
// TODO we know it is a dir, but it doesn't have to be
- if (!m_watcher->Remove(wxFileName::DirName(path)))
+ if (m_filesList->GetItemText(idx).StartsWith("Dir: ", &path))
+ {
+ ret = m_watcher->Remove(wxFileName::DirName(path));
+ }
+ else if (m_filesList->GetItemText(idx).StartsWith("Tree: ", &path))
+ {
+ ret = m_watcher->RemoveTree(wxFileName::DirName(path));
+ }
+ else
+ {
+ wxFAIL_MSG("Unexpected item in wxListView.");
+ }
+
+ if (!ret)
{
wxLogError("Error removing '%s' from watched paths", path);
}
{
wxLogError("Error removing '%s' from watched paths", path);
}