wxCC_POPUP_ON_MOUSE_UP = 0x0002,
// All text is not automatically selected on click
wxCC_NO_TEXT_AUTO_SELECT = 0x0004,
+ // Drop-button stays down as long as popup is displayed.
+ wxCC_BUTTON_STAYS_DOWN = 0x0008,
+ // Drop-button covers the entire control.
+ wxCC_FULL_BUTTON = 0x0010,
+ // Drop-button goes over the custom-border (used under WinVista).
+ wxCC_BUTTON_COVERS_BORDER = 0x0020,
// Internal use: signals creation is complete
wxCC_IFLAG_CREATED = 0x0100,
// Internal use: Secondary popup window type should be used (if available).
wxCC_IFLAG_USE_ALT_POPUP = 0x1000,
// Internal use: Skip popup animation.
- wxCC_IFLAG_DISABLE_POPUP_ANIM = 0x2000
+ wxCC_IFLAG_DISABLE_POPUP_ANIM = 0x2000,
+ // Internal use: Drop-button is a bitmap button or has non-default size
+ // (but can still be on either side of the control).
+ wxCC_IFLAG_HAS_NONSTANDARD_BUTTON = 0x4000
};
bool ShouldDrawFocus() const
{
const wxWindow* curFocus = FindFocus();
- return ( !IsPopupShown() &&
- (curFocus == this || (m_btn && curFocus == m_btn)) &&
+ return ( IsPopupWindowState(Hidden) &&
+ (curFocus == m_mainCtrlWnd || (m_btn && curFocus == m_btn)) &&
(m_windowStyle & wxCB_READONLY) );
}
// Set value returned by GetMainWindowOfCompositeControl
void SetCtrlMainWnd( wxWindow* wnd ) { m_mainCtrlWnd = wnd; }
+ // This is public so we can access it from wxComboCtrlTextCtrl
+ virtual wxWindow *GetMainWindowOfCompositeControl()
+ { return m_mainCtrlWnd; }
+
protected:
//
// Installs standard input handler to combo (and optionally to the textctrl)
void InstallInputHandlers();
- // flags for DrawButton()
+ // Flags for DrawButton
enum
{
- Draw_PaintBg = 1
+ Button_PaintBackground = 0x0001, // Paints control background below the button
+ Button_BitmapOnly = 0x0002 // Only paints the bitmap
};
// Draws dropbutton. Using wxRenderer or bitmaps, as appropriate.
- void DrawButton( wxDC& dc, const wxRect& rect, int flags = Draw_PaintBg );
+ // Flags are defined above.
+ void DrawButton( wxDC& dc, const wxRect& rect, int flags = Button_PaintBackground );
// Call if cursor is on button area or mouse is captured for the button.
//bool HandleButtonMouseEvent( wxMouseEvent& event, bool isInside );
virtual void DoSetToolTip( wxToolTip *tip );
#endif
- virtual wxWindow *GetMainWindowOfCompositeControl()
- { return m_mainCtrlWnd; }
-
// This is used when m_text is hidden (readonly).
wxString m_valueString;
wxASSERT( IsKindOf(CLASSINFO(wxPopupTransientWindow)) );
wxPopupTransientWindow* ptw = (wxPopupTransientWindow*) this;
- wxComboCtrlBase* combo = (wxComboCtrlBase*) GetParent();
if ( show != ptw->IsShown() )
{
if ( show )
- ptw->Popup(combo->GetPopupControl()->GetControl());
+ // We used to do wxPopupTransientWindow::Popup here,
+ // but this would hide normal Show, which we are
+ // also going to need.
+ ptw->Show();
else
ptw->Dismiss();
}
BEGIN_EVENT_TABLE(wxComboBoxExtraInputHandler, wxEvtHandler)
EVT_KEY_DOWN(wxComboBoxExtraInputHandler::OnKey)
EVT_SET_FOCUS(wxComboBoxExtraInputHandler::OnFocus)
+ EVT_KILL_FOCUS(wxComboBoxExtraInputHandler::OnFocus)
END_EVENT_TABLE()
{
// FIXME: This code does run when control is clicked,
// yet on Windows it doesn't select all the text.
- if ( !(m_combo->GetInternalFlags() & wxCC_NO_TEXT_AUTO_SELECT) )
+ if ( event.GetEventType() == wxEVT_SET_FOCUS &&
+ !(m_combo->GetInternalFlags() & wxCC_NO_TEXT_AUTO_SELECT) )
{
if ( m_combo->GetTextCtrl() )
m_combo->GetTextCtrl()->SelectAll();
// wxEVT_SET_FOCUSes (since m_text->SetFocus is called
// from combo's focus event handler), they should be quite
// harmless.
- wxFocusEvent evt2(wxEVT_SET_FOCUS,m_combo->GetId());
+ wxFocusEvent evt2(event.GetEventType(),m_combo->GetId());
evt2.SetEventObject(m_combo);
m_combo->GetEventHandler()->ProcessEvent(evt2);
wxSize sz = m_combo->GetPopupControl()->GetControl()->GetClientSize();
int evtType = event.GetEventType();
bool isInside = pt.x >= 0 && pt.y >= 0 && pt.x < sz.x && pt.y < sz.y;
+ bool relayToButton = false;
+
+ event.Skip();
if ( evtType == wxEVT_MOTION ||
evtType == wxEVT_LEFT_DOWN ||
if ( !isInside || !m_combo->IsPopupShown() )
{
event.Skip(false);
- return;
}
}
else if ( evtType == wxEVT_LEFT_UP )
if ( !m_combo->IsPopupShown() )
{
event.Skip(false);
- return;
+ relayToButton = true;
}
-
- if ( !m_beenInside )
+ else if ( !m_beenInside )
{
if ( isInside )
{
}
else
{
- //
- // Some mouse events to popup that happen outside it, before cursor
- // has been inside the popu, need to be ignored by it but relayed to
- // the dropbutton.
- //
- wxWindow* btn = m_combo->GetButton();
- if ( btn )
- btn->GetEventHandler()->AddPendingEvent(event);
- else
- m_combo->GetEventHandler()->AddPendingEvent(event);
-
- return;
+ relayToButton = true;
}
-
- event.Skip();
}
}
- event.Skip();
+ if ( relayToButton )
+ {
+ //
+ // Some mouse events to popup that happen outside it, before cursor
+ // has been inside the popup, need to be ignored by it but relayed to
+ // the dropbutton.
+ //
+ wxWindow* eventSink = m_combo;
+ wxWindow* btn = m_combo->GetButton();
+ if ( btn )
+ eventSink = btn;
+
+ eventSink->GetEventHandler()->ProcessEvent(event);
+ }
}
+// ----------------------------------------------------------------------------
+// wxComboCtrlTextCtrl
+// ----------------------------------------------------------------------------
+
+class wxComboCtrlTextCtrl : public wxTextCtrl
+{
+public:
+ wxComboCtrlTextCtrl() : wxTextCtrl() { }
+ virtual ~wxComboCtrlTextCtrl() { }
+
+ virtual wxWindow *GetMainWindowOfCompositeControl()
+ {
+ wxComboCtrl* combo = (wxComboCtrl*) GetParent();
+
+ // Returning this instead of just 'parent' lets FindFocus work
+ // correctly even when parent control is a child of a composite
+ // generic control (as is case with wxGenericDatePickerCtrl).
+ return combo->GetMainWindowOfCompositeControl();
+ }
+};
+
// ----------------------------------------------------------------------------
// wxComboCtrlBase
// ----------------------------------------------------------------------------
else
m_ignoreEvtText = 0;
- m_text = new wxTextCtrl(this, wxID_ANY, m_valueString,
- wxDefaultPosition, wxSize(10,-1),
- style, validator);
+ m_text = new wxComboCtrlTextCtrl();
+ m_text->Create(this, wxID_ANY, m_valueString,
+ wxDefaultPosition, wxSize(10,-1),
+ style, validator);
}
}
m_iFlags |= wxCC_IFLAG_BUTTON_OUTSIDE;
btnBorder = 0;
}
+ else if ( (m_iFlags & wxCC_BUTTON_COVERS_BORDER) &&
+ m_btnSpacingX == 0 && !m_bmpNormal.Ok() )
+ {
+ m_iFlags &= ~(wxCC_IFLAG_BUTTON_OUTSIDE);
+ btnBorder = 0;
+ }
else
{
m_iFlags &= ~(wxCC_IFLAG_BUTTON_OUTSIDE);
{
int newY = butHeight+(customBorder*2);
SetClientSize(wxDefaultCoord,newY);
+ if ( m_bmpNormal.Ok() || m_btnArea.width != butWidth || m_btnArea.height != butHeight )
+ m_iFlags |= wxCC_IFLAG_HAS_NONSTANDARD_BUTTON;
+ else
+ m_iFlags &= ~wxCC_IFLAG_HAS_NONSTANDARD_BUTTON;
+
sz.y = newY;
}
}
{
wxSize sz = GetClientSize();
bool isEnabled;
- bool isFocused; // also selected
+ bool doDrawFocusRect; // also selected
// For smaller size control (and for disabled background) use less spacing
int focusSpacingX;
{
// Drawing control
isEnabled = IsEnabled();
- isFocused = ShouldDrawFocus();
+ doDrawFocusRect = ShouldDrawFocus() & !(m_iFlags & wxCC_FULL_BUTTON);
// Windows-style: for smaller size control (and for disabled background) use less spacing
focusSpacingX = isEnabled ? 2 : 1;
{
// Drawing a list item
isEnabled = true; // they are never disabled
- isFocused = flags & wxCONTROL_SELECTED ? true : false;
+ doDrawFocusRect = flags & wxCONTROL_SELECTED ? true : false;
focusSpacingX = 0;
focusSpacingY = 0;
selRect.width -= wcp + (focusSpacingX*2);
wxColour bgCol;
+ bool doDrawSelRect = true;
if ( isEnabled )
{
// If popup is hidden and this control is focused,
// then draw the focus-indicator (selbgcolor background etc.).
- if ( isFocused )
+ if ( doDrawFocusRect )
{
dc.SetTextForeground( wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHTTEXT) );
bgCol = wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHT);
{
dc.SetTextForeground( wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT) );
#ifndef __WXMAC__ // see note in OnThemeChange
+ doDrawSelRect = false;
bgCol = GetBackgroundColour();
#else
bgCol = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW);
}
dc.SetBrush( bgCol );
- dc.SetPen( bgCol );
- dc.DrawRectangle( selRect );
+ if ( doDrawSelRect )
+ {
+ dc.SetPen( bgCol );
+ dc.DrawRectangle( selRect );
+ }
// Don't clip exactly to the selection rectangle so we can draw
// to the non-selected area in front of it.
}
#endif
-void wxComboCtrlBase::DrawButton( wxDC& dc, const wxRect& rect, int paintBg )
+void wxComboCtrlBase::DrawButton( wxDC& dc, const wxRect& rect, int flags )
{
int drawState = m_btnState;
-#ifdef __WXGTK__
- if ( GetPopupWindowState() >= Animating )
+ if ( (m_iFlags & wxCC_BUTTON_STAYS_DOWN) &&
+ GetPopupWindowState() >= Animating )
drawState |= wxCONTROL_PRESSED;
-#endif
wxRect drawRect(rect.x+m_btnSpacingX,
rect.y+((rect.height-m_btnSize.y)/2),
if ( !m_bmpNormal.Ok() )
{
+ if ( flags & Button_BitmapOnly )
+ return;
+
// Need to clear button background even if m_btn is present
- if ( paintBg )
+ if ( flags & Button_PaintBackground )
{
wxColour bgCol;
{
// If using blank button background, we need to clear its background
// with button face colour instead of colour for rest of the control.
- if ( paintBg )
+ if ( flags & Button_PaintBackground )
{
wxColour bgCol = GetParent()->GetBackgroundColour(); //wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE);
//wxColour bgCol = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW);
dc.DrawRectangle(rect);
}
- wxRendererNative::Get().DrawPushButton(this,
- dc,
- drawRect,
- drawState);
-
+ if ( !(flags & Button_BitmapOnly) )
+ {
+ wxRendererNative::Get().DrawPushButton(this,
+ dc,
+ drawRect,
+ drawState);
+ }
}
else
{
// Need to clear button background even if m_btn is present
// (assume non-button background was cleared just before this call so brushes are good)
- if ( paintBg )
+ if ( flags & Button_PaintBackground )
dc.DrawRectangle(rect);
}
// call if cursor is on button area or mouse is captured for the button
bool wxComboCtrlBase::HandleButtonMouseEvent( wxMouseEvent& event,
- int flags )
+ int flags )
{
int type = event.GetEventType();
if ( type == wxEVT_MOTION )
{
- if ( flags & wxCC_MF_ON_BUTTON )
+ if ( (flags & wxCC_MF_ON_BUTTON) &&
+ IsPopupWindowState(Hidden) )
{
if ( !(m_btnState & wxCONTROL_CURRENT) )
{
else
return false;
+ // Never have 'hot' state when popup is being shown
+ // (this is mostly needed because of the animation).
+ if ( !IsPopupWindowState(Hidden) )
+ m_btnState &= ~wxCONTROL_CURRENT;
+
return true;
}
}
#endif
- // Filter out clicks on button immediately after popup dismiss (Windows like behaviour)
+ // Filter out clicks on button immediately after popup dismiss
if ( evtType == wxEVT_LEFT_DOWN && t < m_timeCanAcceptClick )
{
event.SetEventType(0);
#ifdef __WXMAC__
m_resetFocus = true;
#else
+ {
tc->SetFocus();
+ }
#endif
}
m_popupWinType = SECONDARY_POPUP_TYPE;
}
else
-#endif
+#endif // wxComboPopupWindowBase2
{
m_winPopup = new wxComboPopupWindow( this, wxNO_BORDER );
m_popupWinType = PRIMARY_POPUP_TYPE;
// (though the bug was probably fixed).
winPopup->SetSize( rect );
- winPopup->Show();
+#if USES_WXPOPUPTRANSIENTWINDOW
+ if ( m_popupWinType == POPUPWIN_WXPOPUPTRANSIENTWINDOW )
+ ((wxPopupTransientWindow*)winPopup)->Popup(m_popup);
+ else
+#endif
+ winPopup->Show();
m_popupWinState = Visible;
}
m_popupWinState = Hidden;
}
+
+ Refresh();
}
void wxComboCtrlBase::OnPopupDismiss()
// parameters.
#if 0
#include <tmschema.h>
+ #include <VSStyle.h>
#else
//----------------------------------
#define EP_EDITTEXT 1
#define TMT_TEXTCOLOR 3803
#define TMT_BORDERCOLOR 3801
#define TMT_EDGEFILLCOLOR 3808
- //----------------------------------
+ #define TMT_BGTYPE 4001
+
+ #define BT_IMAGEFILE 0
+ #define BT_BORDERFILL 1
+
+ #define CP_DROPDOWNBUTTON 1
+ #define CP_BACKGROUND 2 // This and above are Vista and later only
+ #define CP_TRANSPARENTBACKGROUND 3
+ #define CP_BORDER 4
+ #define CP_READONLY 5
+ #define CP_DROPDOWNBUTTONRIGHT 6
+ #define CP_DROPDOWNBUTTONLEFT 7
+ #define CP_CUEBANNER 8
+
+ #define CBXS_NORMAL 1
+ #define CBXS_HOT 2
+ #define CBXS_PRESSED 3
+ #define CBXS_DISABLED 4
+
+ #define CBXSR_NORMAL 1
+ #define CBXSR_HOT 2
+ #define CBXSR_PRESSED 3
+ #define CBXSR_DISABLED 4
+
+ #define CBXSL_NORMAL 1
+ #define CBXSL_HOT 2
+ #define CBXSL_PRESSED 3
+ #define CBXSL_DISABLED 4
+
+ #define CBTBS_NORMAL 1
+ #define CBTBS_HOT 2
+ #define CBTBS_DISABLED 3
+ #define CBTBS_FOCUSED 4
+
+ #define CBB_NORMAL 1
+ #define CBB_HOT 2
+ #define CBB_FOCUSED 3
+ #define CBB_DISABLED 4
+
+ #define CBRO_NORMAL 1
+ #define CBRO_HOT 2
+ #define CBRO_PRESSED 3
+ #define CBRO_DISABLED 4
+
+ #define CBCB_NORMAL 1
+ #define CBCB_HOT 2
+ #define CBCB_PRESSED 3
+ #define CBCB_DISABLED 4
+
#endif
#define TEXTCTRLXADJUST_XP 1
#define TEXTCTRLYADJUST_XP 3
#define TEXTCTRLXADJUST_CLASSIC 1
-#define TEXTCTRLYADJUST_CLASSIC 2
+#define TEXTCTRLYADJUST_CLASSIC 3
#define COMBOBOX_ANIMATION_RESOLUTION 10
if ( !border )
{
- // For XP, have 1-width custom border, for older version use sunken
if ( theme )
{
+ // For XP, have 1-width custom border, for older version use sunken
border = wxBORDER_NONE;
m_widthCustomBorder = 1;
}
name) )
return false;
+ if ( theme )
+ {
+ if ( ::wxGetWinVersion() >= wxWinVersion_Vista )
+ m_iFlags |= wxCC_BUTTON_STAYS_DOWN |wxCC_BUTTON_COVERS_BORDER;
+ }
+
if ( style & wxCC_STD_BUTTON )
m_iFlags |= wxCC_POPUP_ON_MOUSE_UP;
wxComboCtrl::PrepareBackground( wxDC& dc, const wxRect& rect, int flags ) const
{
wxUxThemeHandle hTheme(this, L"COMBOBOX");
- //COLORREF cref;
wxSize sz = GetClientSize();
bool isEnabled;
- bool isFocused; // also selected
+ bool doDrawFocusRect; // also selected
// For smaller size control (and for disabled background) use less spacing
int focusSpacingX;
{
// Drawing control
isEnabled = IsEnabled();
- isFocused = ShouldDrawFocus();
+ doDrawFocusRect = ShouldDrawFocus();
// Windows-style: for smaller size control (and for disabled background) use less spacing
if ( hTheme )
{
// Drawing a list item
isEnabled = true; // they are never disabled
- isFocused = flags & wxCONTROL_SELECTED ? true : false;
+ doDrawFocusRect = flags & wxCONTROL_SELECTED ? true : false;
focusSpacingX = 0;
focusSpacingY = 0;
// theme = wxUxThemeEngine::GetIfActive();
wxColour bgCol;
- bool drawDottedEdge = false;
+ bool doDrawDottedEdge = false;
+ bool doDrawSelRect = true;
+
+ // TODO: doDrawDottedEdge = true when focus has arrived to control via tab.
+ // (and other cases which are not that apparent).
if ( isEnabled )
{
// If popup is hidden and this control is focused,
// then draw the focus-indicator (selbgcolor background etc.).
- if ( isFocused )
+ if ( doDrawFocusRect )
{
- #if 0
- // TODO: Proper theme color getting (JMS: I don't know which parts/colors to use,
- // those below don't work)
- if ( hTheme )
+ // NB: We can't really use XP visual styles to get TMT_TEXTCOLOR since
+ // it is not properly defined for combo boxes. Instead, they expect
+ // you to use DrawThemeText.
+ //
+ // Here is, however, sample code how to get theme colours:
+ //
+ // COLORREF cref;
+ // theme->GetThemeColor(hTheme,EP_EDITTEXT,ETS_NORMAL,TMT_TEXTCOLOR,&cref);
+ // dc.SetTextForeground( wxRGBToColour(cref) );
+ if ( (m_iFlags & wxCC_FULL_BUTTON) && !(flags & wxCONTROL_ISSUBMENU) )
{
- theme->GetThemeColor(hTheme,EP_EDITTEXT,ETS_SELECTED,TMT_TEXTCOLOR,&cref);
- dc.SetTextForeground( wxRGBToColour(cref) );
- theme->GetThemeColor(hTheme,EP_EDITTEXT,ETS_SELECTED,TMT_FILLCOLOR,&cref);
- bgCol = wxRGBToColour(cref);
+ // Vista style read-only combo
+ doDrawSelRect = false;
+ doDrawDottedEdge = true;
}
else
- #endif
{
dc.SetTextForeground( wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHTTEXT) );
bgCol = wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHT);
- if ( m_windowStyle & wxCB_READONLY )
- drawDottedEdge = true;
}
}
else
{
- /*if ( hTheme )
- {
- theme->GetThemeColor(hTheme,EP_EDITTEXT,ETS_NORMAL,TMT_TEXTCOLOR,&cref);
- dc.SetTextForeground( wxRGBToColour(cref) );
- theme->GetThemeColor(hTheme,EP_EDITTEXT,ETS_NORMAL,TMT_FILLCOLOR,&cref);
- bgCol = wxRGBToColour(cref);
- }
- else
- {*/
- dc.SetTextForeground( wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT) );
- bgCol = GetBackgroundColour();
- //}
+ dc.SetTextForeground( wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT) );
+ bgCol = GetBackgroundColour();
+ doDrawSelRect = false;
}
}
else
{
- /*if ( hTheme )
- {
- theme->GetThemeColor(hTheme,EP_EDITTEXT,ETS_DISABLED,TMT_TEXTCOLOR,&cref);
- dc.SetTextForeground( wxRGBToColour(cref) );
- theme->GetThemeColor(hTheme,EP_EDITTEXT,ETS_DISABLED,TMT_EDGEFILLCOLOR,&cref);
- bgCol = wxRGBToColour(cref);
- }
- else
- {*/
- dc.SetTextForeground( wxSystemSettings::GetColour(wxSYS_COLOUR_GRAYTEXT) );
- bgCol = wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE);
- //}
+ dc.SetTextForeground( wxSystemSettings::GetColour(wxSYS_COLOUR_GRAYTEXT) );
+ bgCol = wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE);
}
dc.SetBrush(bgCol);
- dc.SetPen(bgCol);
- dc.DrawRectangle(selRect);
- if ( drawDottedEdge )
- wxMSWDrawFocusRect(dc,selRect);
+ if ( doDrawSelRect )
+ {
+ dc.SetPen(bgCol);
+ dc.DrawRectangle(selRect);
+ }
+
+ if ( doDrawDottedEdge )
+ wxMSWDrawFocusRect(dc, selRect);
// Don't clip exactly to the selection rectangle so we can draw
// to the non-selected area in front of it.
wxSize sz = GetClientSize();
wxAutoBufferedPaintDC dc(this);
- const wxRect& rectb = m_btnArea;
- wxRect rect = m_tcArea;
- bool isEnabled = IsEnabled();
+ const wxRect& rectButton = m_btnArea;
+ wxRect rectTextField = m_tcArea;
+ const bool isEnabled = IsEnabled();
wxColour bgCol = GetBackgroundColour();
- wxColour fgCol;
+
+ HDC hDc = GetHdcOf(dc);
+ HWND hWnd = GetHwndOf(this);
wxUxThemeEngine* theme = NULL;
wxUxThemeHandle hTheme(this, L"COMBOBOX");
- int etsState;
- // area around both controls
- wxRect rect2(0,0,sz.x,sz.y);
+ if ( hTheme )
+ theme = wxUxThemeEngine::GetIfActive();
+
+ wxRect borderRect(0,0,sz.x,sz.y);
+
if ( m_iFlags & wxCC_IFLAG_BUTTON_OUTSIDE )
{
- rect2 = m_tcArea;
- rect2.Inflate(1);
+ borderRect = m_tcArea;
+ borderRect.Inflate(1);
}
- // Use theme to draw border on XP
+ int drawButFlags = 0;
+
if ( hTheme )
{
- theme = wxUxThemeEngine::GetIfActive();
- COLORREF cref;
+ const bool useVistaComboBox = ::wxGetWinVersion() >= wxWinVersion_Vista;
+
+ RECT rFull;
+ wxCopyRectToRECT(borderRect, rFull);
+
+ RECT rButton;
+ wxCopyRectToRECT(rectButton, rButton);
+
+ RECT rBorder;
+ wxCopyRectToRECT(borderRect, rBorder);
+
+ bool isNonStdButton = (m_iFlags & wxCC_IFLAG_BUTTON_OUTSIDE) ||
+ (m_iFlags & wxCC_IFLAG_HAS_NONSTANDARD_BUTTON);
+
+ //
+ // Get some states for themed drawing
+ int butState;
- // Select correct border colour
if ( !isEnabled )
- etsState = ETS_DISABLED;
+ {
+ butState = CBXS_DISABLED;
+ }
+ // Vista will display the drop-button as depressed always
+ // when the popup window is visilbe
+ else if ( (m_btnState & wxCONTROL_PRESSED) ||
+ (useVistaComboBox && !IsPopupWindowState(Hidden)) )
+ {
+ butState = CBXS_PRESSED;
+ }
+ else if ( m_btnState & wxCONTROL_CURRENT )
+ {
+ butState = CBXS_HOT;
+ }
else
- etsState = ETS_NORMAL;
+ {
+ butState = CBXS_NORMAL;
+ }
+
+ int comboBoxPart = 0; // For XP, use the 'default' part
+ RECT* rUseForBg = &rBorder;
+
+ bool drawFullButton = false;
+ int bgState = butState;
+ const bool isFocused = (FindFocus() == GetMainWindowOfCompositeControl()) ? true : false;
- if ( m_widthCustomBorder )
+ if ( useVistaComboBox )
{
- theme->GetThemeColor(hTheme,EP_EDITTEXT,etsState,TMT_BORDERCOLOR,&cref);
+ // FIXME: Either SetBackgroundColour or GetBackgroundColour
+ // doesn't work under Vista, so here's a temporary
+ // workaround.
+ bgCol = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW);
- // Set border colour
- dc.SetPen( wxRGBToColour(cref) );
+ // Draw the entire control as a single button?
+ if ( !isNonStdButton )
+ {
+ if ( HasFlag(wxCB_READONLY) )
+ drawFullButton = true;
+ }
+
+ if ( drawFullButton )
+ {
+ comboBoxPart = CP_READONLY;
+ rUseForBg = &rFull;
+
+ // It should be safe enough to update this flag here.
+ m_iFlags |= wxCC_FULL_BUTTON;
+ }
+ else
+ {
+ comboBoxPart = CP_BORDER;
+ m_iFlags &= ~wxCC_FULL_BUTTON;
- dc.SetBrush( *wxTRANSPARENT_BRUSH );
- dc.DrawRectangle(rect2);
+ if ( isFocused )
+ bgState = CBB_FOCUSED;
+ else
+ bgState = CBB_NORMAL;
+ }
}
- theme->GetThemeColor(hTheme,EP_EDITTEXT,etsState,TMT_TEXTCOLOR,&cref);
- fgCol = wxRGBToColour(cref);
- }
- else
- {
- // draw regular background
- fgCol = GetForegroundColour();
- }
+ //
+ // Draw parent's background, if necessary
+ RECT* rUseForTb = NULL;
- rect2.Deflate(m_widthCustomBorder);
+ if ( theme->IsThemeBackgroundPartiallyTransparent( hTheme, comboBoxPart, bgState ) )
+ rUseForTb = &rFull;
+ else if ( m_iFlags & wxCC_IFLAG_BUTTON_OUTSIDE )
+ rUseForTb = &rButton;
- dc.SetBrush(bgCol);
- dc.SetPen(bgCol);
+ if ( rUseForTb )
+ theme->DrawThemeParentBackground( hWnd, hDc, rUseForTb );
- // clear main background
- dc.DrawRectangle(rect);
+ //
+ // Draw the control background (including the border)
+ if ( m_widthCustomBorder > 0 )
+ {
+ theme->DrawThemeBackground( hTheme, hDc, comboBoxPart, bgState, rUseForBg, NULL );
+ }
+ else
+ {
+ // No border. We can't use theme, since it cannot be relied on
+ // to deliver borderless drawing, even with DrawThemeBackgroundEx.
+ dc.SetBrush(bgCol);
+ dc.SetPen(bgCol);
+ dc.DrawRectangle(borderRect);
+ }
- // Button background with theme?
- int drawButFlags = Draw_PaintBg;
- if ( hTheme && m_blankButtonBg )
- {
- RECT r;
- wxCopyRectToRECT(rectb, r);
+ //
+ // Draw the drop-button
+ if ( !isNonStdButton )
+ {
+ drawButFlags = Button_BitmapOnly;
- // Draw parent background if needed (since button looks like its out of
- // the combo, this is preferred).
- theme->DrawThemeParentBackground(GetHwndOf(this),
- GetHdcOf(dc),
- &r);
+ int butPart = CP_DROPDOWNBUTTON;
+
+ if ( useVistaComboBox )
+ {
+ if ( drawFullButton )
+ {
+ // We need to alter the button style slightly before
+ // drawing the actual button (but it was good above
+ // when background etc was done).
+ if ( butState == CBXS_HOT || butState == CBXS_PRESSED )
+ butState = CBXS_NORMAL;
+ }
+
+ if ( m_btnSide == wxRIGHT )
+ butPart = CP_DROPDOWNBUTTONRIGHT;
+ else
+ butPart = CP_DROPDOWNBUTTONLEFT;
+
+ }
+ theme->DrawThemeBackground( hTheme, hDc, butPart, butState, &rButton, NULL );
+ }
+ else if ( useVistaComboBox &&
+ (m_iFlags & wxCC_IFLAG_BUTTON_OUTSIDE) )
+ {
+ // We'll do this, because DrawThemeParentBackground
+ // doesn't seem to be reliable on Vista.
+ drawButFlags |= Button_PaintBackground;
+ }
+ }
+ else
+ {
+ // Windows 2000 and earlier
+ drawButFlags = Button_PaintBackground;
- drawButFlags = 0;
+ dc.SetBrush(bgCol);
+ dc.SetPen(bgCol);
+ dc.DrawRectangle(borderRect);
}
- // Standard button rendering
- DrawButton(dc,rectb,drawButFlags);
+ // Button rendering (may only do the bitmap on button, depending on the flags)
+ DrawButton( dc, rectButton, drawButFlags );
- // paint required portion on the control
+ // Paint required portion of the custom image on the control
if ( (!m_text || m_widthCustomPaint) )
{
wxASSERT( m_widthCustomPaint >= 0 );
// this is intentionally here to allow drawed rectangle's
// right edge to be hidden
if ( m_text )
- rect.width = m_widthCustomPaint;
+ rectTextField.width = m_widthCustomPaint;
dc.SetFont( GetFont() );
- dc.SetClippingRegion(rect);
+ dc.SetClippingRegion(rectTextField);
if ( m_popupInterface )
- m_popupInterface->PaintComboControl(dc,rect);
+ m_popupInterface->PaintComboControl(dc,rectTextField);
else
- wxComboPopup::DefaultPaintComboControl(this,dc,rect);
+ wxComboPopup::DefaultPaintComboControl(this,dc,rectTextField);
}
}
projects / wxWidgets.git / commitdiff
