don't set translation credits if they're empty (part of patch 1586730)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42640 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/gtk/aboutdlg.cpp b/src/gtk/aboutdlg.cpp
index c5c73555634b9de7981a2e404de9180dc078d9f0..b6d960990b6298c59d163986967ed7215a239de8 100644 (file)
--- a/src/gtk/aboutdlg.cpp
+++ b/src/gtk/aboutdlg.cpp
@@ -150,10 +150,20 @@ void wxAboutBox(const wxAboutDialogInfo& info)
         else // no translators explicitely specified
         {
             // maybe we have translator credits in the message catalog?
         else // no translators explicitely specified
         {
             // maybe we have translator credits in the message catalog?

-            transCredits = _("translator-credits");
+            wxString translator = _("translator-credits");
+
+            // gtk_about_dialog_set_translator_credits() is smart enough to
+            // detect if "translator-credits" is untranslated and hide the
+            // translators tab in that case, however it will still show the
+            // "credits" button, (at least GTK 2.10.6) even if there are no
+            // credits informations at all, so we still need to do the check
+            // ourselves
+            if ( translator != wxT("translator-credits") ) // untranslated!
+                transCredits = translator;

         }
 
         }
 

-        gtk_about_dialog_set_translator_credits(dlg, GtkStr(transCredits));
+        if ( !transCredits.empty() )
+            gtk_about_dialog_set_translator_credits(dlg, GtkStr(transCredits));

 
         g_signal_connect(dlg, "response",
                             G_CALLBACK(wxGtkAboutDialogOnClose), NULL);
 
         g_signal_connect(dlg, "response",
                             G_CALLBACK(wxGtkAboutDialogOnClose), NULL);