fix wxTextCtrl::SetSelection(-1, -1) to behave as documented (patch 1700000)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@45443 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/docs/changes.txt b/docs/changes.txt
index adcb0e1b99dcdf6b205f5610f867e1b41312854b..e19965a1341d60c632de0b3f755655f87c1ceee3 100644 (file)
--- a/docs/changes.txt
+++ b/docs/changes.txt
@@ -157,6 +157,10 @@ wxGTK:
 - Fix wxNO_BORDER style for wxRadioBox (David Hart)
 - Fix wxTextCtrl::GetLineText() for empty lines (Marcin Wojdyr)
 
+wxUniv:
+
+- Fix wxTextCtrl::SetSelection(-1, -1) to behave as documented (Anders Larsen)
+
 
 2.8.3
 -----

diff --git a/src/univ/textctrl.cpp b/src/univ/textctrl.cpp
index afba680e8db7d3ffc384074ab4595ca3fc113242..487fb2fca0ec9a269704b69d02faa000d3e8c237 100644 (file)
--- a/src/univ/textctrl.cpp
+++ b/src/univ/textctrl.cpp
@@ -1444,8 +1444,12 @@ wxString wxTextCtrl::GetSelectionText() const
 void wxTextCtrl::SetSelection(wxTextPos from, wxTextPos to)
 {
     // selecting till -1 is the same as selecting to the end
-    if ( to == -1 && from != -1 )
+    if ( to == -1 )
     {
+        // and selecting (-1, -1) range is the same as selecting everything, by
+        // convention
+        if ( from == -1 )
+            from = 0;
         to = GetLastPosition();
     }