There shouldn't be any need to draw the backgound

    under a sash.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@32768 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/gtk/renderer.cpp b/src/gtk/renderer.cpp
index e89a2beb747896ead12010d8f1e5ca4f006304c0..4642766fb8a1557dc1fb87a6df13af3fe3ebc103 100644 (file)
--- a/src/gtk/renderer.cpp
+++ b/src/gtk/renderer.cpp
@@ -303,10 +303,13 @@ wxRendererGTK::DrawSplitterSash(wxWindow *win,
         erase_rect.width = w;
     }
 
         erase_rect.width = w;
     }
 

-    // we must erase everything first, otherwise the garbage from the old sash
-    // is left when dragging it
-    //
-    // TODO: is this the right way to draw themed background?
+#if 0
+    // RR: After a correction to the orientation of the sash
+    //     this doesn't seem to be required anymore and it
+    //     seems to confuse some themes
+
+    // we must erase everything first, otherwise the garbage
+    // from the old sash is left when dragging it

     gtk_paint_flat_box
     (
         win->m_wxwindow->style,
     gtk_paint_flat_box
     (
         win->m_wxwindow->style,


@@ -315,12 +318,13 @@ wxRendererGTK::DrawSplitterSash(wxWindow *win,
         GTK_SHADOW_NONE,
         NULL,
         win->m_wxwindow,
         GTK_SHADOW_NONE,
         NULL,
         win->m_wxwindow,

-        (char *)"base", // const_cast
+        (char *)"viewportbin", // const_cast

         erase_rect.x,
         erase_rect.y,
         erase_rect.width,
         erase_rect.height
     );
         erase_rect.x,
         erase_rect.y,
         erase_rect.width,
         erase_rect.height
     );

+#endif

 
 #ifdef __WXGTK20__
     gtk_paint_handle
 
 #ifdef __WXGTK20__
     gtk_paint_handle

diff --git a/src/gtk1/renderer.cpp b/src/gtk1/renderer.cpp
index e89a2beb747896ead12010d8f1e5ca4f006304c0..4642766fb8a1557dc1fb87a6df13af3fe3ebc103 100644 (file)
--- a/src/gtk1/renderer.cpp
+++ b/src/gtk1/renderer.cpp
@@ -303,10 +303,13 @@ wxRendererGTK::DrawSplitterSash(wxWindow *win,
         erase_rect.width = w;
     }
 
         erase_rect.width = w;
     }
 

-    // we must erase everything first, otherwise the garbage from the old sash
-    // is left when dragging it
-    //
-    // TODO: is this the right way to draw themed background?
+#if 0
+    // RR: After a correction to the orientation of the sash
+    //     this doesn't seem to be required anymore and it
+    //     seems to confuse some themes
+
+    // we must erase everything first, otherwise the garbage
+    // from the old sash is left when dragging it

     gtk_paint_flat_box
     (
         win->m_wxwindow->style,
     gtk_paint_flat_box
     (
         win->m_wxwindow->style,


@@ -315,12 +318,13 @@ wxRendererGTK::DrawSplitterSash(wxWindow *win,
         GTK_SHADOW_NONE,
         NULL,
         win->m_wxwindow,
         GTK_SHADOW_NONE,
         NULL,
         win->m_wxwindow,

-        (char *)"base", // const_cast
+        (char *)"viewportbin", // const_cast

         erase_rect.x,
         erase_rect.y,
         erase_rect.width,
         erase_rect.height
     );
         erase_rect.x,
         erase_rect.y,
         erase_rect.width,
         erase_rect.height
     );

+#endif

 
 #ifdef __WXGTK20__
     gtk_paint_handle
 
 #ifdef __WXGTK20__
     gtk_paint_handle