wxImage::Create() should be bool, not void

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@20578 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/include/wx/image.h b/include/wx/image.h
index 62e50e8cd19cc9b0874f55d50cce97b906065eee..12a0223cc77b3ddf4eac77d908ef07d7124675c1 100644 (file)
--- a/include/wx/image.h
+++ b/include/wx/image.h
@@ -162,8 +162,8 @@ public:
 #endif
 #endif
 
 #endif
 #endif
 

-    void Create( int width, int height, bool clear = true );
-    void Create( int width, int height, unsigned char* data, bool static_data = FALSE );
+    bool Create( int width, int height, bool clear = true );
+    bool Create( int width, int height, unsigned char* data, bool static_data = FALSE );

     void Destroy();
 
     // creates an identical copy of the image (the = operator
     void Destroy();
 
     // creates an identical copy of the image (the = operator

diff --git a/src/common/image.cpp b/src/common/image.cpp
index cccfe9f1bffd27601e6146e2a38274b1f4c734d9..98daf43393fc7d42c6137b71d1669aa566981193 100644 (file)
--- a/src/common/image.cpp
+++ b/src/common/image.cpp
@@ -156,45 +156,44 @@ wxImage::wxImage( const wxImage* image )
     if (image) Ref(*image);
 }
 
     if (image) Ref(*image);
 }
 

-void wxImage::Create( int width, int height, bool clear )
+bool wxImage::Create( int width, int height, bool clear )

 {
     UnRef();
 
     m_refData = new wxImageRefData();
 
     M_IMGDATA->m_data = (unsigned char *) malloc( width*height*3 );
 {
     UnRef();
 
     m_refData = new wxImageRefData();
 
     M_IMGDATA->m_data = (unsigned char *) malloc( width*height*3 );

-    if (M_IMGDATA->m_data)
-    {
-        if (clear) memset(M_IMGDATA->m_data, 0, width*height*3);
-
-        M_IMGDATA->m_width = width;
-        M_IMGDATA->m_height = height;
-        M_IMGDATA->m_ok = TRUE;
-    }
-    else
+    if (!M_IMGDATA->m_data)

     {
         UnRef();
     {
         UnRef();

+        return FALSE;

     }
     }

+
+    if (clear)
+        memset(M_IMGDATA->m_data, 0, width*height*3);
+
+    M_IMGDATA->m_width = width;
+    M_IMGDATA->m_height = height;
+    M_IMGDATA->m_ok = TRUE;
+
+    return TRUE;

 }
 
 }
 

-void wxImage::Create( int width, int height, unsigned char* data, bool static_data )
+bool wxImage::Create( int width, int height, unsigned char* data, bool static_data )

 {
     UnRef();
 
 {
     UnRef();
 

+    wxCHECK_MSG( data, FALSE, _T("NULL data in wxImage::Create") );
+

     m_refData = new wxImageRefData();
 
     M_IMGDATA->m_data = data;
     m_refData = new wxImageRefData();
 
     M_IMGDATA->m_data = data;

-    if (M_IMGDATA->m_data)
-    {
-        M_IMGDATA->m_width = width;
-        M_IMGDATA->m_height = height;
-        M_IMGDATA->m_ok = TRUE;
-        M_IMGDATA->m_static = static_data;
-    }
-    else
-    {
-        UnRef();
-    }
+    M_IMGDATA->m_width = width;
+    M_IMGDATA->m_height = height;
+    M_IMGDATA->m_ok = TRUE;
+    M_IMGDATA->m_static = static_data;
+
+    return TRUE;

 }
 
 void wxImage::Destroy()
 }
 
 void wxImage::Destroy()