Check the return value of system() and pipe() in the test suite.

This is mainly to avoid -Wunused-result warnings under recent Linux systems
but also could give valuable information if the call does fail.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72714 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/tests/archive/archivetest.cpp b/tests/archive/archivetest.cpp
index d6ac25692b4be8f5b94510dee9986becc8977c9d..7e8262d0f8e878d32a2b2efc3899122e8a00ed62 100644 (file)
--- a/tests/archive/archivetest.cpp
+++ b/tests/archive/archivetest.cpp
@@ -672,7 +672,10 @@ void ArchiveTestCase<ClassFactoryT>::CreateArchive(wxOutputStream& out,
         wxString tmparc = fn.GetPath(wxPATH_GET_SEPARATOR) + fn.GetFullName();
 
         // call the archiver to create an archive file
         wxString tmparc = fn.GetPath(wxPATH_GET_SEPARATOR) + fn.GetFullName();
 
         // call the archiver to create an archive file

-        system(wxString::Format(archiver, tmparc.c_str()).mb_str());
+        if ( system(wxString::Format(archiver, tmparc.c_str()).mb_str()) == -1 )
+        {
+            wxLogError("Failed to run acrhiver command \"%s\"", archiver);
+        }

 
         // then load the archive file
         {
 
         // then load the archive file
         {


@@ -895,7 +898,11 @@ void ArchiveTestCase<ClassFactoryT>::ExtractArchive(wxInputStream& in,
         }
 
         // call unarchiver
         }
 
         // call unarchiver

-        system(wxString::Format(unarchiver, tmparc.c_str()).mb_str());
+        if ( system(wxString::Format(unarchiver, tmparc.c_str()).mb_str()) == -1 )
+        {
+            wxLogError("Failed to run unarchiver command \"%s\"", unarchiver);
+        }
+

         wxRemoveFile(tmparc);
     }
     else {
         wxRemoveFile(tmparc);
     }
     else {

diff --git a/tests/filekind/filekind.cpp b/tests/filekind/filekind.cpp
index a7d81f81a45a6efbc5c33cdd807c01ec9255b39b..c948050d393e43f96bd73eeea5ce1cda0cb56aa1 100644 (file)
--- a/tests/filekind/filekind.cpp
+++ b/tests/filekind/filekind.cpp
@@ -127,11 +127,13 @@ void FileKindTestCase::File()
 void FileKindTestCase::Pipe()
 {
     int afd[2];
 void FileKindTestCase::Pipe()
 {
     int afd[2];

+    int rc;

 #ifdef __UNIX__
 #ifdef __UNIX__

-    pipe(afd);
+    rc = pipe(afd);

 #else
 #else

-    _pipe(afd, 256, O_BINARY);
+    rc = _pipe(afd, 256, O_BINARY);

 #endif
 #endif

+    CPPUNIT_ASSERT_EQUAL_MESSAGE("Failed to create pipe", 0, rc);

 
     wxFile file0(afd[0]);
     wxFile file1(afd[1]);
 
     wxFile file0(afd[0]);
     wxFile file1(afd[1]);