Applied patch from SF on menu command not blocked

    if they are disabled but still emitted by an
    accelerator
  First attempt at adding wxSizer::Clear(). Further
     testing pending :-)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@12403 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/include/wx/sizer.h b/include/wx/sizer.h
index ccfb67985b4218f812bda27c0be52275794e93a0..11b4e38912da69a0de90e28c929fa0e40f04c75e 100644 (file)
--- a/include/wx/sizer.h
+++ b/include/wx/sizer.h
@@ -47,6 +47,8 @@ public:
     wxSizerItem( wxSizer *sizer, int option, int flag, int border, wxObject* userData );
 
     ~wxSizerItem();
     wxSizerItem( wxSizer *sizer, int option, int flag, int border, wxObject* userData );
 
     ~wxSizerItem();

+    
+    virtual void DeleteWindows();

 
     virtual wxSize GetSize();
     virtual wxSize CalcMin();
 
     virtual wxSize GetSize();
     virtual wxSize CalcMin();


@@ -143,6 +145,9 @@ public:
     virtual bool Remove( wxWindow *window );
     virtual bool Remove( wxSizer *sizer );
     virtual bool Remove( int pos );
     virtual bool Remove( wxWindow *window );
     virtual bool Remove( wxSizer *sizer );
     virtual bool Remove( int pos );

+    
+    virtual void Clear( bool delete_windows=FALSE );
+    virtual void DeleteWindows();

 
     void SetMinSize( int width, int height )
         { DoSetMinSize( width, height ); }
 
     void SetMinSize( int width, int height )
         { DoSetMinSize( width, height ); }

diff --git a/src/common/framecmn.cpp b/src/common/framecmn.cpp
index 55ce182110342e95c670bb939ae91da370f67ebb..fc7b2f413af0aeca6f1a6aaabd0e82c28e05a66f 100644 (file)
--- a/src/common/framecmn.cpp
+++ b/src/common/framecmn.cpp
@@ -182,12 +182,17 @@ bool wxFrameBase::ProcessCommand(int id)
     commandEvent.SetEventObject(this);
 
     wxMenuItem *item = bar->FindItem(id);
     commandEvent.SetEventObject(this);
 
     wxMenuItem *item = bar->FindItem(id);

-    if ( item && item->IsCheckable() )
+    if (item)

     {
     {

-        item->Toggle();
-
-        // use the new value
-        commandEvent.SetInt(item->IsChecked());
+        if (!item->IsEnabled())
+            return TRUE;
+            
+        if (item->IsCheckable())
+        {
+            item->Toggle();
+            // use the new value
+            commandEvent.SetInt(item->IsChecked());
+        }

     }
 
     return GetEventHandler()->ProcessEvent(commandEvent);
     }
 
     return GetEventHandler()->ProcessEvent(commandEvent);

diff --git a/src/common/sizer.cpp b/src/common/sizer.cpp
index 7b2fbb4e741402b6235e8c1a11791563b2e3c568..410aac2bd8e27dab2477b7116f11b377e0aa52f3 100644 (file)
--- a/src/common/sizer.cpp
+++ b/src/common/sizer.cpp
@@ -232,6 +232,15 @@ void wxSizerItem::SetDimension( wxPoint pos, wxSize size )
     m_size = size;
 }
 
     m_size = size;
 }
 

+void wxSizerItem::DeleteWindows()
+{
+    if (m_window)
+         m_window->Destroy();
+         
+    if (m_sizer)
+        m_sizer->DeleteWindows();
+}
+

 bool wxSizerItem::IsWindow()
 {
     return (m_window != NULL);
 bool wxSizerItem::IsWindow()
 {
     return (m_window != NULL);


@@ -355,6 +364,25 @@ bool wxSizer::Remove( int pos )
     return TRUE;
 }
 
     return TRUE;
 }
 

+void wxSizer::Clear( bool delete_windows )
+{
+    if (delete_windows)
+        DeleteWindows();
+        
+    m_children.Clear();
+}
+
+void wxSizer::DeleteWindows()
+{
+    wxNode *node = m_children.First();
+    while (node)
+    {
+        wxSizerItem *item = (wxSizerItem*)node->Data();
+        item->DeleteWindows();
+        node = node->Next();
+    }
+}
+

 void wxSizer::Fit( wxWindow *window )
 {
     wxSize size;
 void wxSizer::Fit( wxWindow *window )
 {
     wxSize size;