Fixed incorrect deletion of hPalette if the call to wxReadDIB() fails

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@12833 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/msw/dib.cpp b/src/msw/dib.cpp
index f5b86d7c2b7d740a658ad60c7654894eb724aa4a..c48d865d23dc5011bda70f4c6d2805c5c4a0421a 100644 (file)
--- a/src/msw/dib.cpp
+++ b/src/msw/dib.cpp
@@ -695,14 +695,15 @@ HPALETTE wxMakeDIBPalette(LPBITMAPINFOHEADER lpInfo)
 
 bool wxLoadIntoBitmap(wxChar *filename, wxBitmap *bitmap, wxPalette **pal)
 {
 
 bool wxLoadIntoBitmap(wxChar *filename, wxBitmap *bitmap, wxPalette **pal)
 {

-  HBITMAP hBitmap;
-  HPALETTE hPalette;
+  HBITMAP hBitmap = NULL;
+  HPALETTE hPalette = NULL;

 
   bool success = (wxReadDIB(filename, &hBitmap, &hPalette) != 0);
 
   if (!success)
   {
 
   bool success = (wxReadDIB(filename, &hBitmap, &hPalette) != 0);
 
   if (!success)
   {

-    DeleteObject(hPalette);
+    if (hPalette)
+        DeleteObject(hPalette);

     return FALSE;
   }
 
     return FALSE;
   }