fixed writing to wxUniCharRef after its 'parent' iterator was destroyed

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@55285 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/include/wx/string.h b/include/wx/string.h
index 35491795df1e0477311423a8784587d1271b9cd8..b7fe3836ae209fe0f1ac1d50ae7ef385213a84ee 100644 (file)
--- a/include/wx/string.h
+++ b/include/wx/string.h
@@ -673,7 +673,7 @@ public:
       }
 
       reference operator*()
       }
 
       reference operator*()

-        { return wxUniCharRef::CreateForString(m_node, m_cur); }
+        { return wxUniCharRef::CreateForString(*str(), m_cur); }

 
       iterator operator+(ptrdiff_t n) const
         { return iterator(str(), wxStringOperations::AddToIter(m_cur, n)); }
 
       iterator operator+(ptrdiff_t n) const
         { return iterator(str(), wxStringOperations::AddToIter(m_cur, n)); }

diff --git a/include/wx/unichar.h b/include/wx/unichar.h
index defc237114679e57013165dc85fb0278dda39f45..2b93bf9c88c19fd5deffef0f716389952bf4eb85 100644 (file)
--- a/include/wx/unichar.h
+++ b/include/wx/unichar.h
@@ -183,7 +183,7 @@ private:
 
     // create the reference
 #if wxUSE_UNICODE_UTF8
 
     // create the reference
 #if wxUSE_UNICODE_UTF8

-    wxUniCharRef(wxStringIteratorNode& node, iterator pos) : m_node(node), m_pos(pos) {}
+    wxUniCharRef(wxString& str, iterator pos) : m_str(str), m_pos(pos) {}

 #else
     wxUniCharRef(iterator pos) : m_pos(pos) {}
 #endif
 #else
     wxUniCharRef(iterator pos) : m_pos(pos) {}
 #endif


@@ -195,8 +195,8 @@ public:
     //     that must be used explicitly (this is more than using 'explicit'
     //     keyword on ctor!):
 #if wxUSE_UNICODE_UTF8
     //     that must be used explicitly (this is more than using 'explicit'
     //     keyword on ctor!):
 #if wxUSE_UNICODE_UTF8

-    static wxUniCharRef CreateForString(wxStringIteratorNode& node, iterator pos)
-        { return wxUniCharRef(node, pos); }
+    static wxUniCharRef CreateForString(wxString& str, iterator pos)
+        { return wxUniCharRef(str, pos); }

 #else
     static wxUniCharRef CreateForString(iterator pos)
         { return wxUniCharRef(pos); }
 #else
     static wxUniCharRef CreateForString(iterator pos)
         { return wxUniCharRef(pos); }


@@ -287,7 +287,7 @@ private:
 private:
     // reference to the string and pointer to the character in string
 #if wxUSE_UNICODE_UTF8
 private:
     // reference to the string and pointer to the character in string
 #if wxUSE_UNICODE_UTF8

-    wxStringIteratorNode& m_node;
+    wxString& m_str;

 #endif
     iterator m_pos;
 };
 #endif
     iterator m_pos;
 };

diff --git a/src/common/unichar.cpp b/src/common/unichar.cpp
index d75555acd925beb123b657f81c36c7e33a7b32d8..7a8df7600d86e6d10214ae9e3efdf7e23b782a57 100644 (file)
--- a/src/common/unichar.cpp
+++ b/src/common/unichar.cpp
@@ -106,8 +106,7 @@ wxUniCharRef& wxUniCharRef::operator=(const wxUniChar& c)
         // code -- in that case, we have to use wxStringImpl::replace() and
         // this invalidates all iterators, so we have to update them too:
 
         // code -- in that case, we have to use wxStringImpl::replace() and
         // this invalidates all iterators, so we have to update them too:
 

-        wxString& str = *wx_const_cast(wxString*, m_node.m_str);
-        wxStringImpl& strimpl = str.m_impl;
+        wxStringImpl& strimpl = m_str.m_impl;

 
         int iterDiff = lenNew - lenOld;
         size_t posIdx = m_pos - strimpl.begin();
 
         int iterDiff = lenNew - lenOld;
         size_t posIdx = m_pos - strimpl.begin();


@@ -121,7 +120,7 @@ wxUniCharRef& wxUniCharRef::operator=(const wxUniChar& c)
         size_t *indexes = indexes_a;
         size_t iterNum = 0;
         wxStringIteratorNode *it;
         size_t *indexes = indexes_a;
         size_t iterNum = 0;
         wxStringIteratorNode *it;

-        for ( it = str.m_iterators.ptr; it; it = it->m_next, ++iterNum )
+        for ( it = m_str.m_iterators.ptr; it; it = it->m_next, ++iterNum )

         {
             wxASSERT( it->m_iter || it->m_citer );
 
         {
             wxASSERT( it->m_iter || it->m_citer );
 


@@ -152,7 +151,7 @@ wxUniCharRef& wxUniCharRef::operator=(const wxUniChar& c)
         // finally, set the iterators to valid values again (note that this
         // updates m_pos as well):
         size_t i;
         // finally, set the iterators to valid values again (note that this
         // updates m_pos as well):
         size_t i;

-        for ( i = 0, it = str.m_iterators.ptr; it; it = it->m_next, ++i )
+        for ( i = 0, it = m_str.m_iterators.ptr; it; it = it->m_next, ++i )

         {
             wxASSERT( i < iterNum );
             wxASSERT( it->m_iter || it->m_citer );
         {
             wxASSERT( i < iterNum );
             wxASSERT( it->m_iter || it->m_citer );

diff --git a/tests/strings/strings.cpp b/tests/strings/strings.cpp
index 0967c6249a27b4e2e2d931a42a9ca0c64bcfecc4..a3fec565982508818f4ad3c3db48201d7eb5d01d 100644 (file)
--- a/tests/strings/strings.cpp
+++ b/tests/strings/strings.cpp
@@ -59,6 +59,7 @@ private:
         CPPUNIT_TEST( CStrDataOperators );
         CPPUNIT_TEST( CStrDataImplicitConversion );
         CPPUNIT_TEST( ExplicitConversion );
         CPPUNIT_TEST( CStrDataOperators );
         CPPUNIT_TEST( CStrDataImplicitConversion );
         CPPUNIT_TEST( ExplicitConversion );

+        CPPUNIT_TEST( IndexedAccess );

     CPPUNIT_TEST_SUITE_END();
 
     void String();
     CPPUNIT_TEST_SUITE_END();
 
     void String();


@@ -89,6 +90,7 @@ private:
     void CStrDataOperators();
     void CStrDataImplicitConversion();
     void ExplicitConversion();
     void CStrDataOperators();
     void CStrDataImplicitConversion();
     void ExplicitConversion();

+    void IndexedAccess();

 
     DECLARE_NO_COPY_CLASS(StringTestCase)
 };
 
     DECLARE_NO_COPY_CLASS(StringTestCase)
 };


@@ -826,3 +828,16 @@ void StringTestCase::ExplicitConversion()
     CPPUNIT_ASSERT( CheckStrConstWChar(s, s.wc_str()) );
     CPPUNIT_ASSERT( CheckStrWChar(s, s.wchar_str()) );
 }
     CPPUNIT_ASSERT( CheckStrConstWChar(s, s.wc_str()) );
     CPPUNIT_ASSERT( CheckStrWChar(s, s.wchar_str()) );
 }

+
+void StringTestCase::IndexedAccess()
+{
+    wxString s("bar");
+    CPPUNIT_ASSERT_EQUAL( 'r', s[2] );
+
+    // this tests for a possible bug in UTF-8 based wxString implementation:
+    // the 3rd character of the underlying byte string is going to change, but
+    // the 3rd character of wxString should remain the same
+    s[0] = L'\u00e9';
+    CPPUNIT_ASSERT_EQUAL( 'r', s[2] );
+}
+