fix yet another assert when the initial combo box value was empty (replaces patch...

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@25771 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/msw/combobox.cpp b/src/msw/combobox.cpp
index 3b7515c645eaae0cdab79fa97b165e978debde21..e62a0ed5a71e536413d5869d48c81f8e4bdf1cc5 100644 (file)
--- a/src/msw/combobox.cpp
+++ b/src/msw/combobox.cpp
@@ -399,9 +399,10 @@ bool wxComboBox::Create(wxWindow *parent, wxWindowID id,
                         validator, name) )
         return FALSE;
 
-    // we shouldn't call SetValue() for an empty read only combobox as it would
-    // (correctly) thro an assert and is otherwise useless anyhow
-    if ( n || !HasFlag(wxCB_READONLY) )
+    // we shouldn't call SetValue() for an empty string because this would
+    // (correctly) result in an assert with a read only combobox and is useless
+    // for the other ones anyhow
+    if ( !value.empty() )
         SetValue(value);
 
     // a (not read only) combobox is, in fact, 2 controls: the combobox itself