Added comment about an untested code path...

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@12925 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/wxPython/src/helpers.cpp b/wxPython/src/helpers.cpp
index 483442eb46d42bbfe74014e77973457520381ef7..8216a27e4ea2ec35062cab17465feeebb03f80e7 100644 (file)
--- a/wxPython/src/helpers.cpp
+++ b/wxPython/src/helpers.cpp
@@ -542,6 +542,7 @@ PyObject* PyFindClassWithAttr(PyObject *klass, PyObject *name)
 
     if (PyType_Check(klass)) {      // new style classes
         // This code is borrowed/adapted from _PyType_Lookup in typeobject.c
 
     if (PyType_Check(klass)) {      // new style classes
         // This code is borrowed/adapted from _PyType_Lookup in typeobject.c

+        // (TODO: This part is not tested yet, so I'm not sure it is correct...)

         PyTypeObject* type = (PyTypeObject*)klass;
         PyObject *mro, *res, *base, *dict;
         /* Look in tp_dict of types in MRO */
         PyTypeObject* type = (PyTypeObject*)klass;
         PyObject *mro, *res, *base, *dict;
         /* Look in tp_dict of types in MRO */


@@ -559,7 +560,7 @@ PyObject* PyFindClassWithAttr(PyObject *klass, PyObject *name)
             assert(dict && PyDict_Check(dict));
             res = PyDict_GetItem(dict, name);
             if (res != NULL)
             assert(dict && PyDict_Check(dict));
             res = PyDict_GetItem(dict, name);
             if (res != NULL)

-                return res;
+                return base;

         }
         return NULL;
     }
         }
         return NULL;
     }