added slightly more informative failure reporting.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@13179 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/include/wx/valtext.h b/include/wx/valtext.h
index 942110e65baa20568fed985b09c23fa237d2ab46..01e0e6d9111d1c4acd7ec98fc4f59bafdbf14d65 100644 (file)
--- a/include/wx/valtext.h
+++ b/include/wx/valtext.h
@@ -34,40 +34,41 @@ class WXDLLEXPORT wxTextValidator: public wxValidator
 {
 DECLARE_DYNAMIC_CLASS(wxTextValidator)
 public:
-  wxTextValidator(long style = wxFILTER_NONE, wxString *val = (wxString *) NULL);
-  wxTextValidator(const wxTextValidator& val);
 
-  ~wxTextValidator();
+    wxTextValidator(long style = wxFILTER_NONE, wxString *val = 0);
+    wxTextValidator(const wxTextValidator& val);
 
-  // Make a clone of this validator (or return NULL) - currently necessary
-  // if you're passing a reference to a validator.
-  // Another possibility is to always pass a pointer to a new validator
-  // (so the calling code can use a copy constructor of the relevant class).
-  virtual wxObject *Clone(void) const { return new wxTextValidator(*this); }
-  bool Copy(const wxTextValidator& val);
+    ~wxTextValidator();
 
-  // Called when the value in the window must be validated.
-  // This function can pop up an error message.
-  virtual bool Validate(wxWindow *parent);
+    // Make a clone of this validator (or return NULL) - currently necessary
+    // if you're passing a reference to a validator.
+    // Another possibility is to always pass a pointer to a new validator
+    // (so the calling code can use a copy constructor of the relevant class).
+    virtual wxObject *Clone() const { return new wxTextValidator(*this); }
+    bool Copy(const wxTextValidator& val);
 
-  // Called to transfer data to the window
-  virtual bool TransferToWindow(void);
+    // Called when the value in the window must be validated.
+    // This function can pop up an error message.
+    virtual bool Validate(wxWindow *parent);
 
-  // Called to transfer data to the window
-  virtual bool TransferFromWindow(void);
+    // Called to transfer data to the window
+    virtual bool TransferToWindow();
 
-  // ACCESSORS
-  inline long GetStyle(void) const { return m_validatorStyle; }
-  inline void SetStyle(long style) { m_validatorStyle = style; }
+    // Called to transfer data to the window
+    virtual bool TransferFromWindow();
 
-  void SetIncludeList(const wxStringList& list);
-  inline wxStringList& GetIncludeList(void) { return m_includeList; }
+    // ACCESSORS
+    inline long GetStyle() const { return m_validatorStyle; }
+    inline void SetStyle(long style) { m_validatorStyle = style; }
 
-  void SetExcludeList(const wxStringList& list);
-  inline wxStringList& GetExcludeList(void) { return m_excludeList; }
+    void SetIncludeList(const wxStringList& list);
+    inline wxStringList& GetIncludeList() { return m_includeList; }
 
-  // Filter keystrokes
-  void OnChar(wxKeyEvent& event);
+    void SetExcludeList(const wxStringList& list);
+    inline wxStringList& GetExcludeList() { return m_excludeList; }
+
+    // Filter keystrokes
+    void OnChar(wxKeyEvent& event);
 
 DECLARE_EVENT_TABLE()
 
@@ -76,6 +77,18 @@ protected:
     wxString *      m_stringValue;
     wxStringList    m_includeList;
     wxStringList    m_excludeList;
+
+    bool CheckValidator() const
+    {
+        wxCHECK_MSG( m_validatorWindow, FALSE,
+                     _T("No window associated with validator") );
+        wxCHECK_MSG( m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)), FALSE,
+                     _T("wxTextValidator is only for wxTextCtrl's") );
+        wxCHECK_MSG( m_stringValue, FALSE,
+                     _T("No variable storage for validator") );
+
+        return TRUE;
+    }
 };
 
 #endif

diff --git a/src/common/valtext.cpp b/src/common/valtext.cpp
index 9e7599571ba2d86d407f1deb5ad45bdef46d9aa5..3ecc428116642a2cc1e079baf98d0fc4bdef5d38 100644 (file)
--- a/src/common/valtext.cpp
+++ b/src/common/valtext.cpp
@@ -119,11 +119,7 @@ static bool wxIsAlphaNumeric(const wxString& val)
 // This function can pop up an error message.
 bool wxTextValidator::Validate(wxWindow *parent)
 {
-    if ( !m_validatorWindow )
-        return FALSE;
-    if ( !m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
-        return FALSE;
-    if ( !m_stringValue )
+    if( !CheckValidator() )
         return FALSE;
 
     wxTextCtrl *control = (wxTextCtrl *) m_validatorWindow ;
@@ -195,11 +191,7 @@ bool wxTextValidator::Validate(wxWindow *parent)
 // Called to transfer data to the window
 bool wxTextValidator::TransferToWindow(void)
 {
-    if ( !m_validatorWindow )
-        return FALSE;
-    if ( !m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
-        return FALSE;
-    if ( !m_stringValue )
+    if( !CheckValidator() )
         return FALSE;
 
     wxTextCtrl *control = (wxTextCtrl *) m_validatorWindow ;
@@ -211,11 +203,7 @@ bool wxTextValidator::TransferToWindow(void)
 // Called to transfer data to the window
 bool wxTextValidator::TransferFromWindow(void)
 {
-    if ( !m_validatorWindow )
-        return FALSE;
-    if ( !m_validatorWindow->IsKindOf(CLASSINFO(wxTextCtrl)) )
-        return FALSE;
-    if ( !m_stringValue )
+    if( !CheckValidator() )
         return FALSE;
 
     wxTextCtrl *control = (wxTextCtrl *) m_validatorWindow ;