fix memory leak of wxMessageOutput if wxApp::OnInit() returned false

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@36119 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/common/appbase.cpp b/src/common/appbase.cpp
index 35145e1e8f731553ea898ddf6c9520405753017b..663e7ea67063d7c5064f7bc9ffe2fa7003b7f974 100644 (file)
--- a/src/common/appbase.cpp
+++ b/src/common/appbase.cpp
@@ -207,10 +207,6 @@ int wxAppConsole::OnExit()
     delete wxConfigBase::Set((wxConfigBase *) NULL);
 #endif // wxUSE_CONFIG
 
-    // use Set(NULL) and not Get() to avoid creating a message output object on
-    // demand when we just want to delete it
-    delete wxMessageOutput::Set(NULL);
-
     return 0;
 }
 

diff --git a/src/common/init.cpp b/src/common/init.cpp
index f6cc91b3503328e4d75f2412bb97d574d8fb6ae9..9b87e1815244d7fbf73bbd262ffa881a144a862a 100644 (file)
--- a/src/common/init.cpp
+++ b/src/common/init.cpp
@@ -364,7 +364,10 @@ static void DoCommonPostCleanup()
     FreeConvertedArgs();
 #endif // wxUSE_UNICODE
 
-    // Note: check for memory leaks is now done via wxDebugContextDumpDelayCounter
+    // use Set(NULL) and not Get() to avoid creating a message output object on
+    // demand when we just want to delete it
+    delete wxMessageOutput::Set(NULL);
+
 #if wxUSE_LOG
     // and now delete the last logger as well
     delete wxLog::SetActiveTarget(NULL);