Revert "Always define WXUSINGDLL when compiling Scintilla in shared wx build."

Finally it's unnecessary to define WXUSINGDLL when building wxScintilla
library as it doesn't use the main DLL, it is simply used as part of it.

This reverts r66222 and finally closes #12626.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66238 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/Makefile.in b/Makefile.in
index 317ebe4f933e786914d5adee259ca39430967b71..dfca390d0bb49a66dce4a7381ad5b7b21ba3fcf7 100644 (file)
--- a/Makefile.in
+++ b/Makefile.in
@@ -2053,7 +2053,7 @@ COND_USE_STC_1___wxscintilla___depname = \
 @COND_SHARED_0_USE_STC_1@      = install_wxscintilla
 @COND_SHARED_0_USE_STC_1@__uninstall_wxscintilla___depname \
 @COND_SHARED_0_USE_STC_1@      = uninstall_wxscintilla
-@COND_SHARED_1@__wxscintilla_usingdll_p = -DWXUSINGDLL
+@COND_MONOLITHIC_0_SHARED_1@__wxscintilla_usingdll_p = -DWXUSINGDLL
 @COND_MONOLITHIC_0@EXTRALIBS_FOR_BASE = $(EXTRALIBS)
 @COND_MONOLITHIC_1@EXTRALIBS_FOR_BASE = $(EXTRALIBS) $(EXTRALIBS_GUI)
 @COND_MONOLITHIC_0@EXTRALIBS_FOR_GUI = $(EXTRALIBS_GUI)

diff --git a/build/bakefiles/scintilla.bkl b/build/bakefiles/scintilla.bkl
index 282c1a656d55c3e1f44676cd3c0c068b9a8941e8..cd1e8aac6b57f9f1f8dfbcad5bb82318f2d41677 100644 (file)
--- a/build/bakefiles/scintilla.bkl
+++ b/build/bakefiles/scintilla.bkl
@@ -39,7 +39,7 @@
     </template>
 
     <set var="wxscintilla_usingdll">
-        <if cond="SHARED=='1'">WXUSINGDLL</if>
+        <if cond="SHARED=='1' and MONOLITHIC=='0'">WXUSINGDLL</if>
     </set>
 
     <lib id="wxscintilla" template="3rdparty_lib,wxscintilla_cppflags"

diff --git a/build/msw/makefile.bcc b/build/msw/makefile.bcc
index 11b331b1503d69c8e0b7aeb23b9c500a94aed614..83d95a7641dd9a2f15087cb192ad7cc2936fd640 100644 (file)
--- a/build/msw/makefile.bcc
+++ b/build/msw/makefile.bcc
@@ -1526,7 +1526,7 @@ __wxjpeg___depname = $(LIBDIRNAME)\wxjpeg$(WXDEBUGFLAG).lib
 !if "$(USE_GUI)" == "1"\r
 __wxtiff___depname = $(LIBDIRNAME)\wxtiff$(WXDEBUGFLAG).lib\r
 !endif\r
-!if "$(SHARED)" == "1"\r
+!if "$(MONOLITHIC)" == "0" && "$(SHARED)" == "1"\r
 __wxscintilla_usingdll_p = -DWXUSINGDLL\r
 !endif\r
 !if "$(MONOLITHIC)" == "0"\r

diff --git a/build/msw/makefile.gcc b/build/msw/makefile.gcc
index 54811fcfe50610e76c5784ae744f970dd7e90e43..6e8a901b55d7bd2b9e7481c72f4eb415febf2fb7 100644 (file)
--- a/build/msw/makefile.gcc
+++ b/build/msw/makefile.gcc
@@ -1532,9 +1532,11 @@ endif
 ifeq ($(USE_GUI),1)\r
 __wxtiff___depname = $(LIBDIRNAME)\libwxtiff$(WXDEBUGFLAG).a\r
 endif\r
+ifeq ($(MONOLITHIC),0)\r
 ifeq ($(SHARED),1)\r
 __wxscintilla_usingdll_p = -DWXUSINGDLL\r
 endif\r
+endif\r
 ifeq ($(MONOLITHIC),0)\r
 EXTRALIBS_FOR_BASE = \r
 endif\r

diff --git a/build/msw/makefile.vc b/build/msw/makefile.vc
index 2735975633ef2dd5d405909f334e4a756e200fd3..6c8e2b983c9c55a5f07c3e1d33608d1ce2fb2479 100644 (file)
--- a/build/msw/makefile.vc
+++ b/build/msw/makefile.vc
@@ -1716,7 +1716,7 @@ __RUNTIME_LIBS_100 = D
 !if "$(RUNTIME_LIBS)" == "static"\r
 __RUNTIME_LIBS_100 = $(__THREADSFLAG)\r
 !endif\r
-!if "$(SHARED)" == "1"\r
+!if "$(MONOLITHIC)" == "0" && "$(SHARED)" == "1"\r
 __wxscintilla_usingdll_p = /DWXUSINGDLL\r
 !endif\r
 !if "$(MONOLITHIC)" == "0"\r

diff --git a/build/msw/makefile.wat b/build/msw/makefile.wat
index 20ced87b09b5d3f5c341992d6442ab3adf166bbc..2a77fdfcc3b4256d15da7160c35d819952840757 100644 (file)
--- a/build/msw/makefile.wat
+++ b/build/msw/makefile.wat
@@ -81,9 +81,11 @@ __wxtiff___depname =
 __wxtiff___depname = $(LIBDIRNAME)\wxtiff$(WXDEBUGFLAG).lib\r
 !endif\r
 __wxscintilla_usingdll_p =\r
+!ifeq MONOLITHIC 0\r
 !ifeq SHARED 1\r
 __wxscintilla_usingdll_p = -dWXUSINGDLL\r
 !endif\r
+!endif\r
 EXTRALIBS_FOR_BASE =\r
 !ifeq MONOLITHIC 0\r
 EXTRALIBS_FOR_BASE = \r