the wxFormatString hack used in wxFileTypeInfo variadic ctors doesn't work anymore...

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@48233 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/include/wx/mimetype.h b/include/wx/mimetype.h
index 588b010b9ad7bc4d8b78c8cc549f3e0d3b5bf481..6febaec81b4f1c94887b271696f1e37d875e7ce3 100644 (file)
--- a/include/wx/mimetype.h
+++ b/include/wx/mimetype.h
@@ -125,25 +125,32 @@ private:
                       const wxString& desc,
                       va_list argptr);
 
-#if !wxUSE_UTF8_LOCALE_ONLY
-    void VarArgInitWchar(const wxChar *mimeType,
-                         const wxChar *openCmd,
-                         const wxChar *printCmd,
-                         const wxChar *desc,
-                         // the other parameters form a NULL terminated list of
-                         // extensions
-                         ...);
-#endif
-#if wxUSE_UNICODE_UTF8
-    void VarArgInitUtf8(const char *mimeType,
-                        const char *openCmd,
-                        const char *printCmd,
-                        const char *desc,
-                        // the other parameters form a NULL terminated list of
-                        // extensions
-                        ...);
-#endif
+    void VarArgInit(const wxString *mimeType,
+                    const wxString *openCmd,
+                    const wxString *printCmd,
+                    const wxString *desc,
+                    // the other parameters form a NULL terminated list of
+                    // extensions
+                    ...);
+
 public:
+    // NB: This is a helper to get implicit conversion of variadic ctor's
+    //     fixed arguments into something that can be passed to VarArgInit().
+    //     Do not use, it's used by the ctor only.
+    struct WXDLLIMPEXP_BASE CtorString
+    {
+        CtorString(const char *str) : m_str(str) {}
+        CtorString(const wchar_t *str) : m_str(str) {}
+        CtorString(const wxString& str) : m_str(str) {}
+        CtorString(const wxCStrData& str) : m_str(str) {}
+        CtorString(const wxCharBuffer& str) : m_str(str) {}
+        CtorString(const wxWCharBuffer& str) : m_str(str) {}
+
+        operator const wxString*() const { return &m_str; }
+
+        wxString m_str;
+    };
+
     // ctors
         // a normal item
 
@@ -156,14 +163,11 @@ public:
     //               // just NULL!)
     //               ...);
     WX_DEFINE_VARARG_FUNC_CTOR(wxFileTypeInfo,
-                               // NB: these are not format strings, using
-                               //     wxFormatString here is a hack to get
-                               //     implicit conversion to wchar_t*/char*
-                               4, (const wxFormatString&,
-                                   const wxFormatString&,
-                                   const wxFormatString&,
-                                   const wxFormatString&),
-                               VarArgInitWchar, VarArgInitUtf8)
+                               4, (const CtorString&,
+                                   const CtorString&,
+                                   const CtorString&,
+                                   const CtorString&),
+                               VarArgInit, VarArgInit)
 #ifdef __WATCOMC__
     // workaround for http://bugzilla.openwatcom.org/show_bug.cgi?id=351
     WX_VARARG_WATCOM_WORKAROUND_CTOR(
@@ -172,40 +176,40 @@ public:
                                     const wxString&,
                                     const wxString&,
                                     const wxString&),
-                                (wxFormatString(f1),
-                                 wxFormatString(f2),
-                                 wxFormatString(f3),
-                                 wxFormatString(f4)));
+                                (CtorString(f1),
+                                 CtorString(f2),
+                                 CtorString(f3),
+                                 CtorString(f4)));
     WX_VARARG_WATCOM_WORKAROUND_CTOR(
                                 wxFileTypeInfo,
                                 4, (const wxCStrData&,
                                     const wxCStrData&,
                                     const wxCStrData&,
                                     const wxCStrData&),
-                                (wxFormatString(f1),
-                                 wxFormatString(f2),
-                                 wxFormatString(f3),
-                                 wxFormatString(f4)));
+                                (CtorString(f1),
+                                 CtorString(f2),
+                                 CtorString(f3),
+                                 CtorString(f4)));
     WX_VARARG_WATCOM_WORKAROUND_CTOR(
                                 wxFileTypeInfo,
                                 4, (const char*,
                                     const char*,
                                     const char*,
                                     const char*),
-                                (wxFormatString(f1),
-                                 wxFormatString(f2),
-                                 wxFormatString(f3),
-                                 wxFormatString(f4)));
+                                (CtorString(f1),
+                                 CtorString(f2),
+                                 CtorString(f3),
+                                 CtorString(f4)));
     WX_VARARG_WATCOM_WORKAROUND_CTOR(
                                 wxFileTypeInfo,
                                 4, (const wchar_t*,
                                     const wchar_t*,
                                     const wchar_t*,
                                     const wchar_t*),
-                                (wxFormatString(f1),
-                                 wxFormatString(f2),
-                                 wxFormatString(f3),
-                                 wxFormatString(f4)));
+                                (CtorString(f1),
+                                 CtorString(f2),
+                                 CtorString(f3),
+                                 CtorString(f4)));
 #endif
 
         // the array elements correspond to the parameters of the ctor above in

diff --git a/src/common/mimecmn.cpp b/src/common/mimecmn.cpp
index bbd1d1e86d2e9605af180dde24b00fe28beb7311..539fd7a7a88076960f73d50bafdef8d44f82b1a6 100644 (file)
--- a/src/common/mimecmn.cpp
+++ b/src/common/mimecmn.cpp
@@ -146,44 +146,19 @@ void wxFileTypeInfo::DoVarArgInit(const wxString& mimeType,
     }
 }
 
-// NB: DoVarArgInit uses WX_VA_ARG_STRING macro to extract the string and this
-//     macro interprets the argument as char* or wchar_t* depending on build
-//     (and in UTF8 build, on the current locale). Because only one of the
-//     vararg forms below is called and the decision about which one gets
-//     called depends on the same conditions WX_VA_ARG_STRING uses, we can
-//     implement both of them in the exact same way:
-
-#if !wxUSE_UTF8_LOCALE_ONLY
-void wxFileTypeInfo::VarArgInitWchar(const wxChar *mimeType,
-                                     const wxChar *openCmd,
-                                     const wxChar *printCmd,
-                                     const wxChar *desc,
-                                     ...)
+void wxFileTypeInfo::VarArgInit(const wxString *mimeType,
+                                const wxString *openCmd,
+                                const wxString *printCmd,
+                                const wxString *desc,
+                                ...)
 {
     va_list argptr;
     va_start(argptr, desc);
 
-    DoVarArgInit(mimeType, openCmd, printCmd, desc, argptr);
+    DoVarArgInit(*mimeType, *openCmd, *printCmd, *desc, argptr);
 
     va_end(argptr);
 }
-#endif // !wxUSE_UTF8_LOCALE_ONLY
-
-#if wxUSE_UNICODE_UTF8
-void wxFileTypeInfo::VarArgInitUtf8(const char *mimeType,
-                                    const char *openCmd,
-                                    const char *printCmd,
-                                    const char *desc,
-                                    ...)
-{
-    va_list argptr;
-    va_start(argptr, desc);
-
-    DoVarArgInit(mimeType, openCmd, printCmd, desc, argptr);
-
-    va_end(argptr);
-}
-#endif // wxUSE_UNICODE_UTF8
 
 
 wxFileTypeInfo::wxFileTypeInfo(const wxArrayString& sArray)