test whether pointer is non-NULL before using it, not after, in wxDoFindStringInList...

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@45144 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/motif/listbox.cpp b/src/motif/listbox.cpp
index fc4ea95718d4c44d75e65dcc145a68cc673305ef..817b9b1c99dd8300c0332f0d038eada17dfc3957 100644 (file)
--- a/src/motif/listbox.cpp
+++ b/src/motif/listbox.cpp
@@ -272,11 +272,10 @@ int wxDoFindStringInList(Widget w, const wxString& s)
     bool success = XmListGetMatchPos (w, str(),
                                       &positions, &no_positions);
 
-    if (success)
+    if (success && positions)
     {
         int pos = positions[0];
-        if (positions)
-            XtFree ((char *) positions);
+        XtFree ((char *) positions);
         return pos - 1;
     }
     else