Defer SetHorizontalExtent to idle, also fixes (wxListBox::Delete ignores Freeze/Thaw...

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@53743 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/include/wx/msw/listbox.h b/include/wx/msw/listbox.h
index afb1dd3aba2bff655b0197e5592c707875dcab65..2d77f86c1a8263a7dc9607ed6c644c7915042bc2 100644 (file)
--- a/include/wx/msw/listbox.h
+++ b/include/wx/msw/listbox.h
@@ -147,11 +147,13 @@ protected:
     virtual void* DoGetItemClientData(unsigned int n) const;
     virtual int DoListHitTest(const wxPoint& point) const;
 
     virtual void* DoGetItemClientData(unsigned int n) const;
     virtual int DoListHitTest(const wxPoint& point) const;
 

+    bool m_updateHorizontalExtent;
+    virtual void OnInternalIdle();
+

     // free memory (common part of Clear() and dtor)
     void Free();
 
     unsigned int m_noItems;
     // free memory (common part of Clear() and dtor)
     void Free();
 
     unsigned int m_noItems;

-    int m_selected;

 
     virtual wxSize DoGetBestSize() const;
 
 
     virtual wxSize DoGetBestSize() const;
 

diff --git a/src/msw/listbox.cpp b/src/msw/listbox.cpp
index aa082d4cdfbe799c638f43dad5d897b45c3580cd..9252783bed0406b208a24047ddfa1aea529f7294 100644 (file)
--- a/src/msw/listbox.cpp
+++ b/src/msw/listbox.cpp
@@ -145,7 +145,7 @@ wxOwnerDrawn *wxListBox::CreateLboxItem(size_t WXUNUSED(n))
 wxListBox::wxListBox()
 {
     m_noItems = 0;
 wxListBox::wxListBox()
 {
     m_noItems = 0;

-    m_selected = 0;
+    m_updateHorizontalExtent = false;

 }
 
 bool wxListBox::Create(wxWindow *parent,
 }
 
 bool wxListBox::Create(wxWindow *parent,


@@ -158,7 +158,7 @@ bool wxListBox::Create(wxWindow *parent,
                        const wxString& name)
 {
     m_noItems = 0;
                        const wxString& name)
 {
     m_noItems = 0;

-    m_selected = 0;
+    m_updateHorizontalExtent = false;

 
     // initialize base class fields
     if ( !CreateControl(parent, id, pos, size, style, validator, name) )
 
     // initialize base class fields
     if ( !CreateControl(parent, id, pos, size, style, validator, name) )


@@ -245,6 +245,17 @@ WXDWORD wxListBox::MSWGetStyle(long style, WXDWORD *exstyle) const
     return msStyle;
 }
 
     return msStyle;
 }
 

+void wxListBox::OnInternalIdle()
+{
+    wxWindow::OnInternalIdle();
+    
+    if (m_updateHorizontalExtent)
+    {
+        SetHorizontalExtent(wxEmptyString);
+        m_updateHorizontalExtent = false;
+    }
+}
+

 // ----------------------------------------------------------------------------
 // implementation of wxListBoxBase methods
 // ----------------------------------------------------------------------------
 // ----------------------------------------------------------------------------
 // implementation of wxListBoxBase methods
 // ----------------------------------------------------------------------------


@@ -265,7 +276,8 @@ void wxListBox::DoDeleteOneItem(unsigned int n)
     SendMessage(GetHwnd(), LB_DELETESTRING, n, 0);
     m_noItems--;
 
     SendMessage(GetHwnd(), LB_DELETESTRING, n, 0);
     m_noItems--;
 

-    SetHorizontalExtent(wxEmptyString);
+    // SetHorizontalExtent(wxEmptyString); can be slow
+    m_updateHorizontalExtent = true;

 
     UpdateOldSelections();
 }
 
     UpdateOldSelections();
 }


@@ -290,7 +302,7 @@ void wxListBox::DoClear()
     ListBox_ResetContent(GetHwnd());
 
     m_noItems = 0;
     ListBox_ResetContent(GetHwnd());
 
     m_noItems = 0;

-    SetHorizontalExtent();
+    m_updateHorizontalExtent = true;

 
     UpdateOldSelections();
 }
 
     UpdateOldSelections();
 }


@@ -468,7 +480,7 @@ int wxListBox::DoInsertItems(const wxArrayStringsAdapter & items,
         AssignNewItemClientData(n, clientData, i, type);
     }
 
         AssignNewItemClientData(n, clientData, i, type);
     }
 

-    SetHorizontalExtent();
+    m_updateHorizontalExtent = true;

 
     UpdateOldSelections();
 
 
     UpdateOldSelections();
 


@@ -530,7 +542,7 @@ void wxListBox::SetString(unsigned int n, const wxString& s)
     if ( wasSelected )
         Select(n);
 
     if ( wasSelected )
         Select(n);
 

-    SetHorizontalExtent();
+    m_updateHorizontalExtent = true;

 }
 
 unsigned int wxListBox::GetCount() const
 }
 
 unsigned int wxListBox::GetCount() const