don't generate an endless stream of asserts for the 0-sized images

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@15304 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/src/html/m_image.cpp b/src/html/m_image.cpp
index 9b7f7dfb8e2c718c71b37375b3c0998635b18e78..e1661058b19908721beccf0200a278dbdc1aaf60 100644 (file)
--- a/src/html/m_image.cpp
+++ b/src/html/m_image.cpp
@@ -385,65 +385,71 @@ wxHtmlImageCell::wxHtmlImageCell(wxWindow *window, wxFSFile *input,
     m_physX = m_physY = -1;
 #endif
 
     m_physX = m_physY = -1;
 #endif
 

-    if ( input )
+    if ( m_bmpW && m_bmpH )

     {
     {

-        wxInputStream *s = input->GetStream();
-
-        if ( s )
+        if ( input )

         {
         {

-            bool readImg = TRUE;
+            wxInputStream *s = input->GetStream();

 
 

-#if wxUSE_GIF && wxUSE_TIMER
-            if ( (input->GetLocation().Matches(wxT("*.gif")) ||
-                  input->GetLocation().Matches(wxT("*.GIF"))) && m_window )
+            if ( s )

             {
             {

-                m_gifDecoder = new wxGIFDecoder(s, TRUE);
-                if ( m_gifDecoder->ReadGIF() == wxGIF_OK )
+                bool readImg = TRUE;
+
+#if wxUSE_GIF && wxUSE_TIMER
+                if ( (input->GetLocation().Matches(wxT("*.gif")) ||
+                      input->GetLocation().Matches(wxT("*.GIF"))) && m_window )

                 {
                 {

-                    wxImage img;
-                    if ( m_gifDecoder->ConvertToImage(&img) )
-                        SetImage(img);
+                    m_gifDecoder = new wxGIFDecoder(s, TRUE);
+                    if ( m_gifDecoder->ReadGIF() == wxGIF_OK )
+                    {
+                        wxImage img;
+                        if ( m_gifDecoder->ConvertToImage(&img) )
+                            SetImage(img);

 
 

-                    readImg = FALSE;
+                        readImg = FALSE;

 
 

-                    if ( m_gifDecoder->IsAnimation() )
-                    {
-                        m_gifTimer = new wxGIFTimer(this);
-                        m_gifTimer->Start(m_gifDecoder->GetDelay(), TRUE);
+                        if ( m_gifDecoder->IsAnimation() )
+                        {
+                            m_gifTimer = new wxGIFTimer(this);
+                            m_gifTimer->Start(m_gifDecoder->GetDelay(), TRUE);
+                        }
+                        else
+                        {
+                            wxDELETE(m_gifDecoder);
+                        }

                     }
                     else
                     {
                         wxDELETE(m_gifDecoder);
                     }
                 }
                     }
                     else
                     {
                         wxDELETE(m_gifDecoder);
                     }
                 }

-                else
-                {
-                    wxDELETE(m_gifDecoder);
-                }
-            }

 
 

-            if ( readImg )
+                if ( readImg )

 #endif // wxUSE_GIF && wxUSE_TIMER
 #endif // wxUSE_GIF && wxUSE_TIMER

-            {
-                SetImage(wxImage(*s, wxBITMAP_TYPE_ANY));
+                {
+                    wxImage image(*s, wxBITMAP_TYPE_ANY);
+                    if ( image.Ok() )
+                        SetImage(image);
+                }

             }
         }
             }
         }

-    }
-    else // input==NULL, use "broken image" bitmap
-    {
-        if ( m_bmpW == -1 && m_bmpH == -1 )
+        else // input==NULL, use "broken image" bitmap

         {
         {

-            m_bmpW = 29;
-            m_bmpH = 31;
-        }
-        else
-        {
-            m_showFrame = TRUE;
-            if ( m_bmpW == -1 ) m_bmpW = 31;
-            if ( m_bmpH == -1 ) m_bmpH = 33;
+            if ( m_bmpW == -1 && m_bmpH == -1 )
+            {
+                m_bmpW = 29;
+                m_bmpH = 31;
+            }
+            else
+            {
+                m_showFrame = TRUE;
+                if ( m_bmpW == -1 ) m_bmpW = 31;
+                if ( m_bmpH == -1 ) m_bmpH = 33;
+            }
+            m_bitmap = new wxBitmap(broken_image_xpm);

         }
         }

-        m_bitmap = new wxBitmap(broken_image_xpm);

     }
     }

+    //else: ignore the 0-sized images used sometimes on the Web pages

 
     m_Width = (int)(scale * (double)m_bmpW);
     m_Height = (int)(scale * (double)m_bmpH);
 
     m_Width = (int)(scale * (double)m_bmpW);
     m_Height = (int)(scale * (double)m_bmpH);