1 /////////////////////////////////////////////////////////////////////////////
2 // Name: ifacecheck.cpp
3 // Purpose: Interface headers <=> real headers coherence checker
4 // Author: Francesco Montorsi
7 // Copyright: (c) 2008 Francesco Montorsi
8 // Licence: wxWindows licence
9 /////////////////////////////////////////////////////////////////////////////
11 // For compilers that support precompilation, includes "wx/wx.h".
12 #include "wx/wxprec.h"
18 // for all others, include the necessary headers
24 #include "wx/cmdline.h"
25 #include "wx/textfile.h"
26 #include "wx/filename.h"
27 #include "wx/stopwatch.h" // for wxGetLocalTime
28 #include "xmlparser.h"
30 // global verbosity flag
31 bool g_verbose
= false;
35 // ----------------------------------------------------------------------------
37 // ----------------------------------------------------------------------------
39 #define API_DUMP_FILE "dump.api.txt"
40 #define INTERFACE_DUMP_FILE "dump.interface.txt"
42 #define PROCESS_ONLY_OPTION "p"
43 #define USE_PREPROCESSOR_OPTION "u"
45 #define MODIFY_SWITCH "m"
46 #define DUMP_SWITCH "d"
47 #define HELP_SWITCH "h"
48 #define VERBOSE_SWITCH "v"
50 static const wxCmdLineEntryDesc g_cmdLineDesc
[] =
52 { wxCMD_LINE_OPTION
, USE_PREPROCESSOR_OPTION
, "use-preproc",
53 "uses the preprocessor output to increase the checker accuracy",
54 wxCMD_LINE_VAL_STRING
, wxCMD_LINE_NEEDS_SEPARATOR
},
55 { wxCMD_LINE_OPTION
, PROCESS_ONLY_OPTION
, "process-only",
56 "processes only header files matching the given wildcard",
57 wxCMD_LINE_VAL_STRING
, wxCMD_LINE_NEEDS_SEPARATOR
},
58 { wxCMD_LINE_SWITCH
, MODIFY_SWITCH
, "modify",
59 "modify the interface headers to match the real ones" },
60 { wxCMD_LINE_SWITCH
, DUMP_SWITCH
, "dump",
61 "dump both interface and API to plain text dump.*.txt files" },
62 { wxCMD_LINE_SWITCH
, HELP_SWITCH
, "help",
63 "show help message", wxCMD_LINE_VAL_NONE
, wxCMD_LINE_OPTION_HELP
},
64 { wxCMD_LINE_SWITCH
, VERBOSE_SWITCH
, "verbose",
66 { wxCMD_LINE_PARAM
, NULL
, NULL
,
67 "gccXML", wxCMD_LINE_VAL_STRING
, wxCMD_LINE_OPTION_MANDATORY
},
68 { wxCMD_LINE_PARAM
, NULL
, NULL
,
69 "doxygenXML", wxCMD_LINE_VAL_STRING
, wxCMD_LINE_OPTION_MANDATORY
},
73 class IfaceCheckLog
: public wxLog
78 virtual void DoLogText(const wxString
& msg
)
80 // send all messages to stdout (normal behaviour is to sent them to stderr)
86 class IfaceCheckApp
: public wxAppConsole
89 // don't use builtin cmd line parsing:
90 virtual bool OnInit() { m_modify
=false; return true; }
93 bool ParsePreprocessorOutput(const wxString
& filename
);
96 int CompareClasses(const wxClass
* iface
, const wxClass
* api
);
97 bool FixMethod(const wxString
& header
, const wxMethod
* iface
, const wxMethod
* api
);
98 bool StringContainsMethodName(const wxString
& str
, const wxMethod
* m
);
100 void PrintStatistics(long secs
);
102 bool IsToProcess(const wxString
& headername
) const
104 if (m_strToMatch
.IsEmpty())
106 return wxMatchWild(m_strToMatch
, headername
, false);
110 wxXmlGccInterface m_gccInterface
; // "real" headers API
111 wxXmlDoxygenInterface m_doxyInterface
; // doxygen-commented headers API
113 // was the MODIFY_SWITCH passed?
116 // if non-empty, then PROCESS_ONLY_OPTION was passed and this is the
117 // wildcard expression to match
118 wxString m_strToMatch
;
121 IMPLEMENT_APP_CONSOLE(IfaceCheckApp
)
123 int IfaceCheckApp::OnRun()
125 long startTime
= wxGetLocalTime(); // for timing purpose
127 wxCmdLineParser
parser(g_cmdLineDesc
, argc
, argv
);
129 wxString::Format("wxWidgets Interface checker utility (built %s against %s)",
130 __DATE__
, wxVERSION_STRING
));
132 // make the output more readable:
133 wxLog::SetActiveTarget(new IfaceCheckLog
);
134 wxLog::DisableTimestamp();
136 // parse the command line...
138 wxString preprocFile
;
139 switch (parser
.Parse())
142 if (parser
.Found(VERBOSE_SWITCH
))
145 // IMPORTANT: parsing #define values must be done _before_ actually
146 // parsing the GCC/doxygen XML files
147 if (parser
.Found(USE_PREPROCESSOR_OPTION
, &preprocFile
))
149 if (!ParsePreprocessorOutput(preprocFile
))
153 // in any case set basic std preprocessor #defines:
154 m_doxyInterface
.AddPreprocessorValue("NULL", "0");
156 // parse the two XML files which contain the real and the doxygen interfaces
157 // for wxWidgets API:
158 if (!m_gccInterface
.Parse(parser
.GetParam(0)) ||
159 !m_doxyInterface
.Parse(parser
.GetParam(1)))
162 if (parser
.Found(DUMP_SWITCH
))
164 wxLogMessage("Dumping real API to '%s'...", API_DUMP_FILE
);
165 m_gccInterface
.Dump(API_DUMP_FILE
);
167 wxLogMessage("Dumping interface API to '%s'...", INTERFACE_DUMP_FILE
);
168 m_doxyInterface
.Dump(INTERFACE_DUMP_FILE
);
172 if (parser
.Found(MODIFY_SWITCH
))
175 if (parser
.Found(PROCESS_ONLY_OPTION
, &m_strToMatch
))
177 size_t len
= m_strToMatch
.Len();
178 if (m_strToMatch
.StartsWith("\"") &&
179 m_strToMatch
.EndsWith("\"") &&
181 m_strToMatch
= m_strToMatch
.Mid(1, len
-2);
188 PrintStatistics(wxGetLocalTime() - startTime
);
192 wxPrintf("\nThis utility checks that the interface XML files created by Doxygen are in\n");
193 wxPrintf("synch with the real headers (whose contents are extracted by the gcc XML file).\n\n");
194 wxPrintf("The 'gccXML' parameter should be the wxapi.xml file created by the 'rungccxml.sh'\n");
195 wxPrintf("script which resides in 'utils/ifacecheck'.\n");
196 wxPrintf("The 'doxygenXML' parameter should be the index.xml file created by Doxygen\n");
197 wxPrintf("for the wxWidgets 'interface' folder.\n\n");
198 wxPrintf("Since the gcc XML file does not contain info about #defines, if you use\n");
199 wxPrintf("the -%s option, you'll get a smaller number of false warnings.\n",
200 USE_PREPROCESSOR_OPTION
);
202 // HELP_SWITCH was passed or a syntax error occurred
207 bool IfaceCheckApp::Compare()
209 const wxClassArray
& interfaces
= m_doxyInterface
.GetClasses();
211 int mcount
= 0, ccount
= 0;
213 wxLogMessage("Comparing the interface API to the real API (%d classes to compare)...",
214 interfaces
.GetCount());
216 if (!m_strToMatch
.IsEmpty())
217 wxLogMessage("Processing only header files matching '%s' expression.", m_strToMatch
);
219 for (unsigned int i
=0; i
<interfaces
.GetCount(); i
++)
221 // only compare the methods which are available for the port
222 // for which the gcc XML was produced
223 if (interfaces
[i
].GetAvailability() != wxPORT_UNKNOWN
&&
224 (interfaces
[i
].GetAvailability() & m_gccInterface
.GetInterfacePort()) == 0) {
227 wxLogMessage("skipping class '%s' since it's not available for the %s port.",
228 interfaces
[i
].GetName(), m_gccInterface
.GetInterfacePortName());
230 continue; // skip this method
233 // shorten the name of the header so the log file is more readable
234 // and also for calling IsToProcess() against it
235 wxString header
= wxFileName(interfaces
[i
].GetHeader()).GetFullName();
237 if (!IsToProcess(header
))
238 continue; // skip this one
240 wxString cname
= interfaces
[i
].GetName();
242 // search in the real headers for i-th interface class; we search for
243 // both class cname and cnameBase since in wxWidgets world tipically
244 // class cname is platform-specific while the real public interface of
245 // that class is part of the cnameBase class.
246 /*c = m_gccInterface.FindClass(cname + "Base");
249 c
= m_gccInterface
.FindClass(cname
);
252 // sometimes the platform-specific class is named "wxGeneric" + cname
254 c
= m_gccInterface
.FindClass("wxGeneric" + cname
.Mid(2));
257 c
= m_gccInterface
.FindClass("wxGtk" + cname
.Mid(2));
263 // there is a class with the same (logic) name!
264 mcount
+= CompareClasses(&interfaces
[i
], c
);
268 wxLogMessage("%s: couldn't find the real interface for the '%s' class",
274 wxLogMessage("%d on a total of %d methods (%.1f%%) of the interface headers do not exist in the real headers",
275 mcount
, m_doxyInterface
.GetMethodCount(), (float)(100.0 * mcount
/m_doxyInterface
.GetMethodCount()));
276 wxLogMessage("%d on a total of %d classes (%.1f%%) of the interface headers do not exist in the real headers",
277 ccount
, m_doxyInterface
.GetClassesCount(), (float)(100.0 * ccount
/m_doxyInterface
.GetClassesCount()));
282 int IfaceCheckApp::CompareClasses(const wxClass
* iface
, const wxClass
* api
)
284 const wxMethod
*real
;
287 wxASSERT(iface
&& api
);
289 // shorten the name of the header so the log file is more readable
290 wxString header
= wxFileName(iface
->GetHeader()).GetFullName();
292 for (unsigned int i
=0; i
<iface
->GetMethodCount(); i
++)
294 const wxMethod
& m
= iface
->GetMethod(i
);
296 // only compare the methods which are available for the port
297 // for which the gcc XML was produced
298 if (m
.GetAvailability() != wxPORT_UNKNOWN
&&
299 (m
.GetAvailability() & m_gccInterface
.GetInterfacePort()) == 0) {
302 wxLogMessage("skipping method '%s' since it's not available for the %s port.",
303 m
.GetAsString(), m_gccInterface
.GetInterfacePortName());
305 continue; // skip this method
308 // search in the methods of the api classes provided
309 real
= api
->RecursiveUpwardFindMethod(m
, &m_gccInterface
);
311 // avoid some false positives:
312 if (!real
&& m
.ActsAsDefaultCtor())
314 // build an artificial default ctor for this class:
316 temp
.GetArgumentTypes().Clear();
319 real
= api
->RecursiveUpwardFindMethod(temp
, &m_gccInterface
);
326 wxMethodPtrArray overloads
=
327 api
->RecursiveUpwardFindMethodsNamed(m
.GetName(), &m_gccInterface
);
329 // avoid false positives:
330 for (unsigned int k
=0; k
<overloads
.GetCount(); k
++)
331 if (overloads
[k
]->MatchesExceptForAttributes(m
) &&
332 m
.IsDeprecated() && !overloads
[k
]->IsDeprecated())
334 // maybe the iface method is marked as deprecated but the
335 // real method is not?
336 wxMethod
tmp(*overloads
[k
]);
337 tmp
.SetDeprecated(true);
341 // in this case, we can disregard this warning... the real
342 // method probably is included in WXWIN_COMPAT sections!
343 proceed
= false; // skip this method
347 #define HACK_TO_AUTO_CORRECT_ONLY_METHOD_ATTRIBUTES 0
348 #if HACK_TO_AUTO_CORRECT_ONLY_METHOD_ATTRIBUTES
349 for (unsigned int k
=0; k
<overloads
.GetCount(); k
++)
350 if (overloads
[k
]->MatchesExceptForAttributes(m
))
352 // fix default values of results[k]:
353 wxMethod
tmp(*overloads
[k
]);
354 tmp
.SetArgumentTypes(m
.GetArgumentTypes());
356 // modify interface header
357 if (FixMethod(iface
->GetHeader(), &m
, &tmp
))
358 wxLogMessage("Adjusted attributes of '%s' method", m
.GetAsString());
363 #endif // HACK_TO_AUTO_CORRECT_ONLY_METHOD_ATTRIBUTES
367 if (overloads
.GetCount()==0)
369 wxLogMessage("%s: real '%s' class and their parents have no method '%s'",
370 header
, api
->GetName(), m
.GetAsString());
371 // we've found no overloads
375 // first, output a warning
376 wxString warning
= header
;
377 if (overloads
.GetCount()>1)
378 warning
+= wxString::Format(": in the real headers there are %d overloads of '%s' for "
379 "'%s' all with different signatures:\n",
380 overloads
.GetCount(), m
.GetName(), api
->GetName());
382 warning
+= wxString::Format(": in the real headers there is a method '%s' for '%s'"
383 " but has different signature:\n",
384 m
.GetName(), api
->GetName());
387 // get a list of the prototypes with _all_ possible attributes:
388 warning
+= "\tdoxy header: " + m
.GetAsString(true, true, true, true);
389 for (unsigned int j
=0; j
<overloads
.GetCount(); j
++)
390 warning
+= "\n\treal header: " + overloads
[j
]->GetAsString(true, true, true, true);
392 wxLogWarning("%s", warning
);
395 if (overloads
.GetCount()>1)
397 // TODO: decide which of these overloads is the most "similar" to m
398 // and eventually modify it
400 wxLogWarning("\tmanual fix is required");
404 wxASSERT(overloads
.GetCount() == 1);
406 if (m_modify
|| m
.IsCtor())
408 wxLogWarning("\tfixing it...");
411 FixMethod(iface
->GetHeader(), &m
, overloads
[0]);
424 bool IfaceCheckApp::StringContainsMethodName(const wxString
& str
, const wxMethod
* m
)
426 return str
.Contains(m
->GetName()) ||
427 (m
->IsOperator() && str
.Contains("operator"));
430 bool IfaceCheckApp::FixMethod(const wxString
& header
, const wxMethod
* iface
, const wxMethod
* api
)
433 wxASSERT(iface
&& api
);
436 if (!file
.Open(header
)) {
437 wxLogError("\tcan't open the '%s' header file.", header
);
441 // GetLocation() returns the line where the last part of the prototype is placed;
442 // i.e. the line containing the semicolon at the end of the declaration.
443 int end
= iface
->GetLocation()-1;
444 if (end
<= 0 || end
>= (int)file
.GetLineCount()) {
445 wxLogWarning("\tinvalid location info for method '%s': %d.",
446 iface
->GetAsString(), iface
->GetLocation());
450 if (!file
.GetLine(end
).Contains(";")) {
451 wxLogWarning("\tinvalid location info for method '%s': %d.",
452 iface
->GetAsString(), iface
->GetLocation());
456 // is this a one-line prototype declaration?
457 bool founddecl
= false;
459 if (StringContainsMethodName(file
.GetLine(end
), iface
))
461 // yes, this prototype is all on this line:
467 start
= end
; // will be decremented inside the while{} loop below
469 // find the start point of this prototype declaration; i.e. the line
470 // containing the function name, which is also the line following
471 // the marker '*/' for the closure of the doxygen comment
474 start
--; // go up one line
476 if (StringContainsMethodName(file
.GetLine(start
), iface
))
479 while (start
> 0 && !founddecl
&&
480 !file
.GetLine(start
).Contains(";") &&
481 !file
.GetLine(start
).Contains("*/"));
484 if (start
<= 0 || !founddecl
)
486 wxLogError("\tcan't find the beginning of the declaration of '%s' method in '%s' header looking backwards from line %d; I arrived at %d and gave up",
487 iface
->GetAsString(), header
, end
+1 /* zero-based => 1-based */, start
);
491 // remove the old prototype
492 for (int k
=start
; k
<=end
; k
++)
493 file
.RemoveLine(start
); // remove (end-start)-nth times the start-th line
495 #define INDENTATION_STR wxString(" ")
497 // if possible, add also the @deprecated tag in the doxygen comment if it's missing
498 int deprecationOffset
= 0;
499 if (file
.GetLine(start
-1).Contains("*/") &&
500 (api
->IsDeprecated() && !iface
->IsDeprecated()))
502 file
.RemoveLine(start
-1);
503 file
.InsertLine(INDENTATION_STR
+ INDENTATION_STR
+
504 "@deprecated @todo provide deprecation description", start
-1);
505 file
.InsertLine(INDENTATION_STR
+ "*/", start
++);
507 // we have added a new line in the final balance
513 // discard gcc XML argument names and replace them with those parsed from doxygen XML;
514 // in this way we should avoid introducing doxygen warnings about cases where the argument
515 // 'xx' of the prototype is called 'yy' in the function's docs.
516 const wxArgumentTypeArray
& doxygenargs
= iface
->GetArgumentTypes();
517 const wxArgumentTypeArray
& realargs
= api
->GetArgumentTypes();
518 if (realargs
.GetCount() == doxygenargs
.GetCount())
520 for (j
=0; j
<doxygenargs
.GetCount(); j
++)
521 if (doxygenargs
[j
]==realargs
[j
])
523 realargs
[j
].SetArgumentName(doxygenargs
[j
].GetArgumentName());
525 if (realargs
[j
].GetDefaultValue().IsNumber() &&
526 doxygenargs
[j
].GetDefaultValue().StartsWith("wx"))
527 realargs
[j
].SetDefaultValue(doxygenargs
[j
].GetDefaultValue());
530 tmp
.SetArgumentTypes(realargs
);
533 #define WRAP_COLUMN 80
535 wxArrayString toinsert
;
536 toinsert
.Add(INDENTATION_STR
+ tmp
.GetAsString() + ";");
538 int nStartColumn
= toinsert
[0].Find('(');
539 wxASSERT(nStartColumn
!= wxNOT_FOUND
);
541 // wrap lines too long at comma boundaries
542 for (i
=0; i
<toinsert
.GetCount(); i
++)
544 size_t len
= toinsert
[i
].Len();
545 if (len
> WRAP_COLUMN
)
547 wxASSERT(i
== toinsert
.GetCount()-1);
550 wxString tmpleft
= toinsert
[i
].Left(WRAP_COLUMN
);
551 int comma
= tmpleft
.Find(',', true /* from end */);
552 if (comma
== wxNOT_FOUND
)
553 break; // break out of the for cycle...
555 toinsert
.Add(wxString(' ', nStartColumn
+1) +
556 toinsert
[i
].Right(len
-comma
-2)); // exclude the comma and the space after it
557 toinsert
[i
] = tmpleft
.Left(comma
+1); // include the comma
561 // insert the new lines
562 for (i
=0; i
<toinsert
.GetCount(); i
++)
563 file
.InsertLine(toinsert
[i
], start
+i
);
565 // now save the modification
567 wxLogError("\tcan't save the '%s' header file.", header
);
571 // how many lines did we add/remove in total?
572 int nOffset
= toinsert
.GetCount() + deprecationOffset
- (end
-start
+1);
577 wxLogMessage("\tthe final row offset for following methods is %d lines.", nOffset
);
579 // update the other method's locations for those methods which belong to the modified header
580 // and are placed _below_ the modified method
581 wxClassPtrArray cToUpdate
= m_doxyInterface
.FindClassesDefinedIn(header
);
582 for (i
=0; i
< cToUpdate
.GetCount(); i
++)
584 for (j
=0; j
< cToUpdate
[i
]->GetMethodCount(); j
++)
586 wxMethod
& m
= cToUpdate
[i
]->GetMethod(j
);
587 if (m
.GetLocation() > iface
->GetLocation())
589 // update the location of this method
590 m
.SetLocation(m
.GetLocation()+nOffset
);
598 bool IfaceCheckApp::ParsePreprocessorOutput(const wxString
& filename
)
601 if (!tf
.Open(filename
)) {
602 wxLogError("can't open the '%s' preprocessor output file.", filename
);
607 for (unsigned int i
=0; i
< tf
.GetLineCount(); i
++)
609 const wxString
& line
= tf
.GetLine(i
);
610 wxString defnameval
= line
.Mid(8); // what follows the "#define " string
612 // the format of this line should be:
613 // #define DEFNAME DEFVALUE
614 if (!line
.StartsWith("#define ")) {
615 wxLogError("unexpected content in '%s' at line %d.", filename
, i
+1);
619 if (defnameval
.Contains(" "))
622 wxString defname
= defnameval
.BeforeFirst(' ');
623 if (defname
.Contains("("))
624 continue; // this is a macro, skip it!
627 wxString defval
= defnameval
.AfterFirst(' ').Strip(wxString::both
);
628 if (defval
.StartsWith("(") && defval
.EndsWith(")"))
629 defval
= defval
.Mid(1, defval
.Len()-2);
631 // store this pair in the doxygen interface, where it can be useful
632 m_doxyInterface
.AddPreprocessorValue(defname
, defval
);
637 // it looks like the format of this line is:
639 // we are not interested to symbols #defined to nothing,
640 // so we just ignore this line.
644 wxLogMessage("Parsed %d preprocessor #defines from '%s' which will be used later...",
650 void IfaceCheckApp::PrintStatistics(long secs
)
652 // these stats, for what regards the gcc XML, are all referred to the wxWidgets
655 wxLogMessage("wx real headers contains declaration of %d classes (%d methods)",
656 m_gccInterface
.GetClassesCount(), m_gccInterface
.GetMethodCount());
657 wxLogMessage("wx interface headers contains declaration of %d classes (%d methods)",
658 m_doxyInterface
.GetClassesCount(), m_doxyInterface
.GetMethodCount());
660 // build a list of the undocumented wx classes
663 const wxClassArray
& arr
= m_gccInterface
.GetClasses();
664 for (unsigned int i
=0; i
<arr
.GetCount(); i
++) {
665 if (m_doxyInterface
.FindClass(arr
[i
].GetName()) == NULL
) {
666 list
+= arr
[i
].GetName() + ", ";
674 wxLogMessage("the list of the %d undocumented wx classes is: %s", undoc
, list
);
675 wxLogMessage("total processing took %d seconds.", secs
);