1 /////////////////////////////////////////////////////////////////////////////
2 // Name: ifacecheck.cpp
3 // Purpose: Interface headers <=> real headers coherence checker
4 // Author: Francesco Montorsi
7 // Copyright: (c) 2008 Francesco Montorsi
8 // Licence: wxWindows licence
9 /////////////////////////////////////////////////////////////////////////////
11 // For compilers that support precompilation, includes "wx/wx.h".
12 #include "wx/wxprec.h"
18 // for all others, include the necessary headers
24 #include "wx/cmdline.h"
25 #include "wx/textfile.h"
26 #include "wx/filename.h"
27 #include "wx/stopwatch.h" // for wxGetLocalTime
28 #include "xmlparser.h"
30 // global verbosity flag
31 bool g_verbose
= false;
35 // ----------------------------------------------------------------------------
37 // ----------------------------------------------------------------------------
39 #define API_DUMP_FILE "dump.api.txt"
40 #define INTERFACE_DUMP_FILE "dump.interface.txt"
42 #define PROCESS_ONLY_OPTION "p"
43 #define USE_PREPROCESSOR_OPTION "u"
45 #define MODIFY_SWITCH "m"
46 #define DUMP_SWITCH "d"
47 #define HELP_SWITCH "h"
48 #define VERBOSE_SWITCH "v"
50 static const wxCmdLineEntryDesc g_cmdLineDesc
[] =
52 { wxCMD_LINE_OPTION
, USE_PREPROCESSOR_OPTION
, "use-preproc",
53 "uses the preprocessor output to increase the checker accuracy",
54 wxCMD_LINE_VAL_STRING
, wxCMD_LINE_NEEDS_SEPARATOR
},
55 { wxCMD_LINE_OPTION
, PROCESS_ONLY_OPTION
, "process-only",
56 "processes only header files matching the given wildcard",
57 wxCMD_LINE_VAL_STRING
, wxCMD_LINE_NEEDS_SEPARATOR
},
58 { wxCMD_LINE_SWITCH
, MODIFY_SWITCH
, "modify",
59 "modify the interface headers to match the real ones" },
60 { wxCMD_LINE_SWITCH
, DUMP_SWITCH
, "dump",
61 "dump both interface and API to plain text dump.*.txt files" },
62 { wxCMD_LINE_SWITCH
, HELP_SWITCH
, "help",
63 "show help message", wxCMD_LINE_VAL_NONE
, wxCMD_LINE_OPTION_HELP
},
64 { wxCMD_LINE_SWITCH
, VERBOSE_SWITCH
, "verbose",
66 { wxCMD_LINE_PARAM
, NULL
, NULL
,
67 "gccXML", wxCMD_LINE_VAL_STRING
, wxCMD_LINE_OPTION_MANDATORY
},
68 { wxCMD_LINE_PARAM
, NULL
, NULL
,
69 "doxygenXML", wxCMD_LINE_VAL_STRING
, wxCMD_LINE_OPTION_MANDATORY
},
73 class IfaceCheckLog
: public wxLog
78 virtual void DoLogText(const wxString
& msg
)
80 // send all messages to stdout (normal behaviour is to sent them to stderr)
86 class IfaceCheckApp
: public wxAppConsole
89 // don't use builtin cmd line parsing:
90 virtual bool OnInit() { m_modify
=false; return true; }
93 bool ParsePreprocessorOutput(const wxString
& filename
);
96 int CompareClasses(const wxClass
* iface
, const wxClass
* api
);
97 bool FixMethod(const wxString
& header
, const wxMethod
* iface
, const wxMethod
* api
);
98 bool StringContainsMethodName(const wxString
& str
, const wxMethod
* m
);
100 void PrintStatistics(long secs
);
102 bool IsToProcess(const wxString
& headername
) const
104 if (m_strToMatch
.IsEmpty())
106 return wxMatchWild(m_strToMatch
, headername
, false);
110 wxXmlGccInterface m_gccInterface
; // "real" headers API
111 wxXmlDoxygenInterface m_doxyInterface
; // doxygen-commented headers API
113 // was the MODIFY_SWITCH passed?
116 // if non-empty, then PROCESS_ONLY_OPTION was passed and this is the
117 // wildcard expression to match
118 wxString m_strToMatch
;
121 IMPLEMENT_APP_CONSOLE(IfaceCheckApp
)
123 int IfaceCheckApp::OnRun()
125 long startTime
= wxGetLocalTime(); // for timing purpose
127 wxCmdLineParser
parser(g_cmdLineDesc
, argc
, argv
);
129 wxString::Format("wxWidgets Interface checker utility (built %s against %s)",
130 __DATE__
, wxVERSION_STRING
));
132 // make the output more readable:
133 wxLog::SetActiveTarget(new IfaceCheckLog
);
134 wxLog::DisableTimestamp();
136 // parse the command line...
138 wxString preprocFile
;
139 switch (parser
.Parse())
142 if (parser
.Found(VERBOSE_SWITCH
))
145 // IMPORTANT: parsing #define values must be done _before_ actually
146 // parsing the GCC/doxygen XML files
147 if (parser
.Found(USE_PREPROCESSOR_OPTION
, &preprocFile
))
149 if (!ParsePreprocessorOutput(preprocFile
))
153 // in any case set basic std preprocessor #defines:
154 m_doxyInterface
.AddPreprocessorValue("NULL", "0");
156 // parse the two XML files which contain the real and the doxygen interfaces
157 // for wxWidgets API:
158 if (!m_gccInterface
.Parse(parser
.GetParam(0)) ||
159 !m_doxyInterface
.Parse(parser
.GetParam(1)))
162 if (parser
.Found(DUMP_SWITCH
))
164 wxLogMessage("Dumping real API to '%s'...", API_DUMP_FILE
);
165 m_gccInterface
.Dump(API_DUMP_FILE
);
167 wxLogMessage("Dumping interface API to '%s'...", INTERFACE_DUMP_FILE
);
168 m_doxyInterface
.Dump(INTERFACE_DUMP_FILE
);
172 if (parser
.Found(MODIFY_SWITCH
))
175 if (parser
.Found(PROCESS_ONLY_OPTION
, &m_strToMatch
))
177 size_t len
= m_strToMatch
.Len();
178 if (m_strToMatch
.StartsWith("\"") &&
179 m_strToMatch
.EndsWith("\"") &&
181 m_strToMatch
= m_strToMatch
.Mid(1, len
-2);
188 PrintStatistics(wxGetLocalTime() - startTime
);
192 wxPrintf("\nThis utility checks that the interface XML files created by Doxygen are in\n");
193 wxPrintf("synch with the real headers (whose contents are extracted by the gcc XML file).\n\n");
194 wxPrintf("The 'gccXML' parameter should be the wxapi.xml file created by the 'rungccxml.sh'\n");
195 wxPrintf("script which resides in 'utils/ifacecheck'.\n");
196 wxPrintf("The 'doxygenXML' parameter should be the index.xml file created by Doxygen\n");
197 wxPrintf("for the wxWidgets 'interface' folder.\n\n");
198 wxPrintf("Since the gcc XML file does not contain info about #defines, if you use\n");
199 wxPrintf("the -%s option, you'll get a smaller number of false warnings.\n",
200 USE_PREPROCESSOR_OPTION
);
202 // HELP_SWITCH was passed or a syntax error occurred
207 bool IfaceCheckApp::Compare()
209 const wxClassArray
& interfaces
= m_doxyInterface
.GetClasses();
211 int mcount
= 0, ccount
= 0;
213 wxLogMessage("Comparing the interface API to the real API (%d classes to compare)...",
214 interfaces
.GetCount());
216 if (!m_strToMatch
.IsEmpty())
218 wxLogMessage("Processing only header files matching '%s' expression.", m_strToMatch
);
221 for (unsigned int i
=0; i
<interfaces
.GetCount(); i
++)
223 // only compare the methods which are available for the port
224 // for which the gcc XML was produced
225 if (interfaces
[i
].GetAvailability() != wxPORT_UNKNOWN
&&
226 (interfaces
[i
].GetAvailability() & m_gccInterface
.GetInterfacePort()) == 0) {
230 wxLogMessage("skipping class '%s' since it's not available for the %s port.",
231 interfaces
[i
].GetName(), m_gccInterface
.GetInterfacePortName());
234 continue; // skip this method
237 // shorten the name of the header so the log file is more readable
238 // and also for calling IsToProcess() against it
239 wxString header
= wxFileName(interfaces
[i
].GetHeader()).GetFullName();
241 if (!IsToProcess(header
))
242 continue; // skip this one
244 wxString cname
= interfaces
[i
].GetName();
246 // search in the real headers for i-th interface class; we search for
247 // both class cname and cnameBase since in wxWidgets world tipically
248 // class cname is platform-specific while the real public interface of
249 // that class is part of the cnameBase class.
250 /*c = m_gccInterface.FindClass(cname + "Base");
253 c
= m_gccInterface
.FindClass(cname
);
256 // sometimes the platform-specific class is named "wxGeneric" + cname
258 c
= m_gccInterface
.FindClass("wxGeneric" + cname
.Mid(2));
261 c
= m_gccInterface
.FindClass("wxGtk" + cname
.Mid(2));
267 // there is a class with the same (logic) name!
268 mcount
+= CompareClasses(&interfaces
[i
], c
);
272 wxLogMessage("%s: couldn't find the real interface for the '%s' class",
278 wxLogMessage("%d on a total of %d methods (%.1f%%) of the interface headers do not exist in the real headers",
279 mcount
, m_doxyInterface
.GetMethodCount(), (float)(100.0 * mcount
/m_doxyInterface
.GetMethodCount()));
280 wxLogMessage("%d on a total of %d classes (%.1f%%) of the interface headers do not exist in the real headers",
281 ccount
, m_doxyInterface
.GetClassesCount(), (float)(100.0 * ccount
/m_doxyInterface
.GetClassesCount()));
286 int IfaceCheckApp::CompareClasses(const wxClass
* iface
, const wxClass
* api
)
288 const wxMethod
*real
;
291 wxASSERT(iface
&& api
);
293 // shorten the name of the header so the log file is more readable
294 wxString header
= wxFileName(iface
->GetHeader()).GetFullName();
296 for (unsigned int i
=0; i
<iface
->GetMethodCount(); i
++)
298 const wxMethod
& m
= iface
->GetMethod(i
);
300 // only compare the methods which are available for the port
301 // for which the gcc XML was produced
302 if (m
.GetAvailability() != wxPORT_UNKNOWN
&&
303 (m
.GetAvailability() & m_gccInterface
.GetInterfacePort()) == 0) {
307 wxLogMessage("skipping method '%s' since it's not available for the %s port.",
308 m
.GetAsString(), m_gccInterface
.GetInterfacePortName());
311 continue; // skip this method
314 // search in the methods of the api classes provided
315 real
= api
->RecursiveUpwardFindMethod(m
, &m_gccInterface
);
317 // avoid some false positives:
318 if (!real
&& m
.ActsAsDefaultCtor())
320 // build an artificial default ctor for this class:
322 temp
.GetArgumentTypes().Clear();
325 real
= api
->RecursiveUpwardFindMethod(temp
, &m_gccInterface
);
332 wxMethodPtrArray overloads
=
333 api
->RecursiveUpwardFindMethodsNamed(m
.GetName(), &m_gccInterface
);
335 // avoid false positives:
336 for (unsigned int k
=0; k
<overloads
.GetCount(); k
++)
337 if (overloads
[k
]->MatchesExceptForAttributes(m
) &&
338 m
.IsDeprecated() && !overloads
[k
]->IsDeprecated())
340 // maybe the iface method is marked as deprecated but the
341 // real method is not?
342 wxMethod
tmp(*overloads
[k
]);
343 tmp
.SetDeprecated(true);
347 // in this case, we can disregard this warning... the real
348 // method probably is included in WXWIN_COMPAT sections!
349 proceed
= false; // skip this method
353 #define HACK_TO_AUTO_CORRECT_ONLY_METHOD_ATTRIBUTES 0
354 #if HACK_TO_AUTO_CORRECT_ONLY_METHOD_ATTRIBUTES
355 for (unsigned int k
=0; k
<overloads
.GetCount(); k
++)
356 if (overloads
[k
]->MatchesExceptForAttributes(m
))
358 // fix default values of results[k]:
359 wxMethod
tmp(*overloads
[k
]);
360 tmp
.SetArgumentTypes(m
.GetArgumentTypes());
362 // modify interface header
363 if (FixMethod(iface
->GetHeader(), &m
, &tmp
))
365 wxLogMessage("Adjusted attributes of '%s' method", m
.GetAsString());
371 #endif // HACK_TO_AUTO_CORRECT_ONLY_METHOD_ATTRIBUTES
375 if (overloads
.GetCount()==0)
377 wxLogMessage("%s: real '%s' class and their parents have no method '%s'",
378 header
, api
->GetName(), m
.GetAsString());
379 // we've found no overloads
383 // first, output a warning
384 wxString warning
= header
;
385 if (overloads
.GetCount()>1)
386 warning
+= wxString::Format(": in the real headers there are %d overloads of '%s' for "
387 "'%s' all with different signatures:\n",
388 overloads
.GetCount(), m
.GetName(), api
->GetName());
390 warning
+= wxString::Format(": in the real headers there is a method '%s' for '%s'"
391 " but has different signature:\n",
392 m
.GetName(), api
->GetName());
395 // get a list of the prototypes with _all_ possible attributes:
396 warning
+= "\tdoxy header: " + m
.GetAsString(true, true, true, true);
397 for (unsigned int j
=0; j
<overloads
.GetCount(); j
++)
398 warning
+= "\n\treal header: " + overloads
[j
]->GetAsString(true, true, true, true);
400 wxLogWarning("%s", warning
);
403 if (overloads
.GetCount()>1)
405 // TODO: decide which of these overloads is the most "similar" to m
406 // and eventually modify it
409 wxLogWarning("\tmanual fix is required");
414 wxASSERT(overloads
.GetCount() == 1);
416 if (m_modify
|| m
.IsCtor())
418 wxLogWarning("\tfixing it...");
421 FixMethod(iface
->GetHeader(), &m
, overloads
[0]);
434 bool IfaceCheckApp::StringContainsMethodName(const wxString
& str
, const wxMethod
* m
)
436 return str
.Contains(m
->GetName()) ||
437 (m
->IsOperator() && str
.Contains("operator"));
440 bool IfaceCheckApp::FixMethod(const wxString
& header
, const wxMethod
* iface
, const wxMethod
* api
)
443 wxASSERT(iface
&& api
);
446 if (!file
.Open(header
)) {
447 wxLogError("\tcan't open the '%s' header file.", header
);
451 // GetLocation() returns the line where the last part of the prototype is placed;
452 // i.e. the line containing the semicolon at the end of the declaration.
453 int end
= iface
->GetLocation()-1;
454 if (end
<= 0 || end
>= (int)file
.GetLineCount()) {
455 wxLogWarning("\tinvalid location info for method '%s': %d.",
456 iface
->GetAsString(), iface
->GetLocation());
460 if (!file
.GetLine(end
).Contains(";")) {
461 wxLogWarning("\tinvalid location info for method '%s': %d.",
462 iface
->GetAsString(), iface
->GetLocation());
466 // is this a one-line prototype declaration?
467 bool founddecl
= false;
469 if (StringContainsMethodName(file
.GetLine(end
), iface
))
471 // yes, this prototype is all on this line:
477 start
= end
; // will be decremented inside the while{} loop below
479 // find the start point of this prototype declaration; i.e. the line
480 // containing the function name, which is also the line following
481 // the marker '*/' for the closure of the doxygen comment
484 start
--; // go up one line
486 if (StringContainsMethodName(file
.GetLine(start
), iface
))
489 while (start
> 0 && !founddecl
&&
490 !file
.GetLine(start
).Contains(";") &&
491 !file
.GetLine(start
).Contains("*/"));
494 if (start
<= 0 || !founddecl
)
496 wxLogError("\tcan't find the beginning of the declaration of '%s' method in '%s' header looking backwards from line %d; I arrived at %d and gave up",
497 iface
->GetAsString(), header
, end
+1 /* zero-based => 1-based */, start
);
501 // remove the old prototype
502 for (int k
=start
; k
<=end
; k
++)
503 file
.RemoveLine(start
); // remove (end-start)-nth times the start-th line
505 #define INDENTATION_STR wxString(" ")
507 // if possible, add also the @deprecated tag in the doxygen comment if it's missing
508 int deprecationOffset
= 0;
509 if (file
.GetLine(start
-1).Contains("*/") &&
510 (api
->IsDeprecated() && !iface
->IsDeprecated()))
512 file
.RemoveLine(start
-1);
513 file
.InsertLine(INDENTATION_STR
+ INDENTATION_STR
+
514 "@deprecated @todo provide deprecation description", start
-1);
515 file
.InsertLine(INDENTATION_STR
+ "*/", start
++);
517 // we have added a new line in the final balance
523 // discard gcc XML argument names and replace them with those parsed from doxygen XML;
524 // in this way we should avoid introducing doxygen warnings about cases where the argument
525 // 'xx' of the prototype is called 'yy' in the function's docs.
526 const wxArgumentTypeArray
& doxygenargs
= iface
->GetArgumentTypes();
527 const wxArgumentTypeArray
& realargs
= api
->GetArgumentTypes();
528 if (realargs
.GetCount() == doxygenargs
.GetCount())
530 for (j
=0; j
<doxygenargs
.GetCount(); j
++)
531 if (doxygenargs
[j
]==realargs
[j
])
533 realargs
[j
].SetArgumentName(doxygenargs
[j
].GetArgumentName());
535 if (realargs
[j
].GetDefaultValue().IsNumber() &&
536 doxygenargs
[j
].GetDefaultValue().StartsWith("wx"))
537 realargs
[j
].SetDefaultValue(doxygenargs
[j
].GetDefaultValue());
540 tmp
.SetArgumentTypes(realargs
);
543 #define WRAP_COLUMN 80
545 wxArrayString toinsert
;
546 toinsert
.Add(INDENTATION_STR
+ tmp
.GetAsString() + ";");
548 int nStartColumn
= toinsert
[0].Find('(');
549 wxASSERT(nStartColumn
!= wxNOT_FOUND
);
551 // wrap lines too long at comma boundaries
552 for (i
=0; i
<toinsert
.GetCount(); i
++)
554 size_t len
= toinsert
[i
].Len();
555 if (len
> WRAP_COLUMN
)
557 wxASSERT(i
== toinsert
.GetCount()-1);
560 wxString tmpleft
= toinsert
[i
].Left(WRAP_COLUMN
);
561 int comma
= tmpleft
.Find(',', true /* from end */);
562 if (comma
== wxNOT_FOUND
)
563 break; // break out of the for cycle...
565 toinsert
.Add(wxString(' ', nStartColumn
+1) +
566 toinsert
[i
].Right(len
-comma
-2)); // exclude the comma and the space after it
567 toinsert
[i
] = tmpleft
.Left(comma
+1); // include the comma
571 // insert the new lines
572 for (i
=0; i
<toinsert
.GetCount(); i
++)
573 file
.InsertLine(toinsert
[i
], start
+i
);
575 // now save the modification
577 wxLogError("\tcan't save the '%s' header file.", header
);
581 // how many lines did we add/remove in total?
582 int nOffset
= toinsert
.GetCount() + deprecationOffset
- (end
-start
+1);
588 wxLogMessage("\tthe final row offset for following methods is %d lines.", nOffset
);
591 // update the other method's locations for those methods which belong to the modified header
592 // and are placed _below_ the modified method
593 wxClassPtrArray cToUpdate
= m_doxyInterface
.FindClassesDefinedIn(header
);
594 for (i
=0; i
< cToUpdate
.GetCount(); i
++)
596 for (j
=0; j
< cToUpdate
[i
]->GetMethodCount(); j
++)
598 wxMethod
& m
= cToUpdate
[i
]->GetMethod(j
);
599 if (m
.GetLocation() > iface
->GetLocation())
601 // update the location of this method
602 m
.SetLocation(m
.GetLocation()+nOffset
);
610 bool IfaceCheckApp::ParsePreprocessorOutput(const wxString
& filename
)
613 if (!tf
.Open(filename
)) {
614 wxLogError("can't open the '%s' preprocessor output file.", filename
);
619 for (unsigned int i
=0; i
< tf
.GetLineCount(); i
++)
621 const wxString
& line
= tf
.GetLine(i
);
622 wxString defnameval
= line
.Mid(8); // what follows the "#define " string
624 // the format of this line should be:
625 // #define DEFNAME DEFVALUE
626 if (!line
.StartsWith("#define ")) {
627 wxLogError("unexpected content in '%s' at line %d.", filename
, i
+1);
631 if (defnameval
.Contains(" "))
634 wxString defname
= defnameval
.BeforeFirst(' ');
635 if (defname
.Contains("("))
636 continue; // this is a macro, skip it!
639 wxString defval
= defnameval
.AfterFirst(' ').Strip(wxString::both
);
640 if (defval
.StartsWith("(") && defval
.EndsWith(")"))
641 defval
= defval
.Mid(1, defval
.Len()-2);
643 // store this pair in the doxygen interface, where it can be useful
644 m_doxyInterface
.AddPreprocessorValue(defname
, defval
);
649 // it looks like the format of this line is:
651 // we are not interested to symbols #defined to nothing,
652 // so we just ignore this line.
656 wxLogMessage("Parsed %d preprocessor #defines from '%s' which will be used later...",
662 void IfaceCheckApp::PrintStatistics(long secs
)
664 // these stats, for what regards the gcc XML, are all referred to the wxWidgets
667 wxLogMessage("wx real headers contains declaration of %d classes (%d methods)",
668 m_gccInterface
.GetClassesCount(), m_gccInterface
.GetMethodCount());
669 wxLogMessage("wx interface headers contains declaration of %d classes (%d methods)",
670 m_doxyInterface
.GetClassesCount(), m_doxyInterface
.GetMethodCount());
672 // build a list of the undocumented wx classes
675 const wxClassArray
& arr
= m_gccInterface
.GetClasses();
676 for (unsigned int i
=0; i
<arr
.GetCount(); i
++) {
677 if (m_doxyInterface
.FindClass(arr
[i
].GetName()) == NULL
) {
678 list
+= arr
[i
].GetName() + ", ";
686 wxLogMessage("the list of the %d undocumented wx classes is: %s", undoc
, list
);
687 wxLogMessage("total processing took %d seconds.", secs
);