1 /////////////////////////////////////////////////////////////////////////////
2 // Name: ifacecheck.cpp
3 // Purpose: Interface headers <=> real headers coherence checker
4 // Author: Francesco Montorsi
7 // Copyright: (c) 2008 Francesco Montorsi
8 // Licence: wxWindows licence
9 /////////////////////////////////////////////////////////////////////////////
11 // For compilers that support precompilation, includes "wx/wx.h".
12 #include "wx/wxprec.h"
18 // for all others, include the necessary headers
24 #include "wx/cmdline.h"
25 #include "wx/textfile.h"
26 #include "wx/filename.h"
27 #include "wx/stopwatch.h" // for wxGetLocalTime
28 #include "xmlparser.h"
30 // global verbosity flag
31 bool g_verbose
= false;
35 // ----------------------------------------------------------------------------
37 // ----------------------------------------------------------------------------
39 #define API_DUMP_FILE "dump.api.txt"
40 #define INTERFACE_DUMP_FILE "dump.interface.txt"
42 #define PROCESS_ONLY_OPTION "p"
43 #define USE_PREPROCESSOR_OPTION "u"
45 #define MODIFY_SWITCH "m"
46 #define DUMP_SWITCH "d"
47 #define HELP_SWITCH "h"
48 #define VERBOSE_SWITCH "v"
50 static const wxCmdLineEntryDesc g_cmdLineDesc
[] =
52 { wxCMD_LINE_OPTION
, USE_PREPROCESSOR_OPTION
, "use-preproc",
53 "uses the preprocessor output to increase the checker accuracy",
54 wxCMD_LINE_VAL_STRING
, wxCMD_LINE_NEEDS_SEPARATOR
},
55 { wxCMD_LINE_OPTION
, PROCESS_ONLY_OPTION
, "process-only",
56 "processes only header files matching the given wildcard",
57 wxCMD_LINE_VAL_STRING
, wxCMD_LINE_NEEDS_SEPARATOR
},
58 { wxCMD_LINE_SWITCH
, MODIFY_SWITCH
, "modify",
59 "modify the interface headers to match the real ones" },
60 { wxCMD_LINE_SWITCH
, DUMP_SWITCH
, "dump",
61 "dump both interface and API to plain text dump.*.txt files" },
62 { wxCMD_LINE_SWITCH
, HELP_SWITCH
, "help",
63 "show help message", wxCMD_LINE_VAL_NONE
, wxCMD_LINE_OPTION_HELP
},
64 { wxCMD_LINE_SWITCH
, VERBOSE_SWITCH
, "verbose",
66 { wxCMD_LINE_PARAM
, NULL
, NULL
,
67 "gccXML", wxCMD_LINE_VAL_STRING
, wxCMD_LINE_OPTION_MANDATORY
},
68 { wxCMD_LINE_PARAM
, NULL
, NULL
,
69 "doxygenXML", wxCMD_LINE_VAL_STRING
, wxCMD_LINE_OPTION_MANDATORY
},
73 class IfaceCheckApp
: public wxAppConsole
76 // don't use builtin cmd line parsing:
77 virtual bool OnInit() { m_modify
=false; return true; }
80 bool ParsePreprocessorOutput(const wxString
& filename
);
83 int CompareClasses(const wxClass
* iface
, const wxClass
* api
);
84 bool FixMethod(const wxString
& header
, const wxMethod
* iface
, const wxMethod
* api
);
85 bool StringContainsMethodName(const wxString
& str
, const wxMethod
* m
);
88 void PrintStatistics(long secs
);
90 bool IsToProcess(const wxString
& headername
) const
92 if (m_strToMatch
.IsEmpty())
94 return wxMatchWild(m_strToMatch
, headername
, false);
98 wxXmlGccInterface m_gccInterface
; // "real" headers API
99 wxXmlDoxygenInterface m_doxyInterface
; // doxygen-commented headers API
101 // was the MODIFY_SWITCH passed?
104 // if non-empty, then PROCESS_ONLY_OPTION was passed and this is the
105 // wildcard expression to match
106 wxString m_strToMatch
;
109 IMPLEMENT_APP_CONSOLE(IfaceCheckApp
)
111 int IfaceCheckApp::OnRun()
113 long startTime
= wxGetLocalTime(); // for timing purpose
115 wxCmdLineParser
parser(g_cmdLineDesc
, argc
, argv
);
117 wxString::Format("wxWidgets Interface checker utility (built %s against %s)",
118 __DATE__
, wxVERSION_STRING
));
120 // parse the command line...
122 wxString preprocFile
;
123 switch (parser
.Parse())
126 if (parser
.Found(VERBOSE_SWITCH
))
129 // IMPORTANT: parsing #define values must be done _before_ actually
130 // parsing the GCC/doxygen XML files
131 if (parser
.Found(USE_PREPROCESSOR_OPTION
, &preprocFile
))
133 if (!ParsePreprocessorOutput(preprocFile
))
137 // in any case set basic std preprocessor #defines:
138 m_doxyInterface
.AddPreprocessorValue("NULL", "0");
140 //g_bLogEnabled = false;
142 // parse the two XML files which contain the real and the doxygen interfaces
143 // for wxWidgets API:
144 if (!m_gccInterface
.Parse(parser
.GetParam(0)) ||
145 !m_doxyInterface
.Parse(parser
.GetParam(1)))
148 g_bLogEnabled
= true;
150 if (parser
.Found(DUMP_SWITCH
))
152 LogMessage("Dumping real API to '%s'...", API_DUMP_FILE
);
153 m_gccInterface
.Dump(API_DUMP_FILE
);
155 LogMessage("Dumping interface API to '%s'...", INTERFACE_DUMP_FILE
);
156 m_doxyInterface
.Dump(INTERFACE_DUMP_FILE
);
160 if (parser
.Found(MODIFY_SWITCH
))
163 if (parser
.Found(PROCESS_ONLY_OPTION
, &m_strToMatch
))
165 size_t len
= m_strToMatch
.Len();
166 if (m_strToMatch
.StartsWith("\"") &&
167 m_strToMatch
.EndsWith("\"") &&
169 m_strToMatch
= m_strToMatch
.Mid(1, len
-2);
176 PrintStatistics(wxGetLocalTime() - startTime
);
180 wxPrintf("\nThis utility checks that the interface XML files created by Doxygen are in\n");
181 wxPrintf("synch with the real headers (whose contents are extracted by the gcc XML file).\n\n");
182 wxPrintf("The 'gccXML' parameter should be the wxapi.xml file created by the 'rungccxml.sh'\n");
183 wxPrintf("script which resides in 'utils/ifacecheck'.\n");
184 wxPrintf("The 'doxygenXML' parameter should be the index.xml file created by Doxygen\n");
185 wxPrintf("for the wxWidgets 'interface' folder.\n\n");
186 wxPrintf("Since the gcc XML file does not contain info about #defines, if you use\n");
187 wxPrintf("the -%s option, you'll get a smaller number of false warnings.\n",
188 USE_PREPROCESSOR_OPTION
);
190 // HELP_SWITCH was passed or a syntax error occurred
195 void IfaceCheckApp::ShowProgress()
201 bool IfaceCheckApp::Compare()
203 const wxClassArray
& interfaces
= m_doxyInterface
.GetClasses();
205 int mcount
= 0, ccount
= 0;
207 LogMessage("Comparing the interface API to the real API (%d classes to compare)...",
208 interfaces
.GetCount());
210 if (!m_strToMatch
.IsEmpty())
211 LogMessage("Processing only header files matching '%s' expression.", m_strToMatch
);
213 for (unsigned int i
=0; i
<interfaces
.GetCount(); i
++)
215 // only compare the methods which are available for the port
216 // for which the gcc XML was produced
217 if (interfaces
[i
].GetAvailability() != wxPORT_UNKNOWN
&&
218 (interfaces
[i
].GetAvailability() & m_gccInterface
.GetInterfacePort()) == 0) {
221 LogMessage("skipping class '%s' since it's not available for the %s port.",
222 interfaces
[i
].GetName(), m_gccInterface
.GetInterfacePortName());
224 continue; // skip this method
227 // shorten the name of the header so the log file is more readable
228 // and also for calling IsToProcess() against it
229 wxString header
= wxFileName(interfaces
[i
].GetHeader()).GetFullName();
231 if (!IsToProcess(header
))
232 continue; // skip this one
234 wxString cname
= interfaces
[i
].GetName();
236 // search in the real headers for i-th interface class; we search for
237 // both class cname and cnameBase since in wxWidgets world tipically
238 // class cname is platform-specific while the real public interface of
239 // that class is part of the cnameBase class.
240 /*c = m_gccInterface.FindClass(cname + "Base");
243 c
= m_gccInterface
.FindClass(cname
);
246 // sometimes the platform-specific class is named "wxGeneric" + cname
248 c
= m_gccInterface
.FindClass("wxGeneric" + cname
.Mid(2));
251 c
= m_gccInterface
.FindClass("wxGtk" + cname
.Mid(2));
257 // there is a class with the same (logic) name!
258 mcount
+= CompareClasses(&interfaces
[i
], c
);
262 LogMessage("%s: couldn't find the real interface for the '%s' class",
268 LogMessage("%d on a total of %d methods (%.1f%%) of the interface headers do not exist in the real headers",
269 mcount
, m_doxyInterface
.GetMethodCount(), (float)(100.0 * mcount
/m_doxyInterface
.GetMethodCount()));
270 LogMessage("%d on a total of %d classes (%.1f%%) of the interface headers do not exist in the real headers",
271 ccount
, m_doxyInterface
.GetClassesCount(), (float)(100.0 * ccount
/m_doxyInterface
.GetClassesCount()));
276 int IfaceCheckApp::CompareClasses(const wxClass
* iface
, const wxClass
* api
)
278 const wxMethod
*real
;
281 wxASSERT(iface
&& api
);
283 // shorten the name of the header so the log file is more readable
284 wxString header
= wxFileName(iface
->GetHeader()).GetFullName();
286 for (unsigned int i
=0; i
<iface
->GetMethodCount(); i
++)
288 const wxMethod
& m
= iface
->GetMethod(i
);
290 // only compare the methods which are available for the port
291 // for which the gcc XML was produced
292 if (m
.GetAvailability() != wxPORT_UNKNOWN
&&
293 (m
.GetAvailability() & m_gccInterface
.GetInterfacePort()) == 0) {
296 LogMessage("skipping method '%s' since it's not available for the %s port.",
297 m
.GetAsString(), m_gccInterface
.GetInterfacePortName());
299 continue; // skip this method
302 // search in the methods of the api classes provided
303 real
= api
->RecursiveUpwardFindMethod(m
, &m_gccInterface
);
305 // avoid some false positives:
306 if (!real
&& m
.ActsAsDefaultCtor())
308 // build an artificial default ctor for this class:
310 temp
.GetArgumentTypes().Clear();
313 real
= api
->RecursiveUpwardFindMethod(temp
, &m_gccInterface
);
320 wxMethodPtrArray overloads
=
321 api
->RecursiveUpwardFindMethodsNamed(m
.GetName(), &m_gccInterface
);
323 // avoid false positives:
324 for (unsigned int k
=0; k
<overloads
.GetCount(); k
++)
325 if (overloads
[k
]->MatchesExceptForAttributes(m
) &&
326 m
.IsDeprecated() && !overloads
[k
]->IsDeprecated())
328 // maybe the iface method is marked as deprecated but the
329 // real method is not?
330 wxMethod
tmp(*overloads
[k
]);
331 tmp
.SetDeprecated(true);
335 // in this case, we can disregard this warning... the real
336 // method probably is included in WXWIN_COMPAT sections!
337 proceed
= false; // skip this method
341 #define HACK_TO_AUTO_CORRECT_ONLY_METHOD_ATTRIBUTES 0
342 #if HACK_TO_AUTO_CORRECT_ONLY_METHOD_ATTRIBUTES
343 for (unsigned int k
=0; k
<overloads
.GetCount(); k
++)
344 if (overloads
[k
]->MatchesExceptForAttributes(m
))
346 // fix default values of results[k]:
347 wxMethod
tmp(*overloads
[k
]);
348 tmp
.SetArgumentTypes(m
.GetArgumentTypes());
350 // modify interface header
351 if (FixMethod(iface
->GetHeader(), &m
, &tmp
))
352 LogMessage("Adjusted attributes of '%s' method", m
.GetAsString());
357 #endif // HACK_TO_AUTO_CORRECT_ONLY_METHOD_ATTRIBUTES
361 if (overloads
.GetCount()==0)
363 LogMessage("%s: real '%s' class and their parents have no method '%s'",
364 header
, api
->GetName(), m
.GetAsString());
365 // we've found no overloads
369 // first, output a warning
370 wxString warning
= header
;
371 if (overloads
.GetCount()>1)
372 warning
+= wxString::Format(": in the real headers there are %d overloads of '%s' for "
373 "'%s' all with different signatures:\n",
374 overloads
.GetCount(), m
.GetName(), api
->GetName());
376 warning
+= wxString::Format(": in the real headers there is a method '%s' for '%s'"
377 " but has different signature:\n",
378 m
.GetName(), api
->GetName());
381 // get a list of the prototypes with _all_ possible attributes:
382 warning
+= "\tdoxy header: " + m
.GetAsString(true, true, true, true);
383 for (unsigned int j
=0; j
<overloads
.GetCount(); j
++)
384 warning
+= "\n\treal header: " + overloads
[j
]->GetAsString(true, true, true, true);
386 wxPrint(warning
+ "\n");
389 if (overloads
.GetCount()>1)
391 // TODO: decide which of these overloads is the most "similar" to m
392 // and eventually modify it
394 wxPrint("\tmanual fix is required\n");
398 wxASSERT(overloads
.GetCount() == 1);
400 if (m_modify
|| m
.IsCtor())
402 wxPrint("\tfixing it...\n");
405 FixMethod(iface
->GetHeader(), &m
, overloads
[0]);
418 bool IfaceCheckApp::StringContainsMethodName(const wxString
& str
, const wxMethod
* m
)
420 return str
.Contains(m
->GetName()) ||
421 (m
->IsOperator() && str
.Contains("operator"));
424 bool IfaceCheckApp::FixMethod(const wxString
& header
, const wxMethod
* iface
, const wxMethod
* api
)
426 wxASSERT(iface
&& api
);
429 if (!file
.Open(header
)) {
430 LogError("\tcan't open the '%s' header file.", header
);
434 // GetLocation() returns the line where the last part of the prototype is placed;
435 // i.e. the line containing the semicolon at the end of the declaration.
436 int end
= iface
->GetLocation()-1;
437 if (end
<= 0 || end
>= (int)file
.GetLineCount()) {
438 LogWarning("\tinvalid location info for method '%s': %d.",
439 iface
->GetAsString(), iface
->GetLocation());
443 if (!file
.GetLine(end
).Contains(";")) {
444 LogWarning("\tinvalid location info for method '%s': %d.",
445 iface
->GetAsString(), iface
->GetLocation());
449 // is this a one-line prototype declaration?
450 bool founddecl
= false;
452 if (StringContainsMethodName(file
.GetLine(end
), iface
))
454 // yes, this prototype is all on this line:
460 start
= end
; // will be decremented inside the while{} loop below
462 // find the start point of this prototype declaration; i.e. the line
463 // containing the function name, which is also the line following
464 // the marker '*/' for the closure of the doxygen comment
467 start
--; // go up one line
469 if (StringContainsMethodName(file
.GetLine(start
), iface
))
472 while (start
> 0 && !founddecl
&&
473 !file
.GetLine(start
).Contains(";") &&
474 !file
.GetLine(start
).Contains("*/"));
477 if (start
<= 0 || !founddecl
)
479 LogError("\tcan't find the beginning of the declaration of '%s' method in '%s' header looking backwards from line %d; I arrived at %d and gave up",
480 iface
->GetAsString(), header
, end
+1 /* zero-based => 1-based */, start
);
484 // remove the old prototype
485 for (int i
=start
; i
<=end
; i
++)
486 file
.RemoveLine(start
); // remove (end-start)-nth times the start-th line
488 #define INDENTATION_STR wxString(" ")
490 // if possible, add also the @deprecated tag in the doxygen comment if it's missing
491 int deprecationOffset
= 0;
492 if (file
.GetLine(start
-1).Contains("*/") &&
493 (api
->IsDeprecated() && !iface
->IsDeprecated()))
495 file
.RemoveLine(start
-1);
496 file
.InsertLine(INDENTATION_STR
+ INDENTATION_STR
+
497 "@deprecated @todo provide deprecation description", start
-1);
498 file
.InsertLine(INDENTATION_STR
+ "*/", start
++);
500 // we have added a new line in the final balance
506 // discard gcc XML argument names and replace them with those parsed from doxygen XML;
507 // in this way we should avoid introducing doxygen warnings about cases where the argument
508 // 'xx' of the prototype is called 'yy' in the function's docs.
509 const wxArgumentTypeArray
& doxygenargs
= iface
->GetArgumentTypes();
510 const wxArgumentTypeArray
& realargs
= api
->GetArgumentTypes();
511 if (realargs
.GetCount() == doxygenargs
.GetCount())
513 for (unsigned int j
=0; j
<doxygenargs
.GetCount(); j
++)
514 if (doxygenargs
[j
]==realargs
[j
])
516 realargs
[j
].SetArgumentName(doxygenargs
[j
].GetArgumentName());
518 if (realargs
[j
].GetDefaultValue().IsNumber() &&
519 doxygenargs
[j
].GetDefaultValue().StartsWith("wx"))
520 realargs
[j
].SetDefaultValue(doxygenargs
[j
].GetDefaultValue());
523 tmp
.SetArgumentTypes(realargs
);
526 #define WRAP_COLUMN 80
528 wxArrayString toinsert
;
529 toinsert
.Add(INDENTATION_STR
+ tmp
.GetAsString() + ";");
531 int nStartColumn
= toinsert
[0].Find('(');
532 wxASSERT(nStartColumn
!= wxNOT_FOUND
);
534 // wrap lines too long at comma boundaries
535 for (unsigned int i
=0; i
<toinsert
.GetCount(); i
++)
537 size_t len
= toinsert
[i
].Len();
538 if (len
> WRAP_COLUMN
)
540 wxASSERT(i
== toinsert
.GetCount()-1);
543 wxString tmpleft
= toinsert
[i
].Left(WRAP_COLUMN
);
544 int comma
= tmpleft
.Find(',', true /* from end */);
545 if (comma
== wxNOT_FOUND
)
546 break; // break out of the for cycle...
548 toinsert
.Add(wxString(' ', nStartColumn
+1) +
549 toinsert
[i
].Right(len
-comma
-2)); // exclude the comma and the space after it
550 toinsert
[i
] = tmpleft
.Left(comma
+1); // include the comma
554 // insert the new lines
555 for (unsigned int i
=0; i
<toinsert
.GetCount(); i
++)
556 file
.InsertLine(toinsert
[i
], start
+i
);
558 // now save the modification
560 LogError("\tcan't save the '%s' header file.", header
);
564 // how many lines did we add/remove in total?
565 int nOffset
= toinsert
.GetCount() + deprecationOffset
- (end
-start
+1);
570 LogMessage("\tthe final row offset for following methods is %d lines.", nOffset
);
572 // update the other method's locations for those methods which belong to the modified header
573 // and are placed _below_ the modified method
574 wxClassPtrArray cToUpdate
= m_doxyInterface
.FindClassesDefinedIn(header
);
575 for (unsigned int i
=0; i
< cToUpdate
.GetCount(); i
++)
577 for (unsigned int j
=0; j
< cToUpdate
[i
]->GetMethodCount(); j
++)
579 wxMethod
& m
= cToUpdate
[i
]->GetMethod(j
);
580 if (m
.GetLocation() > iface
->GetLocation())
582 // update the location of this method
583 m
.SetLocation(m
.GetLocation()+nOffset
);
591 bool IfaceCheckApp::ParsePreprocessorOutput(const wxString
& filename
)
594 if (!tf
.Open(filename
)) {
595 LogError("can't open the '%s' preprocessor output file.", filename
);
600 for (unsigned int i
=0; i
< tf
.GetLineCount(); i
++)
602 const wxString
& line
= tf
.GetLine(i
);
603 wxString defnameval
= line
.Mid(8); // what follows the "#define " string
605 // the format of this line should be:
606 // #define DEFNAME DEFVALUE
607 if (!line
.StartsWith("#define ")) {
608 LogError("unexpected content in '%s' at line %d.", filename
, i
+1);
612 if (defnameval
.Contains(" "))
615 wxString defname
= defnameval
.BeforeFirst(' ');
616 if (defname
.Contains("("))
617 continue; // this is a macro, skip it!
620 wxString defval
= defnameval
.AfterFirst(' ').Strip(wxString::both
);
621 if (defval
.StartsWith("(") && defval
.EndsWith(")"))
622 defval
= defval
.Mid(1, defval
.Len()-2);
624 // store this pair in the doxygen interface, where it can be useful
625 m_doxyInterface
.AddPreprocessorValue(defname
, defval
);
630 // it looks like the format of this line is:
632 // we are not interested to symbols #defined to nothing,
633 // so we just ignore this line.
637 LogMessage("Parsed %d preprocessor #defines from '%s' which will be used later...",
643 void IfaceCheckApp::PrintStatistics(long secs
)
645 // these stats, for what regards the gcc XML, are all referred to the wxWidgets
648 LogMessage("wx real headers contains declaration of %d classes (%d methods)",
649 m_gccInterface
.GetClassesCount(), m_gccInterface
.GetMethodCount());
650 LogMessage("wx interface headers contains declaration of %d classes (%d methods)",
651 m_doxyInterface
.GetClassesCount(), m_doxyInterface
.GetMethodCount());
653 // build a list of the undocumented wx classes
656 const wxClassArray
& arr
= m_gccInterface
.GetClasses();
657 for (unsigned int i
=0; i
<arr
.GetCount(); i
++) {
658 if (m_doxyInterface
.FindClass(arr
[i
].GetName()) == NULL
) {
659 list
+= arr
[i
].GetName() + ", ";
667 LogMessage("the list of the %d undocumented wx classes is: %s", undoc
, list
);
668 LogMessage("total processing took %d seconds.", secs
);