src/msw/menu.cpp

   1 /////////////////////////////////////////////////////////////////////////////
   2 // Name:        src/msw/menu.cpp
   3 // Purpose:     wxMenu, wxMenuBar, wxMenuItem
   4 // Author:      Julian Smart
   5 // Modified by: Vadim Zeitlin
   6 // Created:     04/01/98
   7 // Copyright:   (c) Julian Smart
   8 // Licence:     wxWindows licence
   9 /////////////////////////////////////////////////////////////////////////////
  10
  11 // ===========================================================================
  12 // declarations
  13 // ===========================================================================
  14
  15 // ---------------------------------------------------------------------------
  16 // headers
  17 // ---------------------------------------------------------------------------
  18
  19 // For compilers that support precompilation, includes "wx.h".
  20 #include "wx/wxprec.h"
  21
  22 #ifdef __BORLANDC__
  23     #pragma hdrstop
  24 #endif
  25
  26 #if wxUSE_MENUS
  27
  28 #include "wx/menu.h"
  29
  30 #ifndef WX_PRECOMP
  31     #include "wx/frame.h"
  32     #include "wx/utils.h"
  33     #include "wx/intl.h"
  34     #include "wx/log.h"
  35     #include "wx/image.h"
  36 #endif
  37
  38 #if wxUSE_OWNER_DRAWN
  39     #include "wx/ownerdrw.h"
  40 #endif
  41
  42 #include "wx/scopedarray.h"
  43 #include "wx/vector.h"
  44
  45 #include "wx/msw/private.h"
  46 #include "wx/msw/wrapcctl.h" // include <commctrl.h> "properly"
  47
  48 #ifdef __WXWINCE__
  49 #include <windows.h>
  50 #include <windowsx.h>
  51 #include <tchar.h>
  52 #include <ole2.h>
  53 #include <shellapi.h>
  54 #if (_WIN32_WCE < 400) && !defined(__HANDHELDPC__)
  55 #include <aygshell.h>
  56 #endif
  57
  58 #include "wx/msw/wince/missing.h"
  59
  60 #endif
  61
  62 // other standard headers
  63 #include <string.h>
  64
  65 #if wxUSE_OWNER_DRAWN
  66     #include "wx/dynlib.h"
  67 #endif
  68
  69 #ifndef MNS_CHECKORBMP
  70     #define MNS_CHECKORBMP 0x04000000
  71 #endif
  72 #ifndef MIM_STYLE
  73     #define MIM_STYLE 0x00000010
  74 #endif
  75
  76 // ----------------------------------------------------------------------------
  77 // global variables
  78 // ----------------------------------------------------------------------------
  79
  80 // ----------------------------------------------------------------------------
  81 // constants
  82 // ----------------------------------------------------------------------------
  83
  84 // the (popup) menu title has this special id
  85 static const int idMenuTitle = wxID_NONE;
  86
  87 // ----------------------------------------------------------------------------
  88 // private helper classes and functions
  89 // ----------------------------------------------------------------------------
  90
  91 // Contains the data about the radio items groups in the given menu.
  92 class wxMenuRadioItemsData
  93 {
  94 public:
  95     wxMenuRadioItemsData() { }
  96
  97     // Default copy ctor, assignment operator and dtor are all ok.
  98
  99     // Find the start and end of the group containing the given position or
 100     // return false if it's not inside any range.
 101     bool GetGroupRange(int pos, int *start, int *end) const
 102     {
 103         // We use a simple linear search here because there are not that many
 104         // items in a menu and hence even fewer radio items ranges anyhow, so
 105         // normally there is no need to do anything fancy (like keeping the
 106         // array sorted and using binary search).
 107         for ( Ranges::const_iterator it = m_ranges.begin();
 108               it != m_ranges.end();
 109               ++it )
 110         {
 111             const Range& r = *it;
 112
 113             if ( r.start <= pos && pos <= r.end )
 114             {
 115                 if ( start )
 116                     *start = r.start;
 117                 if ( end )
 118                     *end = r.end;
 119
 120                 return true;
 121             }
 122         }
 123
 124         return false;
 125     }
 126
 127     // Take into account the new radio item about to be added at the given
 128     // position.
 129     //
 130     // Returns true if this item starts a new radio group, false if it extends
 131     // an existing one.
 132     bool UpdateOnInsert(int pos)
 133     {
 134         bool inExistingGroup = false;
 135
 136         for ( Ranges::iterator it = m_ranges.begin();
 137               it != m_ranges.end();
 138               ++it )
 139         {
 140             Range& r = *it;
 141
 142             if ( pos < r.start )
 143             {
 144                 // Item is inserted before this range, update its indices.
 145                 r.start++;
 146                 r.end++;
 147             }
 148             else if ( pos <= r.end + 1 )
 149             {
 150                 // Item is inserted in the middle of this range or immediately
 151                 // after it in which case it extends this range so make it span
 152                 // one more item in any case.
 153                 r.end++;
 154
 155                 inExistingGroup = true;
 156             }
 157             //else: Item is inserted after this range, nothing to do for it.
 158         }
 159
 160         if ( inExistingGroup )
 161             return false;
 162
 163         // Make a new range for the group this item will belong to.
 164         Range r;
 165         r.start = pos;
 166         r.end = pos;
 167         m_ranges.push_back(r);
 168
 169         return true;
 170     }
 171
 172 private:
 173     // Contains the inclusive positions of the range start and end.
 174     struct Range
 175     {
 176         int start;
 177         int end;
 178     };
 179
 180     typedef wxVector<Range> Ranges;
 181     Ranges m_ranges;
 182 };
 183
 184 namespace
 185 {
 186
 187 // make the given menu item default
 188 void SetDefaultMenuItem(HMENU WXUNUSED_IN_WINCE(hmenu),
 189                         UINT WXUNUSED_IN_WINCE(id))
 190 {
 191 #ifndef __WXWINCE__
 192     WinStruct<MENUITEMINFO> mii;
 193     mii.fMask = MIIM_STATE;
 194     mii.fState = MFS_DEFAULT;
 195
 196     if ( !::SetMenuItemInfo(hmenu, id, FALSE, &mii) )
 197     {
 198         wxLogLastError(wxT("SetMenuItemInfo"));
 199     }
 200 #endif // !__WXWINCE__
 201 }
 202
 203 // make the given menu item owner-drawn
 204 void SetOwnerDrawnMenuItem(HMENU WXUNUSED_IN_WINCE(hmenu),
 205                            UINT WXUNUSED_IN_WINCE(id),
 206                            ULONG_PTR WXUNUSED_IN_WINCE(data),
 207                            BOOL WXUNUSED_IN_WINCE(byPositon = FALSE))
 208 {
 209 #ifndef __WXWINCE__
 210     WinStruct<MENUITEMINFO> mii;
 211     mii.fMask = MIIM_FTYPE | MIIM_DATA;
 212     mii.fType = MFT_OWNERDRAW;
 213     mii.dwItemData = data;
 214
 215     if ( reinterpret_cast<wxMenuItem*>(data)->IsSeparator() )
 216         mii.fType |= MFT_SEPARATOR;
 217
 218     if ( !::SetMenuItemInfo(hmenu, id, byPositon, &mii) )
 219     {
 220         wxLogLastError(wxT("SetMenuItemInfo"));
 221     }
 222 #endif // !__WXWINCE__
 223 }
 224
 225 #ifdef __WXWINCE__
 226 UINT GetMenuState(HMENU hMenu, UINT id, UINT flags)
 227 {
 228     WinStruct<MENUITEMINFO> info;
 229     info.fMask = MIIM_STATE;
 230     // MF_BYCOMMAND is zero so test MF_BYPOSITION
 231     if ( !::GetMenuItemInfo(hMenu, id, flags & MF_BYPOSITION ? TRUE : FALSE , & info) )
 232     {
 233         wxLogLastError(wxT("GetMenuItemInfo"));
 234     }
 235     return info.fState;
 236 }
 237 #endif // __WXWINCE__
 238
 239 inline bool IsGreaterThanStdSize(const wxBitmap& bmp)
 240 {
 241     return bmp.GetWidth() > ::GetSystemMetrics(SM_CXMENUCHECK) ||
 242             bmp.GetHeight() > ::GetSystemMetrics(SM_CYMENUCHECK);
 243 }
 244
 245 } // anonymous namespace
 246
 247 // ============================================================================
 248 // implementation
 249 // ============================================================================
 250
 251 // ---------------------------------------------------------------------------
 252 // wxMenu construction, adding and removing menu items
 253 // ---------------------------------------------------------------------------
 254
 255 // Construct a menu with optional title (then use append)
 256 void wxMenu::InitNoCreate()
 257 {
 258     m_radioData = NULL;
 259     m_doBreak = false;
 260
 261 #if wxUSE_OWNER_DRAWN
 262     m_ownerDrawn = false;
 263     m_maxBitmapWidth = 0;
 264     m_maxAccelWidth = -1;
 265 #endif // wxUSE_OWNER_DRAWN
 266 }
 267
 268 void wxMenu::Init()
 269 {
 270     InitNoCreate();
 271
 272     // create the menu
 273     m_hMenu = (WXHMENU)CreatePopupMenu();
 274     if ( !m_hMenu )
 275     {
 276         wxLogLastError(wxT("CreatePopupMenu"));
 277     }
 278
 279     // if we have a title, insert it in the beginning of the menu
 280     if ( !m_title.empty() )
 281     {
 282         const wxString title = m_title;
 283         m_title.clear(); // so that SetTitle() knows there was no title before
 284         SetTitle(title);
 285     }
 286 }
 287
 288 wxMenu::wxMenu(WXHMENU hMenu)
 289 {
 290     InitNoCreate();
 291
 292     m_hMenu = hMenu;
 293
 294     // Ensure that our internal idea of how many items we have corresponds to
 295     // the real number of items in the menu.
 296     //
 297     // We could also retrieve the real labels of the items here but it doesn't
 298     // seem to be worth the trouble.
 299     const int numExistingItems = ::GetMenuItemCount(m_hMenu);
 300     for ( int n = 0; n < numExistingItems; n++ )
 301     {
 302         wxMenuBase::DoAppend(wxMenuItem::New(this, wxID_SEPARATOR));
 303     }
 304 }
 305
 306 // The wxWindow destructor will take care of deleting the submenus.
 307 wxMenu::~wxMenu()
 308 {
 309     // we should free Windows resources only if Windows doesn't do it for us
 310     // which happens if we're attached to a menubar or a submenu of another
 311     // menu
 312     if ( !IsAttached() && !GetParent() )
 313     {
 314         if ( !::DestroyMenu(GetHmenu()) )
 315         {
 316             wxLogLastError(wxT("DestroyMenu"));
 317         }
 318     }
 319
 320 #if wxUSE_ACCEL
 321     // delete accels
 322     WX_CLEAR_ARRAY(m_accels);
 323 #endif // wxUSE_ACCEL
 324
 325     delete m_radioData;
 326 }
 327
 328 void wxMenu::Break()
 329 {
 330     // this will take effect during the next call to Append()
 331     m_doBreak = true;
 332 }
 333
 334 #if wxUSE_ACCEL
 335
 336 int wxMenu::FindAccel(int id) const
 337 {
 338     size_t n, count = m_accels.GetCount();
 339     for ( n = 0; n < count; n++ )
 340     {
 341         if ( m_accels[n]->m_command == id )
 342             return n;
 343     }
 344
 345     return wxNOT_FOUND;
 346 }
 347
 348 void wxMenu::UpdateAccel(wxMenuItem *item)
 349 {
 350     if ( item->IsSubMenu() )
 351     {
 352         wxMenu *submenu = item->GetSubMenu();
 353         wxMenuItemList::compatibility_iterator node = submenu->GetMenuItems().GetFirst();
 354         while ( node )
 355         {
 356             UpdateAccel(node->GetData());
 357
 358             node = node->GetNext();
 359         }
 360     }
 361     else if ( !item->IsSeparator() )
 362     {
 363         // recurse upwards: we should only modify m_accels of the top level
 364         // menus, not of the submenus as wxMenuBar doesn't look at them
 365         // (alternative and arguable cleaner solution would be to recurse
 366         // downwards in GetAccelCount() and CopyAccels())
 367         if ( GetParent() )
 368         {
 369             GetParent()->UpdateAccel(item);
 370             return;
 371         }
 372
 373         // find the (new) accel for this item
 374         wxAcceleratorEntry *accel = wxAcceleratorEntry::Create(item->GetItemLabel());
 375         if ( accel )
 376             accel->m_command = item->GetId();
 377
 378         // find the old one
 379         int n = FindAccel(item->GetId());
 380         if ( n == wxNOT_FOUND )
 381         {
 382             // no old, add new if any
 383             if ( accel )
 384                 m_accels.Add(accel);
 385             else
 386                 return;     // skipping RebuildAccelTable() below
 387         }
 388         else
 389         {
 390             // replace old with new or just remove the old one if no new
 391             delete m_accels[n];
 392             if ( accel )
 393                 m_accels[n] = accel;
 394             else
 395                 m_accels.RemoveAt(n);
 396         }
 397
 398         if ( IsAttached() )
 399         {
 400             GetMenuBar()->RebuildAccelTable();
 401         }
 402
 403 #if wxUSE_OWNER_DRAWN
 404         ResetMaxAccelWidth();
 405 #endif
 406     }
 407     //else: it is a separator, they can't have accels, nothing to do
 408 }
 409
 410 #endif // wxUSE_ACCEL
 411
 412 namespace
 413 {
 414
 415 // helper of DoInsertOrAppend(): returns the HBITMAP to use in MENUITEMINFO
 416 HBITMAP GetHBitmapForMenu(wxMenuItem *pItem, bool checked = true)
 417 {
 418     // Under versions of Windows older than Vista we can't pass HBITMAP
 419     // directly as hbmpItem for 2 reasons:
 420     //  1. We can't draw it with transparency then (this is not
 421     //     very important now but would be with themed menu bg)
 422     //  2. Worse, Windows inverts the bitmap for the selected
 423     //     item and this looks downright ugly
 424     //
 425     // So we prefer to instead draw it ourselves in MSWOnDrawItem().by using
 426     // HBMMENU_CALLBACK when inserting it
 427     //
 428     // However under Vista using HBMMENU_CALLBACK causes the entire menu to be
 429     // drawn using the classic theme instead of the current one and it does
 430     // handle transparency just fine so do use the real bitmap there
 431 #if wxUSE_IMAGE
 432     if ( wxGetWinVersion() >= wxWinVersion_Vista )
 433     {
 434 #if wxUSE_OWNER_DRAWN
 435         wxBitmap bmp = pItem->GetBitmap(checked);
 436         if ( bmp.IsOk() )
 437         {
 438             // we must use PARGB DIB for the menu bitmaps so ensure that we do
 439             wxImage img(bmp.ConvertToImage());
 440             if ( !img.HasAlpha() )
 441             {
 442                 img.InitAlpha();
 443                 pItem->SetBitmap(img, checked);
 444             }
 445
 446             return GetHbitmapOf(pItem->GetBitmap(checked));
 447         }
 448 #endif // wxUSE_OWNER_DRAWN
 449         //else: bitmap is not set
 450
 451         return NULL;
 452     }
 453 #endif // wxUSE_IMAGE
 454
 455     return HBMMENU_CALLBACK;
 456 }
 457
 458 } // anonymous namespace
 459
 460 bool wxMenu::MSWGetRadioGroupRange(int pos, int *start, int *end) const
 461 {
 462     return m_radioData && m_radioData->GetGroupRange(pos, start, end);
 463 }
 464
 465 // append a new item or submenu to the menu
 466 bool wxMenu::DoInsertOrAppend(wxMenuItem *pItem, size_t pos)
 467 {
 468 #if wxUSE_ACCEL
 469     UpdateAccel(pItem);
 470 #endif // wxUSE_ACCEL
 471
 472     // we should support disabling the item even prior to adding it to the menu
 473     UINT flags = pItem->IsEnabled() ? MF_ENABLED : MF_GRAYED;
 474
 475     // if "Break" has just been called, insert a menu break before this item
 476     // (and don't forget to reset the flag)
 477     if ( m_doBreak ) {
 478         flags |= MF_MENUBREAK;
 479         m_doBreak = false;
 480     }
 481
 482     if ( pItem->IsSeparator() ) {
 483         flags |= MF_SEPARATOR;
 484     }
 485
 486     // id is the numeric id for normal menu items and HMENU for submenus as
 487     // required by ::AppendMenu() API
 488     UINT_PTR id;
 489     wxMenu *submenu = pItem->GetSubMenu();
 490     if ( submenu != NULL ) {
 491         wxASSERT_MSG( submenu->GetHMenu(), wxT("invalid submenu") );
 492
 493         submenu->SetParent(this);
 494
 495         id = (UINT_PTR)submenu->GetHMenu();
 496
 497         flags |= MF_POPUP;
 498     }
 499     else {
 500         id = pItem->GetMSWId();
 501     }
 502
 503
 504     // prepare to insert the item in the menu
 505     wxString itemText = pItem->GetItemLabel();
 506     LPCTSTR pData = NULL;
 507     if ( pos == (size_t)-1 )
 508     {
 509         // append at the end (note that the item is already appended to
 510         // internal data structures)
 511         pos = GetMenuItemCount() - 1;
 512     }
 513
 514     // Update radio groups data if we're inserting a new radio item.
 515     //
 516     // NB: If we supported inserting non-radio items in the middle of existing
 517     //     radio groups to break them into two subgroups, we'd need to update
 518     //     m_radioData in this case too but currently this is not supported.
 519     bool checkInitially = false;
 520     if ( pItem->GetKind() == wxITEM_RADIO )
 521     {
 522         if ( !m_radioData )
 523             m_radioData = new wxMenuRadioItemsData;
 524
 525         if ( m_radioData->UpdateOnInsert(pos) )
 526             checkInitially = true;
 527     }
 528
 529     // adjust position to account for the title of a popup menu, if any
 530     if ( !GetMenuBar() && !m_title.empty() )
 531         pos += 2; // for the title itself and its separator
 532
 533     BOOL ok = false;
 534
 535 #if wxUSE_OWNER_DRAWN
 536     // Under older systems mixing owner-drawn and non-owner-drawn items results
 537     // in inconsistent margins, so we force this one to be owner-drawn if any
 538     // other items already are.
 539     if ( m_ownerDrawn )
 540         pItem->SetOwnerDrawn(true);
 541 #endif // wxUSE_OWNER_DRAWN
 542
 543     // check if we have something more than a simple text item
 544 #if wxUSE_OWNER_DRAWN
 545     if ( pItem->IsOwnerDrawn() )
 546     {
 547 #ifndef __DMC__
 548
 549         if ( !m_ownerDrawn && !pItem->IsSeparator() )
 550         {
 551             // MIIM_BITMAP only works under WinME/2000+ so we always use owner
 552             // drawn item under the previous versions and we also have to use
 553             // them in any case if the item has custom colours or font
 554             static const wxWinVersion winver = wxGetWinVersion();
 555             bool mustUseOwnerDrawn = winver < wxWinVersion_98 ||
 556                                      pItem->GetTextColour().IsOk() ||
 557                                      pItem->GetBackgroundColour().IsOk() ||
 558                                      pItem->GetFont().IsOk();
 559
 560             if ( !mustUseOwnerDrawn )
 561             {
 562                 const wxBitmap& bmpUnchecked = pItem->GetBitmap(false),
 563                                 bmpChecked   = pItem->GetBitmap(true);
 564
 565                 if ( (bmpUnchecked.IsOk() && IsGreaterThanStdSize(bmpUnchecked)) ||
 566                      (bmpChecked.IsOk()   && IsGreaterThanStdSize(bmpChecked)) )
 567                 {
 568                     mustUseOwnerDrawn = true;
 569                 }
 570             }
 571
 572             // use InsertMenuItem() if possible as it's guaranteed to look
 573             // correct while our owner-drawn code is not
 574             if ( !mustUseOwnerDrawn )
 575             {
 576                 WinStruct<MENUITEMINFO> mii;
 577                 mii.fMask = MIIM_STRING | MIIM_DATA;
 578
 579                 // don't set hbmpItem for the checkable items as it would
 580                 // be used for both checked and unchecked state
 581                 if ( pItem->IsCheckable() )
 582                 {
 583                     mii.fMask |= MIIM_CHECKMARKS;
 584                     mii.hbmpChecked = GetHBitmapForMenu(pItem, true);
 585                     mii.hbmpUnchecked = GetHBitmapForMenu(pItem, false);
 586                 }
 587                 else if ( pItem->GetBitmap().IsOk() )
 588                 {
 589                     mii.fMask |= MIIM_BITMAP;
 590                     mii.hbmpItem = GetHBitmapForMenu(pItem);
 591                 }
 592
 593                 mii.cch = itemText.length();
 594                 mii.dwTypeData = wxMSW_CONV_LPTSTR(itemText);
 595
 596                 if ( flags & MF_POPUP )
 597                 {
 598                     mii.fMask |= MIIM_SUBMENU;
 599                     mii.hSubMenu = GetHmenuOf(pItem->GetSubMenu());
 600                 }
 601                 else
 602                 {
 603                     mii.fMask |= MIIM_ID;
 604                     mii.wID = id;
 605                 }
 606
 607                 mii.dwItemData = reinterpret_cast<ULONG_PTR>(pItem);
 608
 609                 ok = ::InsertMenuItem(GetHmenu(), pos, TRUE /* by pos */, &mii);
 610                 if ( !ok )
 611                 {
 612                     wxLogLastError(wxT("InsertMenuItem()"));
 613                 }
 614                 else // InsertMenuItem() ok
 615                 {
 616                     // we need to remove the extra indent which is reserved for
 617                     // the checkboxes by default as it looks ugly unless check
 618                     // boxes are used together with bitmaps and this is not the
 619                     // case in wx API
 620                     WinStruct<MENUINFO> mi;
 621
 622                     // don't call SetMenuInfo() directly, this would prevent
 623                     // the app from starting up under Windows 95/NT 4
 624                     typedef BOOL (WINAPI *SetMenuInfo_t)(HMENU, MENUINFO *);
 625
 626                     wxDynamicLibrary dllUser(wxT("user32"));
 627                     wxDYNLIB_FUNCTION(SetMenuInfo_t, SetMenuInfo, dllUser);
 628                     if ( pfnSetMenuInfo )
 629                     {
 630                         mi.fMask = MIM_STYLE;
 631                         mi.dwStyle = MNS_CHECKORBMP;
 632                         if ( !(*pfnSetMenuInfo)(GetHmenu(), &mi) )
 633                         {
 634                             wxLogLastError(wxT("SetMenuInfo(MNS_NOCHECK)"));
 635                         }
 636                     }
 637
 638                     // tell the item that it's not really owner-drawn but only
 639                     // needs to draw its bitmap, the rest is done by Windows
 640                     pItem->SetOwnerDrawn(false);
 641                 }
 642             }
 643         }
 644 #endif // __DMC__
 645
 646         if ( !ok )
 647         {
 648             // item draws itself, pass pointer to it in data parameter
 649             flags |= MF_OWNERDRAW;
 650             pData = (LPCTSTR)pItem;
 651
 652             bool updateAllMargins = false;
 653
 654             // get size of bitmap always return valid value (0 for invalid bitmap),
 655             // so we don't needed check if bitmap is valid ;)
 656             int uncheckedW = pItem->GetBitmap(false).GetWidth();
 657             int checkedW   = pItem->GetBitmap(true).GetWidth();
 658
 659             if ( m_maxBitmapWidth < uncheckedW )
 660             {
 661                 m_maxBitmapWidth = uncheckedW;
 662                 updateAllMargins = true;
 663             }
 664
 665             if ( m_maxBitmapWidth < checkedW )
 666             {
 667                 m_maxBitmapWidth = checkedW;
 668                 updateAllMargins = true;
 669             }
 670
 671             // make other item ownerdrawn and update margin width for equals alignment
 672             if ( !m_ownerDrawn || updateAllMargins )
 673             {
 674                 // we must use position in SetOwnerDrawnMenuItem because
 675                 // all separators have the same id
 676                 int pos = 0;
 677                 wxMenuItemList::compatibility_iterator node = GetMenuItems().GetFirst();
 678                 while (node)
 679                 {
 680                     wxMenuItem* item = node->GetData();
 681
 682                     if ( !item->IsOwnerDrawn())
 683                     {
 684                         item->SetOwnerDrawn(true);
 685                         SetOwnerDrawnMenuItem(GetHmenu(), pos,
 686                                               reinterpret_cast<ULONG_PTR>(item), TRUE);
 687                     }
 688
 689                     item->SetMarginWidth(m_maxBitmapWidth);
 690
 691                     node = node->GetNext();
 692                     pos++;
 693                 }
 694
 695                 // set menu as ownerdrawn
 696                 m_ownerDrawn = true;
 697
 698                 ResetMaxAccelWidth();
 699             }
 700             // only update our margin for equals alignment to other item
 701             else if ( !updateAllMargins )
 702             {
 703                 pItem->SetMarginWidth(m_maxBitmapWidth);
 704             }
 705         }
 706     }
 707     else
 708 #endif // wxUSE_OWNER_DRAWN
 709     {
 710         // item is just a normal string (passed in data parameter)
 711         flags |= MF_STRING;
 712
 713 #ifdef __WXWINCE__
 714         itemText = wxMenuItem::GetLabelText(itemText);
 715 #endif
 716
 717         pData = itemText.t_str();
 718     }
 719
 720     // item might have already been inserted by InsertMenuItem() above
 721     if ( !ok )
 722     {
 723         if ( !::InsertMenu(GetHmenu(), pos, flags | MF_BYPOSITION, id, pData) )
 724         {
 725             wxLogLastError(wxT("InsertMenu[Item]()"));
 726
 727             return false;
 728         }
 729     }
 730
 731
 732     // Check the item if it should be initially checked.
 733     if ( checkInitially )
 734         pItem->Check(true);
 735
 736     // if we just appended the title, highlight it
 737     if ( id == (UINT_PTR)idMenuTitle )
 738     {
 739         // visually select the menu title
 740         SetDefaultMenuItem(GetHmenu(), id);
 741     }
 742
 743     // if we're already attached to the menubar, we must update it
 744     if ( IsAttached() && GetMenuBar()->IsAttached() )
 745     {
 746         GetMenuBar()->Refresh();
 747     }
 748
 749     return true;
 750 }
 751
 752 wxMenuItem* wxMenu::DoAppend(wxMenuItem *item)
 753 {
 754     return wxMenuBase::DoAppend(item) && DoInsertOrAppend(item) ? item : NULL;
 755 }
 756
 757 wxMenuItem* wxMenu::DoInsert(size_t pos, wxMenuItem *item)
 758 {
 759     if (wxMenuBase::DoInsert(pos, item) && DoInsertOrAppend(item, pos))
 760         return item;
 761     else
 762         return NULL;
 763 }
 764
 765 wxMenuItem *wxMenu::DoRemove(wxMenuItem *item)
 766 {
 767     // we need to find the item's position in the child list
 768     size_t pos;
 769     wxMenuItemList::compatibility_iterator node = GetMenuItems().GetFirst();
 770     for ( pos = 0; node; pos++ )
 771     {
 772         if ( node->GetData() == item )
 773             break;
 774
 775         node = node->GetNext();
 776     }
 777
 778     // DoRemove() (unlike Remove) can only be called for an existing item!
 779     wxCHECK_MSG( node, NULL, wxT("bug in wxMenu::Remove logic") );
 780
 781 #if wxUSE_ACCEL
 782     // remove the corresponding accel from the accel table
 783     int n = FindAccel(item->GetId());
 784     if ( n != wxNOT_FOUND )
 785     {
 786         delete m_accels[n];
 787
 788         m_accels.RemoveAt(n);
 789
 790 #if wxUSE_OWNER_DRAWN
 791         ResetMaxAccelWidth();
 792 #endif
 793     }
 794     //else: this item doesn't have an accel, nothing to do
 795 #endif // wxUSE_ACCEL
 796
 797     // remove the item from the menu
 798     if ( !::RemoveMenu(GetHmenu(), (UINT)pos, MF_BYPOSITION) )
 799     {
 800         wxLogLastError(wxT("RemoveMenu"));
 801     }
 802
 803     if ( IsAttached() && GetMenuBar()->IsAttached() )
 804     {
 805         // otherwise, the change won't be visible
 806         GetMenuBar()->Refresh();
 807     }
 808
 809     // and from internal data structures
 810     return wxMenuBase::DoRemove(item);
 811 }
 812
 813 // ---------------------------------------------------------------------------
 814 // accelerator helpers
 815 // ---------------------------------------------------------------------------
 816
 817 #if wxUSE_ACCEL
 818
 819 // create the wxAcceleratorEntries for our accels and put them into the provided
 820 // array - return the number of accels we have
 821 size_t wxMenu::CopyAccels(wxAcceleratorEntry *accels) const
 822 {
 823     size_t count = GetAccelCount();
 824     for ( size_t n = 0; n < count; n++ )
 825     {
 826         *accels++ = *m_accels[n];
 827     }
 828
 829     return count;
 830 }
 831
 832 wxAcceleratorTable *wxMenu::CreateAccelTable() const
 833 {
 834     const size_t count = m_accels.size();
 835     wxScopedArray<wxAcceleratorEntry> accels(new wxAcceleratorEntry[count]);
 836     CopyAccels(accels.get());
 837
 838     return new wxAcceleratorTable(count, accels.get());
 839 }
 840
 841 #endif // wxUSE_ACCEL
 842
 843 // ---------------------------------------------------------------------------
 844 // ownerdrawn helpers
 845 // ---------------------------------------------------------------------------
 846
 847 #if wxUSE_OWNER_DRAWN
 848
 849 void wxMenu::CalculateMaxAccelWidth()
 850 {
 851     wxASSERT_MSG( m_maxAccelWidth == -1, wxT("it's really needed?") );
 852
 853     wxMenuItemList::compatibility_iterator node = GetMenuItems().GetFirst();
 854     while (node)
 855     {
 856         wxMenuItem* item = node->GetData();
 857
 858         if ( item->IsOwnerDrawn() )
 859         {
 860             int width = item->MeasureAccelWidth();
 861             if (width > m_maxAccelWidth )
 862                 m_maxAccelWidth = width;
 863         }
 864
 865         node = node->GetNext();
 866     }
 867 }
 868
 869 #endif // wxUSE_OWNER_DRAWN
 870
 871 // ---------------------------------------------------------------------------
 872 // set wxMenu title
 873 // ---------------------------------------------------------------------------
 874
 875 void wxMenu::SetTitle(const wxString& label)
 876 {
 877     bool hasNoTitle = m_title.empty();
 878     m_title = label;
 879
 880     HMENU hMenu = GetHmenu();
 881
 882     if ( hasNoTitle )
 883     {
 884         if ( !label.empty() )
 885         {
 886             if ( !::InsertMenu(hMenu, 0u, MF_BYPOSITION | MF_STRING,
 887                                (UINT_PTR)idMenuTitle, m_title.t_str()) ||
 888                  !::InsertMenu(hMenu, 1u, MF_BYPOSITION, (unsigned)-1, NULL) )
 889             {
 890                 wxLogLastError(wxT("InsertMenu"));
 891             }
 892         }
 893     }
 894     else
 895     {
 896         if ( label.empty() )
 897         {
 898             // remove the title and the separator after it
 899             if ( !RemoveMenu(hMenu, 0, MF_BYPOSITION) ||
 900                  !RemoveMenu(hMenu, 0, MF_BYPOSITION) )
 901             {
 902                 wxLogLastError(wxT("RemoveMenu"));
 903             }
 904         }
 905         else
 906         {
 907             // modify the title
 908 #ifdef __WXWINCE__
 909             WinStruct<MENUITEMINFO> info;
 910             info.fMask = MIIM_TYPE;
 911             info.fType = MFT_STRING;
 912             info.cch = m_title.length();
 913             info.dwTypeData = wxMSW_CONV_LPTSTR(m_title);
 914             if ( !SetMenuItemInfo(hMenu, 0, TRUE, & info) )
 915             {
 916                 wxLogLastError(wxT("SetMenuItemInfo"));
 917             }
 918 #else
 919             if ( !ModifyMenu(hMenu, 0u,
 920                              MF_BYPOSITION | MF_STRING,
 921                              (UINT_PTR)idMenuTitle, m_title.t_str()) )
 922             {
 923                 wxLogLastError(wxT("ModifyMenu"));
 924             }
 925 #endif
 926         }
 927     }
 928
 929 #ifdef __WIN32__
 930     // put the title string in bold face
 931     if ( !m_title.empty() )
 932     {
 933         SetDefaultMenuItem(GetHmenu(), (UINT)idMenuTitle);
 934     }
 935 #endif // Win32
 936 }
 937
 938 // ---------------------------------------------------------------------------
 939 // event processing
 940 // ---------------------------------------------------------------------------
 941
 942 bool wxMenu::MSWCommand(WXUINT WXUNUSED(param), WXWORD id_)
 943 {
 944     const int id = (signed short)id_;
 945
 946     // ignore commands from the menu title
 947     if ( id != idMenuTitle )
 948     {
 949         // Default value for uncheckable items.
 950         int checked = -1;
 951
 952         // update the check item when it's clicked
 953         wxMenuItem * const item = FindItem(id);
 954         if ( item && item->IsCheckable() )
 955         {
 956             item->Toggle();
 957
 958             // Get the status of the menu item: note that it has been just changed
 959             // by Toggle() above so here we already get the new state of the item.
 960             //
 961             // Also notice that we must pass unsigned id_ and not sign-extended id
 962             // to ::GetMenuState() as this is what it expects.
 963             UINT menuState = ::GetMenuState(GetHmenu(), id_, MF_BYCOMMAND);
 964             checked = (menuState & MF_CHECKED) != 0;
 965         }
 966
 967         SendEvent(id, checked);
 968     }
 969
 970     return true;
 971 }
 972
 973 // get the menu with given handle (recursively)
 974 #if wxUSE_OWNER_DRAWN
 975 wxMenu* wxMenu::MSWGetMenu(WXHMENU hMenu)
 976 {
 977     // check self
 978     if ( GetHMenu() == hMenu )
 979         return this;
 980
 981     // recursively query submenus
 982     for ( size_t n = 0 ; n < GetMenuItemCount(); ++n )
 983     {
 984         wxMenuItem* item = FindItemByPosition(n);
 985         wxMenu* submenu = item->GetSubMenu();
 986         if ( submenu )
 987         {
 988             submenu = submenu->MSWGetMenu(hMenu);
 989             if (submenu)
 990                 return submenu;
 991         }
 992     }
 993
 994     // unknown hMenu
 995     return NULL;
 996 }
 997 #endif // wxUSE_OWNER_DRAWN
 998
 999 // ---------------------------------------------------------------------------
1000 // Menu Bar
1001 // ---------------------------------------------------------------------------
1002
1003 void wxMenuBar::Init()
1004 {
1005     m_eventHandler = this;
1006     m_hMenu = 0;
1007 #if wxUSE_TOOLBAR && defined(__WXWINCE__)
1008     m_toolBar = NULL;
1009 #endif
1010     // Not using a combined wxToolBar/wxMenuBar? then use
1011     // a commandbar in WinCE .NET just to implement the
1012     // menubar.
1013 #if defined(WINCE_WITH_COMMANDBAR)
1014     m_commandBar = NULL;
1015     m_adornmentsAdded = false;
1016 #endif
1017 }
1018
1019 wxMenuBar::wxMenuBar()
1020 {
1021     Init();
1022 }
1023
1024 wxMenuBar::wxMenuBar( long WXUNUSED(style) )
1025 {
1026     Init();
1027 }
1028
1029 wxMenuBar::wxMenuBar(size_t count, wxMenu *menus[], const wxString titles[], long WXUNUSED(style))
1030 {
1031     Init();
1032
1033     for ( size_t i = 0; i < count; i++ )
1034     {
1035         // We just want to store the menu title in the menu itself, not to
1036         // show it as a dummy item in the menu itself as we do with the popup
1037         // menu titles in overridden wxMenu::SetTitle().
1038         menus[i]->wxMenuBase::SetTitle(titles[i]);
1039         m_menus.Append(menus[i]);
1040
1041         menus[i]->Attach(this);
1042     }
1043 }
1044
1045 wxMenuBar::~wxMenuBar()
1046 {
1047     // In Windows CE (not .NET), the menubar is always associated
1048     // with a toolbar, which destroys the menu implicitly.
1049 #if defined(WINCE_WITHOUT_COMMANDBAR) && defined(__POCKETPC__)
1050     if (GetToolBar())
1051     {
1052         wxToolMenuBar* toolMenuBar = wxDynamicCast(GetToolBar(), wxToolMenuBar);
1053         if (toolMenuBar)
1054             toolMenuBar->SetMenuBar(NULL);
1055     }
1056 #else
1057     // we should free Windows resources only if Windows doesn't do it for us
1058     // which happens if we're attached to a frame
1059     if (m_hMenu && !IsAttached())
1060     {
1061 #if defined(WINCE_WITH_COMMANDBAR)
1062         ::DestroyWindow((HWND) m_commandBar);
1063         m_commandBar = (WXHWND) NULL;
1064 #else
1065         ::DestroyMenu((HMENU)m_hMenu);
1066 #endif
1067         m_hMenu = (WXHMENU)NULL;
1068     }
1069 #endif
1070 }
1071
1072 // ---------------------------------------------------------------------------
1073 // wxMenuBar helpers
1074 // ---------------------------------------------------------------------------
1075
1076 void wxMenuBar::Refresh()
1077 {
1078     if ( IsFrozen() )
1079         return;
1080
1081     wxCHECK_RET( IsAttached(), wxT("can't refresh unattached menubar") );
1082
1083 #if defined(WINCE_WITHOUT_COMMANDBAR)
1084     if (GetToolBar())
1085     {
1086         CommandBar_DrawMenuBar((HWND) GetToolBar()->GetHWND(), 0);
1087     }
1088 #elif defined(WINCE_WITH_COMMANDBAR)
1089     if (m_commandBar)
1090         DrawMenuBar((HWND) m_commandBar);
1091 #else
1092     DrawMenuBar(GetHwndOf(GetFrame()));
1093 #endif
1094 }
1095
1096 WXHMENU wxMenuBar::Create()
1097 {
1098     // Note: this doesn't work at all on Smartphone,
1099     // since you have to use resources.
1100     // We'll have to find another way to add a menu
1101     // by changing/adding menu items to an existing menu.
1102 #if defined(WINCE_WITHOUT_COMMANDBAR)
1103     if ( m_hMenu != 0 )
1104         return m_hMenu;
1105
1106     wxToolMenuBar * const bar = static_cast<wxToolMenuBar *>(GetToolBar());
1107     if ( !bar )
1108         return NULL;
1109
1110     HWND hCommandBar = GetHwndOf(bar);
1111
1112     // notify comctl32.dll about the version of the headers we use before using
1113     // any other TB_XXX messages
1114     SendMessage(hCommandBar, TB_BUTTONSTRUCTSIZE, sizeof(TBBUTTON), 0);
1115
1116     TBBUTTON tbButton;
1117     wxZeroMemory(tbButton);
1118     tbButton.iBitmap = I_IMAGENONE;
1119     tbButton.fsState = TBSTATE_ENABLED;
1120     tbButton.fsStyle = TBSTYLE_DROPDOWN |
1121                        TBSTYLE_NO_DROPDOWN_ARROW |
1122                        TBSTYLE_AUTOSIZE;
1123
1124     for ( unsigned i = 0; i < GetMenuCount(); i++ )
1125     {
1126         HMENU hPopupMenu = (HMENU) GetMenu(i)->GetHMenu();
1127         tbButton.dwData = (DWORD)hPopupMenu;
1128         wxString label = wxStripMenuCodes(GetMenuLabel(i));
1129         tbButton.iString = (int) wxMSW_CONV_LPCTSTR(label);
1130
1131         tbButton.idCommand = NewControlId();
1132         if ( !::SendMessage(hCommandBar, TB_INSERTBUTTON, i, (LPARAM)&tbButton) )
1133         {
1134             wxLogLastError(wxT("TB_INSERTBUTTON"));
1135         }
1136     }
1137
1138     m_hMenu = bar->GetHMenu();
1139     return m_hMenu;
1140 #else // !__WXWINCE__
1141     if ( m_hMenu != 0 )
1142         return m_hMenu;
1143
1144     m_hMenu = (WXHMENU)::CreateMenu();
1145
1146     if ( !m_hMenu )
1147     {
1148         wxLogLastError(wxT("CreateMenu"));
1149     }
1150     else
1151     {
1152         for ( wxMenuList::iterator it = m_menus.begin();
1153               it != m_menus.end();
1154               ++it )
1155         {
1156             if ( !::AppendMenu((HMENU)m_hMenu, MF_POPUP | MF_STRING,
1157                                (UINT_PTR)(*it)->GetHMenu(),
1158                                (*it)->GetTitle().t_str()) )
1159             {
1160                 wxLogLastError(wxT("AppendMenu"));
1161             }
1162         }
1163     }
1164
1165     return m_hMenu;
1166 #endif // __WXWINCE__/!__WXWINCE__
1167 }
1168
1169 int wxMenuBar::MSWPositionForWxMenu(wxMenu *menu, int wxpos)
1170 {
1171     wxASSERT(menu);
1172     wxASSERT(menu->GetHMenu());
1173     wxASSERT(m_hMenu);
1174
1175 #if defined(__WXWINCE__)
1176     int totalMSWItems = GetMenuCount();
1177 #else
1178     int totalMSWItems = GetMenuItemCount((HMENU)m_hMenu);
1179 #endif
1180
1181     int i; // For old C++ compatibility
1182     for(i=wxpos; i<totalMSWItems; i++)
1183     {
1184         if(GetSubMenu((HMENU)m_hMenu,i)==(HMENU)menu->GetHMenu())
1185             return i;
1186     }
1187     for(i=0; i<wxpos; i++)
1188     {
1189         if(GetSubMenu((HMENU)m_hMenu,i)==(HMENU)menu->GetHMenu())
1190             return i;
1191     }
1192     wxFAIL;
1193     return -1;
1194 }
1195
1196 // ---------------------------------------------------------------------------
1197 // wxMenuBar functions to work with the top level submenus
1198 // ---------------------------------------------------------------------------
1199
1200 // NB: we don't support owner drawn top level items for now, if we do these
1201 //     functions would have to be changed to use wxMenuItem as well
1202
1203 void wxMenuBar::EnableTop(size_t pos, bool enable)
1204 {
1205     wxCHECK_RET( IsAttached(), wxT("doesn't work with unattached menubars") );
1206     wxCHECK_RET( pos < GetMenuCount(), wxT("invalid menu index") );
1207
1208     int flag = enable ? MF_ENABLED : MF_GRAYED;
1209
1210     EnableMenuItem((HMENU)m_hMenu, MSWPositionForWxMenu(GetMenu(pos),pos), MF_BYPOSITION | flag);
1211
1212     Refresh();
1213 }
1214
1215 bool wxMenuBar::IsEnabledTop(size_t pos) const
1216 {
1217     wxCHECK_MSG( pos < GetMenuCount(), false, wxS("invalid menu index") );
1218     WinStruct<MENUITEMINFO> mii;
1219     mii.fMask = MIIM_STATE;
1220     if ( !::GetMenuItemInfo(GetHmenu(), pos, TRUE, &mii) )
1221     {
1222         wxLogLastError(wxS("GetMenuItemInfo(menubar)"));
1223     }
1224
1225     return !(mii.fState & MFS_GRAYED);
1226 }
1227
1228 void wxMenuBar::SetMenuLabel(size_t pos, const wxString& label)
1229 {
1230     wxCHECK_RET( pos < GetMenuCount(), wxT("invalid menu index") );
1231
1232     m_menus[pos]->wxMenuBase::SetTitle(label);
1233
1234     if ( !IsAttached() )
1235     {
1236         return;
1237     }
1238     //else: have to modify the existing menu
1239
1240     int mswpos = MSWPositionForWxMenu(GetMenu(pos),pos);
1241
1242     UINT_PTR id;
1243     UINT flagsOld = ::GetMenuState((HMENU)m_hMenu, mswpos, MF_BYPOSITION);
1244     if ( flagsOld == 0xFFFFFFFF )
1245     {
1246         wxLogLastError(wxT("GetMenuState"));
1247
1248         return;
1249     }
1250
1251     if ( flagsOld & MF_POPUP )
1252     {
1253         // HIBYTE contains the number of items in the submenu in this case
1254         flagsOld &= 0xff;
1255         id = (UINT_PTR)::GetSubMenu((HMENU)m_hMenu, mswpos);
1256     }
1257     else
1258     {
1259         id = pos;
1260     }
1261
1262 #ifdef __WXWINCE__
1263     WinStruct<MENUITEMINFO> info;
1264     info.fMask = MIIM_TYPE;
1265     info.fType = MFT_STRING;
1266     info.cch = label.length();
1267     info.dwTypeData = wxMSW_CONV_LPTSTR(label);
1268     if ( !SetMenuItemInfo(GetHmenu(), id, TRUE, &info) )
1269     {
1270         wxLogLastError(wxT("SetMenuItemInfo"));
1271     }
1272
1273 #else
1274     if ( ::ModifyMenu(GetHmenu(), mswpos, MF_BYPOSITION | MF_STRING | flagsOld,
1275                       id, label.t_str()) == (int)0xFFFFFFFF )
1276     {
1277         wxLogLastError(wxT("ModifyMenu"));
1278     }
1279 #endif
1280
1281     Refresh();
1282 }
1283
1284 wxString wxMenuBar::GetMenuLabel(size_t pos) const
1285 {
1286     wxCHECK_MSG( pos < GetMenuCount(), wxEmptyString,
1287                  wxT("invalid menu index in wxMenuBar::GetMenuLabel") );
1288
1289     return m_menus[pos]->GetTitle();
1290 }
1291
1292 // ---------------------------------------------------------------------------
1293 // wxMenuBar construction
1294 // ---------------------------------------------------------------------------
1295
1296 wxMenu *wxMenuBar::Replace(size_t pos, wxMenu *menu, const wxString& title)
1297 {
1298     wxMenu *menuOld = wxMenuBarBase::Replace(pos, menu, title);
1299     if ( !menuOld )
1300         return NULL;
1301
1302     menu->wxMenuBase::SetTitle(title);
1303
1304 #if defined(WINCE_WITHOUT_COMMANDBAR)
1305     if (IsAttached())
1306 #else
1307     if (GetHmenu())
1308 #endif
1309     {
1310         int mswpos = MSWPositionForWxMenu(menuOld,pos);
1311
1312         // can't use ModifyMenu() because it deletes the submenu it replaces
1313         if ( !::RemoveMenu(GetHmenu(), (UINT)mswpos, MF_BYPOSITION) )
1314         {
1315             wxLogLastError(wxT("RemoveMenu"));
1316         }
1317
1318         if ( !::InsertMenu(GetHmenu(), (UINT)mswpos,
1319                            MF_BYPOSITION | MF_POPUP | MF_STRING,
1320                            (UINT_PTR)GetHmenuOf(menu), title.t_str()) )
1321         {
1322             wxLogLastError(wxT("InsertMenu"));
1323         }
1324
1325 #if wxUSE_ACCEL
1326         if ( menuOld->HasAccels() || menu->HasAccels() )
1327         {
1328             // need to rebuild accell table
1329             RebuildAccelTable();
1330         }
1331 #endif // wxUSE_ACCEL
1332
1333         if (IsAttached())
1334             Refresh();
1335     }
1336
1337     return menuOld;
1338 }
1339
1340 bool wxMenuBar::Insert(size_t pos, wxMenu *menu, const wxString& title)
1341 {
1342     // Find out which MSW item before which we'll be inserting before
1343     // wxMenuBarBase::Insert is called and GetMenu(pos) is the new menu.
1344     // If IsAttached() is false this won't be used anyway
1345     bool isAttached =
1346 #if defined(WINCE_WITHOUT_COMMANDBAR)
1347         IsAttached();
1348 #else
1349         (GetHmenu() != 0);
1350 #endif
1351
1352     int mswpos = (!isAttached || (pos == m_menus.GetCount()))
1353         ?   -1 // append the menu
1354         :   MSWPositionForWxMenu(GetMenu(pos),pos);
1355
1356     if ( !wxMenuBarBase::Insert(pos, menu, title) )
1357         return false;
1358
1359     menu->wxMenuBase::SetTitle(title);
1360
1361     if ( isAttached )
1362     {
1363 #if defined(WINCE_WITHOUT_COMMANDBAR)
1364         if (!GetToolBar())
1365             return false;
1366         TBBUTTON tbButton;
1367         memset(&tbButton, 0, sizeof(TBBUTTON));
1368         tbButton.iBitmap = I_IMAGENONE;
1369         tbButton.fsState = TBSTATE_ENABLED;
1370         tbButton.fsStyle = TBSTYLE_DROPDOWN | TBSTYLE_NO_DROPDOWN_ARROW | TBSTYLE_AUTOSIZE;
1371
1372         HMENU hPopupMenu = (HMENU) menu->GetHMenu() ;
1373         tbButton.dwData = (DWORD)hPopupMenu;
1374         wxString label = wxStripMenuCodes(title);
1375         tbButton.iString = (int) wxMSW_CONV_LPCTSTR(label);
1376
1377         tbButton.idCommand = NewControlId();
1378         if (!::SendMessage((HWND) GetToolBar()->GetHWND(), TB_INSERTBUTTON, pos, (LPARAM)&tbButton))
1379         {
1380             wxLogLastError(wxT("TB_INSERTBUTTON"));
1381             return false;
1382         }
1383         wxUnusedVar(mswpos);
1384 #else
1385         if ( !::InsertMenu(GetHmenu(), mswpos,
1386                            MF_BYPOSITION | MF_POPUP | MF_STRING,
1387                            (UINT_PTR)GetHmenuOf(menu), title.t_str()) )
1388         {
1389             wxLogLastError(wxT("InsertMenu"));
1390         }
1391 #endif
1392 #if wxUSE_ACCEL
1393         if ( menu->HasAccels() )
1394         {
1395             // need to rebuild accell table
1396             RebuildAccelTable();
1397         }
1398 #endif // wxUSE_ACCEL
1399
1400         if (IsAttached())
1401             Refresh();
1402     }
1403
1404     return true;
1405 }
1406
1407 bool wxMenuBar::Append(wxMenu *menu, const wxString& title)
1408 {
1409     WXHMENU submenu = menu ? menu->GetHMenu() : 0;
1410     wxCHECK_MSG( submenu, false, wxT("can't append invalid menu to menubar") );
1411
1412     if ( !wxMenuBarBase::Append(menu, title) )
1413         return false;
1414
1415     menu->wxMenuBase::SetTitle(title);
1416
1417 #if defined(WINCE_WITHOUT_COMMANDBAR)
1418     if (IsAttached())
1419 #else
1420     if (GetHmenu())
1421 #endif
1422     {
1423 #if defined(WINCE_WITHOUT_COMMANDBAR)
1424         if (!GetToolBar())
1425             return false;
1426         TBBUTTON tbButton;
1427         memset(&tbButton, 0, sizeof(TBBUTTON));
1428         tbButton.iBitmap = I_IMAGENONE;
1429         tbButton.fsState = TBSTATE_ENABLED;
1430         tbButton.fsStyle = TBSTYLE_DROPDOWN | TBSTYLE_NO_DROPDOWN_ARROW | TBSTYLE_AUTOSIZE;
1431
1432         size_t pos = GetMenuCount();
1433         HMENU hPopupMenu = (HMENU) menu->GetHMenu() ;
1434         tbButton.dwData = (DWORD)hPopupMenu;
1435         wxString label = wxStripMenuCodes(title);
1436         tbButton.iString = (int) wxMSW_CONV_LPCTSTR(label);
1437
1438         tbButton.idCommand = NewControlId();
1439         if (!::SendMessage((HWND) GetToolBar()->GetHWND(), TB_INSERTBUTTON, pos, (LPARAM)&tbButton))
1440         {
1441             wxLogLastError(wxT("TB_INSERTBUTTON"));
1442             return false;
1443         }
1444 #else
1445         if ( !::AppendMenu(GetHmenu(), MF_POPUP | MF_STRING,
1446                            (UINT_PTR)submenu, title.t_str()) )
1447         {
1448             wxLogLastError(wxT("AppendMenu"));
1449         }
1450 #endif
1451
1452 #if wxUSE_ACCEL
1453         if ( menu->HasAccels() )
1454         {
1455             // need to rebuild accelerator table
1456             RebuildAccelTable();
1457         }
1458 #endif // wxUSE_ACCEL
1459
1460         if (IsAttached())
1461             Refresh();
1462     }
1463
1464     return true;
1465 }
1466
1467 wxMenu *wxMenuBar::Remove(size_t pos)
1468 {
1469     wxMenu *menu = wxMenuBarBase::Remove(pos);
1470     if ( !menu )
1471         return NULL;
1472
1473 #if defined(WINCE_WITHOUT_COMMANDBAR)
1474     if (IsAttached())
1475 #else
1476     if (GetHmenu())
1477 #endif
1478     {
1479 #if defined(WINCE_WITHOUT_COMMANDBAR)
1480         if (GetToolBar())
1481         {
1482             if (!::SendMessage((HWND) GetToolBar()->GetHWND(), TB_DELETEBUTTON, (UINT) pos, (LPARAM) 0))
1483             {
1484                 wxLogLastError(wxT("TB_DELETEBUTTON"));
1485             }
1486         }
1487 #else
1488         if ( !::RemoveMenu(GetHmenu(), (UINT)MSWPositionForWxMenu(menu,pos), MF_BYPOSITION) )
1489         {
1490             wxLogLastError(wxT("RemoveMenu"));
1491         }
1492 #endif
1493
1494 #if wxUSE_ACCEL
1495         if ( menu->HasAccels() )
1496         {
1497             // need to rebuild accell table
1498             RebuildAccelTable();
1499         }
1500 #endif // wxUSE_ACCEL
1501
1502         if (IsAttached())
1503             Refresh();
1504     }
1505
1506     return menu;
1507 }
1508
1509 #if wxUSE_ACCEL
1510
1511 void wxMenuBar::RebuildAccelTable()
1512 {
1513     // merge the accelerators of all menus into one accel table
1514     size_t nAccelCount = 0;
1515     size_t i, count = GetMenuCount();
1516     wxMenuList::iterator it;
1517     for ( i = 0, it = m_menus.begin(); i < count; i++, it++ )
1518     {
1519         nAccelCount += (*it)->GetAccelCount();
1520     }
1521
1522     if ( nAccelCount )
1523     {
1524         wxAcceleratorEntry *accelEntries = new wxAcceleratorEntry[nAccelCount];
1525
1526         nAccelCount = 0;
1527         for ( i = 0, it = m_menus.begin(); i < count; i++, it++ )
1528         {
1529             nAccelCount += (*it)->CopyAccels(&accelEntries[nAccelCount]);
1530         }
1531
1532         SetAcceleratorTable(wxAcceleratorTable(nAccelCount, accelEntries));
1533
1534         delete [] accelEntries;
1535     }
1536     else // No (more) accelerators.
1537     {
1538         SetAcceleratorTable(wxAcceleratorTable());
1539     }
1540 }
1541
1542 #endif // wxUSE_ACCEL
1543
1544 void wxMenuBar::Attach(wxFrame *frame)
1545 {
1546     wxMenuBarBase::Attach(frame);
1547
1548 #if defined(WINCE_WITH_COMMANDBAR)
1549     if (!m_hMenu)
1550         this->Create();
1551     if (!m_commandBar)
1552         m_commandBar = (WXHWND) CommandBar_Create(wxGetInstance(), (HWND) frame->GetHWND(), NewControlId());
1553     if (m_commandBar)
1554     {
1555         if (m_hMenu)
1556         {
1557             if (!CommandBar_InsertMenubarEx((HWND) m_commandBar, NULL, (LPTSTR) m_hMenu, 0))
1558             {
1559                 wxLogLastError(wxT("CommandBar_InsertMenubarEx"));
1560             }
1561         }
1562     }
1563 #endif
1564
1565 #if wxUSE_ACCEL
1566     RebuildAccelTable();
1567 #endif // wxUSE_ACCEL
1568 }
1569
1570 #if defined(WINCE_WITH_COMMANDBAR)
1571 bool wxMenuBar::AddAdornments(long style)
1572 {
1573     if (m_adornmentsAdded || !m_commandBar)
1574         return false;
1575
1576     if (style & wxCLOSE_BOX)
1577     {
1578         if (!CommandBar_AddAdornments((HWND) m_commandBar, 0, 0))
1579         {
1580             wxLogLastError(wxT("CommandBar_AddAdornments"));
1581         }
1582         else
1583         {
1584             return true;
1585         }
1586     }
1587     return false;
1588 }
1589 #endif
1590
1591 void wxMenuBar::Detach()
1592 {
1593     wxMenuBarBase::Detach();
1594 }
1595
1596 // get the menu with given handle (recursively)
1597 wxMenu* wxMenuBar::MSWGetMenu(WXHMENU hMenu)
1598 {
1599     wxCHECK_MSG( GetHMenu() != hMenu, NULL,
1600                  wxT("wxMenuBar::MSWGetMenu(): menu handle is wxMenuBar, not wxMenu") );
1601
1602 #if wxUSE_OWNER_DRAWN
1603     // query all menus
1604     for ( size_t n = 0 ; n < GetMenuCount(); ++n )
1605     {
1606         wxMenu* menu = GetMenu(n)->MSWGetMenu(hMenu);
1607         if ( menu )
1608             return menu;
1609     }
1610 #endif
1611
1612     // unknown hMenu
1613     return NULL;
1614 }
1615
1616 #endif // wxUSE_MENUS