src/msw/spinctrl.cpp

   1 /////////////////////////////////////////////////////////////////////////////
   2 // Name:        src/msw/spinctrl.cpp
   3 // Purpose:     wxSpinCtrl class implementation for Win32
   4 // Author:      Vadim Zeitlin
   5 // Modified by:
   6 // Created:     22.07.99
   7 // RCS-ID:      $Id$
   8 // Copyright:   (c) 1999-2005 Vadim Zeitlin
   9 // Licence:     wxWindows licence
  10 /////////////////////////////////////////////////////////////////////////////
  11
  12 // ============================================================================
  13 // declarations
  14 // ============================================================================
  15
  16 // ----------------------------------------------------------------------------
  17 // headers
  18 // ----------------------------------------------------------------------------
  19
  20 // for compilers that support precompilation, includes "wx.h".
  21 #include "wx/wxprec.h"
  22
  23 #ifdef __BORLANDC__
  24     #pragma hdrstop
  25 #endif
  26
  27 #if wxUSE_SPINCTRL
  28
  29 #include "wx/spinctrl.h"
  30
  31 #ifndef WX_PRECOMP
  32     #include "wx/hashmap.h"
  33     #include "wx/msw/wrapcctl.h" // include <commctrl.h> "properly"
  34     #include "wx/event.h"
  35     #include "wx/textctrl.h"
  36     #include "wx/wxcrtvararg.h"
  37 #endif
  38
  39 #include "wx/msw/private.h"
  40
  41 #if wxUSE_TOOLTIPS
  42     #include "wx/tooltip.h"
  43 #endif // wxUSE_TOOLTIPS
  44
  45 #include <limits.h>         // for INT_MIN
  46
  47 // ----------------------------------------------------------------------------
  48 // macros
  49 // ----------------------------------------------------------------------------
  50
  51 BEGIN_EVENT_TABLE(wxSpinCtrl, wxSpinButton)
  52     EVT_CHAR(wxSpinCtrl::OnChar)
  53     EVT_SET_FOCUS(wxSpinCtrl::OnSetFocus)
  54     EVT_KILL_FOCUS(wxSpinCtrl::OnKillFocus)
  55 END_EVENT_TABLE()
  56
  57 #define GetBuddyHwnd()      (HWND)(m_hwndBuddy)
  58
  59 // ----------------------------------------------------------------------------
  60 // constants
  61 // ----------------------------------------------------------------------------
  62
  63 // the margin between the up-down control and its buddy (can be arbitrary,
  64 // choose what you like - or may be decide during run-time depending on the
  65 // font size?)
  66 static const int MARGIN_BETWEEN = 1;
  67
  68
  69 // ---------------------------------------------------------------------------
  70 // global vars
  71 // ---------------------------------------------------------------------------
  72
  73 namespace
  74 {
  75
  76 // Global hash used to find the spin control corresponding to the given buddy
  77 // text control HWND.
  78 WX_DECLARE_HASH_MAP(HWND, wxSpinCtrl *,
  79                     wxPointerHash, wxPointerEqual,
  80                     SpinForTextCtrl);
  81
  82 SpinForTextCtrl gs_spinForTextCtrl;
  83
  84 } // anonymous namespace
  85
  86 // ============================================================================
  87 // implementation
  88 // ============================================================================
  89
  90 // ----------------------------------------------------------------------------
  91 // wnd proc for the buddy text ctrl
  92 // ----------------------------------------------------------------------------
  93
  94 LRESULT APIENTRY _EXPORT wxBuddyTextWndProc(HWND hwnd,
  95                                             UINT message,
  96                                             WPARAM wParam,
  97                                             LPARAM lParam)
  98 {
  99     wxSpinCtrl * const spin = wxSpinCtrl::GetSpinForTextCtrl(hwnd);
 100
 101     // forward some messages (mostly the key and focus ones) to the spin ctrl
 102     switch ( message )
 103     {
 104         case WM_SETFOCUS:
 105             // if the focus comes from the spin control itself, don't set it
 106             // back to it -- we don't want to go into an infinite loop
 107             if ( (WXHWND)wParam == spin->GetHWND() )
 108                 break;
 109             //else: fall through
 110
 111         case WM_KILLFOCUS:
 112         case WM_CHAR:
 113         case WM_DEADCHAR:
 114         case WM_KEYUP:
 115         case WM_KEYDOWN:
 116 #ifdef WM_HELP
 117         // we need to forward WM_HELP too to ensure that the context help
 118         // associated with wxSpinCtrl is shown when the text control part of it
 119         // is clicked with the "?" cursor
 120         case WM_HELP:
 121 #endif
 122             {
 123                 WXLRESULT result;
 124                 if ( spin->MSWHandleMessage(&result, message, wParam, lParam) )
 125                 {
 126                     // Do not let the message be processed by the window proc
 127                     // of the text control if it had been already handled at wx
 128                     // level, this is consistent with what happens for normal,
 129                     // non-composite controls.
 130                     return 0;
 131                 }
 132
 133                 // The control may have been deleted at this point, so check.
 134                 if ( !::IsWindow(hwnd) )
 135                     return 0;
 136             }
 137             break;
 138
 139         case WM_GETDLGCODE:
 140             if ( spin->HasFlag(wxTE_PROCESS_ENTER) )
 141             {
 142                 long dlgCode = ::CallWindowProc
 143                                  (
 144                                     CASTWNDPROC spin->GetBuddyWndProc(),
 145                                     hwnd,
 146                                     message,
 147                                     wParam,
 148                                     lParam
 149                                  );
 150                 dlgCode |= DLGC_WANTMESSAGE;
 151                 return dlgCode;
 152             }
 153             break;
 154     }
 155
 156     return ::CallWindowProc(CASTWNDPROC spin->GetBuddyWndProc(),
 157                             hwnd, message, wParam, lParam);
 158 }
 159
 160 /* static */
 161 wxSpinCtrl *wxSpinCtrl::GetSpinForTextCtrl(WXHWND hwndBuddy)
 162 {
 163     const SpinForTextCtrl::const_iterator
 164         it = gs_spinForTextCtrl.find(hwndBuddy);
 165     if ( it == gs_spinForTextCtrl.end() )
 166         return NULL;
 167
 168     wxSpinCtrl * const spin = it->second;
 169
 170     // sanity check
 171     wxASSERT_MSG( spin->m_hwndBuddy == hwndBuddy,
 172                   wxT("wxSpinCtrl has incorrect buddy HWND!") );
 173
 174     return spin;
 175 }
 176
 177 // process a WM_COMMAND generated by the buddy text control
 178 bool wxSpinCtrl::ProcessTextCommand(WXWORD cmd, WXWORD WXUNUSED(id))
 179 {
 180     if ( (cmd == EN_CHANGE) && (!m_blockEvent ))
 181     {
 182         wxCommandEvent event(wxEVT_TEXT, GetId());
 183         event.SetEventObject(this);
 184         wxString val = wxGetWindowText(m_hwndBuddy);
 185         event.SetString(val);
 186         event.SetInt(GetValue());
 187         return HandleWindowEvent(event);
 188     }
 189
 190     // not processed
 191     return false;
 192 }
 193
 194 void wxSpinCtrl::OnChar(wxKeyEvent& event)
 195 {
 196     switch ( event.GetKeyCode() )
 197     {
 198         case WXK_RETURN:
 199             {
 200                 wxCommandEvent event(wxEVT_TEXT_ENTER, m_windowId);
 201                 InitCommandEvent(event);
 202                 wxString val = wxGetWindowText(m_hwndBuddy);
 203                 event.SetString(val);
 204                 event.SetInt(GetValue());
 205                 if ( HandleWindowEvent(event) )
 206                     return;
 207                 break;
 208             }
 209
 210         case WXK_TAB:
 211             // always produce navigation event - even if we process TAB
 212             // ourselves the fact that we got here means that the user code
 213             // decided to skip processing of this TAB - probably to let it
 214             // do its default job.
 215             {
 216                 wxNavigationKeyEvent eventNav;
 217                 eventNav.SetDirection(!event.ShiftDown());
 218                 eventNav.SetWindowChange(event.ControlDown());
 219                 eventNav.SetEventObject(this);
 220
 221                 if ( GetParent()->HandleWindowEvent(eventNav) )
 222                     return;
 223             }
 224             break;
 225     }
 226
 227     // no, we didn't process it
 228     event.Skip();
 229 }
 230
 231 void wxSpinCtrl::OnKillFocus(wxFocusEvent& event)
 232 {
 233     // ensure that a correct value is shown by the control
 234     NormalizeValue();
 235     event.Skip();
 236 }
 237
 238 void wxSpinCtrl::OnSetFocus(wxFocusEvent& event)
 239 {
 240     // when we get focus, give it to our buddy window as it needs it more than
 241     // we do
 242     ::SetFocus((HWND)m_hwndBuddy);
 243
 244     event.Skip();
 245 }
 246
 247 void wxSpinCtrl::NormalizeValue()
 248 {
 249     const int value = GetValue();
 250     const bool changed = value != m_oldValue;
 251
 252     // notice that we have to call SetValue() even if the value didn't change
 253     // because otherwise we could be left with empty buddy control when value
 254     // is 0, see comment in SetValue()
 255     SetValue(value);
 256
 257     if ( changed )
 258     {
 259         SendSpinUpdate(value);
 260     }
 261 }
 262
 263 // ----------------------------------------------------------------------------
 264 // construction
 265 // ----------------------------------------------------------------------------
 266
 267 void wxSpinCtrl::Init()
 268 {
 269     m_blockEvent = false;
 270     m_hwndBuddy = NULL;
 271     m_wndProcBuddy = NULL;
 272     m_oldValue = INT_MIN;
 273 }
 274
 275 bool wxSpinCtrl::Create(wxWindow *parent,
 276                         wxWindowID id,
 277                         const wxString& value,
 278                         const wxPoint& pos,
 279                         const wxSize& size,
 280                         long style,
 281                         int min, int max, int initial,
 282                         const wxString& name)
 283 {
 284     // before using DoGetBestSize(), have to set style to let the base class
 285     // know whether this is a horizontal or vertical control (we're always
 286     // vertical)
 287     style |= wxSP_VERTICAL;
 288
 289     if ( (style & wxBORDER_MASK) == wxBORDER_DEFAULT )
 290 #ifdef __WXWINCE__
 291         style |= wxBORDER_SIMPLE;
 292 #else
 293         style |= wxBORDER_SUNKEN;
 294 #endif
 295
 296     SetWindowStyle(style);
 297
 298     WXDWORD exStyle = 0;
 299     WXDWORD msStyle = MSWGetStyle(GetWindowStyle(), & exStyle) ;
 300
 301     // Scroll text automatically if there is not enough space to show all of
 302     // it, this is better than not allowing to enter more digits at all.
 303     msStyle |= ES_AUTOHSCROLL;
 304
 305     // propagate text alignment style to text ctrl
 306     if ( style & wxALIGN_RIGHT )
 307         msStyle |= ES_RIGHT;
 308     else if ( style & wxALIGN_CENTER )
 309         msStyle |= ES_CENTER;
 310
 311     // calculate the sizes: the size given is the total size for both controls
 312     // and we need to fit them both in the given width (height is the same)
 313     wxSize sizeText(size), sizeBtn(size);
 314     sizeBtn.x = wxSpinButton::DoGetBestSize().x;
 315     if ( sizeText.x <= 0 )
 316     {
 317         // DEFAULT_ITEM_WIDTH is the default width for the text control
 318         sizeText.x = DEFAULT_ITEM_WIDTH + MARGIN_BETWEEN + sizeBtn.x;
 319     }
 320
 321     sizeText.x -= sizeBtn.x + MARGIN_BETWEEN;
 322     if ( sizeText.x <= 0 )
 323     {
 324         wxLogDebug(wxS("wxSpinCtrl \"%s\": initial width %d is too small, ")
 325                    wxS("at least %d pixels needed."),
 326                    name, size.x, sizeBtn.x + MARGIN_BETWEEN + 1);
 327     }
 328
 329     wxPoint posBtn(pos);
 330     posBtn.x += sizeText.x + MARGIN_BETWEEN;
 331
 332     // we must create the text control before the spin button for the purpose
 333     // of the dialog navigation: if there is a static text just before the spin
 334     // control, activating it by Alt-letter should give focus to the text
 335     // control, not the spin and the dialog navigation code will give focus to
 336     // the next control (at Windows level), not the one after it
 337
 338     // create the text window
 339
 340     m_hwndBuddy = (WXHWND)::CreateWindowEx
 341                     (
 342                      exStyle,                // sunken border
 343                      wxT("EDIT"),             // window class
 344                      NULL,                   // no window title
 345                      msStyle,                // style (will be shown later)
 346                      pos.x, pos.y,           // position
 347                      0, 0,                   // size (will be set later)
 348                      GetHwndOf(parent),      // parent
 349                      (HMENU)-1,              // control id
 350                      wxGetInstance(),        // app instance
 351                      NULL                    // unused client data
 352                     );
 353
 354     if ( !m_hwndBuddy )
 355     {
 356         wxLogLastError(wxT("CreateWindow(buddy text window)"));
 357
 358         return false;
 359     }
 360
 361
 362     // create the spin button
 363     if ( !wxSpinButton::Create(parent, id, posBtn, sizeBtn, style, name) )
 364     {
 365         return false;
 366     }
 367
 368     wxSpinButtonBase::SetRange(min, max);
 369
 370     // subclass the text ctrl to be able to intercept some events
 371     gs_spinForTextCtrl[GetBuddyHwnd()] = this;
 372
 373     m_wndProcBuddy = (WXFARPROC)wxSetWindowProc(GetBuddyHwnd(),
 374                                                 wxBuddyTextWndProc);
 375
 376     // set up fonts and colours  (This is nomally done in MSWCreateControl)
 377     InheritAttributes();
 378     if (!m_hasFont)
 379         SetFont(GetDefaultAttributes().font);
 380
 381     // set the size of the text window - can do it only now, because we
 382     // couldn't call DoGetBestSize() before as font wasn't set
 383     if ( sizeText.y <= 0 )
 384     {
 385         int cx, cy;
 386         wxGetCharSize(GetHWND(), &cx, &cy, GetFont());
 387
 388         sizeText.y = EDIT_HEIGHT_FROM_CHAR_HEIGHT(cy);
 389     }
 390
 391     SetInitialSize(size);
 392
 393     (void)::ShowWindow(GetBuddyHwnd(), SW_SHOW);
 394
 395     // associate the text window with the spin button
 396     (void)::SendMessage(GetHwnd(), UDM_SETBUDDY, (WPARAM)m_hwndBuddy, 0);
 397
 398     // If the initial text value is actually a number, it overrides the
 399     // "initial" argument specified later.
 400     long initialFromText;
 401     if ( value.ToLong(&initialFromText) )
 402         initial = initialFromText;
 403
 404     // Set the range in the native control: notice that we must do it before
 405     // calling SetValue() to use the correct validity checks for the initial
 406     // value.
 407     SetRange(min, max);
 408     SetValue(initial);
 409
 410     // Also set the text part of the control if it was specified independently
 411     // but don't generate an event for this, it would be unexpected.
 412     m_blockEvent = true;
 413     if ( !value.empty() )
 414         SetValue(value);
 415     m_blockEvent = false;
 416
 417     return true;
 418 }
 419
 420 wxSpinCtrl::~wxSpinCtrl()
 421 {
 422     // destroy the buddy window because this pointer which wxBuddyTextWndProc
 423     // uses will not soon be valid any more
 424     ::DestroyWindow( GetBuddyHwnd() );
 425
 426     gs_spinForTextCtrl.erase(GetBuddyHwnd());
 427 }
 428
 429 // ----------------------------------------------------------------------------
 430 // wxSpinCtrl-specific methods
 431 // ----------------------------------------------------------------------------
 432
 433 int wxSpinCtrl::GetBase() const
 434 {
 435     return ::SendMessage(GetHwnd(), UDM_GETBASE, 0, 0);
 436 }
 437
 438 bool wxSpinCtrl::SetBase(int base)
 439 {
 440     if ( !::SendMessage(GetHwnd(), UDM_SETBASE, base, 0) )
 441         return false;
 442
 443     // Whether we need to be able enter "x" or not influences whether we should
 444     // use ES_NUMBER for the buddy control.
 445     UpdateBuddyStyle();
 446
 447     return true;
 448 }
 449
 450 // ----------------------------------------------------------------------------
 451 // wxTextCtrl-like methods
 452 // ----------------------------------------------------------------------------
 453
 454 void wxSpinCtrl::SetValue(const wxString& text)
 455 {
 456     if ( !::SetWindowText(GetBuddyHwnd(), text.c_str()) )
 457     {
 458         wxLogLastError(wxT("SetWindowText(buddy)"));
 459     }
 460 }
 461
 462 void  wxSpinCtrl::SetValue(int val)
 463 {
 464     m_blockEvent = true;
 465
 466     wxSpinButton::SetValue(val);
 467
 468     // Normally setting the value of the spin button is enough as it updates
 469     // its buddy control automatically but in a couple of situations it doesn't
 470     // do it, for whatever reason, do it explicitly then:
 471     const wxString text = wxGetWindowText(m_hwndBuddy);
 472
 473     // First case is when the text control is empty and the value is 0: the
 474     // spin button just leaves it empty in this case, while we want to show 0
 475     // in it.
 476     if ( text.empty() && !val )
 477     {
 478         ::SetWindowText(GetBuddyHwnd(), wxT("0"));
 479     }
 480
 481     // Another one is when we're using hexadecimal base but the user input
 482     // doesn't start with "0x" -- we prefer to show it to avoid ambiguity
 483     // between decimal and hexadecimal.
 484     if ( GetBase() == 16 &&
 485             (text.length() < 3 || text[0] != '0' ||
 486                 (text[1] != 'x' && text[1] != 'X')) )
 487     {
 488         ::SetWindowText(GetBuddyHwnd(),
 489                         wxPrivate::wxSpinCtrlFormatAsHex(val, m_max).t_str());
 490     }
 491
 492     m_oldValue = GetValue();
 493
 494     m_blockEvent = false;
 495 }
 496
 497 int wxSpinCtrl::GetValue() const
 498 {
 499     const wxString val = wxGetWindowText(m_hwndBuddy);
 500
 501     long n;
 502     if ( !val.ToLong(&n, GetBase()) )
 503         n = INT_MIN;
 504
 505     if ( n < m_min )
 506         n = m_min;
 507     if ( n > m_max )
 508         n = m_max;
 509
 510     return n;
 511 }
 512
 513 void wxSpinCtrl::SetSelection(long from, long to)
 514 {
 515     // if from and to are both -1, it means (in wxWidgets) that all text should
 516     // be selected - translate into Windows convention
 517     if ( (from == -1) && (to == -1) )
 518     {
 519         from = 0;
 520     }
 521
 522     ::SendMessage(GetBuddyHwnd(), EM_SETSEL, (WPARAM)from, (LPARAM)to);
 523 }
 524
 525 // ----------------------------------------------------------------------------
 526 // wxSpinButton methods
 527 // ----------------------------------------------------------------------------
 528
 529 void wxSpinCtrl::SetRange(int minVal, int maxVal)
 530 {
 531     // Manually adjust the old value to avoid an event being sent from
 532     // NormalizeValue() called from inside the base class SetRange() as we're
 533     // not supposed to generate any events from here.
 534     if ( m_oldValue < minVal )
 535         m_oldValue = minVal;
 536     else if ( m_oldValue > maxVal )
 537         m_oldValue = maxVal;
 538
 539     wxSpinButton::SetRange(minVal, maxVal);
 540
 541     UpdateBuddyStyle();
 542 }
 543
 544 void wxSpinCtrl::UpdateBuddyStyle()
 545 {
 546     // this control is used for numeric entry so restrict the input to numeric
 547     // keys only -- but only if we don't need to be able to enter "-" in it as
 548     // otherwise this would become impossible and also if we don't use
 549     // hexadecimal as entering "x" of the "0x" prefix wouldn't be allowed
 550     // neither then
 551     const DWORD styleOld = ::GetWindowLong(GetBuddyHwnd(), GWL_STYLE);
 552     DWORD styleNew;
 553     if ( m_min < 0 || GetBase() != 10 )
 554         styleNew = styleOld & ~ES_NUMBER;
 555     else
 556         styleNew = styleOld | ES_NUMBER;
 557
 558     if ( styleNew != styleOld )
 559         ::SetWindowLong(GetBuddyHwnd(), GWL_STYLE, styleNew);
 560 }
 561
 562 // ----------------------------------------------------------------------------
 563 // forward some methods to subcontrols
 564 // ----------------------------------------------------------------------------
 565
 566 bool wxSpinCtrl::SetFont(const wxFont& font)
 567 {
 568     if ( !wxWindowBase::SetFont(font) )
 569     {
 570         // nothing to do
 571         return false;
 572     }
 573
 574     WXHANDLE hFont = GetFont().GetResourceHandle();
 575     (void)::SendMessage(GetBuddyHwnd(), WM_SETFONT, (WPARAM)hFont, TRUE);
 576
 577     return true;
 578 }
 579
 580 bool wxSpinCtrl::Show(bool show)
 581 {
 582     if ( !wxControl::Show(show) )
 583     {
 584         return false;
 585     }
 586
 587     ::ShowWindow(GetBuddyHwnd(), show ? SW_SHOW : SW_HIDE);
 588
 589     return true;
 590 }
 591
 592 bool wxSpinCtrl::Reparent(wxWindowBase *newParent)
 593 {
 594     // Reparenting both the updown control and its buddy does not seem to work:
 595     // they continue to be connected somehow, but visually there is no feedback
 596     // on the buddy edit control. To avoid this problem, we reparent the buddy
 597     // window normally, but we recreate the updown control and reassign its
 598     // buddy.
 599
 600     // Get the position before changing the parent as it would be offset after
 601     // changing it.
 602     const wxRect rect = GetRect();
 603
 604     if ( !wxWindowBase::Reparent(newParent) )
 605         return false;
 606
 607     newParent->GetChildren().DeleteObject(this);
 608
 609     // destroy the old spin button after detaching it from this wxWindow object
 610     // (notice that m_hWnd will be reset by UnsubclassWin() so save it first)
 611     const HWND hwndOld = GetHwnd();
 612     UnsubclassWin();
 613     if ( !::DestroyWindow(hwndOld) )
 614     {
 615         wxLogLastError(wxT("DestroyWindow"));
 616     }
 617
 618     // create and initialize the new one
 619     if ( !wxSpinButton::Create(GetParent(), GetId(),
 620                                rect.GetPosition(), rect.GetSize(),
 621                                GetWindowStyle(), GetName()) )
 622         return false;
 623
 624     // reapply our values to wxSpinButton
 625     wxSpinButton::SetValue(GetValue());
 626     SetRange(m_min, m_max);
 627
 628     // also set the size again with wxSIZE_ALLOW_MINUS_ONE flag: this is
 629     // necessary if our original position used -1 for either x or y
 630     SetSize(rect, wxSIZE_ALLOW_MINUS_ONE);
 631
 632     // associate it with the buddy control again
 633     ::SetParent(GetBuddyHwnd(), GetHwndOf(GetParent()));
 634     (void)::SendMessage(GetHwnd(), UDM_SETBUDDY, (WPARAM)GetBuddyHwnd(), 0);
 635
 636     return true;
 637 }
 638
 639 bool wxSpinCtrl::Enable(bool enable)
 640 {
 641     if ( !wxControl::Enable(enable) )
 642     {
 643         return false;
 644     }
 645
 646     MSWEnableHWND(GetBuddyHwnd(), enable);
 647
 648     return true;
 649 }
 650
 651 void wxSpinCtrl::SetFocus()
 652 {
 653     ::SetFocus(GetBuddyHwnd());
 654 }
 655
 656 #if wxUSE_TOOLTIPS
 657
 658 void wxSpinCtrl::DoSetToolTip(wxToolTip *tip)
 659 {
 660     wxSpinButton::DoSetToolTip(tip);
 661
 662     if ( tip )
 663         tip->AddOtherWindow(m_hwndBuddy);
 664 }
 665
 666 #endif // wxUSE_TOOLTIPS
 667
 668 // ----------------------------------------------------------------------------
 669 // events processing and generation
 670 // ----------------------------------------------------------------------------
 671
 672 void wxSpinCtrl::SendSpinUpdate(int value)
 673 {
 674     wxCommandEvent event(wxEVT_SPINCTRL, GetId());
 675     event.SetEventObject(this);
 676     event.SetInt(value);
 677
 678     (void)HandleWindowEvent(event);
 679
 680     m_oldValue = value;
 681 }
 682
 683 bool wxSpinCtrl::MSWOnScroll(int WXUNUSED(orientation), WXWORD wParam,
 684                              WXWORD WXUNUSED(pos), WXHWND control)
 685 {
 686     wxCHECK_MSG( control, false, wxT("scrolling what?") );
 687
 688     if ( wParam != SB_THUMBPOSITION )
 689     {
 690         // probable SB_ENDSCROLL - we don't react to it
 691         return false;
 692     }
 693
 694     // Notice that we can't use "pos" from WM_VSCROLL as it is 16 bit and we
 695     // might be using 32 bit range.
 696     int new_value = GetValue();
 697     if (m_oldValue != new_value)
 698        SendSpinUpdate( new_value );
 699
 700     return true;
 701 }
 702
 703 bool wxSpinCtrl::MSWOnNotify(int WXUNUSED(idCtrl), WXLPARAM lParam, WXLPARAM *result)
 704 {
 705     NM_UPDOWN *lpnmud = (NM_UPDOWN *)lParam;
 706
 707     if (lpnmud->hdr.hwndFrom != GetHwnd()) // make sure it is the right control
 708         return false;
 709
 710     *result = 0;  // never reject UP and DOWN events
 711
 712     return TRUE;
 713 }
 714
 715
 716 // ----------------------------------------------------------------------------
 717 // size calculations
 718 // ----------------------------------------------------------------------------
 719
 720 wxSize wxSpinCtrl::DoGetBestSize() const
 721 {
 722     return DoGetSizeFromTextSize(DEFAULT_ITEM_WIDTH);
 723 }
 724
 725 wxSize wxSpinCtrl::DoGetSizeFromTextSize(int xlen, int ylen) const
 726 {
 727     wxSize sizeBtn = wxSpinButton::DoGetBestSize();
 728
 729     int y;
 730     wxGetCharSize(GetHWND(), NULL, &y, GetFont());
 731     // JACS: we should always use the height calculated
 732     // from above, because otherwise we'll get a spin control
 733     // that's too big. So never use the height calculated
 734     // from wxSpinButton::DoGetBestSize().
 735
 736     wxSize tsize(xlen + sizeBtn.x + MARGIN_BETWEEN + 3*y/10 + 10,
 737                  EDIT_HEIGHT_FROM_CHAR_HEIGHT(y));
 738
 739     // Check if the user requested a non-standard height.
 740     if ( ylen > 0 )
 741         tsize.IncBy(0, ylen - y);
 742
 743     return tsize;
 744 }
 745
 746 void wxSpinCtrl::DoMoveWindow(int x, int y, int width, int height)
 747 {
 748     int widthBtn = wxSpinButton::DoGetBestSize().x;
 749     int widthText = width - widthBtn - MARGIN_BETWEEN;
 750     if ( widthText < 0 )
 751     {
 752         // This can happen during the initial window layout when it's total
 753         // size is too small to accommodate all the controls and usually is not
 754         // a problem because the window will be relaid out with enough space
 755         // later. Of course, if it isn't and this is our final size, then we
 756         // have a real problem but as we don't know if this is going to be the
 757         // case or not, just hope for the best -- we used to give a debug
 758         // warning here and this was annoying as it could result in dozens of
 759         // perfectly harmless warnings.
 760         widthText = 0;
 761     }
 762
 763     // 1) The buddy window
 764     DoMoveSibling(m_hwndBuddy, x, y, widthText, height);
 765
 766     // 2) The button window
 767     if ( widthText > 0 )
 768         x += widthText + MARGIN_BETWEEN;
 769     wxSpinButton::DoMoveWindow(x, y, widthBtn, height);
 770 }
 771
 772 // get total size of the control
 773 void wxSpinCtrl::DoGetSize(int *x, int *y) const
 774 {
 775     RECT spinrect, textrect, ctrlrect;
 776     GetWindowRect(GetHwnd(), &spinrect);
 777     GetWindowRect(GetBuddyHwnd(), &textrect);
 778     UnionRect(&ctrlrect,&textrect, &spinrect);
 779
 780     if ( x )
 781         *x = ctrlrect.right - ctrlrect.left;
 782     if ( y )
 783         *y = ctrlrect.bottom - ctrlrect.top;
 784 }
 785
 786 void wxSpinCtrl::DoGetClientSize(int *x, int *y) const
 787 {
 788     RECT spinrect = wxGetClientRect(GetHwnd());
 789     RECT textrect = wxGetClientRect(GetBuddyHwnd());
 790     RECT ctrlrect;
 791     UnionRect(&ctrlrect,&textrect, &spinrect);
 792
 793     if ( x )
 794         *x = ctrlrect.right - ctrlrect.left;
 795     if ( y )
 796         *y = ctrlrect.bottom - ctrlrect.top;
 797 }
 798
 799 void wxSpinCtrl::DoGetPosition(int *x, int *y) const
 800 {
 801     // hack: pretend that our HWND is the text control just for a moment
 802     WXHWND hWnd = GetHWND();
 803     wxConstCast(this, wxSpinCtrl)->m_hWnd = m_hwndBuddy;
 804
 805     wxSpinButton::DoGetPosition(x, y);
 806
 807     wxConstCast(this, wxSpinCtrl)->m_hWnd = hWnd;
 808 }
 809
 810 #endif // wxUSE_SPINCTRL