src/msw/spinctrl.cpp

   1 /////////////////////////////////////////////////////////////////////////////
   2 // Name:        src/msw/spinctrl.cpp
   3 // Purpose:     wxSpinCtrl class implementation for Win32
   4 // Author:      Vadim Zeitlin
   5 // Modified by:
   6 // Created:     22.07.99
   7 // RCS-ID:      $Id$
   8 // Copyright:   (c) 1999-2005 Vadim Zeitlin
   9 // Licence:     wxWindows licence
  10 /////////////////////////////////////////////////////////////////////////////
  11
  12 // ============================================================================
  13 // declarations
  14 // ============================================================================
  15
  16 // ----------------------------------------------------------------------------
  17 // headers
  18 // ----------------------------------------------------------------------------
  19
  20 // for compilers that support precompilation, includes "wx.h".
  21 #include "wx/wxprec.h"
  22
  23 #ifdef __BORLANDC__
  24     #pragma hdrstop
  25 #endif
  26
  27 #if wxUSE_SPINCTRL
  28
  29 #include "wx/spinctrl.h"
  30
  31 #ifndef WX_PRECOMP
  32     #include "wx/msw/wrapcctl.h" // include <commctrl.h> "properly"
  33     #include "wx/event.h"
  34     #include "wx/textctrl.h"
  35     #include "wx/wxcrtvararg.h"
  36 #endif
  37
  38 #include "wx/msw/private.h"
  39
  40 #if wxUSE_TOOLTIPS
  41     #include "wx/tooltip.h"
  42 #endif // wxUSE_TOOLTIPS
  43
  44 #include <limits.h>         // for INT_MIN
  45
  46 // ----------------------------------------------------------------------------
  47 // macros
  48 // ----------------------------------------------------------------------------
  49
  50 #if wxUSE_EXTENDED_RTTI
  51 WX_DEFINE_FLAGS( wxSpinCtrlStyle )
  52
  53 wxBEGIN_FLAGS( wxSpinCtrlStyle )
  54     // new style border flags, we put them first to
  55     // use them for streaming out
  56     wxFLAGS_MEMBER(wxBORDER_SIMPLE)
  57     wxFLAGS_MEMBER(wxBORDER_SUNKEN)
  58     wxFLAGS_MEMBER(wxBORDER_DOUBLE)
  59     wxFLAGS_MEMBER(wxBORDER_RAISED)
  60     wxFLAGS_MEMBER(wxBORDER_STATIC)
  61     wxFLAGS_MEMBER(wxBORDER_NONE)
  62
  63     // old style border flags
  64     wxFLAGS_MEMBER(wxSIMPLE_BORDER)
  65     wxFLAGS_MEMBER(wxSUNKEN_BORDER)
  66     wxFLAGS_MEMBER(wxDOUBLE_BORDER)
  67     wxFLAGS_MEMBER(wxRAISED_BORDER)
  68     wxFLAGS_MEMBER(wxSTATIC_BORDER)
  69     wxFLAGS_MEMBER(wxBORDER)
  70
  71     // standard window styles
  72     wxFLAGS_MEMBER(wxTAB_TRAVERSAL)
  73     wxFLAGS_MEMBER(wxCLIP_CHILDREN)
  74     wxFLAGS_MEMBER(wxTRANSPARENT_WINDOW)
  75     wxFLAGS_MEMBER(wxWANTS_CHARS)
  76     wxFLAGS_MEMBER(wxFULL_REPAINT_ON_RESIZE)
  77     wxFLAGS_MEMBER(wxALWAYS_SHOW_SB )
  78     wxFLAGS_MEMBER(wxVSCROLL)
  79     wxFLAGS_MEMBER(wxHSCROLL)
  80
  81     wxFLAGS_MEMBER(wxSP_HORIZONTAL)
  82     wxFLAGS_MEMBER(wxSP_VERTICAL)
  83     wxFLAGS_MEMBER(wxSP_ARROW_KEYS)
  84     wxFLAGS_MEMBER(wxSP_WRAP)
  85
  86 wxEND_FLAGS( wxSpinCtrlStyle )
  87
  88 IMPLEMENT_DYNAMIC_CLASS_XTI(wxSpinCtrl, wxControl,"wx/spinbut.h")
  89
  90 wxBEGIN_PROPERTIES_TABLE(wxSpinCtrl)
  91     wxEVENT_RANGE_PROPERTY( Spin , wxEVT_SCROLL_TOP , wxEVT_SCROLL_CHANGED , wxSpinEvent )
  92     wxEVENT_PROPERTY( Updated , wxEVT_COMMAND_SPINCTRL_UPDATED , wxCommandEvent )
  93     wxEVENT_PROPERTY( TextUpdated , wxEVT_COMMAND_TEXT_UPDATED , wxCommandEvent )
  94     wxEVENT_PROPERTY( TextEnter , wxEVT_COMMAND_TEXT_ENTER , wxCommandEvent )
  95
  96     wxPROPERTY( ValueString , wxString , SetValue , GetValue , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) ;
  97     wxPROPERTY( Value , int , SetValue, GetValue, 0 , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
  98     wxPROPERTY( Min , int , SetMin, GetMin, 0, 0 /*flags*/ , wxT("Helpstring") , wxT("group") )
  99     wxPROPERTY( Max , int , SetMax, GetMax, 0 , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
 100     wxPROPERTY_FLAGS( WindowStyle , wxSpinCtrlStyle , long , SetWindowStyleFlag , GetWindowStyleFlag , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) // style
 101 /*
 102     TODO PROPERTIES
 103         style wxSP_ARROW_KEYS
 104 */
 105 wxEND_PROPERTIES_TABLE()
 106
 107 wxBEGIN_HANDLERS_TABLE(wxSpinCtrl)
 108 wxEND_HANDLERS_TABLE()
 109
 110 wxCONSTRUCTOR_6( wxSpinCtrl , wxWindow* , Parent , wxWindowID , Id , wxString , ValueString , wxPoint , Position , wxSize , Size , long , WindowStyle )
 111 #else
 112 IMPLEMENT_DYNAMIC_CLASS(wxSpinCtrl, wxControl)
 113 #endif
 114
 115 BEGIN_EVENT_TABLE(wxSpinCtrl, wxSpinButton)
 116     EVT_CHAR(wxSpinCtrl::OnChar)
 117     EVT_SET_FOCUS(wxSpinCtrl::OnSetFocus)
 118     EVT_KILL_FOCUS(wxSpinCtrl::OnKillFocus)
 119 END_EVENT_TABLE()
 120
 121 #define GetBuddyHwnd()      (HWND)(m_hwndBuddy)
 122
 123 // ----------------------------------------------------------------------------
 124 // constants
 125 // ----------------------------------------------------------------------------
 126
 127 // the margin between the up-down control and its buddy (can be arbitrary,
 128 // choose what you like - or may be decide during run-time depending on the
 129 // font size?)
 130 static const int MARGIN_BETWEEN = 1;
 131
 132 // ============================================================================
 133 // implementation
 134 // ============================================================================
 135
 136 wxArraySpins wxSpinCtrl::ms_allSpins;
 137
 138 // ----------------------------------------------------------------------------
 139 // wnd proc for the buddy text ctrl
 140 // ----------------------------------------------------------------------------
 141
 142 LRESULT APIENTRY _EXPORT wxBuddyTextWndProc(HWND hwnd,
 143                                             UINT message,
 144                                             WPARAM wParam,
 145                                             LPARAM lParam)
 146 {
 147     wxSpinCtrl *spin = (wxSpinCtrl *)wxGetWindowUserData(hwnd);
 148
 149     // forward some messages (mostly the key and focus ones) to the spin ctrl
 150     switch ( message )
 151     {
 152         case WM_SETFOCUS:
 153             // if the focus comes from the spin control itself, don't set it
 154             // back to it -- we don't want to go into an infinite loop
 155             if ( (WXHWND)wParam == spin->GetHWND() )
 156                 break;
 157             //else: fall through
 158
 159         case WM_KILLFOCUS:
 160         case WM_CHAR:
 161         case WM_DEADCHAR:
 162         case WM_KEYUP:
 163         case WM_KEYDOWN:
 164 #ifdef WM_HELP
 165         // we need to forward WM_HELP too to ensure that the context help
 166         // associated with wxSpinCtrl is shown when the text control part of it
 167         // is clicked with the "?" cursor
 168         case WM_HELP:
 169 #endif
 170             spin->MSWWindowProc(message, wParam, lParam);
 171
 172             // The control may have been deleted at this point, so check.
 173             if ( !::IsWindow(hwnd) || wxGetWindowUserData(hwnd) != spin )
 174                 return 0;
 175             break;
 176
 177         case WM_GETDLGCODE:
 178             if ( spin->HasFlag(wxTE_PROCESS_ENTER) )
 179             {
 180                 long dlgCode = ::CallWindowProc
 181                                  (
 182                                     CASTWNDPROC spin->GetBuddyWndProc(),
 183                                     hwnd,
 184                                     message,
 185                                     wParam,
 186                                     lParam
 187                                  );
 188                 dlgCode |= DLGC_WANTMESSAGE;
 189                 return dlgCode;
 190             }
 191             break;
 192     }
 193
 194     return ::CallWindowProc(CASTWNDPROC spin->GetBuddyWndProc(),
 195                             hwnd, message, wParam, lParam);
 196 }
 197
 198 /* static */
 199 wxSpinCtrl *wxSpinCtrl::GetSpinForTextCtrl(WXHWND hwndBuddy)
 200 {
 201     wxSpinCtrl *spin = (wxSpinCtrl *)wxGetWindowUserData((HWND)hwndBuddy);
 202
 203     int i = ms_allSpins.Index(spin);
 204
 205     if ( i == wxNOT_FOUND )
 206         return NULL;
 207
 208     // sanity check
 209     wxASSERT_MSG( spin->m_hwndBuddy == hwndBuddy,
 210                   _T("wxSpinCtrl has incorrect buddy HWND!") );
 211
 212     return spin;
 213 }
 214
 215 // process a WM_COMMAND generated by the buddy text control
 216 bool wxSpinCtrl::ProcessTextCommand(WXWORD cmd, WXWORD WXUNUSED(id))
 217 {
 218     if ( (cmd == EN_CHANGE) && (!m_blockEvent ))
 219     {
 220         wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, GetId());
 221         event.SetEventObject(this);
 222         wxString val = wxGetWindowText(m_hwndBuddy);
 223         event.SetString(val);
 224         event.SetInt(GetValue());
 225         return HandleWindowEvent(event);
 226     }
 227
 228     // not processed
 229     return false;
 230 }
 231
 232 void wxSpinCtrl::OnChar(wxKeyEvent& event)
 233 {
 234     switch ( event.GetKeyCode() )
 235     {
 236         case WXK_RETURN:
 237             {
 238                 wxCommandEvent event(wxEVT_COMMAND_TEXT_ENTER, m_windowId);
 239                 InitCommandEvent(event);
 240                 wxString val = wxGetWindowText(m_hwndBuddy);
 241                 event.SetString(val);
 242                 event.SetInt(GetValue());
 243                 if ( HandleWindowEvent(event) )
 244                     return;
 245                 break;
 246             }
 247
 248         case WXK_TAB:
 249             // always produce navigation event - even if we process TAB
 250             // ourselves the fact that we got here means that the user code
 251             // decided to skip processing of this TAB - probably to let it
 252             // do its default job.
 253             {
 254                 wxNavigationKeyEvent eventNav;
 255                 eventNav.SetDirection(!event.ShiftDown());
 256                 eventNav.SetWindowChange(event.ControlDown());
 257                 eventNav.SetEventObject(this);
 258
 259                 if ( GetParent()->HandleWindowEvent(eventNav) )
 260                     return;
 261             }
 262             break;
 263     }
 264
 265     // no, we didn't process it
 266     event.Skip();
 267 }
 268
 269 void wxSpinCtrl::OnKillFocus(wxFocusEvent& event)
 270 {
 271     // ensure that a correct value is shown by the control
 272     NormalizeValue();
 273     event.Skip();
 274 }
 275
 276 void wxSpinCtrl::OnSetFocus(wxFocusEvent& event)
 277 {
 278     // when we get focus, give it to our buddy window as it needs it more than
 279     // we do
 280     ::SetFocus((HWND)m_hwndBuddy);
 281
 282     event.Skip();
 283 }
 284
 285 void wxSpinCtrl::NormalizeValue()
 286 {
 287     const int value = GetValue();
 288     const bool changed = value != m_oldValue;
 289
 290     // notice that we have to call SetValue() even if the value didn't change
 291     // because otherwise we could be left with empty buddy control when value
 292     // is 0, see comment in SetValue()
 293     SetValue(value);
 294
 295     if ( changed )
 296     {
 297         SendSpinUpdate(value);
 298     }
 299 }
 300
 301 // ----------------------------------------------------------------------------
 302 // construction
 303 // ----------------------------------------------------------------------------
 304
 305 bool wxSpinCtrl::Create(wxWindow *parent,
 306                         wxWindowID id,
 307                         const wxString& value,
 308                         const wxPoint& pos,
 309                         const wxSize& size,
 310                         long style,
 311                         int min, int max, int initial,
 312                         const wxString& name)
 313 {
 314     m_blockEvent = false;
 315
 316     // this should be in ctor/init function but I don't want to add one to 2.8
 317     // to avoid problems with default ctor which can be inlined in the user
 318     // code and so might not get this fix without recompilation
 319     m_oldValue = INT_MIN;
 320
 321     // before using DoGetBestSize(), have to set style to let the base class
 322     // know whether this is a horizontal or vertical control (we're always
 323     // vertical)
 324     style |= wxSP_VERTICAL;
 325
 326     if ( (style & wxBORDER_MASK) == wxBORDER_DEFAULT )
 327 #ifdef __WXWINCE__
 328         style |= wxBORDER_SIMPLE;
 329 #else
 330         style |= wxBORDER_SUNKEN;
 331 #endif
 332
 333     SetWindowStyle(style);
 334
 335     WXDWORD exStyle = 0;
 336     WXDWORD msStyle = MSWGetStyle(GetWindowStyle(), & exStyle) ;
 337
 338     // this control is used for numeric entry so normally using these flags by
 339     // default shouldn't be a problem, if it is we can always add a style such
 340     // as wxSP_NON_NUMERIC later
 341     msStyle |= ES_RIGHT | ES_NUMBER;
 342
 343     // calculate the sizes: the size given is the total size for both controls
 344     // and we need to fit them both in the given width (height is the same)
 345     wxSize sizeText(size), sizeBtn(size);
 346     sizeBtn.x = wxSpinButton::DoGetBestSize().x;
 347     if ( sizeText.x <= 0 )
 348     {
 349         // DEFAULT_ITEM_WIDTH is the default width for the text control
 350         sizeText.x = DEFAULT_ITEM_WIDTH + MARGIN_BETWEEN + sizeBtn.x;
 351     }
 352
 353     sizeText.x -= sizeBtn.x + MARGIN_BETWEEN;
 354     if ( sizeText.x <= 0 )
 355     {
 356         wxLogDebug(_T("not enough space for wxSpinCtrl!"));
 357     }
 358
 359     wxPoint posBtn(pos);
 360     posBtn.x += sizeText.x + MARGIN_BETWEEN;
 361
 362     // we must create the text control before the spin button for the purpose
 363     // of the dialog navigation: if there is a static text just before the spin
 364     // control, activating it by Alt-letter should give focus to the text
 365     // control, not the spin and the dialog navigation code will give focus to
 366     // the next control (at Windows level), not the one after it
 367
 368     // create the text window
 369
 370     m_hwndBuddy = (WXHWND)::CreateWindowEx
 371                     (
 372                      exStyle,                // sunken border
 373                      _T("EDIT"),             // window class
 374                      NULL,                   // no window title
 375                      msStyle,                // style (will be shown later)
 376                      pos.x, pos.y,           // position
 377                      0, 0,                   // size (will be set later)
 378                      GetHwndOf(parent),      // parent
 379                      (HMENU)-1,              // control id
 380                      wxGetInstance(),        // app instance
 381                      NULL                    // unused client data
 382                     );
 383
 384     if ( !m_hwndBuddy )
 385     {
 386         wxLogLastError(wxT("CreateWindow(buddy text window)"));
 387
 388         return false;
 389     }
 390
 391
 392     // create the spin button
 393     if ( !wxSpinButton::Create(parent, id, posBtn, sizeBtn, style, name) )
 394     {
 395         return false;
 396     }
 397
 398     wxSpinButtonBase::SetRange(min, max);
 399
 400     // subclass the text ctrl to be able to intercept some events
 401     wxSetWindowUserData(GetBuddyHwnd(), this);
 402     m_wndProcBuddy = (WXFARPROC)wxSetWindowProc(GetBuddyHwnd(),
 403                                                 wxBuddyTextWndProc);
 404
 405     // set up fonts and colours  (This is nomally done in MSWCreateControl)
 406     InheritAttributes();
 407     if (!m_hasFont)
 408         SetFont(GetDefaultAttributes().font);
 409
 410     // set the size of the text window - can do it only now, because we
 411     // couldn't call DoGetBestSize() before as font wasn't set
 412     if ( sizeText.y <= 0 )
 413     {
 414         int cx, cy;
 415         wxGetCharSize(GetHWND(), &cx, &cy, GetFont());
 416
 417         sizeText.y = EDIT_HEIGHT_FROM_CHAR_HEIGHT(cy);
 418     }
 419
 420     SetInitialSize(size);
 421
 422     (void)::ShowWindow(GetBuddyHwnd(), SW_SHOW);
 423
 424     // associate the text window with the spin button
 425     (void)::SendMessage(GetHwnd(), UDM_SETBUDDY, (WPARAM)m_hwndBuddy, 0);
 426
 427     SetValue(initial);
 428
 429     // Set the range in the native control
 430     SetRange(min, max);
 431
 432     if ( !value.empty() )
 433     {
 434         SetValue(value);
 435         m_oldValue = (int) wxAtol(value);
 436     }
 437     else
 438     {
 439         SetValue(wxString::Format(wxT("%d"), initial));
 440         m_oldValue = initial;
 441     }
 442
 443     // do it after finishing with m_hwndBuddy creation to avoid generating
 444     // initial wxEVT_COMMAND_TEXT_UPDATED message
 445     ms_allSpins.Add(this);
 446
 447     return true;
 448 }
 449
 450 wxSpinCtrl::~wxSpinCtrl()
 451 {
 452     ms_allSpins.Remove(this);
 453
 454     // This removes spurious memory leak reporting
 455     if (ms_allSpins.GetCount() == 0)
 456         ms_allSpins.Clear();
 457
 458     // destroy the buddy window because this pointer which wxBuddyTextWndProc
 459     // uses will not soon be valid any more
 460     ::DestroyWindow(GetBuddyHwnd());
 461 }
 462
 463 // ----------------------------------------------------------------------------
 464 // wxTextCtrl-like methods
 465 // ----------------------------------------------------------------------------
 466
 467 void wxSpinCtrl::SetValue(const wxString& text)
 468 {
 469     if ( !::SetWindowText(GetBuddyHwnd(), text.c_str()) )
 470     {
 471         wxLogLastError(wxT("SetWindowText(buddy)"));
 472     }
 473 }
 474
 475 void  wxSpinCtrl::SetValue(int val)
 476 {
 477     m_blockEvent = true;
 478
 479     wxSpinButton::SetValue(val);
 480
 481     // normally setting the value of the spin button is enough as it updates
 482     // its buddy control automatically ...
 483     if ( wxGetWindowText(m_hwndBuddy).empty() )
 484     {
 485         // ... but sometimes it doesn't, notably when the value is 0 and the
 486         // text control is currently empty, the spin button seems to be happy
 487         // to leave it like this, while we really want to always show the
 488         // current value in the control, so do it manually
 489         ::SetWindowText(GetBuddyHwnd(),
 490                         wxString::Format(_T("%d"), val).wx_str());
 491     }
 492
 493     m_oldValue = GetValue();
 494
 495     m_blockEvent = false;
 496 }
 497
 498 int wxSpinCtrl::GetValue() const
 499 {
 500     wxString val = wxGetWindowText(m_hwndBuddy);
 501
 502     long n;
 503     if ( (wxSscanf(val, wxT("%ld"), &n) != 1) )
 504         n = INT_MIN;
 505
 506     if ( n < m_min )
 507         n = m_min;
 508     if ( n > m_max )
 509         n = m_max;
 510
 511     return n;
 512 }
 513
 514 void wxSpinCtrl::SetSelection(long from, long to)
 515 {
 516     // if from and to are both -1, it means (in wxWidgets) that all text should
 517     // be selected - translate into Windows convention
 518     if ( (from == -1) && (to == -1) )
 519     {
 520         from = 0;
 521     }
 522
 523     ::SendMessage(GetBuddyHwnd(), EM_SETSEL, (WPARAM)from, (LPARAM)to);
 524 }
 525
 526 // ----------------------------------------------------------------------------
 527 // forward some methods to subcontrols
 528 // ----------------------------------------------------------------------------
 529
 530 bool wxSpinCtrl::SetFont(const wxFont& font)
 531 {
 532     if ( !wxWindowBase::SetFont(font) )
 533     {
 534         // nothing to do
 535         return false;
 536     }
 537
 538     WXHANDLE hFont = GetFont().GetResourceHandle();
 539     (void)::SendMessage(GetBuddyHwnd(), WM_SETFONT, (WPARAM)hFont, TRUE);
 540
 541     return true;
 542 }
 543
 544 bool wxSpinCtrl::Show(bool show)
 545 {
 546     if ( !wxControl::Show(show) )
 547     {
 548         return false;
 549     }
 550
 551     ::ShowWindow(GetBuddyHwnd(), show ? SW_SHOW : SW_HIDE);
 552
 553     return true;
 554 }
 555
 556 bool wxSpinCtrl::Reparent(wxWindowBase *newParent)
 557 {
 558     // Reparenting both the updown control and its buddy does not seem to work:
 559     // they continue to be connected somehow, but visually there is no feedback
 560     // on the buddy edit control. To avoid this problem, we reparent the buddy
 561     // window normally, but we recreate the updown control and reassign its
 562     // buddy.
 563
 564     if ( !wxWindowBase::Reparent(newParent) )
 565         return false;
 566
 567     newParent->GetChildren().DeleteObject(this);
 568
 569     // preserve the old values
 570     const wxSize size = GetSize();
 571     int value = GetValue();
 572     const wxRect btnRect = wxRectFromRECT(wxGetWindowRect(GetHwnd()));
 573
 574     // destroy the old spin button
 575     UnsubclassWin();
 576     if ( !::DestroyWindow(GetHwnd()) )
 577         wxLogLastError(wxT("DestroyWindow"));
 578
 579     // create and initialize the new one
 580     if ( !wxSpinButton::Create(GetParent(), GetId(),
 581                                btnRect.GetPosition(), btnRect.GetSize(),
 582                                GetWindowStyle(), GetName()) )
 583         return false;
 584
 585     SetValue(value);
 586     SetRange(m_min, m_max);
 587     SetInitialSize(size);
 588
 589     // associate it with the buddy control again
 590     ::SetParent(GetBuddyHwnd(), GetHwndOf(GetParent()));
 591     (void)::SendMessage(GetHwnd(), UDM_SETBUDDY, (WPARAM)GetBuddyHwnd(), 0);
 592
 593     return true;
 594 }
 595
 596 bool wxSpinCtrl::Enable(bool enable)
 597 {
 598     if ( !wxControl::Enable(enable) )
 599     {
 600         return false;
 601     }
 602
 603     ::EnableWindow(GetBuddyHwnd(), enable);
 604
 605     return true;
 606 }
 607
 608 void wxSpinCtrl::SetFocus()
 609 {
 610     ::SetFocus(GetBuddyHwnd());
 611 }
 612
 613 #if wxUSE_TOOLTIPS
 614
 615 void wxSpinCtrl::DoSetToolTip(wxToolTip *tip)
 616 {
 617     wxSpinButton::DoSetToolTip(tip);
 618
 619     if ( tip )
 620         tip->Add(m_hwndBuddy);
 621 }
 622
 623 #endif // wxUSE_TOOLTIPS
 624
 625 // ----------------------------------------------------------------------------
 626 // events processing and generation
 627 // ----------------------------------------------------------------------------
 628
 629 void wxSpinCtrl::SendSpinUpdate(int value)
 630 {
 631     wxCommandEvent event(wxEVT_COMMAND_SPINCTRL_UPDATED, GetId());
 632     event.SetEventObject(this);
 633     event.SetInt(value);
 634
 635     (void)HandleWindowEvent(event);
 636
 637     m_oldValue = value;
 638 }
 639
 640 bool wxSpinCtrl::MSWOnScroll(int WXUNUSED(orientation), WXWORD wParam,
 641                                WXWORD pos, WXHWND control)
 642 {
 643     wxCHECK_MSG( control, false, wxT("scrolling what?") );
 644
 645     if ( wParam != SB_THUMBPOSITION )
 646     {
 647         // probable SB_ENDSCROLL - we don't react to it
 648         return false;
 649     }
 650
 651     int new_value = (short) pos;
 652     if (m_oldValue != new_value)
 653        SendSpinUpdate( new_value );
 654
 655     return TRUE;
 656 }
 657
 658 bool wxSpinCtrl::MSWOnNotify(int WXUNUSED(idCtrl), WXLPARAM lParam, WXLPARAM *result)
 659 {
 660     NM_UPDOWN *lpnmud = (NM_UPDOWN *)lParam;
 661
 662     if (lpnmud->hdr.hwndFrom != GetHwnd()) // make sure it is the right control
 663         return false;
 664
 665     *result = 0;  // never reject UP and DOWN events
 666
 667     return TRUE;
 668 }
 669
 670
 671 // ----------------------------------------------------------------------------
 672 // size calculations
 673 // ----------------------------------------------------------------------------
 674
 675 wxSize wxSpinCtrl::DoGetBestSize() const
 676 {
 677     wxSize sizeBtn = wxSpinButton::DoGetBestSize();
 678     sizeBtn.x += DEFAULT_ITEM_WIDTH + MARGIN_BETWEEN;
 679
 680     int y;
 681     wxGetCharSize(GetHWND(), NULL, &y, GetFont());
 682     y = EDIT_HEIGHT_FROM_CHAR_HEIGHT(y);
 683
 684     // JACS: we should always use the height calculated
 685     // from above, because otherwise we'll get a spin control
 686     // that's too big. So never use the height calculated
 687     // from wxSpinButton::DoGetBestSize().
 688
 689     // if ( sizeBtn.y < y )
 690     {
 691         // make the text tall enough
 692         sizeBtn.y = y;
 693     }
 694
 695     return sizeBtn;
 696 }
 697
 698 void wxSpinCtrl::DoMoveWindow(int x, int y, int width, int height)
 699 {
 700     int widthBtn = wxSpinButton::DoGetBestSize().x;
 701     int widthText = width - widthBtn - MARGIN_BETWEEN;
 702     if ( widthText <= 0 )
 703     {
 704         wxLogDebug(_T("not enough space for wxSpinCtrl!"));
 705     }
 706
 707     // 1) The buddy window
 708     DoMoveSibling(m_hwndBuddy, x, y, widthText, height);
 709
 710     // 2) The button window
 711     x += widthText + MARGIN_BETWEEN;
 712     wxSpinButton::DoMoveWindow(x, y, widthBtn, height);
 713 }
 714
 715 // get total size of the control
 716 void wxSpinCtrl::DoGetSize(int *x, int *y) const
 717 {
 718     RECT spinrect, textrect, ctrlrect;
 719     GetWindowRect(GetHwnd(), &spinrect);
 720     GetWindowRect(GetBuddyHwnd(), &textrect);
 721     UnionRect(&ctrlrect,&textrect, &spinrect);
 722
 723     if ( x )
 724         *x = ctrlrect.right - ctrlrect.left;
 725     if ( y )
 726         *y = ctrlrect.bottom - ctrlrect.top;
 727 }
 728
 729 void wxSpinCtrl::DoGetClientSize(int *x, int *y) const
 730 {
 731     RECT spinrect = wxGetClientRect(GetHwnd());
 732     RECT textrect = wxGetClientRect(GetBuddyHwnd());
 733     RECT ctrlrect;
 734     UnionRect(&ctrlrect,&textrect, &spinrect);
 735
 736     if ( x )
 737         *x = ctrlrect.right - ctrlrect.left;
 738     if ( y )
 739         *y = ctrlrect.bottom - ctrlrect.top;
 740 }
 741
 742 void wxSpinCtrl::DoGetPosition(int *x, int *y) const
 743 {
 744     // hack: pretend that our HWND is the text control just for a moment
 745     WXHWND hWnd = GetHWND();
 746     wxConstCast(this, wxSpinCtrl)->m_hWnd = m_hwndBuddy;
 747
 748     wxSpinButton::DoGetPosition(x, y);
 749
 750     wxConstCast(this, wxSpinCtrl)->m_hWnd = hWnd;
 751 }
 752
 753 #endif // wxUSE_SPINCTRL