Ensire that m_value is updated when SetSelection is called
[wxWidgets.git] / src / msw / combobox.cpp
1 /////////////////////////////////////////////////////////////////////////////
2 // Name: msw/combobox.cpp
3 // Purpose: wxComboBox class
4 // Author: Julian Smart
5 // Modified by:
6 // Created: 01/02/97
7 // RCS-ID: $Id$
8 // Copyright: (c) Julian Smart
9 // Licence: wxWindows licence
10 /////////////////////////////////////////////////////////////////////////////
11
12 // ============================================================================
13 // declarations
14 // ============================================================================
15
16 // ----------------------------------------------------------------------------
17 // headers
18 // ----------------------------------------------------------------------------
19
20 #if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
21 #pragma implementation "combobox.h"
22 #endif
23
24 // For compilers that support precompilation, includes "wx.h".
25 #include "wx/wxprec.h"
26
27 #ifdef __BORLANDC__
28 #pragma hdrstop
29 #endif
30
31 #if wxUSE_COMBOBOX
32
33 #ifndef WX_PRECOMP
34 #include "wx/settings.h"
35 #include "wx/log.h"
36 // for wxEVT_COMMAND_TEXT_ENTER
37 #include "wx/textctrl.h"
38 #endif
39
40 #include "wx/combobox.h"
41 #include "wx/brush.h"
42 #include "wx/clipbrd.h"
43 #include "wx/msw/private.h"
44
45 #if wxUSE_TOOLTIPS
46 #if !defined(__GNUWIN32_OLD__) || defined(__CYGWIN10__)
47 #include <commctrl.h>
48 #endif
49 #include "wx/tooltip.h"
50 #endif // wxUSE_TOOLTIPS
51
52 // ----------------------------------------------------------------------------
53 // wxWin macros
54 // ----------------------------------------------------------------------------
55
56 #if wxUSE_EXTENDED_RTTI
57 WX_DEFINE_FLAGS( wxComboBoxStyle )
58
59 wxBEGIN_FLAGS( wxComboBoxStyle )
60 // new style border flags, we put them first to
61 // use them for streaming out
62 wxFLAGS_MEMBER(wxBORDER_SIMPLE)
63 wxFLAGS_MEMBER(wxBORDER_SUNKEN)
64 wxFLAGS_MEMBER(wxBORDER_DOUBLE)
65 wxFLAGS_MEMBER(wxBORDER_RAISED)
66 wxFLAGS_MEMBER(wxBORDER_STATIC)
67 wxFLAGS_MEMBER(wxBORDER_NONE)
68
69 // old style border flags
70 wxFLAGS_MEMBER(wxSIMPLE_BORDER)
71 wxFLAGS_MEMBER(wxSUNKEN_BORDER)
72 wxFLAGS_MEMBER(wxDOUBLE_BORDER)
73 wxFLAGS_MEMBER(wxRAISED_BORDER)
74 wxFLAGS_MEMBER(wxSTATIC_BORDER)
75 wxFLAGS_MEMBER(wxBORDER)
76
77 // standard window styles
78 wxFLAGS_MEMBER(wxTAB_TRAVERSAL)
79 wxFLAGS_MEMBER(wxCLIP_CHILDREN)
80 wxFLAGS_MEMBER(wxTRANSPARENT_WINDOW)
81 wxFLAGS_MEMBER(wxWANTS_CHARS)
82 wxFLAGS_MEMBER(wxFULL_REPAINT_ON_RESIZE)
83 wxFLAGS_MEMBER(wxALWAYS_SHOW_SB )
84 wxFLAGS_MEMBER(wxVSCROLL)
85 wxFLAGS_MEMBER(wxHSCROLL)
86
87 wxFLAGS_MEMBER(wxCB_SIMPLE)
88 wxFLAGS_MEMBER(wxCB_SORT)
89 wxFLAGS_MEMBER(wxCB_READONLY)
90 wxFLAGS_MEMBER(wxCB_DROPDOWN)
91
92 wxEND_FLAGS( wxComboBoxStyle )
93
94 IMPLEMENT_DYNAMIC_CLASS_XTI(wxComboBox, wxControl,"wx/combobox.h")
95
96 wxBEGIN_PROPERTIES_TABLE(wxComboBox)
97 wxEVENT_PROPERTY( Select , wxEVT_COMMAND_COMBOBOX_SELECTED , wxCommandEvent )
98 wxEVENT_PROPERTY( TextEnter , wxEVT_COMMAND_TEXT_ENTER , wxCommandEvent )
99
100 // TODO DELEGATES
101 wxPROPERTY( Font , wxFont , SetFont , GetFont , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
102 wxPROPERTY_COLLECTION( Choices , wxArrayString , wxString , AppendString , GetStrings , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
103 wxPROPERTY( Value ,wxString, SetValue, GetValue, EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
104 wxPROPERTY( Selection ,int, SetSelection, GetSelection, EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group"))
105 wxPROPERTY_FLAGS( WindowStyle , wxComboBoxStyle , long , SetWindowStyleFlag , GetWindowStyleFlag , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) // style
106 wxEND_PROPERTIES_TABLE()
107
108 wxBEGIN_HANDLERS_TABLE(wxComboBox)
109 wxEND_HANDLERS_TABLE()
110
111 wxCONSTRUCTOR_5( wxComboBox , wxWindow* , Parent , wxWindowID , Id , wxString , Value , wxPoint , Position , wxSize , Size )
112 #else
113 IMPLEMENT_DYNAMIC_CLASS(wxComboBox, wxControl)
114 #endif
115
116 // ----------------------------------------------------------------------------
117 // function prototypes
118 // ----------------------------------------------------------------------------
119
120 LRESULT APIENTRY _EXPORT wxComboEditWndProc(HWND hWnd,
121 UINT message,
122 WPARAM wParam,
123 LPARAM lParam);
124
125 // ---------------------------------------------------------------------------
126 // global vars
127 // ---------------------------------------------------------------------------
128
129 // the pointer to standard radio button wnd proc
130 static WNDPROC gs_wndprocEdit = (WNDPROC)NULL;
131
132 // ============================================================================
133 // implementation
134 // ============================================================================
135
136 // ----------------------------------------------------------------------------
137 // wnd proc for subclassed edit control
138 // ----------------------------------------------------------------------------
139
140 LRESULT APIENTRY _EXPORT wxComboEditWndProc(HWND hWnd,
141 UINT message,
142 WPARAM wParam,
143 LPARAM lParam)
144 {
145 HWND hwndCombo = ::GetParent(hWnd);
146 wxWindow *win = wxFindWinFromHandle((WXHWND)hwndCombo);
147
148 switch ( message )
149 {
150 // forward some messages to the combobox to generate the appropriate
151 // wxEvents from them
152 case WM_KEYUP:
153 case WM_KEYDOWN:
154 case WM_CHAR:
155 case WM_SETFOCUS:
156 case WM_KILLFOCUS:
157 {
158 wxComboBox *combo = wxDynamicCast(win, wxComboBox);
159 if ( !combo )
160 {
161 // we can get WM_KILLFOCUS while our parent is already half
162 // destroyed and hence doesn't look like a combobx any
163 // longer, check for it to avoid bogus assert failures
164 if ( !win->IsBeingDeleted() )
165 {
166 wxFAIL_MSG( _T("should have combo as parent") );
167 }
168 }
169 else if ( combo->MSWProcessEditMsg(message, wParam, lParam) )
170 {
171 // handled by parent
172 return 0;
173 }
174 }
175 break;
176
177 case WM_GETDLGCODE:
178 {
179 wxCHECK_MSG( win, 0, _T("should have a parent") );
180
181 if ( win->GetWindowStyle() & wxPROCESS_ENTER )
182 {
183 // need to return a custom dlg code or we'll never get it
184 return DLGC_WANTMESSAGE;
185 }
186 }
187 break;
188
189 // deal with tooltips here
190 #if wxUSE_TOOLTIPS && defined(TTN_NEEDTEXT)
191 case WM_NOTIFY:
192 {
193 wxCHECK_MSG( win, 0, _T("should have a parent") );
194
195 NMHDR* hdr = (NMHDR *)lParam;
196 if ( hdr->code == TTN_NEEDTEXT )
197 {
198 wxToolTip *tooltip = win->GetToolTip();
199 if ( tooltip )
200 {
201 TOOLTIPTEXT *ttt = (TOOLTIPTEXT *)lParam;
202 ttt->lpszText = (wxChar *)tooltip->GetTip().c_str();
203 }
204
205 // processed
206 return 0;
207 }
208 }
209 break;
210 #endif // wxUSE_TOOLTIPS
211 }
212
213 return ::CallWindowProc(CASTWNDPROC gs_wndprocEdit, hWnd, message, wParam, lParam);
214 }
215
216 WXHBRUSH wxComboBox::OnCtlColor(WXHDC pDC,
217 WXHWND WXUNUSED(pWnd),
218 WXUINT WXUNUSED(nCtlColor),
219 WXUINT WXUNUSED(message),
220 WXWPARAM WXUNUSED(wParam),
221 WXLPARAM WXUNUSED(lParam))
222 {
223 HDC hdc = (HDC)pDC;
224 wxColour colBack = GetBackgroundColour();
225
226 if (!IsEnabled())
227 colBack = wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE);
228
229 ::SetBkColor(hdc, wxColourToRGB(colBack));
230 ::SetTextColor(hdc, wxColourToRGB(GetForegroundColour()));
231
232 wxBrush *brush = wxTheBrushList->FindOrCreateBrush(colBack, wxSOLID);
233
234 return (WXHBRUSH)brush->GetResourceHandle();
235 }
236
237 // ----------------------------------------------------------------------------
238 // wxComboBox callbacks
239 // ----------------------------------------------------------------------------
240
241 WXLRESULT wxComboBox::MSWWindowProc(WXUINT nMsg, WXWPARAM wParam, WXLPARAM lParam)
242 {
243 // handle WM_CTLCOLOR messages from our EDIT control to be able to set its
244 // colour correctly (to be the same as our own one)
245 switch ( nMsg )
246 {
247 // we have to handle both: one for the normal case and the other for
248 // wxCB_READONLY
249 case WM_CTLCOLOREDIT:
250 case WM_CTLCOLORSTATIC:
251 WXWORD nCtlColor;
252 WXHDC hdc;
253 WXHWND hwnd;
254 UnpackCtlColor(wParam, lParam, &nCtlColor, &hdc, &hwnd);
255
256 return (WXLRESULT)OnCtlColor(hdc, hwnd, nCtlColor, nMsg, wParam, lParam);
257
258 case CB_SETCURSEL:
259 // Selection was set with SetSelection. Update the value too.
260 if (wParam < 0 || wParam > GetCount())
261 m_value = wxEmptyString;
262 else
263 m_value = GetString(wParam);
264 break;
265
266 }
267
268 return wxChoice::MSWWindowProc(nMsg, wParam, lParam);
269 }
270
271 bool wxComboBox::MSWProcessEditMsg(WXUINT msg, WXWPARAM wParam, WXLPARAM lParam)
272 {
273 switch ( msg )
274 {
275 case WM_CHAR:
276 // for compatibility with wxTextCtrl, generate a special message
277 // when Enter is pressed
278 if ( wParam == VK_RETURN )
279 {
280 wxCommandEvent event(wxEVT_COMMAND_TEXT_ENTER, m_windowId);
281 InitCommandEvent(event);
282 event.SetString(GetValue());
283 event.SetInt(GetSelection());
284 ProcessCommand(event);
285 }
286
287 return HandleChar(wParam, lParam, true /* isASCII */);
288
289 case WM_KEYDOWN:
290 return HandleKeyDown(wParam, lParam);
291
292 case WM_KEYUP:
293 return HandleKeyUp(wParam, lParam);
294
295 case WM_SETFOCUS:
296 return HandleSetFocus((WXHWND)wParam);
297
298 case WM_KILLFOCUS:
299 return HandleKillFocus((WXHWND)wParam);
300 }
301
302 return false;
303 }
304
305 bool wxComboBox::MSWCommand(WXUINT param, WXWORD WXUNUSED(id))
306 {
307 wxString value;
308 int sel = -1;
309 switch ( param )
310 {
311 case CBN_SELCHANGE:
312 sel = GetSelection();
313
314 // somehow we get 2 CBN_SELCHANGE events with the same index when
315 // the user selects an item in the combobox -- ignore duplicates
316 if ( sel > -1 && sel != m_selectionOld )
317 {
318 m_selectionOld = sel;
319
320 // GetValue() would still return the old value from here but
321 // according to the docs we should return the new value if the
322 // user calls it in his event handler, so update internal
323 // m_value
324 m_value = GetString(sel);
325
326 wxCommandEvent event(wxEVT_COMMAND_COMBOBOX_SELECTED, GetId());
327 event.SetInt(sel);
328 event.SetEventObject(this);
329 event.SetString(m_value);
330 ProcessCommand(event);
331 }
332 else // no valid selection
333 {
334 m_selectionOld = sel;
335
336 // hence no EVT_TEXT neither
337 break;
338 }
339
340 // fall through: for compability with wxGTK, also send the text
341 // update event when the selection changes (this also seems more
342 // logical as the text does change)
343
344 case CBN_EDITCHANGE:
345 {
346 wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, GetId());
347
348 // if sel != -1, value was initialized above (and we can't use
349 // GetValue() here as it would return the old selection and we
350 // want the new one)
351 if ( sel == -1 )
352 {
353 m_value = wxGetWindowText(GetHwnd());
354 }
355 else // we're synthesizing text updated event from sel change
356 {
357 // We need to retrieve the current selection because the
358 // user may have changed it in the previous handler (for
359 // CBN_SELCHANGE above).
360 sel = GetSelection();
361 if ( sel > -1 )
362 {
363 m_value = GetString(sel);
364 }
365 }
366
367 event.SetString(m_value);
368 event.SetEventObject(this);
369 ProcessCommand(event);
370 }
371 break;
372 }
373
374 // there is no return value for the CBN_ notifications, so always return
375 // false from here to pass the message to DefWindowProc()
376 return false;
377 }
378
379 WXHWND wxComboBox::GetEditHWND() const
380 {
381 // this function should not be called for wxCB_READONLY controls, it is
382 // the callers responsability to check this
383 wxASSERT_MSG( !(GetWindowStyle() & wxCB_READONLY),
384 _T("read-only combobox doesn't have any edit control") );
385
386 POINT pt;
387 pt.x = pt.y = 4;
388 HWND hwndEdit = ::ChildWindowFromPoint(GetHwnd(), pt);
389 if ( !hwndEdit || hwndEdit == GetHwnd() )
390 {
391 wxFAIL_MSG(_T("not read only combobox without edit control?"));
392 }
393
394 return (WXHWND)hwndEdit;
395 }
396
397 // ----------------------------------------------------------------------------
398 // wxComboBox creation
399 // ----------------------------------------------------------------------------
400
401 bool wxComboBox::Create(wxWindow *parent, wxWindowID id,
402 const wxString& value,
403 const wxPoint& pos,
404 const wxSize& size,
405 int n, const wxString choices[],
406 long style,
407 const wxValidator& validator,
408 const wxString& name)
409 {
410 // pretend that wxComboBox is hidden while it is positioned and resized and
411 // show it only right before leaving this method because otherwise there is
412 // some noticeable flicker while the control rearranges itself
413 m_isShown = false;
414
415 if ( !CreateAndInit(parent, id, pos, size, n, choices, style,
416 validator, name) )
417 return false;
418
419 // we shouldn't call SetValue() for an empty string because this would
420 // (correctly) result in an assert with a read only combobox and is useless
421 // for the other ones anyhow
422 if ( !value.empty() )
423 SetValue(value);
424
425 // a (not read only) combobox is, in fact, 2 controls: the combobox itself
426 // and an edit control inside it and if we want to catch events from this
427 // edit control, we must subclass it as well
428 if ( !(style & wxCB_READONLY) )
429 {
430 gs_wndprocEdit = wxSetWindowProc((HWND)GetEditHWND(),
431 wxComboEditWndProc);
432 }
433
434 // and finally, show the control
435 Show(true);
436
437 return true;
438 }
439
440 bool wxComboBox::Create(wxWindow *parent, wxWindowID id,
441 const wxString& value,
442 const wxPoint& pos,
443 const wxSize& size,
444 const wxArrayString& choices,
445 long style,
446 const wxValidator& validator,
447 const wxString& name)
448 {
449 wxCArrayString chs(choices);
450 return Create(parent, id, value, pos, size, chs.GetCount(),
451 chs.GetStrings(), style, validator, name);
452 }
453
454 WXDWORD wxComboBox::MSWGetStyle(long style, WXDWORD *exstyle) const
455 {
456 // we never have an external border
457 WXDWORD msStyle = wxChoice::MSWGetStyle
458 (
459 (style & ~wxBORDER_MASK) | wxBORDER_NONE, exstyle
460 );
461
462 // remove the style always added by wxChoice
463 msStyle &= ~CBS_DROPDOWNLIST;
464
465 if ( style & wxCB_READONLY )
466 msStyle |= CBS_DROPDOWNLIST;
467 #ifndef __WXWINCE__
468 else if ( style & wxCB_SIMPLE )
469 msStyle |= CBS_SIMPLE; // A list (shown always) and edit control
470 #endif
471 else
472 msStyle |= CBS_DROPDOWN;
473
474 // there is no reason to not always use CBS_AUTOHSCROLL, so do use it
475 msStyle |= CBS_AUTOHSCROLL;
476
477 // NB: we used to also add CBS_NOINTEGRALHEIGHT here but why?
478
479 return msStyle;
480 }
481
482 // ----------------------------------------------------------------------------
483 // wxComboBox text control-like methods
484 // ----------------------------------------------------------------------------
485
486 void wxComboBox::SetValue(const wxString& value)
487 {
488 if ( HasFlag(wxCB_READONLY) )
489 SetStringSelection(value);
490 else
491 SetWindowText(GetHwnd(), value.c_str());
492
493 m_value = value;
494 m_selectionOld = GetSelection();
495 }
496
497 // Clipboard operations
498 void wxComboBox::Copy()
499 {
500 SendMessage(GetHwnd(), WM_COPY, 0, 0L);
501 }
502
503 void wxComboBox::Cut()
504 {
505 SendMessage(GetHwnd(), WM_CUT, 0, 0L);
506 }
507
508 void wxComboBox::Paste()
509 {
510 SendMessage(GetHwnd(), WM_PASTE, 0, 0L);
511 }
512
513 void wxComboBox::SetEditable(bool WXUNUSED(editable))
514 {
515 // Can't implement in MSW?
516 // HWND hWnd = GetHwnd();
517 // SendMessage(hWnd, EM_SETREADONLY, (WPARAM)!editable, (LPARAM)0L);
518 }
519
520 void wxComboBox::SetInsertionPoint(long pos)
521 {
522 if ( GetWindowStyle() & wxCB_READONLY )
523 return;
524
525 #ifdef __WIN32__
526 HWND hWnd = GetHwnd();
527 ::SendMessage(hWnd, CB_SETEDITSEL, 0, MAKELPARAM(pos, pos));
528 HWND hEditWnd = (HWND) GetEditHWND() ;
529 if ( hEditWnd )
530 {
531 // Scroll insertion point into view
532 SendMessage(hEditWnd, EM_SCROLLCARET, (WPARAM)0, (LPARAM)0);
533 // Why is this necessary? (Copied from wxTextCtrl::SetInsertionPoint)
534 SendMessage(hEditWnd, EM_REPLACESEL, 0, (LPARAM) wxEmptyString);
535 }
536 #endif // __WIN32__
537 }
538
539 void wxComboBox::SetInsertionPointEnd()
540 {
541 // setting insertion point doesn't make sense for read only comboboxes
542 if ( !(GetWindowStyle() & wxCB_READONLY) )
543 {
544 long pos = GetLastPosition();
545 SetInsertionPoint(pos);
546 }
547 }
548
549 long wxComboBox::GetInsertionPoint() const
550 {
551 #ifdef __WIN32__
552 DWORD Pos=(DWORD)SendMessage(GetHwnd(), CB_GETEDITSEL, 0, 0L);
553 return Pos&0xFFFF;
554 #else
555 return 0;
556 #endif
557 }
558
559 long wxComboBox::GetLastPosition() const
560 {
561 HWND hEditWnd = (HWND) GetEditHWND();
562
563 // Get number of characters in the last (only) line. We'll add this to the character
564 // index for the last line, 1st position.
565 int lineLength = (int)SendMessage(hEditWnd, EM_LINELENGTH, (WPARAM) 0, (LPARAM)0L);
566
567 return (long)(lineLength);
568 }
569
570 void wxComboBox::Replace(long from, long to, const wxString& value)
571 {
572 #if wxUSE_CLIPBOARD
573 Remove(from, to);
574
575 // Now replace with 'value', by pasting.
576 wxSetClipboardData(wxDF_TEXT, (wxObject *)(const wxChar *)value, 0, 0);
577
578 // Paste into edit control
579 SendMessage(GetHwnd(), WM_PASTE, (WPARAM)0, (LPARAM)0L);
580 #endif
581 }
582
583 void wxComboBox::Remove(long from, long to)
584 {
585 // Set selection and remove it
586 SetSelection(from, to);
587 SendMessage(GetHwnd(), WM_CUT, (WPARAM)0, (LPARAM)0);
588 }
589
590 void wxComboBox::SetSelection(long from, long to)
591 {
592 HWND hWnd = GetHwnd();
593 long fromChar = from;
594 long toChar = to;
595 // if from and to are both -1, it means
596 // (in wxWidgets) that all text should be selected.
597 // This translates into Windows convention
598 if ((from == -1) && (to == -1))
599 {
600 fromChar = 0;
601 toChar = -1;
602 }
603
604 if ( SendMessage(hWnd, CB_SETEDITSEL, (WPARAM)0, (LPARAM)MAKELONG(fromChar, toChar)) == CB_ERR )
605 {
606 wxLogDebug(_T("CB_SETEDITSEL failed"));
607 }
608 }
609
610 #endif // wxUSE_COMBOBOX
611