src/msw/menu.cpp

   1 /////////////////////////////////////////////////////////////////////////////
   2 // Name:        src/msw/menu.cpp
   3 // Purpose:     wxMenu, wxMenuBar, wxMenuItem
   4 // Author:      Julian Smart
   5 // Modified by: Vadim Zeitlin
   6 // Created:     04/01/98
   7 // RCS-ID:      $Id$
   8 // Copyright:   (c) Julian Smart
   9 // Licence:     wxWindows licence
  10 /////////////////////////////////////////////////////////////////////////////
  11
  12 // ===========================================================================
  13 // declarations
  14 // ===========================================================================
  15
  16 // ---------------------------------------------------------------------------
  17 // headers
  18 // ---------------------------------------------------------------------------
  19
  20 // For compilers that support precompilation, includes "wx.h".
  21 #include "wx/wxprec.h"
  22
  23 #ifdef __BORLANDC__
  24     #pragma hdrstop
  25 #endif
  26
  27 #if wxUSE_MENUS
  28
  29 #include "wx/menu.h"
  30
  31 #ifndef WX_PRECOMP
  32     #include "wx/frame.h"
  33     #include "wx/utils.h"
  34     #include "wx/intl.h"
  35     #include "wx/log.h"
  36     #include "wx/image.h"
  37 #endif
  38
  39 #if wxUSE_OWNER_DRAWN
  40     #include "wx/ownerdrw.h"
  41 #endif
  42
  43 #include "wx/scopedarray.h"
  44 #include "wx/vector.h"
  45
  46 #include "wx/msw/private.h"
  47 #include "wx/msw/wrapcctl.h" // include <commctrl.h> "properly"
  48
  49 #ifdef __WXWINCE__
  50 #include <windows.h>
  51 #include <windowsx.h>
  52 #include <tchar.h>
  53 #include <ole2.h>
  54 #include <shellapi.h>
  55 #if (_WIN32_WCE < 400) && !defined(__HANDHELDPC__)
  56 #include <aygshell.h>
  57 #endif
  58
  59 #include "wx/msw/wince/missing.h"
  60
  61 #endif
  62
  63 // other standard headers
  64 #include <string.h>
  65
  66 #if wxUSE_OWNER_DRAWN
  67     #include "wx/dynlib.h"
  68 #endif
  69
  70 #ifndef MNS_CHECKORBMP
  71     #define MNS_CHECKORBMP 0x04000000
  72 #endif
  73 #ifndef MIM_STYLE
  74     #define MIM_STYLE 0x00000010
  75 #endif
  76
  77 // ----------------------------------------------------------------------------
  78 // global variables
  79 // ----------------------------------------------------------------------------
  80
  81 // ----------------------------------------------------------------------------
  82 // constants
  83 // ----------------------------------------------------------------------------
  84
  85 // the (popup) menu title has this special id
  86 static const int idMenuTitle = wxID_NONE;
  87
  88 // ----------------------------------------------------------------------------
  89 // private helper classes and functions
  90 // ----------------------------------------------------------------------------
  91
  92 // Contains the data about the radio items groups in the given menu.
  93 class wxMenuRadioItemsData
  94 {
  95 public:
  96     wxMenuRadioItemsData() { }
  97
  98     // Default copy ctor, assignment operator and dtor are all ok.
  99
 100     // Find the start and end of the group containing the given position or
 101     // return false if it's not inside any range.
 102     bool GetGroupRange(int pos, int *start, int *end) const
 103     {
 104         // We use a simple linear search here because there are not that many
 105         // items in a menu and hence even fewer radio items ranges anyhow, so
 106         // normally there is no need to do anything fancy (like keeping the
 107         // array sorted and using binary search).
 108         for ( Ranges::const_iterator it = m_ranges.begin();
 109               it != m_ranges.end();
 110               ++it )
 111         {
 112             const Range& r = *it;
 113
 114             if ( r.start <= pos && pos <= r.end )
 115             {
 116                 if ( start )
 117                     *start = r.start;
 118                 if ( end )
 119                     *end = r.end;
 120
 121                 return true;
 122             }
 123         }
 124
 125         return false;
 126     }
 127
 128     // Take into account the new radio item about to be added at the given
 129     // position.
 130     //
 131     // Returns true if this item starts a new radio group, false if it extends
 132     // an existing one.
 133     bool UpdateOnInsert(int pos)
 134     {
 135         bool inExistingGroup = false;
 136
 137         for ( Ranges::iterator it = m_ranges.begin();
 138               it != m_ranges.end();
 139               ++it )
 140         {
 141             Range& r = *it;
 142
 143             if ( pos < r.start )
 144             {
 145                 // Item is inserted before this range, update its indices.
 146                 r.start++;
 147                 r.end++;
 148             }
 149             else if ( pos <= r.end + 1 )
 150             {
 151                 // Item is inserted in the middle of this range or immediately
 152                 // after it in which case it extends this range so make it span
 153                 // one more item in any case.
 154                 r.end++;
 155
 156                 inExistingGroup = true;
 157             }
 158             //else: Item is inserted after this range, nothing to do for it.
 159         }
 160
 161         if ( inExistingGroup )
 162             return false;
 163
 164         // Make a new range for the group this item will belong to.
 165         Range r;
 166         r.start = pos;
 167         r.end = pos;
 168         m_ranges.push_back(r);
 169
 170         return true;
 171     }
 172
 173 private:
 174     // Contains the inclusive positions of the range start and end.
 175     struct Range
 176     {
 177         int start;
 178         int end;
 179     };
 180
 181     typedef wxVector<Range> Ranges;
 182     Ranges m_ranges;
 183 };
 184
 185 namespace
 186 {
 187
 188 // make the given menu item default
 189 void SetDefaultMenuItem(HMENU WXUNUSED_IN_WINCE(hmenu),
 190                         UINT WXUNUSED_IN_WINCE(id))
 191 {
 192 #ifndef __WXWINCE__
 193     MENUITEMINFO mii;
 194     wxZeroMemory(mii);
 195     mii.cbSize = sizeof(MENUITEMINFO);
 196     mii.fMask = MIIM_STATE;
 197     mii.fState = MFS_DEFAULT;
 198
 199     if ( !::SetMenuItemInfo(hmenu, id, FALSE, &mii) )
 200     {
 201         wxLogLastError(wxT("SetMenuItemInfo"));
 202     }
 203 #endif // !__WXWINCE__
 204 }
 205
 206 // make the given menu item owner-drawn
 207 void SetOwnerDrawnMenuItem(HMENU WXUNUSED_IN_WINCE(hmenu),
 208                            UINT WXUNUSED_IN_WINCE(id),
 209                            ULONG_PTR WXUNUSED_IN_WINCE(data),
 210                            BOOL WXUNUSED_IN_WINCE(byPositon = FALSE))
 211 {
 212 #ifndef __WXWINCE__
 213     MENUITEMINFO mii;
 214     wxZeroMemory(mii);
 215     mii.cbSize = sizeof(MENUITEMINFO);
 216     mii.fMask = MIIM_FTYPE | MIIM_DATA;
 217     mii.fType = MFT_OWNERDRAW;
 218     mii.dwItemData = data;
 219
 220     if ( reinterpret_cast<wxMenuItem*>(data)->IsSeparator() )
 221         mii.fType |= MFT_SEPARATOR;
 222
 223     if ( !::SetMenuItemInfo(hmenu, id, byPositon, &mii) )
 224     {
 225         wxLogLastError(wxT("SetMenuItemInfo"));
 226     }
 227 #endif // !__WXWINCE__
 228 }
 229
 230 #ifdef __WXWINCE__
 231 UINT GetMenuState(HMENU hMenu, UINT id, UINT flags)
 232 {
 233     MENUITEMINFO info;
 234     wxZeroMemory(info);
 235     info.cbSize = sizeof(info);
 236     info.fMask = MIIM_STATE;
 237     // MF_BYCOMMAND is zero so test MF_BYPOSITION
 238     if ( !::GetMenuItemInfo(hMenu, id, flags & MF_BYPOSITION ? TRUE : FALSE , & info) )
 239     {
 240         wxLogLastError(wxT("GetMenuItemInfo"));
 241     }
 242     return info.fState;
 243 }
 244 #endif // __WXWINCE__
 245
 246 inline bool IsGreaterThanStdSize(const wxBitmap& bmp)
 247 {
 248     return bmp.GetWidth() > ::GetSystemMetrics(SM_CXMENUCHECK) ||
 249             bmp.GetHeight() > ::GetSystemMetrics(SM_CYMENUCHECK);
 250 }
 251
 252 } // anonymous namespace
 253
 254 // ============================================================================
 255 // implementation
 256 // ============================================================================
 257
 258 // ---------------------------------------------------------------------------
 259 // wxMenu construction, adding and removing menu items
 260 // ---------------------------------------------------------------------------
 261
 262 // Construct a menu with optional title (then use append)
 263 void wxMenu::InitNoCreate()
 264 {
 265     m_radioData = NULL;
 266     m_doBreak = false;
 267
 268 #if wxUSE_OWNER_DRAWN
 269     m_ownerDrawn = false;
 270     m_maxBitmapWidth = 0;
 271     m_maxAccelWidth = -1;
 272 #endif // wxUSE_OWNER_DRAWN
 273 }
 274
 275 void wxMenu::Init()
 276 {
 277     InitNoCreate();
 278
 279     // create the menu
 280     m_hMenu = (WXHMENU)CreatePopupMenu();
 281     if ( !m_hMenu )
 282     {
 283         wxLogLastError(wxT("CreatePopupMenu"));
 284     }
 285
 286     // if we have a title, insert it in the beginning of the menu
 287     if ( !m_title.empty() )
 288     {
 289         const wxString title = m_title;
 290         m_title.clear(); // so that SetTitle() knows there was no title before
 291         SetTitle(title);
 292     }
 293 }
 294
 295 wxMenu::wxMenu(WXHMENU hMenu)
 296 {
 297     InitNoCreate();
 298
 299     m_hMenu = hMenu;
 300
 301     // Ensure that our internal idea of how many items we have corresponds to
 302     // the real number of items in the menu.
 303     //
 304     // We could also retrieve the real labels of the items here but it doesn't
 305     // seem to be worth the trouble.
 306     const int numExistingItems = ::GetMenuItemCount(m_hMenu);
 307     for ( int n = 0; n < numExistingItems; n++ )
 308     {
 309         wxMenuBase::DoAppend(wxMenuItem::New(this, wxID_SEPARATOR));
 310     }
 311 }
 312
 313 // The wxWindow destructor will take care of deleting the submenus.
 314 wxMenu::~wxMenu()
 315 {
 316     // we should free Windows resources only if Windows doesn't do it for us
 317     // which happens if we're attached to a menubar or a submenu of another
 318     // menu
 319     if ( !IsAttached() && !GetParent() )
 320     {
 321         if ( !::DestroyMenu(GetHmenu()) )
 322         {
 323             wxLogLastError(wxT("DestroyMenu"));
 324         }
 325     }
 326
 327 #if wxUSE_ACCEL
 328     // delete accels
 329     WX_CLEAR_ARRAY(m_accels);
 330 #endif // wxUSE_ACCEL
 331
 332     delete m_radioData;
 333 }
 334
 335 void wxMenu::Break()
 336 {
 337     // this will take effect during the next call to Append()
 338     m_doBreak = true;
 339 }
 340
 341 #if wxUSE_ACCEL
 342
 343 int wxMenu::FindAccel(int id) const
 344 {
 345     size_t n, count = m_accels.GetCount();
 346     for ( n = 0; n < count; n++ )
 347     {
 348         if ( m_accels[n]->m_command == id )
 349             return n;
 350     }
 351
 352     return wxNOT_FOUND;
 353 }
 354
 355 void wxMenu::UpdateAccel(wxMenuItem *item)
 356 {
 357     if ( item->IsSubMenu() )
 358     {
 359         wxMenu *submenu = item->GetSubMenu();
 360         wxMenuItemList::compatibility_iterator node = submenu->GetMenuItems().GetFirst();
 361         while ( node )
 362         {
 363             UpdateAccel(node->GetData());
 364
 365             node = node->GetNext();
 366         }
 367     }
 368     else if ( !item->IsSeparator() )
 369     {
 370         // recurse upwards: we should only modify m_accels of the top level
 371         // menus, not of the submenus as wxMenuBar doesn't look at them
 372         // (alternative and arguable cleaner solution would be to recurse
 373         // downwards in GetAccelCount() and CopyAccels())
 374         if ( GetParent() )
 375         {
 376             GetParent()->UpdateAccel(item);
 377             return;
 378         }
 379
 380         // find the (new) accel for this item
 381         wxAcceleratorEntry *accel = wxAcceleratorEntry::Create(item->GetItemLabel());
 382         if ( accel )
 383             accel->m_command = item->GetId();
 384
 385         // find the old one
 386         int n = FindAccel(item->GetId());
 387         if ( n == wxNOT_FOUND )
 388         {
 389             // no old, add new if any
 390             if ( accel )
 391                 m_accels.Add(accel);
 392             else
 393                 return;     // skipping RebuildAccelTable() below
 394         }
 395         else
 396         {
 397             // replace old with new or just remove the old one if no new
 398             delete m_accels[n];
 399             if ( accel )
 400                 m_accels[n] = accel;
 401             else
 402                 m_accels.RemoveAt(n);
 403         }
 404
 405         if ( IsAttached() )
 406         {
 407             GetMenuBar()->RebuildAccelTable();
 408         }
 409
 410 #if wxUSE_OWNER_DRAW
 411         ResetMaxAccelWidth();
 412 #endif
 413     }
 414     //else: it is a separator, they can't have accels, nothing to do
 415 }
 416
 417 #endif // wxUSE_ACCEL
 418
 419 namespace
 420 {
 421
 422 // helper of DoInsertOrAppend(): returns the HBITMAP to use in MENUITEMINFO
 423 HBITMAP GetHBitmapForMenu(wxMenuItem *pItem, bool checked = true)
 424 {
 425     // Under versions of Windows older than Vista we can't pass HBITMAP
 426     // directly as hbmpItem for 2 reasons:
 427     //  1. We can't draw it with transparency then (this is not
 428     //     very important now but would be with themed menu bg)
 429     //  2. Worse, Windows inverts the bitmap for the selected
 430     //     item and this looks downright ugly
 431     //
 432     // So we prefer to instead draw it ourselves in MSWOnDrawItem().by using
 433     // HBMMENU_CALLBACK when inserting it
 434     //
 435     // However under Vista using HBMMENU_CALLBACK causes the entire menu to be
 436     // drawn using the classic theme instead of the current one and it does
 437     // handle transparency just fine so do use the real bitmap there
 438 #if wxUSE_IMAGE
 439     if ( wxGetWinVersion() >= wxWinVersion_Vista )
 440     {
 441 #if wxUSE_OWNER_DRAW
 442         wxBitmap bmp = pItem->GetBitmap(checked);
 443         if ( bmp.IsOk() )
 444         {
 445             // we must use PARGB DIB for the menu bitmaps so ensure that we do
 446             wxImage img(bmp.ConvertToImage());
 447             if ( !img.HasAlpha() )
 448             {
 449                 img.InitAlpha();
 450                 pItem->SetBitmap(img, checked);
 451             }
 452
 453             return GetHbitmapOf(pItem->GetBitmap(checked));
 454         }
 455 #endif // wxUSE_OWNER_DRAW
 456         //else: bitmap is not set
 457
 458         return NULL;
 459     }
 460 #endif // wxUSE_IMAGE
 461
 462     return HBMMENU_CALLBACK;
 463 }
 464
 465 } // anonymous namespace
 466
 467 bool wxMenu::MSWGetRadioGroupRange(int pos, int *start, int *end) const
 468 {
 469     return m_radioData && m_radioData->GetGroupRange(pos, start, end);
 470 }
 471
 472 // append a new item or submenu to the menu
 473 bool wxMenu::DoInsertOrAppend(wxMenuItem *pItem, size_t pos)
 474 {
 475 #if wxUSE_ACCEL
 476     UpdateAccel(pItem);
 477 #endif // wxUSE_ACCEL
 478
 479     // we should support disabling the item even prior to adding it to the menu
 480     UINT flags = pItem->IsEnabled() ? MF_ENABLED : MF_GRAYED;
 481
 482     // if "Break" has just been called, insert a menu break before this item
 483     // (and don't forget to reset the flag)
 484     if ( m_doBreak ) {
 485         flags |= MF_MENUBREAK;
 486         m_doBreak = false;
 487     }
 488
 489     if ( pItem->IsSeparator() ) {
 490         flags |= MF_SEPARATOR;
 491     }
 492
 493     // id is the numeric id for normal menu items and HMENU for submenus as
 494     // required by ::AppendMenu() API
 495     UINT_PTR id;
 496     wxMenu *submenu = pItem->GetSubMenu();
 497     if ( submenu != NULL ) {
 498         wxASSERT_MSG( submenu->GetHMenu(), wxT("invalid submenu") );
 499
 500         submenu->SetParent(this);
 501
 502         id = (UINT_PTR)submenu->GetHMenu();
 503
 504         flags |= MF_POPUP;
 505     }
 506     else {
 507         id = pItem->GetMSWId();
 508     }
 509
 510
 511     // prepare to insert the item in the menu
 512     wxString itemText = pItem->GetItemLabel();
 513     LPCTSTR pData = NULL;
 514     if ( pos == (size_t)-1 )
 515     {
 516         // append at the end (note that the item is already appended to
 517         // internal data structures)
 518         pos = GetMenuItemCount() - 1;
 519     }
 520
 521     // Update radio groups data if we're inserting a new radio item.
 522     //
 523     // NB: If we supported inserting non-radio items in the middle of existing
 524     //     radio groups to break them into two subgroups, we'd need to update
 525     //     m_radioData in this case too but currently this is not supported.
 526     bool checkInitially = false;
 527     if ( pItem->GetKind() == wxITEM_RADIO )
 528     {
 529         if ( !m_radioData )
 530             m_radioData = new wxMenuRadioItemsData;
 531
 532         if ( m_radioData->UpdateOnInsert(pos) )
 533             checkInitially = true;
 534     }
 535
 536     // adjust position to account for the title of a popup menu, if any
 537     if ( !GetMenuBar() && !m_title.empty() )
 538         pos += 2; // for the title itself and its separator
 539
 540     BOOL ok = false;
 541
 542 #if wxUSE_OWNER_DRAWN
 543     // Under older systems mixing owner-drawn and non-owner-drawn items results
 544     // in inconsistent margins, so we force this one to be owner-drawn if any
 545     // other items already are.
 546     if ( m_ownerDrawn )
 547         pItem->SetOwnerDrawn(true);
 548 #endif // wxUSE_OWNER_DRAWN
 549
 550     // check if we have something more than a simple text item
 551 #if wxUSE_OWNER_DRAWN
 552     if ( pItem->IsOwnerDrawn() )
 553     {
 554 #ifndef __DMC__
 555
 556         if ( !m_ownerDrawn && !pItem->IsSeparator() )
 557         {
 558             // MIIM_BITMAP only works under WinME/2000+ so we always use owner
 559             // drawn item under the previous versions and we also have to use
 560             // them in any case if the item has custom colours or font
 561             static const wxWinVersion winver = wxGetWinVersion();
 562             bool mustUseOwnerDrawn = winver < wxWinVersion_98 ||
 563                                      pItem->GetTextColour().IsOk() ||
 564                                      pItem->GetBackgroundColour().IsOk() ||
 565                                      pItem->GetFont().IsOk();
 566
 567             if ( !mustUseOwnerDrawn )
 568             {
 569                 const wxBitmap& bmpUnchecked = pItem->GetBitmap(false),
 570                                 bmpChecked   = pItem->GetBitmap(true);
 571
 572                 if ( (bmpUnchecked.IsOk() && IsGreaterThanStdSize(bmpUnchecked)) ||
 573                      (bmpChecked.IsOk()   && IsGreaterThanStdSize(bmpChecked)) )
 574                 {
 575                     mustUseOwnerDrawn = true;
 576                 }
 577             }
 578
 579             // use InsertMenuItem() if possible as it's guaranteed to look
 580             // correct while our owner-drawn code is not
 581             if ( !mustUseOwnerDrawn )
 582             {
 583                 WinStruct<MENUITEMINFO> mii;
 584                 mii.fMask = MIIM_STRING | MIIM_DATA;
 585
 586                 // don't set hbmpItem for the checkable items as it would
 587                 // be used for both checked and unchecked state
 588                 if ( pItem->IsCheckable() )
 589                 {
 590                     mii.fMask |= MIIM_CHECKMARKS;
 591                     mii.hbmpChecked = GetHBitmapForMenu(pItem, true);
 592                     mii.hbmpUnchecked = GetHBitmapForMenu(pItem, false);
 593                 }
 594                 else if ( pItem->GetBitmap().IsOk() )
 595                 {
 596                     mii.fMask |= MIIM_BITMAP;
 597                     mii.hbmpItem = GetHBitmapForMenu(pItem);
 598                 }
 599
 600                 mii.cch = itemText.length();
 601                 mii.dwTypeData = const_cast<wxChar *>(itemText.wx_str());
 602
 603                 if ( flags & MF_POPUP )
 604                 {
 605                     mii.fMask |= MIIM_SUBMENU;
 606                     mii.hSubMenu = GetHmenuOf(pItem->GetSubMenu());
 607                 }
 608                 else
 609                 {
 610                     mii.fMask |= MIIM_ID;
 611                     mii.wID = id;
 612                 }
 613
 614                 mii.dwItemData = reinterpret_cast<ULONG_PTR>(pItem);
 615
 616                 ok = ::InsertMenuItem(GetHmenu(), pos, TRUE /* by pos */, &mii);
 617                 if ( !ok )
 618                 {
 619                     wxLogLastError(wxT("InsertMenuItem()"));
 620                 }
 621                 else // InsertMenuItem() ok
 622                 {
 623                     // we need to remove the extra indent which is reserved for
 624                     // the checkboxes by default as it looks ugly unless check
 625                     // boxes are used together with bitmaps and this is not the
 626                     // case in wx API
 627                     WinStruct<MENUINFO> mi;
 628
 629                     // don't call SetMenuInfo() directly, this would prevent
 630                     // the app from starting up under Windows 95/NT 4
 631                     typedef BOOL (WINAPI *SetMenuInfo_t)(HMENU, MENUINFO *);
 632
 633                     wxDynamicLibrary dllUser(wxT("user32"));
 634                     wxDYNLIB_FUNCTION(SetMenuInfo_t, SetMenuInfo, dllUser);
 635                     if ( pfnSetMenuInfo )
 636                     {
 637                         mi.fMask = MIM_STYLE;
 638                         mi.dwStyle = MNS_CHECKORBMP;
 639                         if ( !(*pfnSetMenuInfo)(GetHmenu(), &mi) )
 640                         {
 641                             wxLogLastError(wxT("SetMenuInfo(MNS_NOCHECK)"));
 642                         }
 643                     }
 644
 645                     // tell the item that it's not really owner-drawn but only
 646                     // needs to draw its bitmap, the rest is done by Windows
 647                     pItem->SetOwnerDrawn(false);
 648                 }
 649             }
 650         }
 651 #endif // __DMC__
 652
 653         if ( !ok )
 654         {
 655             // item draws itself, pass pointer to it in data parameter
 656             flags |= MF_OWNERDRAW;
 657             pData = (LPCTSTR)pItem;
 658
 659             bool updateAllMargins = false;
 660
 661             // get size of bitmap always return valid value (0 for invalid bitmap),
 662             // so we don't needed check if bitmap is valid ;)
 663             int uncheckedW = pItem->GetBitmap(false).GetWidth();
 664             int checkedW   = pItem->GetBitmap(true).GetWidth();
 665
 666             if ( m_maxBitmapWidth < uncheckedW )
 667             {
 668                 m_maxBitmapWidth = uncheckedW;
 669                 updateAllMargins = true;
 670             }
 671
 672             if ( m_maxBitmapWidth < checkedW )
 673             {
 674                 m_maxBitmapWidth = checkedW;
 675                 updateAllMargins = true;
 676             }
 677
 678             // make other item ownerdrawn and update margin width for equals alignment
 679             if ( !m_ownerDrawn || updateAllMargins )
 680             {
 681                 // we must use position in SetOwnerDrawnMenuItem because
 682                 // all separators have the same id
 683                 int pos = 0;
 684                 wxMenuItemList::compatibility_iterator node = GetMenuItems().GetFirst();
 685                 while (node)
 686                 {
 687                     wxMenuItem* item = node->GetData();
 688
 689                     if ( !item->IsOwnerDrawn())
 690                     {
 691                         item->SetOwnerDrawn(true);
 692                         SetOwnerDrawnMenuItem(GetHmenu(), pos,
 693                                               reinterpret_cast<ULONG_PTR>(item), TRUE);
 694                     }
 695
 696                     item->SetMarginWidth(m_maxBitmapWidth);
 697
 698                     node = node->GetNext();
 699                     pos++;
 700                 }
 701
 702                 // set menu as ownerdrawn
 703                 m_ownerDrawn = true;
 704
 705                 ResetMaxAccelWidth();
 706             }
 707             // only update our margin for equals alignment to other item
 708             else if ( !updateAllMargins )
 709             {
 710                 pItem->SetMarginWidth(m_maxBitmapWidth);
 711             }
 712         }
 713     }
 714     else
 715 #endif // wxUSE_OWNER_DRAWN
 716     {
 717         // item is just a normal string (passed in data parameter)
 718         flags |= MF_STRING;
 719
 720 #ifdef __WXWINCE__
 721         itemText = wxMenuItem::GetLabelText(itemText);
 722 #endif
 723
 724         pData = (wxChar*)itemText.wx_str();
 725     }
 726
 727     // item might have already been inserted by InsertMenuItem() above
 728     if ( !ok )
 729     {
 730         if ( !::InsertMenu(GetHmenu(), pos, flags | MF_BYPOSITION, id, pData) )
 731         {
 732             wxLogLastError(wxT("InsertMenu[Item]()"));
 733
 734             return false;
 735         }
 736     }
 737
 738
 739     // Check the item if it should be initially checked.
 740     if ( checkInitially )
 741         pItem->Check(true);
 742
 743     // if we just appended the title, highlight it
 744     if ( id == (UINT_PTR)idMenuTitle )
 745     {
 746         // visually select the menu title
 747         SetDefaultMenuItem(GetHmenu(), id);
 748     }
 749
 750     // if we're already attached to the menubar, we must update it
 751     if ( IsAttached() && GetMenuBar()->IsAttached() )
 752     {
 753         GetMenuBar()->Refresh();
 754     }
 755
 756     return true;
 757 }
 758
 759 wxMenuItem* wxMenu::DoAppend(wxMenuItem *item)
 760 {
 761     return wxMenuBase::DoAppend(item) && DoInsertOrAppend(item) ? item : NULL;
 762 }
 763
 764 wxMenuItem* wxMenu::DoInsert(size_t pos, wxMenuItem *item)
 765 {
 766     if (wxMenuBase::DoInsert(pos, item) && DoInsertOrAppend(item, pos))
 767         return item;
 768     else
 769         return NULL;
 770 }
 771
 772 wxMenuItem *wxMenu::DoRemove(wxMenuItem *item)
 773 {
 774     // we need to find the item's position in the child list
 775     size_t pos;
 776     wxMenuItemList::compatibility_iterator node = GetMenuItems().GetFirst();
 777     for ( pos = 0; node; pos++ )
 778     {
 779         if ( node->GetData() == item )
 780             break;
 781
 782         node = node->GetNext();
 783     }
 784
 785     // DoRemove() (unlike Remove) can only be called for an existing item!
 786     wxCHECK_MSG( node, NULL, wxT("bug in wxMenu::Remove logic") );
 787
 788 #if wxUSE_ACCEL
 789     // remove the corresponding accel from the accel table
 790     int n = FindAccel(item->GetId());
 791     if ( n != wxNOT_FOUND )
 792     {
 793         delete m_accels[n];
 794
 795         m_accels.RemoveAt(n);
 796
 797 #if wxUSE_OWNER_DRAW
 798         ResetMaxAccelWidth();
 799 #endif
 800     }
 801     //else: this item doesn't have an accel, nothing to do
 802 #endif // wxUSE_ACCEL
 803
 804     // remove the item from the menu
 805     if ( !::RemoveMenu(GetHmenu(), (UINT)pos, MF_BYPOSITION) )
 806     {
 807         wxLogLastError(wxT("RemoveMenu"));
 808     }
 809
 810     if ( IsAttached() && GetMenuBar()->IsAttached() )
 811     {
 812         // otherwise, the change won't be visible
 813         GetMenuBar()->Refresh();
 814     }
 815
 816     // and from internal data structures
 817     return wxMenuBase::DoRemove(item);
 818 }
 819
 820 // ---------------------------------------------------------------------------
 821 // accelerator helpers
 822 // ---------------------------------------------------------------------------
 823
 824 #if wxUSE_ACCEL
 825
 826 // create the wxAcceleratorEntries for our accels and put them into the provided
 827 // array - return the number of accels we have
 828 size_t wxMenu::CopyAccels(wxAcceleratorEntry *accels) const
 829 {
 830     size_t count = GetAccelCount();
 831     for ( size_t n = 0; n < count; n++ )
 832     {
 833         *accels++ = *m_accels[n];
 834     }
 835
 836     return count;
 837 }
 838
 839 wxAcceleratorTable *wxMenu::CreateAccelTable() const
 840 {
 841     const size_t count = m_accels.size();
 842     wxScopedArray<wxAcceleratorEntry> accels(new wxAcceleratorEntry[count]);
 843     CopyAccels(accels.get());
 844
 845     return new wxAcceleratorTable(count, accels.get());
 846 }
 847
 848 #endif // wxUSE_ACCEL
 849
 850 // ---------------------------------------------------------------------------
 851 // ownerdrawn helpers
 852 // ---------------------------------------------------------------------------
 853
 854 #if wxUSE_OWNER_DRAWN
 855
 856 void wxMenu::CalculateMaxAccelWidth()
 857 {
 858     wxASSERT_MSG( m_maxAccelWidth == -1, wxT("it's really needed?") );
 859
 860     wxMenuItemList::compatibility_iterator node = GetMenuItems().GetFirst();
 861     while (node)
 862     {
 863         wxMenuItem* item = node->GetData();
 864
 865         if ( item->IsOwnerDrawn() )
 866         {
 867             int width = item->MeasureAccelWidth();
 868             if (width > m_maxAccelWidth )
 869                 m_maxAccelWidth = width;
 870         }
 871
 872         node = node->GetNext();
 873     }
 874 }
 875
 876 #endif // wxUSE_OWNER_DRAWN
 877
 878 // ---------------------------------------------------------------------------
 879 // set wxMenu title
 880 // ---------------------------------------------------------------------------
 881
 882 void wxMenu::SetTitle(const wxString& label)
 883 {
 884     bool hasNoTitle = m_title.empty();
 885     m_title = label;
 886
 887     HMENU hMenu = GetHmenu();
 888
 889     if ( hasNoTitle )
 890     {
 891         if ( !label.empty() )
 892         {
 893             if ( !::InsertMenu(hMenu, 0u, MF_BYPOSITION | MF_STRING,
 894                                (UINT_PTR)idMenuTitle, m_title.wx_str()) ||
 895                  !::InsertMenu(hMenu, 1u, MF_BYPOSITION, (unsigned)-1, NULL) )
 896             {
 897                 wxLogLastError(wxT("InsertMenu"));
 898             }
 899         }
 900     }
 901     else
 902     {
 903         if ( label.empty() )
 904         {
 905             // remove the title and the separator after it
 906             if ( !RemoveMenu(hMenu, 0, MF_BYPOSITION) ||
 907                  !RemoveMenu(hMenu, 0, MF_BYPOSITION) )
 908             {
 909                 wxLogLastError(wxT("RemoveMenu"));
 910             }
 911         }
 912         else
 913         {
 914             // modify the title
 915 #ifdef __WXWINCE__
 916             MENUITEMINFO info;
 917             wxZeroMemory(info);
 918             info.cbSize = sizeof(info);
 919             info.fMask = MIIM_TYPE;
 920             info.fType = MFT_STRING;
 921             info.cch = m_title.length();
 922             info.dwTypeData = const_cast<wxChar *>(m_title.wx_str());
 923             if ( !SetMenuItemInfo(hMenu, 0, TRUE, & info) )
 924             {
 925                 wxLogLastError(wxT("SetMenuItemInfo"));
 926             }
 927 #else
 928             if ( !ModifyMenu(hMenu, 0u,
 929                              MF_BYPOSITION | MF_STRING,
 930                              (UINT_PTR)idMenuTitle, m_title.wx_str()) )
 931             {
 932                 wxLogLastError(wxT("ModifyMenu"));
 933             }
 934 #endif
 935         }
 936     }
 937
 938 #ifdef __WIN32__
 939     // put the title string in bold face
 940     if ( !m_title.empty() )
 941     {
 942         SetDefaultMenuItem(GetHmenu(), (UINT_PTR)idMenuTitle);
 943     }
 944 #endif // Win32
 945 }
 946
 947 // ---------------------------------------------------------------------------
 948 // event processing
 949 // ---------------------------------------------------------------------------
 950
 951 bool wxMenu::MSWCommand(WXUINT WXUNUSED(param), WXWORD id_)
 952 {
 953     const int id = (signed short)id_;
 954
 955     // ignore commands from the menu title
 956     if ( id != idMenuTitle )
 957     {
 958         // Default value for uncheckable items.
 959         int checked = -1;
 960
 961         // update the check item when it's clicked
 962         wxMenuItem * const item = FindItem(id);
 963         if ( item && item->IsCheckable() )
 964         {
 965             item->Toggle();
 966
 967             // Get the status of the menu item: note that it has been just changed
 968             // by Toggle() above so here we already get the new state of the item.
 969             //
 970             // Also notice that we must pass unsigned id_ and not sign-extended id
 971             // to ::GetMenuState() as this is what it expects.
 972             UINT menuState = ::GetMenuState(GetHmenu(), id_, MF_BYCOMMAND);
 973             checked = (menuState & MF_CHECKED) != 0;
 974         }
 975
 976         SendEvent(id, checked);
 977     }
 978
 979     return true;
 980 }
 981
 982 // get the menu with given handle (recursively)
 983 #if wxUSE_OWNER_DRAW
 984 wxMenu* wxMenu::MSWGetMenu(WXHMENU hMenu)
 985 {
 986     // check self
 987     if ( GetHMenu() == hMenu )
 988         return this;
 989
 990     // recursively query submenus
 991     for ( size_t n = 0 ; n < GetMenuItemCount(); ++n )
 992     {
 993         wxMenuItem* item = FindItemByPosition(n);
 994         wxMenu* submenu = item->GetSubMenu();
 995         if ( submenu )
 996         {
 997             submenu = submenu->MSWGetMenu(hMenu);
 998             if (submenu)
 999                 return submenu;
1000         }
1001     }
1002
1003     // unknown hMenu
1004     return NULL;
1005 }
1006 #endif // wxUSE_OWNER_DRAW
1007
1008 // ---------------------------------------------------------------------------
1009 // Menu Bar
1010 // ---------------------------------------------------------------------------
1011
1012 void wxMenuBar::Init()
1013 {
1014     m_eventHandler = this;
1015     m_hMenu = 0;
1016 #if wxUSE_TOOLBAR && defined(__WXWINCE__)
1017     m_toolBar = NULL;
1018 #endif
1019     // Not using a combined wxToolBar/wxMenuBar? then use
1020     // a commandbar in WinCE .NET just to implement the
1021     // menubar.
1022 #if defined(WINCE_WITH_COMMANDBAR)
1023     m_commandBar = NULL;
1024     m_adornmentsAdded = false;
1025 #endif
1026 }
1027
1028 wxMenuBar::wxMenuBar()
1029 {
1030     Init();
1031 }
1032
1033 wxMenuBar::wxMenuBar( long WXUNUSED(style) )
1034 {
1035     Init();
1036 }
1037
1038 wxMenuBar::wxMenuBar(size_t count, wxMenu *menus[], const wxString titles[], long WXUNUSED(style))
1039 {
1040     Init();
1041
1042     for ( size_t i = 0; i < count; i++ )
1043     {
1044         // We just want to store the menu title in the menu itself, not to
1045         // show it as a dummy item in the menu itself as we do with the popup
1046         // menu titles in overridden wxMenu::SetTitle().
1047         menus[i]->wxMenuBase::SetTitle(titles[i]);
1048         m_menus.Append(menus[i]);
1049
1050         menus[i]->Attach(this);
1051     }
1052 }
1053
1054 wxMenuBar::~wxMenuBar()
1055 {
1056     // In Windows CE (not .NET), the menubar is always associated
1057     // with a toolbar, which destroys the menu implicitly.
1058 #if defined(WINCE_WITHOUT_COMMANDBAR) && defined(__POCKETPC__)
1059     if (GetToolBar())
1060     {
1061         wxToolMenuBar* toolMenuBar = wxDynamicCast(GetToolBar(), wxToolMenuBar);
1062         if (toolMenuBar)
1063             toolMenuBar->SetMenuBar(NULL);
1064     }
1065 #else
1066     // we should free Windows resources only if Windows doesn't do it for us
1067     // which happens if we're attached to a frame
1068     if (m_hMenu && !IsAttached())
1069     {
1070 #if defined(WINCE_WITH_COMMANDBAR)
1071         ::DestroyWindow((HWND) m_commandBar);
1072         m_commandBar = (WXHWND) NULL;
1073 #else
1074         ::DestroyMenu((HMENU)m_hMenu);
1075 #endif
1076         m_hMenu = (WXHMENU)NULL;
1077     }
1078 #endif
1079 }
1080
1081 // ---------------------------------------------------------------------------
1082 // wxMenuBar helpers
1083 // ---------------------------------------------------------------------------
1084
1085 void wxMenuBar::Refresh()
1086 {
1087     if ( IsFrozen() )
1088         return;
1089
1090     wxCHECK_RET( IsAttached(), wxT("can't refresh unattached menubar") );
1091
1092 #if defined(WINCE_WITHOUT_COMMANDBAR)
1093     if (GetToolBar())
1094     {
1095         CommandBar_DrawMenuBar((HWND) GetToolBar()->GetHWND(), 0);
1096     }
1097 #elif defined(WINCE_WITH_COMMANDBAR)
1098     if (m_commandBar)
1099         DrawMenuBar((HWND) m_commandBar);
1100 #else
1101     DrawMenuBar(GetHwndOf(GetFrame()));
1102 #endif
1103 }
1104
1105 WXHMENU wxMenuBar::Create()
1106 {
1107     // Note: this doesn't work at all on Smartphone,
1108     // since you have to use resources.
1109     // We'll have to find another way to add a menu
1110     // by changing/adding menu items to an existing menu.
1111 #if defined(WINCE_WITHOUT_COMMANDBAR)
1112     if ( m_hMenu != 0 )
1113         return m_hMenu;
1114
1115     wxToolMenuBar * const bar = static_cast<wxToolMenuBar *>(GetToolBar());
1116     if ( !bar )
1117         return NULL;
1118
1119     HWND hCommandBar = GetHwndOf(bar);
1120
1121     // notify comctl32.dll about the version of the headers we use before using
1122     // any other TB_XXX messages
1123     SendMessage(hCommandBar, TB_BUTTONSTRUCTSIZE, sizeof(TBBUTTON), 0);
1124
1125     TBBUTTON tbButton;
1126     wxZeroMemory(tbButton);
1127     tbButton.iBitmap = I_IMAGENONE;
1128     tbButton.fsState = TBSTATE_ENABLED;
1129     tbButton.fsStyle = TBSTYLE_DROPDOWN |
1130                        TBSTYLE_NO_DROPDOWN_ARROW |
1131                        TBSTYLE_AUTOSIZE;
1132
1133     for ( unsigned i = 0; i < GetMenuCount(); i++ )
1134     {
1135         HMENU hPopupMenu = (HMENU) GetMenu(i)->GetHMenu();
1136         tbButton.dwData = (DWORD)hPopupMenu;
1137         wxString label = wxStripMenuCodes(GetMenuLabel(i));
1138         tbButton.iString = (int) label.wx_str();
1139
1140         tbButton.idCommand = NewControlId();
1141         if ( !::SendMessage(hCommandBar, TB_INSERTBUTTON, i, (LPARAM)&tbButton) )
1142         {
1143             wxLogLastError(wxT("TB_INSERTBUTTON"));
1144         }
1145     }
1146
1147     m_hMenu = bar->GetHMenu();
1148     return m_hMenu;
1149 #else // !__WXWINCE__
1150     if ( m_hMenu != 0 )
1151         return m_hMenu;
1152
1153     m_hMenu = (WXHMENU)::CreateMenu();
1154
1155     if ( !m_hMenu )
1156     {
1157         wxLogLastError(wxT("CreateMenu"));
1158     }
1159     else
1160     {
1161         for ( wxMenuList::iterator it = m_menus.begin();
1162               it != m_menus.end();
1163               ++it )
1164         {
1165             if ( !::AppendMenu((HMENU)m_hMenu, MF_POPUP | MF_STRING,
1166                                (UINT_PTR)(*it)->GetHMenu(),
1167                                (*it)->GetTitle().wx_str()) )
1168             {
1169                 wxLogLastError(wxT("AppendMenu"));
1170             }
1171         }
1172     }
1173
1174     return m_hMenu;
1175 #endif // __WXWINCE__/!__WXWINCE__
1176 }
1177
1178 int wxMenuBar::MSWPositionForWxMenu(wxMenu *menu, int wxpos)
1179 {
1180     wxASSERT(menu);
1181     wxASSERT(menu->GetHMenu());
1182     wxASSERT(m_hMenu);
1183
1184 #if defined(__WXWINCE__)
1185     int totalMSWItems = GetMenuCount();
1186 #else
1187     int totalMSWItems = GetMenuItemCount((HMENU)m_hMenu);
1188 #endif
1189
1190     int i; // For old C++ compatibility
1191     for(i=wxpos; i<totalMSWItems; i++)
1192     {
1193         if(GetSubMenu((HMENU)m_hMenu,i)==(HMENU)menu->GetHMenu())
1194             return i;
1195     }
1196     for(i=0; i<wxpos; i++)
1197     {
1198         if(GetSubMenu((HMENU)m_hMenu,i)==(HMENU)menu->GetHMenu())
1199             return i;
1200     }
1201     wxFAIL;
1202     return -1;
1203 }
1204
1205 // ---------------------------------------------------------------------------
1206 // wxMenuBar functions to work with the top level submenus
1207 // ---------------------------------------------------------------------------
1208
1209 // NB: we don't support owner drawn top level items for now, if we do these
1210 //     functions would have to be changed to use wxMenuItem as well
1211
1212 void wxMenuBar::EnableTop(size_t pos, bool enable)
1213 {
1214     wxCHECK_RET( IsAttached(), wxT("doesn't work with unattached menubars") );
1215     wxCHECK_RET( pos < GetMenuCount(), wxT("invalid menu index") );
1216
1217     int flag = enable ? MF_ENABLED : MF_GRAYED;
1218
1219     EnableMenuItem((HMENU)m_hMenu, MSWPositionForWxMenu(GetMenu(pos),pos), MF_BYPOSITION | flag);
1220
1221     Refresh();
1222 }
1223
1224 void wxMenuBar::SetMenuLabel(size_t pos, const wxString& label)
1225 {
1226     wxCHECK_RET( pos < GetMenuCount(), wxT("invalid menu index") );
1227
1228     m_menus[pos]->wxMenuBase::SetTitle(label);
1229
1230     if ( !IsAttached() )
1231     {
1232         return;
1233     }
1234     //else: have to modify the existing menu
1235
1236     int mswpos = MSWPositionForWxMenu(GetMenu(pos),pos);
1237
1238     UINT_PTR id;
1239     UINT flagsOld = ::GetMenuState((HMENU)m_hMenu, mswpos, MF_BYPOSITION);
1240     if ( flagsOld == 0xFFFFFFFF )
1241     {
1242         wxLogLastError(wxT("GetMenuState"));
1243
1244         return;
1245     }
1246
1247     if ( flagsOld & MF_POPUP )
1248     {
1249         // HIBYTE contains the number of items in the submenu in this case
1250         flagsOld &= 0xff;
1251         id = (UINT_PTR)::GetSubMenu((HMENU)m_hMenu, mswpos);
1252     }
1253     else
1254     {
1255         id = pos;
1256     }
1257
1258 #ifdef __WXWINCE__
1259     MENUITEMINFO info;
1260     wxZeroMemory(info);
1261     info.cbSize = sizeof(info);
1262     info.fMask = MIIM_TYPE;
1263     info.fType = MFT_STRING;
1264     info.cch = label.length();
1265     info.dwTypeData = const_cast<wxChar *>(label.wx_str());
1266     if ( !SetMenuItemInfo(GetHmenu(), id, TRUE, &info) )
1267     {
1268         wxLogLastError(wxT("SetMenuItemInfo"));
1269     }
1270
1271 #else
1272     if ( ::ModifyMenu(GetHmenu(), mswpos, MF_BYPOSITION | MF_STRING | flagsOld,
1273                       id, label.wx_str()) == (int)0xFFFFFFFF )
1274     {
1275         wxLogLastError(wxT("ModifyMenu"));
1276     }
1277 #endif
1278
1279     Refresh();
1280 }
1281
1282 wxString wxMenuBar::GetMenuLabel(size_t pos) const
1283 {
1284     wxCHECK_MSG( pos < GetMenuCount(), wxEmptyString,
1285                  wxT("invalid menu index in wxMenuBar::GetMenuLabel") );
1286
1287     return m_menus[pos]->GetTitle();
1288 }
1289
1290 // ---------------------------------------------------------------------------
1291 // wxMenuBar construction
1292 // ---------------------------------------------------------------------------
1293
1294 wxMenu *wxMenuBar::Replace(size_t pos, wxMenu *menu, const wxString& title)
1295 {
1296     wxMenu *menuOld = wxMenuBarBase::Replace(pos, menu, title);
1297     if ( !menuOld )
1298         return NULL;
1299
1300     menu->wxMenuBase::SetTitle(title);
1301
1302 #if defined(WINCE_WITHOUT_COMMANDBAR)
1303     if (IsAttached())
1304 #else
1305     if (GetHmenu())
1306 #endif
1307     {
1308         int mswpos = MSWPositionForWxMenu(menuOld,pos);
1309
1310         // can't use ModifyMenu() because it deletes the submenu it replaces
1311         if ( !::RemoveMenu(GetHmenu(), (UINT)mswpos, MF_BYPOSITION) )
1312         {
1313             wxLogLastError(wxT("RemoveMenu"));
1314         }
1315
1316         if ( !::InsertMenu(GetHmenu(), (UINT)mswpos,
1317                            MF_BYPOSITION | MF_POPUP | MF_STRING,
1318                            (UINT_PTR)GetHmenuOf(menu), title.wx_str()) )
1319         {
1320             wxLogLastError(wxT("InsertMenu"));
1321         }
1322
1323 #if wxUSE_ACCEL
1324         if ( menuOld->HasAccels() || menu->HasAccels() )
1325         {
1326             // need to rebuild accell table
1327             RebuildAccelTable();
1328         }
1329 #endif // wxUSE_ACCEL
1330
1331         if (IsAttached())
1332             Refresh();
1333     }
1334
1335     return menuOld;
1336 }
1337
1338 bool wxMenuBar::Insert(size_t pos, wxMenu *menu, const wxString& title)
1339 {
1340     // Find out which MSW item before which we'll be inserting before
1341     // wxMenuBarBase::Insert is called and GetMenu(pos) is the new menu.
1342     // If IsAttached() is false this won't be used anyway
1343     bool isAttached =
1344 #if defined(WINCE_WITHOUT_COMMANDBAR)
1345         IsAttached();
1346 #else
1347         (GetHmenu() != 0);
1348 #endif
1349
1350     int mswpos = (!isAttached || (pos == m_menus.GetCount()))
1351         ?   -1 // append the menu
1352         :   MSWPositionForWxMenu(GetMenu(pos),pos);
1353
1354     if ( !wxMenuBarBase::Insert(pos, menu, title) )
1355         return false;
1356
1357     menu->wxMenuBase::SetTitle(title);
1358
1359     if ( isAttached )
1360     {
1361 #if defined(WINCE_WITHOUT_COMMANDBAR)
1362         if (!GetToolBar())
1363             return false;
1364         TBBUTTON tbButton;
1365         memset(&tbButton, 0, sizeof(TBBUTTON));
1366         tbButton.iBitmap = I_IMAGENONE;
1367         tbButton.fsState = TBSTATE_ENABLED;
1368         tbButton.fsStyle = TBSTYLE_DROPDOWN | TBSTYLE_NO_DROPDOWN_ARROW | TBSTYLE_AUTOSIZE;
1369
1370         HMENU hPopupMenu = (HMENU) menu->GetHMenu() ;
1371         tbButton.dwData = (DWORD)hPopupMenu;
1372         wxString label = wxStripMenuCodes(title);
1373         tbButton.iString = (int) label.wx_str();
1374
1375         tbButton.idCommand = NewControlId();
1376         if (!::SendMessage((HWND) GetToolBar()->GetHWND(), TB_INSERTBUTTON, pos, (LPARAM)&tbButton))
1377         {
1378             wxLogLastError(wxT("TB_INSERTBUTTON"));
1379             return false;
1380         }
1381         wxUnusedVar(mswpos);
1382 #else
1383         if ( !::InsertMenu(GetHmenu(), mswpos,
1384                            MF_BYPOSITION | MF_POPUP | MF_STRING,
1385                            (UINT_PTR)GetHmenuOf(menu), title.wx_str()) )
1386         {
1387             wxLogLastError(wxT("InsertMenu"));
1388         }
1389 #endif
1390 #if wxUSE_ACCEL
1391         if ( menu->HasAccels() )
1392         {
1393             // need to rebuild accell table
1394             RebuildAccelTable();
1395         }
1396 #endif // wxUSE_ACCEL
1397
1398         if (IsAttached())
1399             Refresh();
1400     }
1401
1402     return true;
1403 }
1404
1405 bool wxMenuBar::Append(wxMenu *menu, const wxString& title)
1406 {
1407     WXHMENU submenu = menu ? menu->GetHMenu() : 0;
1408     wxCHECK_MSG( submenu, false, wxT("can't append invalid menu to menubar") );
1409
1410     if ( !wxMenuBarBase::Append(menu, title) )
1411         return false;
1412
1413     menu->wxMenuBase::SetTitle(title);
1414
1415 #if defined(WINCE_WITHOUT_COMMANDBAR)
1416     if (IsAttached())
1417 #else
1418     if (GetHmenu())
1419 #endif
1420     {
1421 #if defined(WINCE_WITHOUT_COMMANDBAR)
1422         if (!GetToolBar())
1423             return false;
1424         TBBUTTON tbButton;
1425         memset(&tbButton, 0, sizeof(TBBUTTON));
1426         tbButton.iBitmap = I_IMAGENONE;
1427         tbButton.fsState = TBSTATE_ENABLED;
1428         tbButton.fsStyle = TBSTYLE_DROPDOWN | TBSTYLE_NO_DROPDOWN_ARROW | TBSTYLE_AUTOSIZE;
1429
1430         size_t pos = GetMenuCount();
1431         HMENU hPopupMenu = (HMENU) menu->GetHMenu() ;
1432         tbButton.dwData = (DWORD)hPopupMenu;
1433         wxString label = wxStripMenuCodes(title);
1434         tbButton.iString = (int) label.wx_str();
1435
1436         tbButton.idCommand = NewControlId();
1437         if (!::SendMessage((HWND) GetToolBar()->GetHWND(), TB_INSERTBUTTON, pos, (LPARAM)&tbButton))
1438         {
1439             wxLogLastError(wxT("TB_INSERTBUTTON"));
1440             return false;
1441         }
1442 #else
1443         if ( !::AppendMenu(GetHmenu(), MF_POPUP | MF_STRING,
1444                            (UINT_PTR)submenu, title.wx_str()) )
1445         {
1446             wxLogLastError(wxT("AppendMenu"));
1447         }
1448 #endif
1449
1450 #if wxUSE_ACCEL
1451         if ( menu->HasAccels() )
1452         {
1453             // need to rebuild accelerator table
1454             RebuildAccelTable();
1455         }
1456 #endif // wxUSE_ACCEL
1457
1458         if (IsAttached())
1459             Refresh();
1460     }
1461
1462     return true;
1463 }
1464
1465 wxMenu *wxMenuBar::Remove(size_t pos)
1466 {
1467     wxMenu *menu = wxMenuBarBase::Remove(pos);
1468     if ( !menu )
1469         return NULL;
1470
1471 #if defined(WINCE_WITHOUT_COMMANDBAR)
1472     if (IsAttached())
1473 #else
1474     if (GetHmenu())
1475 #endif
1476     {
1477 #if defined(WINCE_WITHOUT_COMMANDBAR)
1478         if (GetToolBar())
1479         {
1480             if (!::SendMessage((HWND) GetToolBar()->GetHWND(), TB_DELETEBUTTON, (UINT) pos, (LPARAM) 0))
1481             {
1482                 wxLogLastError(wxT("TB_DELETEBUTTON"));
1483             }
1484         }
1485 #else
1486         if ( !::RemoveMenu(GetHmenu(), (UINT)MSWPositionForWxMenu(menu,pos), MF_BYPOSITION) )
1487         {
1488             wxLogLastError(wxT("RemoveMenu"));
1489         }
1490 #endif
1491
1492 #if wxUSE_ACCEL
1493         if ( menu->HasAccels() )
1494         {
1495             // need to rebuild accell table
1496             RebuildAccelTable();
1497         }
1498 #endif // wxUSE_ACCEL
1499
1500         if (IsAttached())
1501             Refresh();
1502     }
1503
1504     return menu;
1505 }
1506
1507 #if wxUSE_ACCEL
1508
1509 void wxMenuBar::RebuildAccelTable()
1510 {
1511     // merge the accelerators of all menus into one accel table
1512     size_t nAccelCount = 0;
1513     size_t i, count = GetMenuCount();
1514     wxMenuList::iterator it;
1515     for ( i = 0, it = m_menus.begin(); i < count; i++, it++ )
1516     {
1517         nAccelCount += (*it)->GetAccelCount();
1518     }
1519
1520     if ( nAccelCount )
1521     {
1522         wxAcceleratorEntry *accelEntries = new wxAcceleratorEntry[nAccelCount];
1523
1524         nAccelCount = 0;
1525         for ( i = 0, it = m_menus.begin(); i < count; i++, it++ )
1526         {
1527             nAccelCount += (*it)->CopyAccels(&accelEntries[nAccelCount]);
1528         }
1529
1530         SetAcceleratorTable(wxAcceleratorTable(nAccelCount, accelEntries));
1531
1532         delete [] accelEntries;
1533     }
1534 }
1535
1536 #endif // wxUSE_ACCEL
1537
1538 void wxMenuBar::Attach(wxFrame *frame)
1539 {
1540     wxMenuBarBase::Attach(frame);
1541
1542 #if defined(WINCE_WITH_COMMANDBAR)
1543     if (!m_hMenu)
1544         this->Create();
1545     if (!m_commandBar)
1546         m_commandBar = (WXHWND) CommandBar_Create(wxGetInstance(), (HWND) frame->GetHWND(), NewControlId());
1547     if (m_commandBar)
1548     {
1549         if (m_hMenu)
1550         {
1551             if (!CommandBar_InsertMenubarEx((HWND) m_commandBar, NULL, (LPTSTR) m_hMenu, 0))
1552             {
1553                 wxLogLastError(wxT("CommandBar_InsertMenubarEx"));
1554             }
1555         }
1556     }
1557 #endif
1558
1559 #if wxUSE_ACCEL
1560     RebuildAccelTable();
1561 #endif // wxUSE_ACCEL
1562 }
1563
1564 #if defined(WINCE_WITH_COMMANDBAR)
1565 bool wxMenuBar::AddAdornments(long style)
1566 {
1567     if (m_adornmentsAdded || !m_commandBar)
1568         return false;
1569
1570     if (style & wxCLOSE_BOX)
1571     {
1572         if (!CommandBar_AddAdornments((HWND) m_commandBar, 0, 0))
1573         {
1574             wxLogLastError(wxT("CommandBar_AddAdornments"));
1575         }
1576         else
1577         {
1578             return true;
1579         }
1580     }
1581     return false;
1582 }
1583 #endif
1584
1585 void wxMenuBar::Detach()
1586 {
1587     wxMenuBarBase::Detach();
1588 }
1589
1590 // get the menu with given handle (recursively)
1591 wxMenu* wxMenuBar::MSWGetMenu(WXHMENU hMenu)
1592 {
1593     wxCHECK_MSG( GetHMenu() != hMenu, NULL,
1594                  wxT("wxMenuBar::MSWGetMenu(): menu handle is wxMenuBar, not wxMenu") );
1595
1596 #if wxUSE_OWNER_DRAW
1597     // query all menus
1598     for ( size_t n = 0 ; n < GetMenuCount(); ++n )
1599     {
1600         wxMenu* menu = GetMenu(n)->MSWGetMenu(hMenu);
1601         if ( menu )
1602             return menu;
1603     }
1604 #endif
1605
1606     // unknown hMenu
1607     return NULL;
1608 }
1609
1610 #endif // wxUSE_MENUS