INCRBY/DECRBY now support 64bit increments, with tests

diff --git a/Changelog b/Changelog
index e470cd07a1a25158adeabd095697c6991f708e7b..e5df8c67bb99a1bc890d72bdac18dd5038a7a4a3 100644 (file)
--- a/Changelog
+++ b/Changelog
@@ -1,3 +1,5 @@
+2009-04-23 RANDOMKEY regression test added
+2009-04-23 dictGetRandomKey bug fixed, RANDOMKEY will not block the server anymore

 2009-04-22 FLUSHALL/FLUSHDB no longer sync on disk. Just increment the dirty counter by the number of elements removed, that will probably trigger a background saving operation
 2009-04-21 forgot to comment testing code in PHP lib. Now it is ok
 2009-04-21 PHP client ported to PHP5 and fixed
 2009-04-22 FLUSHALL/FLUSHDB no longer sync on disk. Just increment the dirty counter by the number of elements removed, that will probably trigger a background saving operation
 2009-04-21 forgot to comment testing code in PHP lib. Now it is ok
 2009-04-21 PHP client ported to PHP5 and fixed

diff --git a/TODO b/TODO
index f3a911cbc0fd51169cf1566f811fcfcde2182a4e..89b67c5700fb9380f32c25d4f5343b4fabeea021 100644 (file)
--- a/TODO
+++ b/TODO
@@ -1,7 +1,6 @@
 BEFORE REDIS 1.0.0-rc1
 
 - What happens if the saving child gets killed instead to end normally? Handle this.
 BEFORE REDIS 1.0.0-rc1
 
 - What happens if the saving child gets killed instead to end normally? Handle this.

-- Fix INCRBY argument that is limited to 32bit int.

 - Make sinterstore / unionstore / sdiffstore returning the cardinality of the resulting set.
 - Add a new field as INFO output: bgsaveinprogress
 - Remove max number of args limit
 - Make sinterstore / unionstore / sdiffstore returning the cardinality of the resulting set.
 - Add a new field as INFO output: bgsaveinprogress
 - Remove max number of args limit


@@ -24,6 +23,7 @@ This command should be smart and don't use too much memory, that is, take two co
 - Document replication
 - Objects sharing configuration, add the directive "objectsharingpool <size>"
 - Make sure to convert all the fstat() calls to 64bit versions.
 - Document replication
 - Objects sharing configuration, add the directive "objectsharingpool <size>"
 - Make sure to convert all the fstat() calls to 64bit versions.

+- SINTERCOUNT, SUNIONCOUNT, SDIFFCOUNT

 
 FUTURE HINTS
 
 
 FUTURE HINTS
 

diff --git a/redis.c b/redis.c
index e74910ba093e45ed9b622925838e364397806a9e..e8ed621d2174ddf9dfa09bdde83b1563140c6028 100644 (file)
--- a/redis.c
+++ b/redis.c
@@ -2195,7 +2195,7 @@ static void mgetCommand(redisClient *c) {
     }
 }
 
     }
 }
 

-static void incrDecrCommand(redisClient *c, int incr) {
+static void incrDecrCommand(redisClient *c, long long incr) {

     long long value;
     int retval;
     robj *o;
     long long value;
     int retval;
     robj *o;


@@ -2237,12 +2237,12 @@ static void decrCommand(redisClient *c) {
 }
 
 static void incrbyCommand(redisClient *c) {
 }
 
 static void incrbyCommand(redisClient *c) {

-    int incr = atoi(c->argv[2]->ptr);
+    long long incr = strtoll(c->argv[2]->ptr, NULL, 10);

     incrDecrCommand(c,incr);
 }
 
 static void decrbyCommand(redisClient *c) {
     incrDecrCommand(c,incr);
 }
 
 static void decrbyCommand(redisClient *c) {

-    int incr = atoi(c->argv[2]->ptr);
+    long long incr = strtoll(c->argv[2]->ptr, NULL, 10);

     incrDecrCommand(c,-incr);
 }
 
     incrDecrCommand(c,-incr);
 }
 

diff --git a/test-redis.tcl b/test-redis.tcl
index 0e1c852f0223c119307cc92320ead469b74c5ace..63df9764aba5273df1e1487d7b5c5b77a24d76dd 100644 (file)
--- a/test-redis.tcl
+++ b/test-redis.tcl
@@ -101,6 +101,21 @@ proc main {server port} {
         $r incr novar
     } {101}
 
         $r incr novar
     } {101}
 

+    test {INCR over 32bit value} {
+        $r set novar 17179869184
+        $r incr novar
+    } {17179869185}
+
+    test {INCRBY over 32bit value with over 32bit increment} {
+        $r set novar 17179869184
+        $r incrby novar 17179869184
+    } {34359738368}
+
+    test {DECRBY over 32bit value with over 32bit increment, negative res} {
+        $r set novar 17179869184
+        $r decrby novar 17179869185
+    } {-1}
+

     test {SETNX target key missing} {
         $r setnx novar2 foobared
         $r get novar2
     test {SETNX target key missing} {
         $r setnx novar2 foobared
         $r get novar2