Refactor all of Java bridge to release references.

[cycript.git] / Console.cpp

diff --git a/Console.cpp b/Console.cpp
index e01dd07beea56bdcb22c8024f45edf37521493f5..31a2dbbc6fc4eb348b7862dbabf786979c34d965 100644 (file)
--- a/Console.cpp
+++ b/Console.cpp
@@ -1,5 +1,5 @@
-/* Cycript - Optimizing JavaScript Compiler/Runtime
- * Copyright (C) 2009-2015  Jay Freeman (saurik)
+/* Cycript - The Truly Universal Scripting Language
+ * Copyright (C) 2009-2016  Jay Freeman (saurik)
 */
 
 /* GNU Affero General Public License, Version 3 {{{ */
@@ -219,7 +219,9 @@ static void sigint(int) {
         case Parsing:
             longjmp(ctrlc_, 1);
         case Running:
+#ifndef __ANDROID__
             CYCancel();
+#endif
             return;
         case Sending:
             return;
@@ -389,10 +391,23 @@ static Type_ *CYmemrchr(Type_ *data, Type_ value, size_t size) {
     return NULL;
 }
 
+static void _lblcall(int (*command)(int, int), int count, int key) {
+    int last(_rl_last_c_pos);
+    // rl_rubout crashes in _rl_erase_at_end_of_line if _rl_last_c_pos != 0
+    if (command == &rl_rubout)
+        _rl_last_c_pos = 0;
+    for (int i(0); i != count; ++i)
+        if (command(1, key) != 0)
+            _assert(false);
+    _rl_last_c_pos = last;
+}
+
 static int CYConsoleKeyReturn(int count, int key) {
     if (rl_point != rl_end) {
-        if (memchr(rl_line_buffer, '\n', rl_end) == NULL)
-            return rl_newline(count, key);
+        if (memchr(rl_line_buffer, '\n', rl_end) == NULL) {
+            _lblcall(&rl_newline, count, key);
+            return 0;
+        }
 
       insert:
         char *before(CYmemrchr(rl_line_buffer, '\n', rl_point));
@@ -405,11 +420,11 @@ static int CYConsoleKeyReturn(int count, int key) {
 
         int adjust(rl_line_buffer + space - 1 - before);
         if (space == rl_point && adjust != 0)
-            rl_rubout(adjust, '\b');
+            _lblcall(&rl_rubout, adjust, '\b');
 
-        rl_insert(count, '\n');
+        _lblcall(&rl_insert, count, '\n');
         if (adjust != 0)
-            rl_insert(adjust, ' ');
+            _lblcall(&rl_insert, adjust, ' ');
 
         return 0;
     }
@@ -438,15 +453,17 @@ static int CYConsoleKeyReturn(int count, int key) {
             done = true;
     }
 
-    if (done)
-        return rl_newline(count, key);
+    if (done) {
+        _lblcall(&rl_newline, count, key);
+        return 0;
+    }
 
     // XXX: this was the most obvious fix, but is seriously dumb
     goto insert;
 }
 
 static int CYConsoleKeyUp(int count, int key) {
-    while (count-- != 0) {
+    for (; count != 0; --count) {
         char *after(CYmemrchr(rl_line_buffer, '\n', rl_point));
         if (after == NULL) {
             if (int value = rl_get_previous_history(1, key))
@@ -469,7 +486,7 @@ static int CYConsoleKeyUp(int count, int key) {
 }
 
 static int CYConsoleKeyDown(int count, int key) {
-    while (count-- != 0) {
+    for (; count != 0; --count) {
         char *after(static_cast<char *>(memchr(rl_line_buffer + rl_point, '\n', rl_end - rl_point)));
         if (after == NULL) {
             int where(where_history());
@@ -516,21 +533,28 @@ static int CYConsoleLineEnd(int count, int key) {
 }
 
 static int CYConsoleKeyBack(int count, int key) {
-    while (count-- != 0) {
+    for (; count != 0; --count) {
+        if (rl_point == 0)
+            return 1;
+
         char *before(CYmemrchr(rl_line_buffer, '\n', rl_point));
-        if (before == NULL)
-            return rl_rubout(count, key);
+        if (before == NULL) {
+            int adjust(std::min(count, rl_point));
+            _lblcall(&rl_rubout, adjust, key);
+            count -= adjust - 1;
+            continue;
+        }
 
         int start(before + 1 - rl_line_buffer);
         if (start == rl_point) rubout: {
-            rl_rubout(1, key);
+            _lblcall(&rl_rubout, 1, key);
             continue;
         }
 
         for (int i(start); i != rl_point; ++i)
             if (rl_line_buffer[i] != ' ')
                 goto rubout;
-        rl_rubout((rl_point - start) % 4 ?: 4, key);
+        _lblcall(&rl_rubout, (rl_point - start) % 4 ?: 4, key);
     }
 
     return 0;
@@ -544,7 +568,8 @@ static int CYConsoleKeyTab(int count, int key) {
     for (int i(start); i != rl_point; ++i)
         if (rl_line_buffer[i] != ' ')
             goto complete;
-    return rl_insert(4 - (rl_point - start) % 4, ' ');
+    _lblcall(&rl_insert, 4 - (rl_point - start) % 4, ' ');
+    return 0;
 }
 
 static void CYConsoleRemapBind(Keymap map, rl_command_func_t *from, rl_command_func_t *to) {
@@ -1001,7 +1026,7 @@ int Main(int argc, char * const argv[], char const * const envp[]) {
             }
         } file(address.sun_path);
 
-        _syscall(bind(server, reinterpret_cast<sockaddr *>(&address), SUN_LEN(&address)));
+        _syscall(bind(server, reinterpret_cast<sockaddr *>(&address), sizeof(address)));
         _syscall(chmod(address.sun_path, 0777));
 
         _syscall(listen(server, 1));